)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d56b08eabe66af799d8629503131b0297a6f1e8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Wang Haojue \u003cwghaojue@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-22 05:16:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix bug 1907775"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I16585b9d97edc11b774316ca61096ebde7472622"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a482f65b_30af3a9c","line":7,"updated":"2020-12-22 10:35:25.000000000","message":"You should explain what you\u0027re changing and why","commit_id":"19201e2f54a2cf26248411b8bee36c79979e649f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d56b08eabe66af799d8629503131b0297a6f1e8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e2ef894c_85979171","line":10,"updated":"2020-12-22 10:35:25.000000000","message":"Can you add\n\n  Closes-bug: #1907775","commit_id":"19201e2f54a2cf26248411b8bee36c79979e649f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f5609c93fd223e2b847a2a9d5144fd0bd6ac5f74","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003cstephenfin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-22 10:36:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix bug 1907775"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I16585b9d97edc11b774316ca61096ebde7472622"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7e80a250_e5dd92e9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"updated":"2021-03-19 07:56:20.000000000","message":"Indeed, it shouldnot say fix bug 190775, you should have the simple title to incloud what are you changing, and add more details in the commit messages.","commit_id":"8db3176ebaab1a2d8b6767b2d623ce7576c1528f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f5609c93fd223e2b847a2a9d5144fd0bd6ac5f74","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-12-22 10:36:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix bug 1907775"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I16585b9d97edc11b774316ca61096ebde7472622"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"65c2ebf1_301d2f96","line":8,"updated":"2021-03-19 07:56:20.000000000","message":"Add tag of Closes-Bug:#1907775","commit_id":"8db3176ebaab1a2d8b6767b2d623ce7576c1528f"}],"nova/compute/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d56b08eabe66af799d8629503131b0297a6f1e8","unresolved":true,"context_lines":[{"line_number":6170,"context_line":"            raise exception.ComputeHostNotFound(host\u003dhost_name)"},{"line_number":6171,"context_line":""},{"line_number":6172,"context_line":"        aggregate \u003d objects.Aggregate.get_by_id(context, aggregate_id)"},{"line_number":6173,"context_line":"        compute_node \u003d objects.ComputeNodeList.get_all_by_host(context, host_name)"},{"line_number":6174,"context_line":"        if compute_node[0].running_vms \u003e 0:"},{"line_number":6175,"context_line":"            msg \u003d _(\"Aggregate %s does not support adding when \""},{"line_number":6176,"context_line":"                    \"there are running_vms on the host\") % aggregate.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"6acdde49_ffe0973d","line":6173,"in_reply_to":"8de715ac_bc6a0f85","updated":"2020-12-22 10:35:25.000000000","message":"\u003e pep8: E501 line too long (82 \u003e 79 characters)\n\nPlease fix.\n\nAlso, rather than checking this attribute of ComputeNodeList, can you simply filter Instances by host? Something like:\n\n  instances \u003d objects.InstanceList.get_by_host(context, host_name)\n  if instances:\n      ...","commit_id":"19201e2f54a2cf26248411b8bee36c79979e649f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d56b08eabe66af799d8629503131b0297a6f1e8","unresolved":true,"context_lines":[{"line_number":6174,"context_line":"        if compute_node[0].running_vms \u003e 0:"},{"line_number":6175,"context_line":"            msg \u003d _(\"Aggregate %s does not support adding when \""},{"line_number":6176,"context_line":"                    \"there are running_vms on the host\") % aggregate.name"},{"line_number":6177,"context_line":"            self._raise_invalid_aggregate_exc(AGGREGATE_ACTION_ADD, aggregate_id,"},{"line_number":6178,"context_line":"                                              msg)"},{"line_number":6179,"context_line":""},{"line_number":6180,"context_line":"        compute_utils.notify_about_aggregate_action("}],"source_content_type":"text/x-python","patch_set":1,"id":"19f2f893_ef8b856a","line":6177,"in_reply_to":"49e83ffd_b45e19fc","updated":"2020-12-22 10:35:25.000000000","message":"\u003e pep8: E501 line too long (81 \u003e 79 characters)\n\nPlease fix.\n\nCan you wrap like e.g.\n\n  self._raise_invalid_aggregate_exc(\n      AGGREGATE_ACTION_ADD, aggregate_id, msg)","commit_id":"19201e2f54a2cf26248411b8bee36c79979e649f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d56b08eabe66af799d8629503131b0297a6f1e8","unresolved":true,"context_lines":[{"line_number":6230,"context_line":"                                                    aggregate_payload)"},{"line_number":6231,"context_line":"        _get_service_in_cell_by_host(context, host_name)"},{"line_number":6232,"context_line":"        aggregate \u003d objects.Aggregate.get_by_id(context, aggregate_id)"},{"line_number":6233,"context_line":"        compute_node \u003d objects.ComputeNodeList.get_all_by_host(context, host_name)"},{"line_number":6234,"context_line":"        if compute_node[0].running_vms \u003e 0:"},{"line_number":6235,"context_line":"            msg \u003d _(\"Aggregate %s does not support removing when \""},{"line_number":6236,"context_line":"                    \"there are running_vms on the host\") % aggregate.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2540e33_b07f3eee","line":6233,"in_reply_to":"a240e15e_a00c2481","updated":"2020-12-22 10:35:25.000000000","message":"\u003e pep8: E501 line too long (82 \u003e 79 characters)\n\nPlease fix.\n\nAlso, as above (check for instances instead)","commit_id":"19201e2f54a2cf26248411b8bee36c79979e649f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d56b08eabe66af799d8629503131b0297a6f1e8","unresolved":true,"context_lines":[{"line_number":6232,"context_line":"        aggregate \u003d objects.Aggregate.get_by_id(context, aggregate_id)"},{"line_number":6233,"context_line":"        compute_node \u003d objects.ComputeNodeList.get_all_by_host(context, host_name)"},{"line_number":6234,"context_line":"        if compute_node[0].running_vms \u003e 0:"},{"line_number":6235,"context_line":"            msg \u003d _(\"Aggregate %s does not support removing when \""},{"line_number":6236,"context_line":"                    \"there are running_vms on the host\") % aggregate.name"},{"line_number":6237,"context_line":"            self._raise_invalid_aggregate_exc(AGGREGATE_ACTION_DELETE, aggregate_id,"},{"line_number":6238,"context_line":"                                              msg)"},{"line_number":6239,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"52670a2a_c2097337","line":6236,"range":{"start_line":6235,"start_character":21,"end_line":6236,"end_character":54},"updated":"2020-12-22 10:35:25.000000000","message":"How about:\n\n  msg \u003d _(\n      \u0027One or more instances still present on host %s\u0027\n  ) % host_name","commit_id":"19201e2f54a2cf26248411b8bee36c79979e649f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d56b08eabe66af799d8629503131b0297a6f1e8","unresolved":true,"context_lines":[{"line_number":6234,"context_line":"        if compute_node[0].running_vms \u003e 0:"},{"line_number":6235,"context_line":"            msg \u003d _(\"Aggregate %s does not support removing when \""},{"line_number":6236,"context_line":"                    \"there are running_vms on the host\") % aggregate.name"},{"line_number":6237,"context_line":"            self._raise_invalid_aggregate_exc(AGGREGATE_ACTION_DELETE, aggregate_id,"},{"line_number":6238,"context_line":"                                              msg)"},{"line_number":6239,"context_line":""},{"line_number":6240,"context_line":"        compute_utils.notify_about_aggregate_action("}],"source_content_type":"text/x-python","patch_set":1,"id":"551934a9_16e4c1f0","line":6237,"in_reply_to":"11d22abb_7b53462b","updated":"2020-12-22 10:35:25.000000000","message":"\u003e pep8: E501 line too long (84 \u003e 79 characters)\n\nPlease fix.","commit_id":"19201e2f54a2cf26248411b8bee36c79979e649f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f5609c93fd223e2b847a2a9d5144fd0bd6ac5f74","unresolved":true,"context_lines":[{"line_number":6155,"context_line":""},{"line_number":6156,"context_line":"        aggregate \u003d objects.Aggregate.get_by_id(context, aggregate_id)"},{"line_number":6157,"context_line":"        compute_node \u003d objects.ComputeNodeList.get_all_by_host(context, host_name)"},{"line_number":6158,"context_line":"        if compute_node[0].running_vms \u003e 0:"},{"line_number":6159,"context_line":"            msg \u003d _(\"Aggregate %s does not support adding when \""},{"line_number":6160,"context_line":"                    \"there are running_vms on the host\") % aggregate.name"},{"line_number":6161,"context_line":"            self._raise_invalid_aggregate_exc(AGGREGATE_ACTION_ADD, aggregate_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"93069b8d_749b05f1","line":6158,"updated":"2021-03-19 07:56:20.000000000","message":"I would like to change the running_vms\u0027s available_zone, update it to the neweast if the host\u0027s aggregate changed.\n\nFrom users point of view, if they want to add [remove] a host to [from] the host aggregate, they should migrate the host from this host, than add [remove] the host to [from] this host aggregate, this is not a good UX for users.","commit_id":"8db3176ebaab1a2d8b6767b2d623ce7576c1528f"}]}