)]}'
{"id":"openstack%2Fnova~768194","triplet_id":"openstack%2Fnova~stable%2Ftrain~I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c","project":"openstack/nova","branch":"stable/train","topic":"bug/1899649","hashtags":[],"change_id":"I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c","subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","status":"ABANDONED","created":"2020-12-22 11:43:06.000000000","updated":"2023-09-01 17:02:02.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"04737f90910741e7025c789aee5fa6f6940d79e5","_number":768194,"virtual_id_number":768194,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-12-22 18:34:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-22 14:10:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-22 14:18:03.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-12-22 19:39:39.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"48876b4b6a5609c54e140c259e3f17a31711638b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-12-22 11:43:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c96e3d29ae6aad84449edbfd4b87d10fbf75efa","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-12-22 11:52:34.000000000","message":"Topic set to bug/1899649","accounts_in_message":[],"_revision_number":1},{"id":"3c47ac019caa6b52f2adab9e5555d917d6eba096","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-12-22 11:59:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"91904d5384b000ac3a20b1f8785495db55a6a030","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-22 14:10:10.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/255a7d7368714d4a95ee7f735719fbb1 : SUCCESS in 57m 55s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/66864cb546a744f4b6bacc06f390768b : SUCCESS in 1h 22m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/79e27cb14d9b4fd8aaf3c4d4c8bfdb90 : SUCCESS in 15m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/55666a1ea83f41598b2adf484aff7fbb : SUCCESS in 15m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/45652314529340b2a983db3989a2b961 : FAILURE in 9m 21s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e2cbbd1f8c384c16bd975a05f2a2bdcc : SUCCESS in 14m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/56a91ddea6ff483b80f5524c2988043f : SUCCESS in 14m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/023a28dc2e0c49afbaf3e57d1410b2c8 : SUCCESS in 12m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8b148812f8d24150bc043a0dfa421a9b : SUCCESS in 9m 03s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/3c05c092ab92467e960c1b34a11ffba7 : SUCCESS in 1h 09m 28s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/bdca8d895f764aef90686d23041617c1 : SUCCESS in 1h 21m 19s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/a151275d1a4c4b919d939cb97db77a87 : SUCCESS in 1h 10m 17s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/23b6e17c10da4d87a9a652c076a49c7d : SUCCESS in 1h 24m 21s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/bf97966c120c4e21933976888cb8eb00 : SUCCESS in 41m 43s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/4eb1f2c61a2947adb6a22926b6a2382b : SUCCESS in 1h 24m 33s\n- nova-next https://zuul.opendev.org/t/openstack/build/13f84147fd30440d9d958f2f0b84f424 : SUCCESS in 1h 18m 40s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/d1ff0b25e3ee469fa02e149c742b1964 : FAILURE in 20m 06s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/55d903a0a3c5442fa007b2c4ad51d2f6 : FAILURE in 19m 20s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/4f204275df5e4f49884e18048dafcf9b : SUCCESS in 2h 03m 49s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/03bfeeacaa4b4442ac6c834e01029373 : FAILURE in 21m 59s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/be202b64a5bc40228e8943f67e64a554 : SUCCESS in 53m 23s","accounts_in_message":[],"_revision_number":2},{"id":"5a0ed1f93a6bdf76a684979ade4909a61aa122b9","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-12-22 14:18:03.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/94/768194/2/check/tempest-dsvm-full-bionic-py3/9b26aec/ : SUCCESS in 1h 41m 01s","accounts_in_message":[],"_revision_number":2},{"id":"47bbf958141537feed06f4b94d977b7247fee0ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-12-22 16:24:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7f5964ab45b5c59c217c90ec464c24bf7fb306c6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-12-22 17:49:48.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/94/768194/3/check/tempest-dsvm-full-bionic-py3/fc4e294/ : SUCCESS in 1h 19m 10s","accounts_in_message":[],"_revision_number":3},{"id":"ff6999214441704c7439213d46ff0cdd64d418bb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-22 18:34:42.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/561a9c6d81c54cf698cebf28670a0980 : SUCCESS in 53m 55s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/2d6bf370a67c4209a487dc21a6225a32 : SUCCESS in 1h 39m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2788448046b4488a94919c820dfad88b : SUCCESS in 20m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f8fd65b4a5344ef788c1442af9f342a3 : SUCCESS in 12m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/86ebfff6372d4515b0cb2b8f046828c5 : FAILURE in 10m 21s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/81058dbdb11b4c10a934b7a2fe51e851 : SUCCESS in 12m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a98c9e54312240769f8ea3dd66c1b003 : SUCCESS in 10m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1d2e5c0277004d23bdf43aaba2f0390d : SUCCESS in 14m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/05b8cc804d37408193f8ffaf3b53b48d : SUCCESS in 9m 52s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/e02665d0a818484e8ec26b80c9e9d646 : SUCCESS in 1h 06m 34s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/92d9dfd89fd74c508a6a37e6cf3ca7d6 : SUCCESS in 1h 06m 17s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/40bcfa28a7ff44b280f84468fe2ae48b : SUCCESS in 1h 02m 16s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/abb66396c81f4ec58b43fcf2f5973b56 : SUCCESS in 1h 02m 26s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/620d5d6d7c7b4d69b40a7ac49d0fa894 : SUCCESS in 43m 48s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/413d6af6bf9646758a9bc1092c72e6ee : SUCCESS in 1h 19m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/6653be83ecfc4653bc17da17bc6370fc : SUCCESS in 1h 04m 50s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/8bb3c64290fe47f0af974d08fbede79a : SUCCESS in 21m 59s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/0970c7bbd073442f9005b4323f442395 : SUCCESS in 20m 11s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/a86be02c8fe74d54803ff4ec1a341250 : SUCCESS in 2h 06m 31s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/afbf9494f1c14b37a0f8a2ef21beb759 : FAILURE in 26m 26s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/03336a6831604d478d4e122b07fa8448 : SUCCESS in 54m 52s","accounts_in_message":[],"_revision_number":3},{"id":"11748fc0de976ca2a5f332e7613b8e8a5e675470","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-12-22 19:39:39.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/768194/3 : FAILURE in 2h 50m 39s","accounts_in_message":[],"_revision_number":3},{"id":"04737f90910741e7025c789aee5fa6f6940d79e5","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 17:02:02.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"fd298bf8c7f28056390fc3004414049f53bb1d0d","revisions":{"528807e7ffcc0468c4117c0c0e408d8798dc2ea9":{"kind":"REWORK","_number":1,"created":"2020-12-22 11:43:06.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/94/768194/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/94/768194/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/94/768194/1"}}},"commit":{"parents":[{"commit":"3da30ac94be64d8775b891f5edd0bab724e7535b","subject":"Add regression test for bug #1899649","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3da30ac94be64d8775b891f5edd0bab724e7535b"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-10-13 15:01:19.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-12-22 11:42:46.000000000","tz":0},"subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","message":"compute: Don\u0027t detach volumes when RescheduledException raised without retry\n\nI8b1c05317734e14ea73dc868941351bb31210bf0 introduced a crude call to\n_cleanup_volumes within _do_build_and_run_instance when handling a\nRescheduledException exception raised from _build_and_run_instance\nwithout any retry information provided from the scheduler.\n\nThis situation can arise when using the \u0027availability_zone\u0027 parameter to\nskip the scheduler by providing both a target availability_zone and host\nin the format of `$availability_zone:$host`. If the instance is unable\nto build on the compute the failure will eventually lead to\n_cleanup_volumes calling DriverVolumeBlockDevice.detach that will either\ndetach (cinderv2) or delete the associated volume attachments (cinderv3)\nmoving the volume to an `available` state, assuming it isn\u0027t\nmulti-attached etc.\n\nThe issue with this is that this behaviour is in stark contrast to that\nof volumes associated with instances that have failed to schedule. In\nthat case the volumes remain marked as reserved and associated with the\nERROR\u0027d out instance until the instance itself is deleted.\n\nThis change aims to align both cases by removing the call to\n_cleanup_volumes and in doing so keeping any volumes in a `reserved`\nstate until the underlying instance is deleted.\n\nNote that leaving these volumes associated with ERROR\u0027d out instances is\nnow safe after I4dc6c8bd3bb6c135f8a698af41f5d0e026c39117 landed and now\nensures that ports and volumes associated with such an instance are\ncorrectly cleaned up.\n\nNOTE(lyarwood): Conflict as I26395d57bd4ba55276b7514baa808f9888639e11\nisn\u0027t present on stable/train.\n\nConflicts:\n  nova/tests/unit/compute/test_compute_mgr.py\n\nCloses-Bug: #1899649\nChange-Id: I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c\n(cherry picked from commit 26c46a409fa3a75f11fe0ecfc3cf1a8e77da8f51)\n(cherry picked from commit d0daac2c089b015c28e02e7965afdb22f08e42a1)\n(cherry picked from commit 643d01970ec2dc8e9c15612af7279f9a5df57745)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/528807e7ffcc0468c4117c0c0e408d8798dc2ea9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/528807e7ffcc0468c4117c0c0e408d8798dc2ea9"}]},"branch":"refs/heads/stable/train"},"b6a5fa288eb32db6f4e236b77fb0bed98bcbb9b0":{"kind":"REWORK","_number":2,"created":"2020-12-22 11:59:33.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/94/768194/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/94/768194/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/94/768194/2"}}},"commit":{"parents":[{"commit":"ae9c14bd64e9dd5a2a96ec3ede25730ee9e4b029","subject":"Add regression test for bug #1899649","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae9c14bd64e9dd5a2a96ec3ede25730ee9e4b029"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-10-13 15:01:19.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-12-22 11:59:20.000000000","tz":0},"subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","message":"compute: Don\u0027t detach volumes when RescheduledException raised without retry\n\nI8b1c05317734e14ea73dc868941351bb31210bf0 introduced a crude call to\n_cleanup_volumes within _do_build_and_run_instance when handling a\nRescheduledException exception raised from _build_and_run_instance\nwithout any retry information provided from the scheduler.\n\nThis situation can arise when using the \u0027availability_zone\u0027 parameter to\nskip the scheduler by providing both a target availability_zone and host\nin the format of `$availability_zone:$host`. If the instance is unable\nto build on the compute the failure will eventually lead to\n_cleanup_volumes calling DriverVolumeBlockDevice.detach that will either\ndetach (cinderv2) or delete the associated volume attachments (cinderv3)\nmoving the volume to an `available` state, assuming it isn\u0027t\nmulti-attached etc.\n\nThe issue with this is that this behaviour is in stark contrast to that\nof volumes associated with instances that have failed to schedule. In\nthat case the volumes remain marked as reserved and associated with the\nERROR\u0027d out instance until the instance itself is deleted.\n\nThis change aims to align both cases by removing the call to\n_cleanup_volumes and in doing so keeping any volumes in a `reserved`\nstate until the underlying instance is deleted.\n\nNote that leaving these volumes associated with ERROR\u0027d out instances is\nnow safe after I4dc6c8bd3bb6c135f8a698af41f5d0e026c39117 landed and now\nensures that ports and volumes associated with such an instance are\ncorrectly cleaned up.\n\nNOTE(lyarwood): Conflict as I26395d57bd4ba55276b7514baa808f9888639e11\nisn\u0027t present on stable/train.\n\nConflicts:\n  nova/tests/unit/compute/test_compute_mgr.py\n\nCloses-Bug: #1899649\nChange-Id: I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c\n(cherry picked from commit 26c46a409fa3a75f11fe0ecfc3cf1a8e77da8f51)\n(cherry picked from commit d0daac2c089b015c28e02e7965afdb22f08e42a1)\n(cherry picked from commit 643d01970ec2dc8e9c15612af7279f9a5df57745)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b6a5fa288eb32db6f4e236b77fb0bed98bcbb9b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b6a5fa288eb32db6f4e236b77fb0bed98bcbb9b0"}]},"branch":"refs/heads/stable/train"},"fd298bf8c7f28056390fc3004414049f53bb1d0d":{"kind":"REWORK","_number":3,"created":"2020-12-22 16:24:39.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/94/768194/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/94/768194/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/768194/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/94/768194/3"}}},"commit":{"parents":[{"commit":"ae9c14bd64e9dd5a2a96ec3ede25730ee9e4b029","subject":"Add regression test for bug #1899649","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae9c14bd64e9dd5a2a96ec3ede25730ee9e4b029"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-10-13 15:01:19.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-12-22 16:22:55.000000000","tz":0},"subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","message":"compute: Don\u0027t detach volumes when RescheduledException raised without retry\n\nI8b1c05317734e14ea73dc868941351bb31210bf0 introduced a crude call to\n_cleanup_volumes within _do_build_and_run_instance when handling a\nRescheduledException exception raised from _build_and_run_instance\nwithout any retry information provided from the scheduler.\n\nThis situation can arise when using the \u0027availability_zone\u0027 parameter to\nskip the scheduler by providing both a target availability_zone and host\nin the format of `$availability_zone:$host`. If the instance is unable\nto build on the compute the failure will eventually lead to\n_cleanup_volumes calling DriverVolumeBlockDevice.detach that will either\ndetach (cinderv2) or delete the associated volume attachments (cinderv3)\nmoving the volume to an `available` state, assuming it isn\u0027t\nmulti-attached etc.\n\nThe issue with this is that this behaviour is in stark contrast to that\nof volumes associated with instances that have failed to schedule. In\nthat case the volumes remain marked as reserved and associated with the\nERROR\u0027d out instance until the instance itself is deleted.\n\nThis change aims to align both cases by removing the call to\n_cleanup_volumes and in doing so keeping any volumes in a `reserved`\nstate until the underlying instance is deleted.\n\nNote that leaving these volumes associated with ERROR\u0027d out instances is\nnow safe after I4dc6c8bd3bb6c135f8a698af41f5d0e026c39117 landed and now\nensures that ports and volumes associated with such an instance are\ncorrectly cleaned up.\n\nNOTE(lyarwood): Conflict as I26395d57bd4ba55276b7514baa808f9888639e11\nisn\u0027t present on stable/train.\n\nConflicts:\n  nova/tests/unit/compute/test_compute_mgr.py\n\nCloses-Bug: #1899649\nChange-Id: I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c\n(cherry picked from commit 26c46a409fa3a75f11fe0ecfc3cf1a8e77da8f51)\n(cherry picked from commit d0daac2c089b015c28e02e7965afdb22f08e42a1)\n(cherry picked from commit 643d01970ec2dc8e9c15612af7279f9a5df57745)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd298bf8c7f28056390fc3004414049f53bb1d0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd298bf8c7f28056390fc3004414049f53bb1d0d"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}