)]}'
{"id":"openstack%2Fnova~768202","triplet_id":"openstack%2Fnova~master~Iceac2b596ea13b605a7b3ed5d538a4175304c0a5","project":"openstack/nova","branch":"master","topic":"story/2007938","hashtags":[],"change_id":"Iceac2b596ea13b605a7b3ed5d538a4175304c0a5","subject":"Fix Unit test for arm64","status":"ABANDONED","created":"2020-12-22 13:28:17.000000000","updated":"2021-01-19 13:53:34.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"142647448797c6d7464926f2686fbd4f12e9886f","_number":768202,"virtual_id_number":768202,"owner":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-22 14:04:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-22 14:57:56.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-12-22 16:37:08.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-12-22 17:34:00.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-19 12:53:46.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"CC"}],"messages":[{"id":"8108511dfb9ee7024f68976a723ee70bd0e3ab98","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2020-12-22 13:28:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"71e75a160da7874d2868d73796944901c64d098b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-22 14:04:02.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5c85856623b0464fb08c773e9e86c900 : SUCCESS in 24m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/51c036645acd4064b36095901ebcf7fb : SUCCESS in 13m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a03a8d107c31405f8ef4798a8e5d4892 : FAILURE in 12m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7b02513d26bc4d8b831f0eb9252d5514 : FAILURE in 30m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9235043c592f433a903abd6693662228 : FAILURE in 31m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/92f05b9c254a40378b283abc72ddc35e : SUCCESS in 13m 01s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/75180307276342c8ab4e063698d58afd : SUCCESS in 10m 47s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/8217baade30b42bf8d669fe0b7306b1e : SUCCESS in 13m 11s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d602630b10074f638c17da89707eb147 : FAILURE in 33m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c0678babff64804f997924d1bb74d8e00732a24e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-12-22 14:57:56.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks for the change. This isn\u0027t how to go about this. If something is changing because our host architecture is changing, that indicates a failure in mocking. The issue here is that our call to \u0027get_disk_mapping\u0027 calls \u0027_get_stable_device_rescue_mapping\u0027, which calls \u0027get_rescue_bus\u0027 to identify a suitable disk bus, which calls \u0027get_disk_bus_for_device_type\u0027 since we haven\u0027t set a rescue disk bus via image metadata properties. \u0027get_disk_bus_for_device_type\u0027 then calls \u0027libvirt_utils.get_arch\u0027 and  \u0027libvirt_utils.get_machine_type\u0027, neither of which we\u0027ve mocked out, meaning the response is platform dependent. If you can mock out \u0027libvirt_utils.get_arch\u0027 and \u0027libvirt_utils.get_machine_type\u0027 so they always returns x86 and PC/Q35, respectively, and we\u0027ll be good.","accounts_in_message":[],"_revision_number":1},{"id":"285eef0521c145165d454a57806a9c070bbb752c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-12-22 16:37:08.000000000","message":"Patch Set 1:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/768202/768202/1/check-not-vote/ext-nova-zuul/4a55362 : SUCCESS in 1h 15m 26s","accounts_in_message":[],"_revision_number":1},{"id":"071205dfefc26beb4c42a588fcd00e76b3cb2325","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-12-22 17:34:00.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/768202/1 : SUCCESS in 2h 32m 55s","accounts_in_message":[],"_revision_number":1},{"id":"3b15c9920d5c07b8127d024be15aba18449d1308","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2021-01-19 12:46:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7903d902ac02913e59825778ce74b16067faa1c9","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-01-19 12:53:46.000000000","message":"Patch Set 2:\n\nDuplicate of Iccdbbb8cf2a9c0e01f0f32ed6d78a267486824af, I didn\u0027t notice this change when writing that but it\u0027s already got +2 so I\u0027m not sure if you want to use this.","accounts_in_message":[],"_revision_number":2},{"id":"107edbbb1211d6c4371557b6c99debb5d89eb58a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-19 13:16:41.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/bc40503130f945d4afaaa448ac1a3a4b : SUCCESS in 20m 04s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/abc7c41f08bb4e37977b01bd90ed429c : SUCCESS in 23m 26s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"250f064fff49fb814a9adb655e758f1d077e5317","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2021-01-19 13:52:42.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e Duplicate of Iccdbbb8cf2a9c0e01f0f32ed6d78a267486824af, I didn\u0027t notice this change when writing that but it\u0027s already got +2 so I\u0027m not sure if you want to use this.\n\nlet\u0027s go with that one, I only care if taht issue fixed","accounts_in_message":[],"_revision_number":2},{"id":"142647448797c6d7464926f2686fbd4f12e9886f","tag":"autogenerated:gerrit:abandon","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2021-01-19 13:53:34.000000000","message":"Abandoned\n\nIn favor of https://review.opendev.org/c/openstack/nova/+/769916","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"218b4697d9d3f25d972a07fef52e62ec3b2a1ca7","revisions":{"93ccb7ee7b586732a99ca394799cf899cc217234":{"kind":"REWORK","_number":1,"created":"2020-12-22 13:28:17.000000000","uploader":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"ref":"refs/changes/02/768202/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/768202/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/768202/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/768202/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/768202/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/768202/1"}}},"commit":{"parents":[{"commit":"ce74e156da0ae27baba864ba06ea883c8fa6f3c4","subject":"add openstack-python3-wallaby-jobs-arm64 job","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ce74e156da0ae27baba864ba06ea883c8fa6f3c4"}]}],"author":{"name":"ricolin","email":"rico.lin.guanyu@gmail.com","date":"2020-12-22 13:15:14.000000000","tz":480},"committer":{"name":"ricolin","email":"rico.lin.guanyu@gmail.com","date":"2020-12-22 13:27:36.000000000","tz":480},"subject":"Fix Unit test for arm64","message":"Fix Unit test for arm64\n\nChange-Id: Iceac2b596ea13b605a7b3ed5d538a4175304c0a5\nStory: 2007938\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93ccb7ee7b586732a99ca394799cf899cc217234"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93ccb7ee7b586732a99ca394799cf899cc217234"}]},"branch":"refs/heads/master"},"218b4697d9d3f25d972a07fef52e62ec3b2a1ca7":{"kind":"REWORK","_number":2,"created":"2021-01-19 12:46:34.000000000","uploader":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"ref":"refs/changes/02/768202/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/768202/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/768202/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/768202/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/768202/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/768202/2"}}},"commit":{"parents":[{"commit":"af15488be9d6f02b5bb893beb8a429d274a01ed4","subject":"add openstack-python3-wallaby-jobs-arm64 job","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/af15488be9d6f02b5bb893beb8a429d274a01ed4"}]}],"author":{"name":"ricolin","email":"rico.lin.guanyu@gmail.com","date":"2021-01-19 12:45:34.000000000","tz":480},"committer":{"name":"ricolin","email":"rico.lin.guanyu@gmail.com","date":"2021-01-19 12:45:34.000000000","tz":480},"subject":"Fix Unit test for arm64","message":"Fix Unit test for arm64\n\nChange-Id: Iceac2b596ea13b605a7b3ed5d538a4175304c0a5\nStory: 2007938\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/218b4697d9d3f25d972a07fef52e62ec3b2a1ca7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/218b4697d9d3f25d972a07fef52e62ec3b2a1ca7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}