)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21a786876015a8899422046ce53eb67bdc6d06e0","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support the e1000-82545em interface in nova for OS"},{"line_number":10,"context_line":"which needs this interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I441655aad36be036b611455359def80cfd275f7f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a26010d_fd7444b8","line":11,"updated":"2022-04-29 09:37:28.000000000","message":"this needs a specless blueprint which has to be approved at the team meeting \nbefore it can proceed.\n\nplease file one here https://blueprints.launchpad.net/nova/+addspec\n\nthen update the commit message with \nimplements: bluprint \u003curl to blueprint\u003e","commit_id":"93b9ab14d8ba8e2821cb5ee04fbb6aeef409ad1b"}],"nova/network/model.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21a786876015a8899422046ce53eb67bdc6d06e0","unresolved":true,"context_lines":[{"line_number":124,"context_line":"VIF_MODEL_RTL8139 \u003d \u0027rtl8139\u0027"},{"line_number":125,"context_line":"VIF_MODEL_E1000 \u003d \u0027e1000\u0027"},{"line_number":126,"context_line":"VIF_MODEL_E1000E \u003d \u0027e1000e\u0027"},{"line_number":127,"context_line":"VIF_MODEL_E1000_82545EM \u003d \u0027e1000-82545em\u0027"},{"line_number":128,"context_line":"VIF_MODEL_NETFRONT \u003d \u0027netfront\u0027"},{"line_number":129,"context_line":"VIF_MODEL_SPAPR_VLAN \u003d \u0027spapr-vlan\u0027"},{"line_number":130,"context_line":"VIF_MODEL_LAN9118 \u003d \u0027lan9118\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"8b2d7091_9edc2d61","line":127,"updated":"2022-04-29 09:37:28.000000000","message":"i would be tempted to shorten this to VIF_MODEL_82545EM and use hw_vif_model\u003d82545em  as the image propert then map it to as this is getting a bit log but i guess this is ok","commit_id":"93b9ab14d8ba8e2821cb5ee04fbb6aeef409ad1b"}],"nova/objects/fields.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21a786876015a8899422046ce53eb67bdc6d06e0","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                     network_model.VIF_MODEL_E1000,"},{"line_number":580,"context_line":"                     \"virtuale1000e\":"},{"line_number":581,"context_line":"                     network_model.VIF_MODEL_E1000E,"},{"line_number":582,"context_line":"                     \"virtuale1000-82545em\":"},{"line_number":583,"context_line":"                     network_model.VIF_MODEL_E1000_82545EM,"},{"line_number":584,"context_line":"                     \"virtualpcnet32\":"},{"line_number":585,"context_line":"                     network_model.VIF_MODEL_PCNET,"}],"source_content_type":"text/x-python","patch_set":7,"id":"e3fa1473_6820b162","line":582,"updated":"2022-04-29 09:37:28.000000000","message":"this does not need to be updated.\n\nthe legacy values should not be exteded when we add new values","commit_id":"93b9ab14d8ba8e2821cb5ee04fbb6aeef409ad1b"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21a786876015a8899422046ce53eb67bdc6d06e0","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        network_model.VIF_MODEL_RTL8139,"},{"line_number":56,"context_line":"        network_model.VIF_MODEL_E1000,"},{"line_number":57,"context_line":"        network_model.VIF_MODEL_E1000E,"},{"line_number":58,"context_line":"        network_model.VIF_MODEL_E1000_82545EM,"},{"line_number":59,"context_line":"        network_model.VIF_MODEL_LAN9118,"},{"line_number":60,"context_line":"        network_model.VIF_MODEL_SPAPR_VLAN,"},{"line_number":61,"context_line":"        network_model.VIF_MODEL_VMXNET3],"}],"source_content_type":"text/x-python","patch_set":7,"id":"a6113912_bb1778ab","line":58,"updated":"2022-04-29 09:37:28.000000000","message":"you wil need to add a new trait to os-traits\nhttps://github.com/openstack/os-traits/blob/master/os_traits/compute/net.py#L27","commit_id":"93b9ab14d8ba8e2821cb5ee04fbb6aeef409ad1b"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21a786876015a8899422046ce53eb67bdc6d06e0","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        return \u0027VirtualE1000\u0027"},{"line_number":412,"context_line":"    if name \u003d\u003d network_model.VIF_MODEL_E1000E:"},{"line_number":413,"context_line":"        return \u0027VirtualE1000e\u0027"},{"line_number":414,"context_line":"    if name \u003d\u003d network_model.VIF_MODEL_E1000_82545EM:"},{"line_number":415,"context_line":"        return \u0027VirtualE1000-82545em\u0027"},{"line_number":416,"context_line":"    if name \u003d\u003d network_model.VIF_MODEL_PCNET:"},{"line_number":417,"context_line":"        return \u0027VirtualPCNet32\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"f4cbe40c_5f144c5c","line":414,"updated":"2022-04-29 09:37:28.000000000","message":"have yo tested that this works on both libvirt with qemu and kvm and vmware.\n\nif not can you provide refernce to documentation that say that this is supported and in what release it was added","commit_id":"93b9ab14d8ba8e2821cb5ee04fbb6aeef409ad1b"}],"releasenotes/notes/add-e1000-82545em-5f41ce364c61fc96.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21a786876015a8899422046ce53eb67bdc6d06e0","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    To support the e1000-82545em interface in nova for OS which needs this"},{"line_number":5,"context_line":"    interface, such as macos."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa72a2a6_1ae311ed","line":5,"updated":"2022-04-29 09:37:28.000000000","message":"we do not really support macos today.\nim not against this but just so you know we do not test macos guests and we dont advertiese or expect it to work today.\n\ncan  you list the min verions of libvirt, qemu and vmware that are required for this","commit_id":"93b9ab14d8ba8e2821cb5ee04fbb6aeef409ad1b"}]}