)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8835553ca07a6a95ec298de5847bc0b4cb5e4aa7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force raising an timeout exception for rados connect"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RadosClient::connect does not have an timeout option,"},{"line_number":10,"context_line":"and pybind silently ignores user input which causes"},{"line_number":11,"context_line":"rados.connect hangs indefinitely and does not yield"},{"line_number":12,"context_line":"control. This patch uses a tpool and raises timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"82e33e69_f74e134a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":53},"updated":"2021-01-21 10:33:45.000000000","message":"This doesn\u0027t appear to be true. The docs say that it does have a timeout option:\n\n  https://docs.ceph.com/en/latest/rados/api/python/#rados.Rados.connect\n\nIf I\u0027m missing something, then can you please clarify this further?","commit_id":"6c181e9b1d394b5414e42a77d5b49af98944babd"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"44046b82ba56cdd0f83b5ef6a04cf87edf1fdaa2","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force raising an timeout exception for rados connect"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RadosClient::connect does not have an timeout option,"},{"line_number":10,"context_line":"and pybind silently ignores user input which causes"},{"line_number":11,"context_line":"rados.connect hangs indefinitely and does not yield"},{"line_number":12,"context_line":"control. This patch uses a tpool and raises timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"887749ae_b00e01ad","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":53},"in_reply_to":"60948a97_0fa8326d","updated":"2021-04-20 08:39:20.000000000","message":"https://github.com/ceph/ceph/blob/0be78da368f2dc1c891e3caafac38f7aa96d3c49/src/pybind/rados/rados.pyx#L660\nfrom the source code, although timeout is there, it is not used...","commit_id":"6c181e9b1d394b5414e42a77d5b49af98944babd"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"434d24c0ef005126da2841ac886e207291a074cc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force raising an timeout exception for rados connect"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RadosClient::connect does not have an timeout option,"},{"line_number":10,"context_line":"and pybind silently ignores user input which causes"},{"line_number":11,"context_line":"rados.connect hangs indefinitely and does not yield"},{"line_number":12,"context_line":"control. This patch uses a tpool and raises timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"60948a97_0fa8326d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":53},"in_reply_to":"82e33e69_f74e134a","updated":"2021-01-21 10:45:05.000000000","message":"Yeah I was worried for a second that this wasn\u0027t a kwarg but it is at least with my version:\n\n```\n$ rpm -q python3-rados\npython3-rados-15.2.8-1.fc33.x86_64\n\n$ ipython\n\nIn [1]: import rados \n\nIn [2]: rados.Rados.connect?                                                                                                                      \nDocstring:\nRados.connect(self, timeout\u003d0)\n\nConnect to the cluster.  Use shutdown() to release resources.\nType:      method_descriptor\n\n```\n\nPretty sure I checked this on older versions as well, can you confirm which version you are using?","commit_id":"6c181e9b1d394b5414e42a77d5b49af98944babd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8835553ca07a6a95ec298de5847bc0b4cb5e4aa7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b393bf08_3b272a28","line":16,"updated":"2021-01-21 10:33:45.000000000","message":"Can you create a bug or link an existing one, as this won\u0027t be able to be backported without one","commit_id":"6c181e9b1d394b5414e42a77d5b49af98944babd"}],"nova/storage/rbd_utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8835553ca07a6a95ec298de5847bc0b4cb5e4aa7","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _connect_to_rados(self, pool\u003dNone):"},{"line_number":158,"context_line":"        client \u003d tpool.Proxy(rados.Rados(rados_id\u003dself.rbd_user,"},{"line_number":159,"context_line":"                                         conffile\u003dself.ceph_conf))"},{"line_number":160,"context_line":"        try:"},{"line_number":161,"context_line":"            # RadosClient::connect does not have a connect time,"},{"line_number":162,"context_line":"            # rbd_connect_timeout is siliently ignored, patch object"}],"source_content_type":"text/x-python","patch_set":2,"id":"9eda8a71_4201d9f5","line":159,"updated":"2021-01-21 10:33:45.000000000","message":"nit:\n\n  client \u003d tpool.Proxy(\n      rados.Rados(rados_id\u003dself.rbd_user, conffile\u003dself.ceph_conf))","commit_id":"6c181e9b1d394b5414e42a77d5b49af98944babd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8835553ca07a6a95ec298de5847bc0b4cb5e4aa7","unresolved":true,"context_lines":[{"line_number":170,"context_line":"            # str() conversion."},{"line_number":171,"context_line":"            ioctx \u003d client.open_ioctx(str(pool_to_open))"},{"line_number":172,"context_line":"            return client, ioctx"},{"line_number":173,"context_line":"        except rados.Error:"},{"line_number":174,"context_line":"            # shutdown cannot raise an exception"},{"line_number":175,"context_line":"            client.shutdown()"},{"line_number":176,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"59eafc79_822c4d48","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":27},"updated":"2021-01-21 10:33:45.000000000","message":"nit:\n\n  except (rados.Error, timeout.Timeout):","commit_id":"6c181e9b1d394b5414e42a77d5b49af98944babd"}]}