)]}'
{"nova/api/openstack/compute/hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ba641426ffb84c8b43caacb6ec52cc2f85b52f4","unresolved":true,"context_lines":[{"line_number":360,"context_line":"        try:"},{"line_number":361,"context_line":"            host \u003d hyp.host"},{"line_number":362,"context_line":"            uptime \u003d self.host_api.get_host_uptime(context, host)"},{"line_number":363,"context_line":"            service \u003d self.host_api.service_get_by_compute_host(context, host)"},{"line_number":364,"context_line":"        except NotImplementedError:"},{"line_number":365,"context_line":"            common.raise_feature_not_supported()"},{"line_number":366,"context_line":"        except ("}],"source_content_type":"text/x-python","patch_set":1,"id":"b7328a68_efb5d3d4","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":78},"updated":"2021-01-06 19:34:48.000000000","message":"this also need to be guard by ComputeHostNotFound","commit_id":"cdc72bea1fa8d63c38bb3f05e96f0868713c3216"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4071fca65e12d9adc3c8a617c724a11bced02fd3","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        try:"},{"line_number":361,"context_line":"            host \u003d hyp.host"},{"line_number":362,"context_line":"            uptime \u003d self.host_api.get_host_uptime(context, host)"},{"line_number":363,"context_line":"            service \u003d self.host_api.service_get_by_compute_host(context, host)"},{"line_number":364,"context_line":"        except NotImplementedError:"},{"line_number":365,"context_line":"            common.raise_feature_not_supported()"},{"line_number":366,"context_line":"        except ("}],"source_content_type":"text/x-python","patch_set":1,"id":"353232ee_0ddd9608","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":78},"in_reply_to":"b7328a68_efb5d3d4","updated":"2021-01-07 16:53:56.000000000","message":"Done","commit_id":"cdc72bea1fa8d63c38bb3f05e96f0868713c3216"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef3b8020ac4460b5b50f587b44ec09ed1abd3cf7","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        context.can(hv_policies.BASE_POLICY_NAME % \u0027search\u0027, target\u003d{})"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        # Get all compute nodes with a hypervisor_hostname that matches"},{"line_number":393,"context_line":"        # the given pattern. If none are found then it\u0027s a 404 error."},{"line_number":394,"context_line":"        compute_nodes \u003d self._get_compute_nodes_by_name_pattern(context, id)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        hypervisors \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"801a89cf_3a5bf801","line":393,"range":{"start_line":393,"start_character":29,"end_line":393,"end_character":69},"updated":"2021-01-06 11:40:47.000000000","message":"note the next reviewer: it is not obvious for the first glance as 404 coming from _get_compute_nodes_by_name_pattern() call.","commit_id":"cdc72bea1fa8d63c38bb3f05e96f0868713c3216"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4071fca65e12d9adc3c8a617c724a11bced02fd3","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        context.can(hv_policies.BASE_POLICY_NAME % \u0027search\u0027, target\u003d{})"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        # Get all compute nodes with a hypervisor_hostname that matches"},{"line_number":393,"context_line":"        # the given pattern. If none are found then it\u0027s a 404 error."},{"line_number":394,"context_line":"        compute_nodes \u003d self._get_compute_nodes_by_name_pattern(context, id)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        hypervisors \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"66ea25a1_bc3cbeab","line":393,"range":{"start_line":393,"start_character":29,"end_line":393,"end_character":69},"in_reply_to":"801a89cf_3a5bf801","updated":"2021-01-07 16:53:56.000000000","message":"Ack","commit_id":"cdc72bea1fa8d63c38bb3f05e96f0868713c3216"}],"nova/tests/unit/api/openstack/compute/test_hypervisors.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef3b8020ac4460b5b50f587b44ec09ed1abd3cf7","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        if hyper.uuid \u003d\u003d compute_id:"},{"line_number":137,"context_line":"            return hyper"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        if ("},{"line_number":140,"context_line":"            (isinstance(compute_id, int) or compute_id.isdigit()) and"},{"line_number":141,"context_line":"            hyper.id \u003d\u003d int(compute_id)"},{"line_number":142,"context_line":"        ):"},{"line_number":143,"context_line":"            return hyper"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e00036a_e2c3ce95","line":140,"range":{"start_line":139,"start_character":8,"end_line":140,"end_character":13},"updated":"2021-01-06 11:40:47.000000000","message":"meh","commit_id":"cdc72bea1fa8d63c38bb3f05e96f0868713c3216"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a2397196379c97a010922dce2afb208041fc5502","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if hyper.uuid \u003d\u003d compute_id:"},{"line_number":137,"context_line":"            return hyper"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        if ("},{"line_number":140,"context_line":"            (isinstance(compute_id, int) or compute_id.isdigit()) and"},{"line_number":141,"context_line":"            hyper.id \u003d\u003d int(compute_id)"},{"line_number":142,"context_line":"        ):"},{"line_number":143,"context_line":"            return hyper"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c23e38c_add8de0a","line":140,"range":{"start_line":139,"start_character":8,"end_line":140,"end_character":13},"in_reply_to":"2e00036a_e2c3ce95","updated":"2021-01-06 11:46:07.000000000","message":"I needed the second bracket because I have to handle both an integer and a string-ified integer. For some reason the \"is_uuid_like\" check wasn\u0027t doing the job to filter out integer values 😞","commit_id":"cdc72bea1fa8d63c38bb3f05e96f0868713c3216"}]}