)]}'
{"id":"openstack%2Fnova~769520","triplet_id":"openstack%2Fnova~master~Iacabaea31311ae14084b55341608e16e531e6bd5","project":"openstack/nova","branch":"master","topic":"bp/modernize-os-hypervisors-api","hashtags":[],"change_id":"Iacabaea31311ae14084b55341608e16e531e6bd5","subject":"api: Normalize exception handling for os-hypervisors","status":"MERGED","created":"2021-01-06 11:16:10.000000000","updated":"2021-01-11 17:41:46.000000000","submitted":"2021-01-11 17:37:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"769520-bp/modernize-os-hypervisors-api","meta_rev_id":"d1b8e9688e570134d7e1d75cb345e1c603a6669c","_number":769520,"virtual_id_number":769520,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-11 17:37:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"recommended":{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},"all":[{"value":1,"date":"2021-01-11 01:47:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":2,"date":"2021-01-07 22:21:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":2,"date":"2021-01-11 11:46:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":1,"date":"2021-01-11 11:46:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"}],"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-06 11:40:47.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-01-06 13:10:58.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-06 13:49:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-06 13:53:54.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-06 15:08:04.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2021-01-06 15:52:07.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-07 21:11:23.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-11 01:47:12.000000000","updated_by":{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},"reviewer":{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},"state":"REVIEWER"}],"messages":[{"id":"736fa76d03eec308a6e101d39587a22d89b202cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-06 11:16:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ef3b8020ac4460b5b50f587b44ec09ed1abd3cf7","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-01-06 11:40:47.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a2397196379c97a010922dce2afb208041fc5502","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-06 11:46:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"89431d413014071dd1468614ecd59daf455588bc","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-06 13:10:58.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/20/769520/1/check/tempest-dsvm-full-focal-py3/705dc29/ : SUCCESS in 1h 42m 29s","accounts_in_message":[],"_revision_number":1},{"id":"a0e4c2816fd6a3e91149252118cf3e8c2e155e17","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-06 13:49:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/c24362e69336459ab2dcaeea70c06a0f : SUCCESS in 1h 13m 34s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/045bb7003f96416bbdab24515fa45cab : SUCCESS in 1h 42m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8908c7b4fab2433ba1ab0a924b2208ff : SUCCESS in 15m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a96322c1e2d24917b439020ca7def7da : SUCCESS in 13m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1b35814600454079bcad8567f1316a20 : SUCCESS in 7m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3ad3404eede24899a419652342655186 : SUCCESS in 11m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/006d6ec9a34a4f46a1c0b7d0ff38ad23 : SUCCESS in 13m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fa94be3b69844585ab7e38ee812e6021 : SUCCESS in 14m 53s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/30c3e83fc2f843859654e2b23c526a1f : SUCCESS in 10m 07s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/5a48aa50d5874ae2a5f1282cf00599ad : SUCCESS in 1h 10m 25s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c7e17d1e0ab543c78d91d85037b0c2b2 : SUCCESS in 1h 06m 40s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/0645e78786cf4cf1b391a48361834273 : SUCCESS in 1h 12m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/18e7c64630f74e43803618a6dbe730bd : SUCCESS in 52m 02s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/0a6e815513d04140a5a583dfd9ef140d : FAILURE in 1h 31m 14s\n- nova-next https://zuul.opendev.org/t/openstack/build/9f45ab3b29da486494bcab77263cb2fa : FAILURE in 1h 57m 59s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/fef60d393ee34700bc7a7a26c38e55c0 : SUCCESS in 18m 03s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/ec932bdeae28405cb78212e98612bdbd : SUCCESS in 18m 49s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/00facea219f041fe821e694c118b4cb8 : SUCCESS in 58m 14s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9144aa6b6861443493f1aa5018dda1a1 : SUCCESS in 53m 54s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/f8d51820ed3f4d09b56c5704cc244f49 : SUCCESS in 28m 45s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/395b40a848df4097afccab637f96be82 : FAILURE in 39m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fbc68e47cee89aac134f588fc7b3c6cca14d940d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-06 13:53:54.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/769520/1 : SUCCESS in 2h 31m 05s","accounts_in_message":[],"_revision_number":1},{"id":"ee803800e9537784e0963f9681731c934cadd2ca","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-06 14:15:53.000000000","message":"Patch Set 1:\n\nrecheck failed to delete volume","accounts_in_message":[],"_revision_number":1},{"id":"2de9bc650ecb520ed2f5de24255df6eacf41f94f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-06 15:51:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/27e3d8b124084d9881eec1291c560285 : SUCCESS in 1h 07m 08s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1bf60b81a5bb42219d9158be872ebc47 : SUCCESS in 1h 17m 13s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b75f3f7af2164a78bb13cfc536de6775 : SUCCESS in 22m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/412a2ce6581a4ffa821ef1965bb8ce16 : SUCCESS in 13m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e2d143f9df864868926f19527e8df1e6 : SUCCESS in 8m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/083362342881454fbb3d05df726f7f58 : SUCCESS in 11m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6a7788e62b2a45c3a15f48473502dbca : SUCCESS in 19m 07s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/06338222317245ff8d4e9af89d8099d8 : SUCCESS in 20m 10s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9122869b23d243cc937a73b0cfb905bd : SUCCESS in 10m 33s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/72c0fae976f5490a8b8bffadaa0035db : SUCCESS in 1h 05m 33s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/8ed85b492b834d4fbe2f32b2a098b812 : SUCCESS in 1h 08m 22s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/034d85ade34445f895d72dd82cc50228 : SUCCESS in 1h 15m 50s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8dfdbd362b0047f29de49d6a59b9f09a : SUCCESS in 51m 38s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/30bb2cbfb87f4cadb2f1c0c7fe6ac9d7 : SUCCESS in 1h 27m 03s\n- nova-next https://zuul.opendev.org/t/openstack/build/8b018a850ee047e7af44b42fd09e4d8e : SUCCESS in 1h 29m 36s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/9c03aaf360d64a818ada4ac93f4d629e : SUCCESS in 21m 21s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/3e5b920ab0b4432990634e125b77b71b : SUCCESS in 22m 38s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/93b7a26440164e999103ffc4abd4ccea : SUCCESS in 58m 32s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f9b007d8b0ea443fafdc1d3582561226 : SUCCESS in 1h 02m 07s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/5eb56a4574cd42e3b4e0b71196928ee9 : SUCCESS in 27m 23s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/4ca4dfa0f9c44c70a093bcbc4de04285 : FAILURE in 46m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"57355fab1515a6a91378ae420054246acf9f6218","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-01-06 15:52:07.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/20/769520/1/check/EMC_PowerFlex_NOVA/d650359/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"267e0d7b565d73ca46b1ce28cdc40130524b717f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-06 16:13:23.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/20/769520/1/check/tempest-dsvm-full-focal-py3/ff3fbcc/ : SUCCESS in 1h 52m 41s","accounts_in_message":[],"_revision_number":1},{"id":"e928c6ce9eda8527f58058c4ea62cd7119f252b8","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-06 17:08:13.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/769520/1 : SUCCESS in 2h 50m 54s","accounts_in_message":[],"_revision_number":1},{"id":"6ba641426ffb84c8b43caacb6ec52cc2f85b52f4","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-01-06 19:34:48.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nlgtm, only one place if left to guard service_get_by_compute_host with ComputeHostNotFound","accounts_in_message":[],"_revision_number":1},{"id":"4071fca65e12d9adc3c8a617c724a11bced02fd3","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-07 16:53:56.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"16c9dd20fb874bf984462eb8c8c318695fb68713","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-07 17:36:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1c90cc73fd60f6bffe6c4dc00592dbfeac3ca3bb","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-01-07 21:11:23.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/769520/769520/2/check-not-vote/ext-nova-zuul/bda535b : SUCCESS in 1h 09m 04s","accounts_in_message":[],"_revision_number":2},{"id":"1ba0edc13b10642d2ae181b2678add1921cf0080","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-07 21:11:41.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/769520/2 : FAILURE in 11m 52s","accounts_in_message":[],"_revision_number":2},{"id":"a03549300c99bac14b7c433e27309b3467ba8b3c","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-07 22:03:16.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/20/769520/2/check/tempest-dsvm-full-focal-py3/446158e/ : SUCCESS in 1h 58m 54s","accounts_in_message":[],"_revision_number":2},{"id":"c42506e57f751dd3ef4eb703f5b5cb19d9d147e7","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-01-07 22:21:11.000000000","message":"Patch Set 2: Code-Review+2\n\nthanks lgtm.","accounts_in_message":[],"_revision_number":2},{"id":"2a2d19e87f562cb9f268d6fe6356a05e36ffb4c7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-07 23:35:59.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/623569fb2db54c1c840a4f2a88e31f91 : SUCCESS in 1h 21m 20s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c69e683d21224591ba59e0f31804c31b : SUCCESS in 1h 25m 16s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9279d6fa03f6445b91b2d65ca2dfaaa3 : SUCCESS in 16m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c82683da47fc487a93f46571323b5e5e : SUCCESS in 18m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e4104571d2614e2d850f1236a181c499 : SUCCESS in 7m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/05bea382f2a84354846aa453bc5522fb : SUCCESS in 11m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/50cdcfb812cc4f4fa4dac6fa4dec0feb : TIMED_OUT in 41m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5302bb0b780042e2a3436089dfd8a550 : SUCCESS in 13m 23s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a9290ff15f4245a98b837536511a88b3 : SUCCESS in 10m 58s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/4526e63fff5b4a2385724919838186f1 : SUCCESS in 1h 15m 02s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/9c77526c098545eaace3a2cff46edda9 : SUCCESS in 1h 08m 11s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/9af2cdf98ae744a3a4d0adfb3de2a4bf : SUCCESS in 1h 12m 34s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/4120320cc6544082ac8b88faff80838f : SUCCESS in 55m 53s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/4188fee2f0134570abf5d8d26e5e27b5 : SUCCESS in 1h 40m 20s\n- nova-next https://zuul.opendev.org/t/openstack/build/5ac7d21a6a4c4172ac6f6b900451c0a5 : SUCCESS in 1h 45m 53s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/afa756aaa84b42d0803d7a3ef96e93e8 : SUCCESS in 17m 01s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/5150ec90172644f2b4618cd6f15f9ba1 : SUCCESS in 18m 35s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1023c94dd5ba41439daafbae3d14e92f : SUCCESS in 1h 00m 21s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f479af037ced4dc89e41d40c45f2ed16 : SUCCESS in 56m 15s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/02728ba39b464d3cb3f92b545e42f65f : SUCCESS in 29m 20s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/f5a3025600164f7483ac21ebf6375b08 : SUCCESS in 39m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9b0211e34db3b5c534b9a4a6f4ca768b2774ac0c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-08 09:28:23.000000000","message":"Patch Set 2:\n\nrecheck timeout","accounts_in_message":[],"_revision_number":2},{"id":"cd064ba97c01ae2816997905a1771c5cf9ae13df","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-01-08 10:40:14.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/769520/769520/2/check-not-vote/ext-nova-zuul/4ab4d81 : SUCCESS in 1h 10m 25s","accounts_in_message":[],"_revision_number":2},{"id":"991e043c62b94430a0f49b758026a4eb21a0aaa5","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-08 11:46:09.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/20/769520/2/check/tempest-dsvm-full-focal-py3/3f2e46d/ : SUCCESS in 1h 42m 20s","accounts_in_message":[],"_revision_number":2},{"id":"5e306db9c43cd70b34fec3aceef7ccc02cd40008","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-08 11:56:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/956efafb1522497bb785b442e53b2653 : SUCCESS in 1h 02m 43s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/24c497a137d546f89743590468208177 : SUCCESS in 1h 13m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1966ea4a95ad4faa8ca708d9cf8f439c : SUCCESS in 17m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2e65ba46da2c4b958c6014e2aba0fbe6 : SUCCESS in 13m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/940d675fe82c423fa2cb99550985da2b : SUCCESS in 7m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/25333370c5a442cf932d42324a0421e1 : SUCCESS in 15m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d8f8bd708a934f8b8fe14604cc7e4610 : SUCCESS in 22m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/126f007d7518419ba7237207c736a5d0 : SUCCESS in 16m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4b5432ae3eae4244ab22d387353ea4f4 : SUCCESS in 10m 12s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/128e865a20404cd08381f5e513078b98 : SUCCESS in 1h 09m 25s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/887bac9c4f9e4d9a846037d33a23288e : SUCCESS in 1h 10m 22s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/600fcf1851ac4c2699f995ff8d1dac4b : SUCCESS in 1h 25m 29s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5eeb597ce62e41e7b5ae5145ee5a4f8a : SUCCESS in 48m 38s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/08a201afb12e49f68321006b46b88e39 : SUCCESS in 1h 38m 43s\n- nova-next https://zuul.opendev.org/t/openstack/build/581aa30cd44842989099fc9baa8f35ca : SUCCESS in 1h 58m 12s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/14698e8f37654214b4a65c0d7ba780fe : SUCCESS in 17m 05s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/778178a0fe5047fd91e515d7d375ff9b : SUCCESS in 17m 46s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2789f00e3b144a5dbcd3b47920f64f90 : SUCCESS in 59m 35s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/d114ec34efc24f5ea00fbce99ca90133 : SUCCESS in 54m 41s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/3eb6be08b617482589af3e2c5f37b973 : SUCCESS in 36m 19s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/35afadc394fc4168860e4f6cfaed3142 : SUCCESS in 47m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0b6e58370816085f5f672dcfc4a8f5acb45ac2fc","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-01-08 11:57:07.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/20/769520/2/check/EMC_PowerFlex_NOVA/8a5628e/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"1ea11a49aeca832b84834408bf04b7cfd9425ed1","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-08 12:08:07.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/769520/2 : SUCCESS in 2h 37m 47s","accounts_in_message":[],"_revision_number":2},{"id":"80c8efd6bfdb6f4e04e2e689d0389f1a1b6fde95","author":{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},"date":"2021-01-11 01:47:12.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ffabfa96ed7563d55abc68655a30d1907bd17e4b","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-01-11 11:46:05.000000000","message":"Patch Set 2: Code-Review+2\n\nStill looks good","accounts_in_message":[],"_revision_number":2},{"id":"b734178d559521103a1995b4926b6ff36442e21b","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-01-11 11:46:10.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7c9421a3496ee238a428483c43379643fca4615a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-11 11:46:31.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9cf535148c5532479c240f2e43a7dbef60ef7df0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-11 17:37:01.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/e6b1de4ba3db48c89b50cef1229f1acb : SUCCESS in 57m 04s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/01ce16f2a6ff41158d21a191744a4238 : SUCCESS in 1h 34m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e7314d8945244c5c9b54dfb2a832630a : SUCCESS in 16m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/daa43bf1ca244bbca7d940ee6d2ab5f7 : SUCCESS in 7m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7136813539a24623bcaccacd3e4d5a7c : SUCCESS in 18m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d35161e2a1894bd7ab806da5161eed78 : SUCCESS in 15m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bff11c41b6664b3b94bd71bb71bd8452 : SUCCESS in 12m 50s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/e0b3c7cca9904e2ba0601acdb3e40649 : SUCCESS in 1h 17m 21s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6ea3d6dd80f845f89ec8be2298350335 : SUCCESS in 56m 56s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/7d4d6929a79144a496495ac1d9ed2227 : SUCCESS in 21m 01s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/51b0a3d5013c430bb36fd75fc821a42b : SUCCESS in 1h 46m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/f9973d0c4c4a4953a70baec4be92e857 : SUCCESS in 1h 47m 13s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c633af73638042088098758a494e09ff : SUCCESS in 1h 10m 44s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/36b708ae11214a27b3541a59826ab8c7 : SUCCESS in 58m 52s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ea1097c6277f4f40a50a401d5845aa54 : SUCCESS in 50m 09s","accounts_in_message":[],"_revision_number":2},{"id":"e5a1303895cf002d019ac72292701fb21e4d2b1e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-11 17:37:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d1b8e9688e570134d7e1d75cb345e1c603a6669c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-11 17:41:46.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1aed713edbe34e03ac9feb4ccd146033 : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ef7598ac2896d08a89e50ccb82a47244e63d6248","revisions":{"cdc72bea1fa8d63c38bb3f05e96f0868713c3216":{"kind":"REWORK","_number":1,"created":"2021-01-06 11:16:10.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/20/769520/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/20/769520/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/769520/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/769520/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/769520/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/20/769520/1"}}},"commit":{"parents":[{"commit":"f86bf703e5367dfce21a2819b926b2f32d0c72e4","subject":"tests: Remove \u0027test_extended_hypervisors\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f86bf703e5367dfce21a2819b926b2f32d0c72e4"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-05 17:28:15.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-06 11:16:00.000000000","tz":0},"subject":"api: Normalize exception handling for os-hypervisors","message":"api: Normalize exception handling for os-hypervisors\n\nMany of the functions implementing the various \u0027os-hypervisors\u0027\nendpoints share common code. In particular any of these functions\ncontain calls to both the \u0027instance_get_all_by_host\u0027 and\n\u0027service_get_by_compute_host\u0027 APIs of \u0027nova.compute.api.HostAPI\u0027 so we\ncan include instance and service information in the responses. All of\nthese calls are guarded with exception handlers, but the exceptions\nhandled differ between resources.\n\nThere is one exception we need to care about for\n\u0027instance_get_all_by_host\u0027: \u0027HostMappingNotFound\u0027, which is raised\nbecause the API is decorated with the \u0027target_cell\u0027 decorator. The\n\u0027service_get_by_compute_host\u0027 API is also decorated by the\n\u0027target_host_cell\u0027 decorator, however, it can also raise\n\u0027ComputeHostNotFound\u0027. This exception is possible because the\n\u0027service_get_by_compute_host\u0027 API calls\n\u0027nova.objects.Service.get_by_compute_host\u0027, which in turns calls\n\u0027nova.db.sqlalchemy.api.service_get_by_compute_host\u0027, via the\n\u0027_db_service_get_by_compute_host\u0027 helper. Not all of the functions that\ncalled \u0027service_get_by_compute_host\u0027 were correctly guarding against\n\u0027ComputeHostNotFound\u0027.\n\nIn addition to this, the call to the \u0027get_host_uptime\u0027 API used by the\n\u0027/os-hypervisors/uptime\u0027 API can raise \u0027HostNotFound\u0027 if the service has\nbeen deleted but the compute node still has to be manually cleaned up.\nConversely, a number of functions were handling \u0027ValueError\u0027 even though\nthis couldn\u0027t realistically be raised by the test.\n\nResolve all of the above.\n\nChange-Id: Iacabaea31311ae14084b55341608e16e531e6bd5\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nRelated-Bug: #1646255\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdc72bea1fa8d63c38bb3f05e96f0868713c3216"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdc72bea1fa8d63c38bb3f05e96f0868713c3216"}]},"branch":"refs/heads/master"},"ef7598ac2896d08a89e50ccb82a47244e63d6248":{"kind":"REWORK","_number":2,"created":"2021-01-07 17:36:26.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/20/769520/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/20/769520/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/769520/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/769520/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/769520/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/20/769520/2"}}},"commit":{"parents":[{"commit":"46899968619e4ea0ff2ab380977619bb29578d43","subject":"Merge \"tests: Remove \u0027test_extended_hypervisors\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/46899968619e4ea0ff2ab380977619bb29578d43"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-05 17:28:15.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-07 16:52:39.000000000","tz":0},"subject":"api: Normalize exception handling for os-hypervisors","message":"api: Normalize exception handling for os-hypervisors\n\nMany of the functions implementing the various \u0027os-hypervisors\u0027\nendpoints share common code. In particular any of these functions\ncontain calls to both the \u0027instance_get_all_by_host\u0027 and\n\u0027service_get_by_compute_host\u0027 APIs of \u0027nova.compute.api.HostAPI\u0027 so we\ncan include instance and service information in the responses. All of\nthese calls are guarded with exception handlers, but the exceptions\nhandled differ between resources.\n\nThere is one exception we need to care about for\n\u0027instance_get_all_by_host\u0027: \u0027HostMappingNotFound\u0027, which is raised\nbecause the API is decorated with the \u0027target_cell\u0027 decorator. The\n\u0027service_get_by_compute_host\u0027 API is also decorated by the\n\u0027target_host_cell\u0027 decorator, however, it can also raise\n\u0027ComputeHostNotFound\u0027. This exception is possible because the\n\u0027service_get_by_compute_host\u0027 API calls\n\u0027nova.objects.Service.get_by_compute_host\u0027, which in turns calls\n\u0027nova.db.sqlalchemy.api.service_get_by_compute_host\u0027, via the\n\u0027_db_service_get_by_compute_host\u0027 helper. Not all of the functions that\ncalled \u0027service_get_by_compute_host\u0027 were correctly guarding against\n\u0027ComputeHostNotFound\u0027.\n\nIn addition to this, the call to the \u0027get_host_uptime\u0027 API used by the\n\u0027/os-hypervisors/uptime\u0027 API can raise \u0027HostNotFound\u0027 if the service has\nbeen deleted but the compute node still has to be manually cleaned up.\nConversely, a number of functions were handling \u0027ValueError\u0027 even though\nthis couldn\u0027t realistically be raised by the test.\n\nResolve all of the above.\n\nChange-Id: Iacabaea31311ae14084b55341608e16e531e6bd5\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nRelated-Bug: #1646255\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ef7598ac2896d08a89e50ccb82a47244e63d6248"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ef7598ac2896d08a89e50ccb82a47244e63d6248"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}