)]}'
{"mypy-files.txt":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f45593a1c75bc6de166a18fbc2ed5683e4fb1c7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"nova/compute/manager.py"},{"line_number":2,"context_line":"nova/crypto.py"},{"line_number":3,"context_line":"nova/privsep/path.py"},{"line_number":4,"context_line":"nova/scheduler/utils.py"},{"line_number":5,"context_line":"nova/virt/driver.py"},{"line_number":6,"context_line":"nova/virt/hardware.py"},{"line_number":7,"context_line":"nova/virt/libvirt/__init__.py"}],"source_content_type":"text/plain","patch_set":2,"id":"a66328bc_b8283153","line":4,"updated":"2021-01-27 10:51:58.000000000","message":"/me whispers...","commit_id":"e6ff3651e60f9b9aeaa1201a7d15be0c82fbe02e"}],"nova/scheduler/utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd5589e3cac96d921e3e7f1cdaf35d458bb355f7","unresolved":true,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        :return: A dict of the form {resource_class: amount}"},{"line_number":431,"context_line":"        \"\"\""},{"line_number":432,"context_line":"        ret: ty.DefaultDict[str, int] \u003d collections.defaultdict(lambda: 0)"},{"line_number":433,"context_line":"        for rg in self._rg_by_id.values():"},{"line_number":434,"context_line":"            for resource_class, amount in rg.resources.items():"},{"line_number":435,"context_line":"                ret[resource_class] +\u003d amount"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9563d75_aa3b1a96","line":432,"updated":"2021-01-22 13:38:48.000000000","message":"your are jsut adding typeing here\nbut just a not that this use fo defaultdict with a lambda like that while clever is\na bit surprising.\n\ni totally get what its doing but clever is not nessasarly intunitive.\n\nthat said i dont know of a better way to do this so its fine","commit_id":"e6ff3651e60f9b9aeaa1201a7d15be0c82fbe02e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f45593a1c75bc6de166a18fbc2ed5683e4fb1c7","unresolved":true,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        :return: A dict of the form {resource_class: amount}"},{"line_number":431,"context_line":"        \"\"\""},{"line_number":432,"context_line":"        ret: ty.DefaultDict[str, int] \u003d collections.defaultdict(lambda: 0)"},{"line_number":433,"context_line":"        for rg in self._rg_by_id.values():"},{"line_number":434,"context_line":"            for resource_class, amount in rg.resources.items():"},{"line_number":435,"context_line":"                ret[resource_class] +\u003d amount"}],"source_content_type":"text/x-python","patch_set":2,"id":"9699d253_0a5b630e","line":432,"in_reply_to":"9e12033b_48edca2f","updated":"2021-01-27 10:51:58.000000000","message":"My bike is red and I don\u0027t want to discuss about how and where to park it.","commit_id":"e6ff3651e60f9b9aeaa1201a7d15be0c82fbe02e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"40b8c98270e113bdd828d8f70de2598260b85e6f","unresolved":true,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        :return: A dict of the form {resource_class: amount}"},{"line_number":431,"context_line":"        \"\"\""},{"line_number":432,"context_line":"        ret: ty.DefaultDict[str, int] \u003d collections.defaultdict(lambda: 0)"},{"line_number":433,"context_line":"        for rg in self._rg_by_id.values():"},{"line_number":434,"context_line":"            for resource_class, amount in rg.resources.items():"},{"line_number":435,"context_line":"                ret[resource_class] +\u003d amount"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e12033b_48edca2f","line":432,"in_reply_to":"a9563d75_aa3b1a96","updated":"2021-01-26 12:02:53.000000000","message":"it is either \n\ncollections.defaultdict(int)\n\nor\n\ncollections.defaultdict(lambda: 0)\n\nI agree that the lambda is more surprising at first but at the same time it is lot more explicit what it does than \u0027int\u0027.","commit_id":"e6ff3651e60f9b9aeaa1201a7d15be0c82fbe02e"}]}