)]}'
{"nova/cmd/status.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a0a5460a45f6083348c67730db26eb13fc290bd","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# NOTE(lyarwood): The following are imported as machine_type_utils expects them"},{"line_number":42,"context_line":"# to be registered under nova.objects when called via _check_machine_type_set"},{"line_number":43,"context_line":"from nova.objects import image_meta as image_meta_obj  # noqa: F401"},{"line_number":44,"context_line":"from nova.objects import instance as instance_obj  # noqa: F401"},{"line_number":45,"context_line":"from nova import policy"},{"line_number":46,"context_line":"from nova import utils"},{"line_number":47,"context_line":"from nova import version"}],"source_content_type":"text/x-python","patch_set":8,"id":"85d884b1_2b5f2fbe","line":44,"updated":"2021-02-16 10:14:49.000000000","message":"I\u0027m pretty sure if you just add \u0027from nova import objects\u0027 then this will happen automatically. There might be other side effects that we don\u0027t care for though?","commit_id":"7562e534d50fe65b388bd38075cb3a0eb3e8593e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"865e94cc8373bb1d2f5700c5439bac46d1904b88","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# NOTE(lyarwood): The following are imported as machine_type_utils expects them"},{"line_number":42,"context_line":"# to be registered under nova.objects when called via _check_machine_type_set"},{"line_number":43,"context_line":"from nova.objects import image_meta as image_meta_obj  # noqa: F401"},{"line_number":44,"context_line":"from nova.objects import instance as instance_obj  # noqa: F401"},{"line_number":45,"context_line":"from nova import policy"},{"line_number":46,"context_line":"from nova import utils"},{"line_number":47,"context_line":"from nova import version"}],"source_content_type":"text/x-python","patch_set":8,"id":"8ac4f939_e230cd5e","line":44,"in_reply_to":"85d884b1_2b5f2fbe","updated":"2021-02-16 17:02:56.000000000","message":"$ nova-status upgrade check\nTraceback (most recent call last):\n  File \"/usr/local/bin/nova-status\", line 6, in \u003cmodule\u003e\n    from nova.cmd.status import main\n  File \"/opt/stack/nova/nova/cmd/status.py\", line 49, in \u003cmodule\u003e\n    from nova.virt import machine_type_utils\n  File \"/opt/stack/nova/nova/virt/machine_type_utils.py\", line 189, in \u003cmodule\u003e\n    ) -\u003e ty.List[objects.Instance]:\nAttributeError: module \u0027nova.objects\u0027 has no attribute \u0027Instance\u0027\n\n^ that\u0027s the trace without this and it\u0027s because I\u0027m using nova.objects instead of nova.objects.instance.Instance in the previous change, I\u0027ll update.","commit_id":"7562e534d50fe65b388bd38075cb3a0eb3e8593e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"dad42eedb75a72b00f939e779b50f2d47fd53ec2","unresolved":true,"context_lines":[{"line_number":36,"context_line":"from nova import exception"},{"line_number":37,"context_line":"from nova.i18n import _"},{"line_number":38,"context_line":"from nova.objects import cell_mapping as cell_mapping_obj"},{"line_number":39,"context_line":"# NOTE(lyarwood): The following are imported as machine_type_utils expects them"},{"line_number":40,"context_line":"# to be registered under nova.objects when called via _check_machine_type_set"},{"line_number":41,"context_line":"from nova.objects import image_meta as image_meta_obj  # noqa: F401"},{"line_number":42,"context_line":"from nova.objects import instance as instance_obj  # noqa: F401"},{"line_number":43,"context_line":"from nova import policy"},{"line_number":44,"context_line":"from nova import utils"},{"line_number":45,"context_line":"from nova import version"}],"source_content_type":"text/x-python","patch_set":9,"id":"f069a065_a9bbc31a","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":63},"updated":"2021-02-17 09:51:31.000000000","message":"Argh apologies, I had sorted this out but lost it somehow. The issue is with the typing suggestions using nova.objects.Class instead of nova.objects.$module.Class.\n\nI\u0027ll respin later after reviews etc.","commit_id":"1c5b8dd25c131d19936fb24895cfe412a74e0c14"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"90ca6fb4cae59e6d0d5b9e3e17af4153facd7892","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        if machine_type_utils.get_instances_without_type(ctxt):"},{"line_number":318,"context_line":"            msg \u003d (_(\"\"\""},{"line_number":319,"context_line":"Instances found without hw_machine_type set. This warning can be ignored if"},{"line_number":320,"context_line":"your environment does not contain hyperv or libvirt based compute hosts."},{"line_number":321,"context_line":"Use the `nova-manage machine_type list_unset` command to list these instances."},{"line_number":322,"context_line":"For more details see the following:"},{"line_number":323,"context_line":"https://docs.openstack.org/latest/nova/admin/hw_machine_type.html\"\"\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"50732504_21c8b236","line":320,"range":{"start_line":320,"start_character":33,"end_line":320,"end_character":44},"updated":"2021-03-01 17:37:04.000000000","message":"drop","commit_id":"9a7c65c41551057ae0cdf32cee62308068f5df09"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"984b7bb35e412cef8e928b8af41b0585b2d99fba","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        if machine_type_utils.get_instances_without_type(ctxt):"},{"line_number":318,"context_line":"            msg \u003d (_(\"\"\""},{"line_number":319,"context_line":"Instances found without hw_machine_type set. This warning can be ignored if"},{"line_number":320,"context_line":"your environment does not contain hyperv or libvirt based compute hosts."},{"line_number":321,"context_line":"Use the `nova-manage machine_type list_unset` command to list these instances."},{"line_number":322,"context_line":"For more details see the following:"},{"line_number":323,"context_line":"https://docs.openstack.org/latest/nova/admin/hw_machine_type.html\"\"\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"fbc711d0_f3013e2f","line":320,"range":{"start_line":320,"start_character":33,"end_line":320,"end_character":44},"in_reply_to":"50732504_21c8b236","updated":"2021-03-01 21:57:29.000000000","message":"Done","commit_id":"9a7c65c41551057ae0cdf32cee62308068f5df09"}]}