)]}'
{"id":"openstack%2Fnova~770943","triplet_id":"openstack%2Fnova~stable%2Ftrain~I9480ac1749d448efe4f415f5e80ff9b9837216b6","project":"openstack/nova","branch":"stable/train","topic":"stale_train_hacking_2.0","hashtags":[],"change_id":"I9480ac1749d448efe4f415f5e80ff9b9837216b6","subject":"trivial: Resolve (most) flake8 3.x issues","status":"ABANDONED","created":"2021-01-15 14:39:34.000000000","updated":"2021-01-19 11:20:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"be4651257b6c728e16fc48397c44a364bcfb3705","_number":770943,"virtual_id_number":770943,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-01-18 14:39:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-15 14:39:34.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-01-15 17:12:03.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-15 18:40:51.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-16 00:31:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"36454530c323b275737955217876330dd69dfc6d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-01-15 14:39:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"01a3e61646597f24d47b25b2377533b2cf4d75f3","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-15 17:12:03.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/770943/1 : FAILURE in 2h 30m 56s","accounts_in_message":[],"_revision_number":1},{"id":"a496ae441da5941cf836cf436082b1fca406c082","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-15 18:40:51.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/43/770943/1/check/tempest-dsvm-full-bionic-py3/cd1a42a/ : SUCCESS in 1h 47m 54s","accounts_in_message":[],"_revision_number":1},{"id":"21e4abf74b9b6a5d4dc2e89a5f508d11566b2eec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-16 00:31:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/22af53efec3f4dcd8b99af04cfac7c2f : SUCCESS in 1h 11m 20s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/8ababfed90c24d4892f16d95256e0ada : SUCCESS in 1h 13m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f11c96fe3dad41c787f55b1c7811f52a : SUCCESS in 17m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/207d16c36faf46e19e4c88822d9e7bdb : SUCCESS in 13m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e40f5bc7156c4ea98b369d5637210986 : SUCCESS in 12m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d15219c4c32943e9b140639eb28c58a5 : SUCCESS in 12m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3a115852c8294d0a9b36fde660a0087f : SUCCESS in 12m 43s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/873a5b7c9ec44668a68502ed45fd3e2f : SUCCESS in 13m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66551904b5cf497ca53fa77f32fa5f4a : SUCCESS in 10m 20s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/747eadef74c8426fa6f7381d7fd1c345 : SUCCESS in 1h 16m 57s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/8b08d45760354fa7b09d69d4ef61dc66 : SUCCESS in 1h 15m 56s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/f1d55a156e504e0eadd85ed48fb799e5 : SUCCESS in 1h 15m 24s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ec318b3dd96a41688a8025d8db7724cd : SUCCESS in 1h 10m 10s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/86f2859d548e4c05bf4acba6f701d439 : SUCCESS in 56m 52s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/f3592852ab8b433a9a77b6d1608042e9 : SUCCESS in 1h 17m 37s\n- nova-next https://zuul.opendev.org/t/openstack/build/b79478e5148d424795497074de8b71e0 : SUCCESS in 1h 24m 29s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b0884c5bcbc746679599f38f615391bd : SUCCESS in 21m 22s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/3efef6c33e944f2884448dfc42653f4f : SUCCESS in 18m 03s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/b17fbea13f7a4e13b82d113caa9968e5 : SUCCESS in 2h 04m 16s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d1c75461b0b1444e8c23d76de76d45cb : SUCCESS in 56m 01s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6d9421231bc04eee9a4a73ced6a05014 : SUCCESS in 55m 55s","accounts_in_message":[],"_revision_number":1},{"id":"f430619859f7486e9b29b86d857aaef28c3860f7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-01-18 11:13:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"147d86eb3835e0587d40d6135241113ad299d15e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-18 13:55:07.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/770943/2 : FAILURE in 2h 39m 02s","accounts_in_message":[],"_revision_number":2},{"id":"128130517dea269c6d680f43d5ce95894ec5bc16","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-18 14:24:25.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/43/770943/2/check/tempest-dsvm-full-bionic-py3/91b7f21/ : SUCCESS in 1h 56m 50s","accounts_in_message":[],"_revision_number":2},{"id":"b3864ee2338f67cba4ebfbd3d6203fd59ac71fd2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-18 14:39:14.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/772ffa76c00141648e1df35ef555d4f1 : SUCCESS in 1h 10m 03s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/8cc2e5e6ed0844859f6cfb6725f16266 : FAILURE in 1h 27m 38s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e77838c405124a6f8d361c56430ec8b3 : SUCCESS in 18m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/65bac26f8588467787136b872e7fa8f7 : SUCCESS in 13m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/026d452156104889b78c950f61c150fa : SUCCESS in 13m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b5b2734d8c7342bf8d6e12ec9a26df71 : SUCCESS in 18m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/75a29b2bc106408ebfa4d8affcf0d5eb : SUCCESS in 11m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/51794ae968b540949e7ad9316f721014 : SUCCESS in 19m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5c261ca6eb75468fb5cc60b1e1ec48ca : SUCCESS in 10m 13s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ae7db38cfed64d24a12b606c3fb1aa9f : SUCCESS in 1h 08m 56s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/17f7611a42064352b20e13983bd45093 : SUCCESS in 1h 18m 30s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/0dcc3389e7a346aab5b2d95f1de49a1b : SUCCESS in 1h 03m 20s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f22f1060563d44a3b66fd152ae8d04ee : SUCCESS in 1h 06m 05s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ef8b6617744e4a979d207678002ecf5f : SUCCESS in 50m 47s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/bd320906115b420b8bc466678bbbcc10 : SUCCESS in 54m 18s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/844f78a2d334417dbd56cc5ee9315795 : SUCCESS in 1h 31m 17s\n- nova-next https://zuul.opendev.org/t/openstack/build/abd5c6828ced4b5995fb7f0a8c4e8d3c : SUCCESS in 1h 21m 02s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/eaa42f2a48d14c55b6bebf8b71d9c5d3 : SUCCESS in 21m 11s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/b00000ced5e04b488d44923aa4d1432a : SUCCESS in 20m 25s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/4207436193e64c05927646befcbd6db1 : SUCCESS in 2h 00m 28s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d7afb07e897b4620a1e9d8db8ccba7cd : SUCCESS in 1h 00m 58s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/201c8a6847aa4011a3f958cd8b396148 : SUCCESS in 55m 11s","accounts_in_message":[],"_revision_number":2},{"id":"be4651257b6c728e16fc48397c44a364bcfb3705","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-01-19 11:20:18.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d98a280aab58323fdc1e2d2aefd4a33cf2c1b4a4","revisions":{"86055635156df486a2259056386f54753c4d93e6":{"kind":"REWORK","_number":1,"created":"2021-01-15 14:39:34.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/43/770943/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/43/770943/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/43/770943/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/43/770943/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/43/770943/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/43/770943/1"}}},"commit":{"parents":[{"commit":"b2037fc4e356b55949339a1358c16431a9ab8930","subject":"[stable-only] Cap bandit to 1.6.2 and raise hacking, flake8 and stestr","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b2037fc4e356b55949339a1358c16431a9ab8930"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-11-22 15:47:13.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-01-15 14:35:13.000000000","tz":0},"subject":"trivial: Resolve (most) flake8 3.x issues","message":"trivial: Resolve (most) flake8 3.x issues\n\nA future change will bump flake8 to 3.x. See off most of the issues that\nthis will introduce now, with the exception of some missing typing\nimports in \u0027nova/virt/hardware.py\u0027 - fixing those here with the current\nversion of flake8 would actually raise an error about unused imports.\n\nChange-Id: I9480ac1749d448efe4f415f5e80ff9b9837216b6\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n(cherry picked from commit 9428ebfed976e0d5755b72ef85fc92721f9d30ee)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/86055635156df486a2259056386f54753c4d93e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/86055635156df486a2259056386f54753c4d93e6"}]},"branch":"refs/heads/stable/train"},"d98a280aab58323fdc1e2d2aefd4a33cf2c1b4a4":{"kind":"REWORK","_number":2,"created":"2021-01-18 11:13:58.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/43/770943/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/43/770943/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/43/770943/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/43/770943/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/43/770943/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/43/770943/2"}}},"commit":{"parents":[{"commit":"b2037fc4e356b55949339a1358c16431a9ab8930","subject":"[stable-only] Cap bandit to 1.6.2 and raise hacking, flake8 and stestr","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b2037fc4e356b55949339a1358c16431a9ab8930"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-11-22 15:47:13.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-01-18 11:12:12.000000000","tz":0},"subject":"trivial: Resolve (most) flake8 3.x issues","message":"trivial: Resolve (most) flake8 3.x issues\n\nA future change will bump flake8 to 3.x. See off most of the issues that\nthis will introduce now, with the exception of some missing typing\nimports in \u0027nova/virt/hardware.py\u0027 - fixing those here with the current\nversion of flake8 would actually raise an error about unused imports.\n\nNOTE(lyarwood): This stable/train backport includes changes to the\nfollowing files that were not required on master at the time of the\noriginal change:\n\nConflicts:\n    nova/tests/unit/virt/libvirt/test_driver.py\n    nova/virt/libvirt/driver.py\n    nova/virt/zvm/driver.py\n\nChange-Id: I9480ac1749d448efe4f415f5e80ff9b9837216b6\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n(cherry picked from commit 9428ebfed976e0d5755b72ef85fc92721f9d30ee)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d98a280aab58323fdc1e2d2aefd4a33cf2c1b4a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d98a280aab58323fdc1e2d2aefd4a33cf2c1b4a4"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}