)]}'
{"id":"openstack%2Fnova~771985","triplet_id":"openstack%2Fnova~stable%2Frocky~I2a6ccaff904c1f0759d55feeeef0ec1da32c65df","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1798688","hashtags":[],"change_id":"I2a6ccaff904c1f0759d55feeeef0ec1da32c65df","subject":"Remove allocations before setting vm_status to SHELVED_OFFLOADED","status":"MERGED","created":"2021-01-22 14:31:56.000000000","updated":"2021-06-17 09:47:24.000000000","submitted":"2021-06-17 09:47:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"771985-bug/1798688","meta_rev_id":"91e707d922a8ea56469e46d0e8e94ebdc3eebb43","_number":771985,"virtual_id_number":771985,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-17 09:47:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2021-06-13 02:37:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2021-06-17 03:00:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2021-06-10 13:56:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2021-06-17 03:00:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-22 14:31:56.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2021-01-22 14:42:47.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-22 16:55:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-22 17:22:22.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-06-04 14:48:37.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"},{"updated":"2021-06-10 13:56:31.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2021-06-13 02:37:51.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2021-06-17 03:00:13.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"}],"messages":[{"id":"7bd62f1ae23eadb6cc3d95e690045394f4a4a2e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-01-22 14:31:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2be4085c2e7d7e19446b3f80b45b609a7eb365fa","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-22 14:42:47.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/771985/1 : FAILURE in 9m 17s","accounts_in_message":[],"_revision_number":1},{"id":"6ef40abe699c2d11ddad62fc36627f9072382d5c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 16:55:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a6f3a38170d44f90bade5d0cb08cfff1 : SUCCESS in 9m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0ca07104f33e4a4f98993512f729fa7f : FAILURE in 4m 34s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/465f6258478e482baec384323ffecdf9 : SUCCESS in 13m 46s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/6b280e407b614c799f6e98633cdd0790 : SUCCESS in 9m 37s\n- tempest-full https://zuul.opendev.org/t/openstack/build/53e96debaa3f497dbf63e2a6ee7ec856 : SUCCESS in 1h 18m 25s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/17285981c27d411c8b68471cbf280548 : SUCCESS in 50m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6d9e7c785d574c139d4b76bc93ffecea : SUCCESS in 1h 19m 22s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/669db6275ff4473f9c935bea821d72ab : SUCCESS in 44m 52s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/d70b7f83bba144f1b0a31412cf81c8bd : SUCCESS in 1h 01m 15s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/42a4b63b12904c0cbc25d8625281a700 : SUCCESS in 58m 59s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/563b69f4f2b440d2a4c1ff68f709cb1f : SUCCESS in 57m 47s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/55d341065b064c968ec4280c1dc44c28 : SUCCESS in 59m 27s\n- nova-next https://zuul.opendev.org/t/openstack/build/201795b8ea2f4d35a1546fc334f574b9 : SUCCESS in 1h 24m 16s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/43634e007d5546c3876612c9bb4c8cc5 : SUCCESS in 1h 50m 08s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f907a07ddb414427abb5e6c0a070686e : FAILURE in 5m 14s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/de6724faa6714dc497d3f68d5807602f : SUCCESS in 16m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/913ef638ddbe477c9ad69031b53c4ddd : FAILURE in 4m 17s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/d6d35b0f11144eb9859a34b715bd252e : SUCCESS in 58m 09s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/02d66134c3d34c1a872058d77c9041d2 : FAILURE in 1h 00m 48s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/784ad4febcc044958fd0c904afa20adc : SUCCESS in 1h 31m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"41df522a3bd6d29831c1de5c9726fc3afdc38abf","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-22 17:22:22.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/85/771985/1/check/tempest-dsvm-full-bionic-py3/f67d2d2/ : SUCCESS in 1h 32m 20s","accounts_in_message":[],"_revision_number":1},{"id":"f1258542a250b1f67c4d3a4b13d246d01703d138","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-04 14:48:37.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"511614eb13d209cb3f40b571a9205a2933634c06","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-04 14:48:51.000000000","message":"Topic set to bug/1798688","accounts_in_message":[],"_revision_number":1},{"id":"3f5a9a01f4212bcaf8c0710fe3c6dd94b91c69fc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 17:22:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/be56323830f743a497ed716713e77ba1 : SUCCESS in 11m 13s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1b2a833b850741e8960d042d4a2c0a04 : SUCCESS in 14m 09s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/f39e1132dcb24055beed0383a69ee949 : SUCCESS in 17m 56s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/93845d5aff03434f93ef3024bb12170f : SUCCESS in 9m 15s\n- tempest-full https://zuul.opendev.org/t/openstack/build/64f45c39e8be4385bdc3a81e993e3d64 : SUCCESS in 1h 32m 31s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/44c7d258997d4e3bbb3774c5f804d64d : SUCCESS in 1h 00m 18s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8e4e8e20c4ec47c396b9c717a323e13c : SUCCESS in 1h 25m 58s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d046f76d531d4e598d7d5b73be72def0 : SUCCESS in 50m 20s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/46d7db5aff88450e8dbae5d3600d577f : SUCCESS in 1h 00m 23s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/eef1c8bb43b940d9a9420b9cca64ed53 : SUCCESS in 1h 07m 13s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/4a9d833142f94515a72e9618784f656b : SUCCESS in 52m 25s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/84763d0445ed471691259e21908e3b4d : SUCCESS in 1h 06m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/c9eb2e8b619646bd8f36a04a982d50c8 : SUCCESS in 1h 26m 22s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/5a551f9dee1b4ce69a46572a422280b4 : SUCCESS in 1h 57m 13s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f112077ce24c400d97ac5208b181cf3f : SUCCESS in 18m 54s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/02671e1aaae7457488c3c563b47787b3 : SUCCESS in 18m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/44d5d896b8f34d34b102e34fc0782b3f : FAILURE in 4m 16s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/1b22ac2923de4be49ef7778fc30393c4 : SUCCESS in 1h 08m 17s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/9ea7c92e2fec46aa84aed4a485d36dcb : SUCCESS in 1h 30m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"65562fd01abab51cadafd841822a7a504f1c0863","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-04 19:28:38.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/696a831a00604f90998b03f5b68011b7 : POST_FAILURE in 1h 40m 07s","accounts_in_message":[],"_revision_number":1},{"id":"a5b16995edeb558e383797e7a7923a70c151e117","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-10 13:56:31.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry pick from stein, where the patch has merged (when it was still master). Looks OK to backport.","accounts_in_message":[],"_revision_number":1},{"id":"7291685cd91d92e7d2770cbcf2c555ad00300d56","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-06-13 02:37:51.000000000","message":"Patch Set 1: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"4f44b69ef4e1cc4831dc2baed15affc04f3d4b46","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-06-17 03:00:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport of important bug fix that originally landed in stein. LGTM","accounts_in_message":[],"_revision_number":1},{"id":"3a6972cd718acc33da463923a6836bcf396df0c6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 03:00:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"41704b6e9b78bf645ea484b86665339afb0bee8a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 09:47:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0105620f513a42be8e45a64897e1c3e5 : SUCCESS in 11m 10s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/856e3bcd56b14a489b46531a5b9f98cf : SUCCESS in 23m 49s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/32d22d1eb9c34af6bed8173f1e6c4fa8 : SUCCESS in 14m 36s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/0045eac512d449a0ad064c30f017a582 : SUCCESS in 11m 24s\n- tempest-full https://zuul.opendev.org/t/openstack/build/6bba2b991dc14436b88d499a1deb6628 : SUCCESS in 1h 41m 09s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/46fbe1d13361499086d7215d5b5b1b86 : SUCCESS in 53m 44s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1896c1af6fd5443b854c2a1a2ee2e7a3 : SUCCESS in 1h 39m 38s\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/5d17ac6b806f48daa842cee153019a17 : SUCCESS in 1h 00m 44s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/637ae9962a454dad8ad946ded14919e8 : SUCCESS in 1h 07m 37s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/1e529d5642be49ea8aeb48522998a4df : SUCCESS in 56m 21s\n- nova-next https://zuul.opendev.org/t/openstack/build/962ac20e35cb4d719068ea2e7f7b3c1e : SUCCESS in 1h 23m 49s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/79d1fa374a7a4a118cea4758b5ca15b1 : SUCCESS in 2h 00m 32s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/590e177a63494f51b0a6b1fd40a7cc5f : SUCCESS in 16m 53s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/59a1e55a1623486c852dec784e7fa144 : SUCCESS in 17m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/340c778075dc4195b85c7a12d002fae1 : FAILURE in 10m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"91e707d922a8ea56469e46d0e8e94ebdc3eebb43","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 09:47:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1121a59edb48fe133df14bfd4384eef04ce687a7","revisions":{"1121a59edb48fe133df14bfd4384eef04ce687a7":{"kind":"REWORK","_number":1,"created":"2021-01-22 14:31:56.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/85/771985/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/771985/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/771985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/771985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/771985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/771985/1"}}},"commit":{"parents":[{"commit":"3c774435502a339f202e94ae15d637e49a19d4ce","subject":"Follow up for cherry-pick check for merge patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3c774435502a339f202e94ae15d637e49a19d4ce"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-12-07 22:27:16.000000000","tz":-300},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-01-22 14:31:03.000000000","tz":0},"subject":"Remove allocations before setting vm_status to SHELVED_OFFLOADED","message":"Remove allocations before setting vm_status to SHELVED_OFFLOADED\n\nTempest is intermittently failing a test which does the\nfollowing:\n\n1. Create a server.\n2. Shelve offload it.\n3. Unshelve it.\n\nTempest waits for the server status to be SHELVED_OFFLOADED\nbefore unshelving the server, which goes through the\nscheduler to pick a compute node and claim resources on it.\n\nWhen shelve offloading a server, the resource allocations\nfor the instance and compute node it was on are cleared, which\nwill also delete the internal consumer record in the placement\nservice.\n\nThe race is that the allocations are removed during shelve\noffload *after* the server status changes to SHELVED_OFFLOADED.\nThis leaves a window where unshelve is going through the\nscheduler and gets the existing allocations for the instance,\nwhich are non-empty and have a consumer generation. The\nclaim_resources method in the scheduler then uses that\nconsumer generation when PUTing the allocations. That PUT\nfails because in between the GET and PUT of the allocations,\nplacement has deleted the internal consumer record. When\nPUTing the new allocations with a non-null consumer generation,\nplacement returns a 409 conflict error because for a new\nconsumer it expects the \"consumer_generation\" parameter to be\nNone.\n\nThis change handles the race by simply making sure the allocations\nare deleted (along with the related consumer record in placement)\n*before* the instance.vm_status is changed.\n\nChange-Id: I2a6ccaff904c1f0759d55feeeef0ec1da32c65df\nCloses-Bug: #1798688\n(cherry picked from commit 6369f39244558b147f7b0796269d9a86ce9b12d8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1121a59edb48fe133df14bfd4384eef04ce687a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1121a59edb48fe133df14bfd4384eef04ce687a7"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}