)]}'
{"id":"openstack%2Fnova~771986","triplet_id":"openstack%2Fnova~stable%2Fqueens~I2a6ccaff904c1f0759d55feeeef0ec1da32c65df","project":"openstack/nova","branch":"stable/queens","topic":"bug/1798688","hashtags":[],"change_id":"I2a6ccaff904c1f0759d55feeeef0ec1da32c65df","subject":"Remove allocations before setting vm_status to SHELVED_OFFLOADED","status":"ABANDONED","created":"2021-01-22 14:32:25.000000000","updated":"2022-11-11 18:23:20.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9b1438f1f3d362a9c628229925e997a426dc4e7d","_number":771986,"virtual_id_number":771986,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-06-24 21:58:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2021-06-24 13:41:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-22 14:32:25.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2021-01-22 14:44:16.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-22 15:55:02.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-22 16:46:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-24 13:41:50.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"7f4cffe924c44c736c143be4151f818800c4f07f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-01-22 14:32:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"27f0cdbc66b693afe358798262c5766011bba62f","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-22 14:44:16.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/771986/1 : FAILURE in 9m 31s","accounts_in_message":[],"_revision_number":1},{"id":"c021a490ef302cf3f64612c26bed92eb29753fe5","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-22 15:55:02.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/86/771986/1/check/tempest-dsvm-full-xenial/afad7ac/ : FAILURE in 35m 52s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/86/771986/1/check/tempest-dsvm-full-xenial-py3/4d5b3c8/ : FAILURE in 34m 25s","accounts_in_message":[],"_revision_number":1},{"id":"bdb10780ca2d5fbaf241b97d88a573d9d01c0f23","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 16:46:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b7be702f74fb48be9dbac83952c2deac : FAILURE in 13m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/68b057d2b1b5496ab2c90cd8920fddcb : SUCCESS in 15m 44s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/0003830972cf44939665ff30aa3a6027 : SUCCESS in 13m 19s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/49c490b5de8040f0990e4fc6a33874f7 : SUCCESS in 8m 08s\n- tempest-full https://zuul.opendev.org/t/openstack/build/2dc5d772143847d5a9992179f3b9a959 : SUCCESS in 1h 15m 58s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/4d068c6574a645259d505bbcb8fefa02 : SUCCESS in 52m 37s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4514dc5528cc49778ec7bfa1222fa88a : SUCCESS in 1h 10m 52s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b461dc89e414493689f9c2f29ff66e1d : SUCCESS in 40m 04s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/9a960957f39d42e99e54d2368ff5a4bb : FAILURE in 44m 55s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/c19d24655bf2477481cf7def75fc44c1 : FAILURE in 43m 01s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/75fa63c86ff34d10a0458b23a8b77e61 : SUCCESS in 43m 41s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/9959cc475f7443f0907d3b93de455026 : SUCCESS in 49m 46s\n- nova-next https://zuul.opendev.org/t/openstack/build/cade65fa45464b579c029dbd4b4211b6 : SUCCESS in 1h 17m 38s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/09bb7c9aceef4d5b92d515236e4b1327 : SUCCESS in 1h 40m 57s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/dfaad2b6fe96401aa98f105aa5c2cc3a : SUCCESS in 22m 48s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/6a3c8d687aa349a2982e7aec6161be33 : SUCCESS in 18m 34s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/d940465c9cd644e59cc95ffe259e34f6 : SUCCESS in 58m 16s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/e40c7aa721594692a86d0eecb2b8a3df : FAILURE in 56m 06s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/7b9873c22b1a413e93f3f6c0786d804b : FAILURE in 1h 15m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"967c352e940ed86bf34d56064341a92e7fad7089","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-04 14:49:12.000000000","message":"Topic set to bug/1798688","accounts_in_message":[],"_revision_number":1},{"id":"aac9de1aba3d6717c3b251e9af937063f53c289f","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-24 13:41:50.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry pick from Rocky, where the patch has merged. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"3dbe18d3a16dcd10f28a5f4516d724ade1353d56","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-24 13:42:11.000000000","message":"Patch Set 1:\n\nrecheck - rocky patch has merged","accounts_in_message":[],"_revision_number":1},{"id":"dcc7fab3231f0ea0d41ed2b8ca2b1be94e0f585e","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-24 19:26:33.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial finger://zuul-v3-executor.novalocal/81a0dc98dde0439a9e376ded376f357a : POST_FAILURE in 28m 56s\n- tempest-dsvm-full-xenial-py3 finger://zuul-v3-executor.novalocal/727bb03cb7fe4c6d953e5016ca71b870 : POST_FAILURE in 28m 44s","accounts_in_message":[],"_revision_number":1},{"id":"77944076efe4f6a91952808fd0fc07249d2cad70","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 21:58:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d3bfc6f2e93648b2a9d72a7b66c1e785 : SUCCESS in 11m 56s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7f6999571a114ff79ee77401cc902450 : SUCCESS in 16m 07s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/4a3e3538e6104e36b70311846df5ba52 : SUCCESS in 20m 27s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/5bc597fb137647ee9638578c9c56706f : SUCCESS in 10m 49s\n- tempest-full https://zuul.opendev.org/t/openstack/build/be22d0a673f24d5797eef77c5a65fab9 : SUCCESS in 1h 29m 55s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/6708becd72314eb89499fc3855176be2 : SUCCESS in 52m 13s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4446866f8ac440e4a52236394400b41f : SUCCESS in 1h 23m 25s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/800b9888de074108a3eae52919ee6674 : SUCCESS in 49m 23s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/33a9a2f0e65047768297d0aa76fc6f5b : SUCCESS in 44m 46s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/71e7073379e54011affa3cd77bac07f7 : SUCCESS in 58m 16s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/17debef3f0b64215b8414e01f9af2656 : SUCCESS in 48m 33s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/7cee09a0df7343bcabf92d70f97503b5 : SUCCESS in 57m 38s\n- nova-next https://zuul.opendev.org/t/openstack/build/b76b3286402246c1aa296cfed5338294 : SUCCESS in 1h 27m 45s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/956255819e244a5496afb33a416c5e32 : SUCCESS in 1h 51m 22s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bcfb4e85db4c4ef4b4d3c8f7b591857a : SUCCESS in 21m 40s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/79cbbeb13bf34294b2255493e6f35fca : SUCCESS in 20m 46s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/54d628dd905a48beb58e1e59160d4af9 : SUCCESS in 1h 11m 58s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/da6af1ef64024771816161191cdc7740 : SUCCESS in 1h 28m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9b1438f1f3d362a9c628229925e997a426dc4e7d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:23:20.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6101380051cd7dbd3613bfa7358710cb14f03bee","revisions":{"6101380051cd7dbd3613bfa7358710cb14f03bee":{"kind":"REWORK","_number":1,"created":"2021-01-22 14:32:25.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/86/771986/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/86/771986/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/86/771986/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/86/771986/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/86/771986/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/86/771986/1"}}},"commit":{"parents":[{"commit":"2592ee950e9ef1ac36bbc7f01ce94a25fd76bb1f","subject":"[stable-only] Cap bandit to 1.6.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2592ee950e9ef1ac36bbc7f01ce94a25fd76bb1f"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-12-07 22:27:16.000000000","tz":-300},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-01-22 14:32:09.000000000","tz":0},"subject":"Remove allocations before setting vm_status to SHELVED_OFFLOADED","message":"Remove allocations before setting vm_status to SHELVED_OFFLOADED\n\nTempest is intermittently failing a test which does the\nfollowing:\n\n1. Create a server.\n2. Shelve offload it.\n3. Unshelve it.\n\nTempest waits for the server status to be SHELVED_OFFLOADED\nbefore unshelving the server, which goes through the\nscheduler to pick a compute node and claim resources on it.\n\nWhen shelve offloading a server, the resource allocations\nfor the instance and compute node it was on are cleared, which\nwill also delete the internal consumer record in the placement\nservice.\n\nThe race is that the allocations are removed during shelve\noffload *after* the server status changes to SHELVED_OFFLOADED.\nThis leaves a window where unshelve is going through the\nscheduler and gets the existing allocations for the instance,\nwhich are non-empty and have a consumer generation. The\nclaim_resources method in the scheduler then uses that\nconsumer generation when PUTing the allocations. That PUT\nfails because in between the GET and PUT of the allocations,\nplacement has deleted the internal consumer record. When\nPUTing the new allocations with a non-null consumer generation,\nplacement returns a 409 conflict error because for a new\nconsumer it expects the \"consumer_generation\" parameter to be\nNone.\n\nThis change handles the race by simply making sure the allocations\nare deleted (along with the related consumer record in placement)\n*before* the instance.vm_status is changed.\n\nChange-Id: I2a6ccaff904c1f0759d55feeeef0ec1da32c65df\nCloses-Bug: #1798688\n(cherry picked from commit 6369f39244558b147f7b0796269d9a86ce9b12d8)\n(cherry picked from commit 1121a59edb48fe133df14bfd4384eef04ce687a7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6101380051cd7dbd3613bfa7358710cb14f03bee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6101380051cd7dbd3613bfa7358710cb14f03bee"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}