)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4e20d336810977fbb418dba9558a321a669b0a0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add emulation support if host arch !\u003d guest arch."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tested [aarch64, armv7l, ppc64, ppc64le] on DevStack with both kvm and qemu"},{"line_number":10,"context_line":"virt_type set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Launching a guest will fail if guest arch isn\u0027t supported, but that is already"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"01189fbc_5a13e9ab","line":9,"updated":"2021-04-27 17:15:37.000000000","message":"nit: can you wrap this body at \u003c\u003d 72 characters","commit_id":"560b8b6ba70dd97873c22bb262c86c4f22124139"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4e20d336810977fbb418dba9558a321a669b0a0","unresolved":true,"context_lines":[{"line_number":6232,"context_line":"    ) -\u003e None:"},{"line_number":6233,"context_line":"        if CONF.libvirt.virt_type in (\"kvm\", \"qemu\"):"},{"line_number":6234,"context_line":"            host_arch \u003d self._host.get_capabilities().host.cpu.arch"},{"line_number":6235,"context_line":"            guest.os_arch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":6236,"context_line":"            guest.os_mach_type \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":6237,"context_line":"            if guest.os_arch !\u003d host_arch:"},{"line_number":6238,"context_line":"                # If emulating, downgrade from kvm to qemu"}],"source_content_type":"text/x-python","patch_set":7,"id":"7202b4f8_b23f0029","line":6235,"updated":"2021-04-27 17:15:37.000000000","message":"nit: could you save this as \u0027guest_arch\u0027 and simply assign that to \u0027guest.os_arch\u0027 at some point, like we do for \u0027mach_type\u0027","commit_id":"560b8b6ba70dd97873c22bb262c86c4f22124139"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4e20d336810977fbb418dba9558a321a669b0a0","unresolved":true,"context_lines":[{"line_number":6275,"context_line":"                    # hard fail if we don\u0027t support secure boot and it\u0027s"},{"line_number":6276,"context_line":"                    # required"},{"line_number":6277,"context_line":"                    if not self._check_secure_boot_support("},{"line_number":6278,"context_line":"                        host_arch, mach_type, hw_firmware_type,"},{"line_number":6279,"context_line":"                    ):"},{"line_number":6280,"context_line":"                        raise exception.SecureBootNotSupported()"},{"line_number":6281,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3da516de_fa867101","line":6278,"range":{"start_line":6278,"start_character":24,"end_line":6278,"end_character":33},"updated":"2021-04-27 17:15:37.000000000","message":"This should be checking against the guest architecture since (to the best of my knowledge) e.g. using SEV in a AArch64 guest on a x86_64 host doesn\u0027t make any sense.","commit_id":"560b8b6ba70dd97873c22bb262c86c4f22124139"}]}