)]}'
{"id":"openstack%2Fnova~772271","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1581977","hashtags":[],"change_id":"I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82","subject":"utils: Remove periods from instance hostnames","status":"ABANDONED","created":"2021-01-25 09:49:02.000000000","updated":"2021-02-11 17:07:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d51091294c53e255c3c180652461e9085622132c","_number":772271,"virtual_id_number":772271,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-01-25 13:19:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"disliked":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":-1,"date":"2021-01-27 09:57:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2021-02-02 14:30:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":-1,"date":"2021-02-11 16:58:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-25 12:00:25.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-25 12:30:33.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-25 13:19:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-27 09:57:59.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2021-01-27 12:27:10.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"CC"},{"updated":"2021-02-02 14:30:29.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-02-11 16:58:06.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"}],"messages":[{"id":"b590d26da7f0ca74b1a7f5d3ce0ff7d09ecacf41","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 09:49:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4ced9d27d0f51ef3903d15d2c6b312be626f67a5","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-25 12:00:25.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/71/772271/1/check/tempest-dsvm-full-focal-py3/611d5cc/ : SUCCESS in 1h 56m 24s","accounts_in_message":[],"_revision_number":1},{"id":"05bd733b0f17cd06c992cf7c370e3c9bfebb6c04","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-25 12:30:33.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/772271/1 : SUCCESS in 2h 38m 21s","accounts_in_message":[],"_revision_number":1},{"id":"5d7786ee0583afe8b49b3e6fc618c6b02c66790a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-25 13:19:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/e8f1bf56e63a4bbea043d1dd1c3f3002 : SUCCESS in 1h 02m 21s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/e4975bad53134170882a06cd2676681a : SUCCESS in 1h 20m 10s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/437a229ea83448bb87e34c76c069d580 : SUCCESS in 18m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/19210efb75e344c789ddee5a59bb74ae : SUCCESS in 15m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b5b0eeb5d7a94244af5aeae0b4fdc9d8 : SUCCESS in 8m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/49203805b4a74807961a8722567c0828 : SUCCESS in 13m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ec32948e35a1409abed8cf92a5815923 : SUCCESS in 12m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7e40a0a887124136b471f45eb0066afc : SUCCESS in 10m 49s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c4f05492bf2d4415ad8033541533e53c : SUCCESS in 15m 08s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/717146d3c2cc42a88ea59f7783354283 : SUCCESS in 1h 24m 54s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/e9726fb2e68b4abfbf177dbf2144f9a3 : SUCCESS in 1h 04m 16s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/03b64fbedb7240358fa1f51fabf7ca38 : SUCCESS in 1h 11m 24s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/16b1e36e5fd94657930ea248945630ed : SUCCESS in 52m 05s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/86879fc3fa3b41788b0dbf6ff7db5faa : SUCCESS in 1h 29m 40s\n- nova-next https://zuul.opendev.org/t/openstack/build/538227cb81a14c068c717168e5656bac : SUCCESS in 1h 46m 18s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b120a4e2e06f4ecebdeebdbf31ed049b : SUCCESS in 13m 27s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6473d9948af04f0ba8e63224fca93748 : SUCCESS in 1h 08m 08s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/875bcf8c6bd24d41aed0d27af1407432 : SUCCESS in 50m 53s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/7af0a1426b3046b7bf8e8a1614e00494 : FAILURE in 29m 56s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/42ac89fbf8a3443d8842a0f2b0c296c4 : FAILURE in 34m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9e6d428f3ed957e9d437196e471a48eb87c9f1ef","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-01-27 09:57:59.000000000","message":"Patch Set 1: Code-Review-1\n\nSorry, Stephen, I know that this patch was discussed previously... but I have been thinking and I think this would introduce a behavior change in stable so I don\u0027t feel comfortable with the backport to stable branch. :-/ stable cores: let me know if you think differently.","accounts_in_message":[],"_revision_number":1},{"id":"8f61232a26edecb08936c37e8e5426fc07fa0659","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-01-27 12:27:10.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e Sorry, Stephen, I know that this patch was discussed previously... but I have been thinking and I think this would introduce a behavior change in stable so I don\u0027t feel comfortable with the backport to stable branch. :-/ stable cores: let me know if you think differently.\n\nI agree that it introduces a change in behaviour but when the original behaviour is broken and invalid I think it\u0027s valid to change that on stable with an accompanying releasenote. For me this LGTM but I\u0027ll let Elod reply before voting.","accounts_in_message":[],"_revision_number":1},{"id":"c6f250999657e721e62cf2167390630d9b889ceb","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-02-02 14:30:29.000000000","message":"Patch Set 1: Code-Review+2\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e Sorry, Stephen, I know that this patch was discussed previously... but I have been thinking and I think this would introduce a behavior change in stable so I don\u0027t feel comfortable with the backport to stable branch. :-/ stable cores: let me know if you think differently.\n\u003e \n\u003e I agree that it introduces a change in behaviour but when the original behaviour is broken and invalid I think it\u0027s valid to change that on stable with an accompanying releasenote. For me this LGTM but I\u0027ll let Elod reply before voting.\n\nAdding my +2 after talking to Elod briefly.\n\nI\u0027ll leave it to other stable cores to act as tiebreakers here.","accounts_in_message":[],"_revision_number":1},{"id":"1037b5e800965c3e53ba8c1800e0adaef9b6ad6d","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-02-02 14:33:33.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e Sorry, Stephen, I know that this patch was discussed previously... but I have been thinking and I think this would introduce a behavior change in stable so I don\u0027t feel comfortable with the backport to stable branch. :-/ stable cores: let me know if you think differently.\n\u003e \n\u003e I agree that it introduces a change in behaviour but when the original behaviour is broken and invalid I think it\u0027s valid to change that on stable with an accompanying releasenote. For me this LGTM but I\u0027ll let Elod reply before voting.\n\nI\u0027m still hesitant with this patch, though Lee\u0027s comment made me rethink and I\u0027m unsure now, that maybe this could merge. Other opinions?","accounts_in_message":[],"_revision_number":1},{"id":"becbea4097bf29968613878abe2e50c8650905c4","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-02-11 16:58:06.000000000","message":"Patch Set 1: Code-Review-1\n\nYeah, I\u0027m in agreement with Elod. Here are my reasons:\n\n1. This is not a regression. It\u0027s been broken forever, but more specifically, it\u0027s been behavior that \npeople either have known about or worked around forever. That already gives it mass in terms of potential breakage when people move to wallaby, but at least that is moving across a seam where things like this are expected.\n2. It\u0027s very workaroundable. There\u0027s nobody today that is unable to do a thing until this is fixed.\n3. It doesn\u0027t affect everyone\n4. The failure mode is not a huge deal. It\u0027s not data loss, state corruption, etc. It may not be incredibly obvious what the problem is (which is always the case in nova) but once you google, you\u0027re able to help yourself out the problem and move on.\n\nAny one of those things (except maybe 3) would be grounds for considering NOT backporting. All of them together make the case super weak, IMHO, and since it involves a very user-visible API change, I\u0027d say it\u0027s just not worth it.","accounts_in_message":[],"_revision_number":1},{"id":"d51091294c53e255c3c180652461e9085622132c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-11 17:07:15.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0419847980fde4dbc980720a61315c14aeb4575b","revisions":{"0419847980fde4dbc980720a61315c14aeb4575b":{"kind":"REWORK","_number":1,"created":"2021-01-25 09:49:02.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/71/772271/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/772271/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/772271/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/772271/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/772271/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/772271/1"}}},"commit":{"parents":[{"commit":"d3968f17dfd079251b7a38fbd38ebec98868336b","subject":"Merge \"Reproduce bug 1907522 in functional test\" into stable/victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d3968f17dfd079251b7a38fbd38ebec98868336b"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-14 10:50:59.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-25 09:47:50.000000000","tz":0},"subject":"utils: Remove periods from instance hostnames","message":"utils: Remove periods from instance hostnames\n\nWhen creating an instance, nova sanitizes the \u0027instance.name\u0027 attribute,\nusing the \u0027nova.utils.sanitize_hostname\u0027 function, and stores this as\nthe \u0027instance.hostname\u0027 attribute. If neutron has the DNS extension\nenabled then this attribute will be reported as the \u0027dns_name\u0027 value\nwhen attaching ports [1].\n\nNova does not currently remove or replace periods in the name as part of\nthis sanitization. This results in the hostname being identified as a\n(FQDN) fully qualified domain name, with all the constraints placed on\nFQDNs [2]. This can be problematic for instances with common names such\nas \u0027ubuntu18.04\u0027 or \u0027test.a\u0027, which aren\u0027t valid since TLDs must start\nwith an alpha character and must be greater than 1 character long,\nrespectively. Attempting to boot instances with such names can result in\nfailures like the below when DNS integration is enabled in neutron:\n\n  RescheduledException: Build of instance foo was re-scheduled:\n  Invalid input for dns_name.\n  Reason: \u0027test-ubuntu-20.04\u0027 not a valid PQDN or FQDN.\n  Reason: TLD \u002704\u0027 must not be all numeric.\n\nStart replacing these periods with hyphens. This is a change in behavior\nand may affect users who are relying on this inadvertent support for\ninstance names as FQDNs when using cloud-init, however, a quick poll on\nopenstack-discuss [3] suggests the people that are using FQDN-like\ninstance names are setting hostnames in the guest explicitly and not\nrelying on the information provided via the nova metadata service,\nmeaning this will not affect them.\n\n[1] https://docs.openstack.org/neutron/victoria/admin/config-dns-int.html\n[2] https://stackoverflow.com/a/53875771/613428\n[3] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/019113.html\n\nChange-Id: I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1581977\n(cherry picked from commit 9046f0fff4be424eda25401a3f9b8752964de775)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0419847980fde4dbc980720a61315c14aeb4575b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0419847980fde4dbc980720a61315c14aeb4575b"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}