)]}'
{"id":"openstack%2Fnova~772276","triplet_id":"openstack%2Fnova~stable%2Fussuri~I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1581977","hashtags":[],"change_id":"I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82","subject":"utils: Remove periods from instance hostnames","status":"ABANDONED","created":"2021-01-25 09:50:58.000000000","updated":"2021-02-11 17:07:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ef5fceabf15bf3ec5a90d04a2521e791719ecb73","_number":772276,"virtual_id_number":772276,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-01-25 13:22:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-25 10:09:14.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-25 12:16:59.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-25 13:22:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"eb249b7757f2e116b961818fb8afd51c25e44eb5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 09:50:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fae9284ad5910bfe852f60d943a4aea4f1e0470b","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-25 10:09:14.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/772276/1 : FAILURE in 9m 20s","accounts_in_message":[],"_revision_number":1},{"id":"da8165a8f201fc1b8daa5d3b214874695471e140","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-25 12:16:59.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/76/772276/1/check/tempest-dsvm-full-bionic/adaed02/ : SUCCESS in 2h 03m 24s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/76/772276/1/check/tempest-dsvm-full-bionic-py3/b7cfab4/ : SUCCESS in 1h 38m 04s","accounts_in_message":[],"_revision_number":1},{"id":"718ecb83c8da71662a06a48df7d4b46752006eb6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-25 13:22:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/61a94f8c1ded4f51b1e0ff6c056fba5b : FAILURE in 9m 30s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/d3a32c6f04ca45b9b061081c47c028ec : SUCCESS in 1h 21m 47s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/547120d65663444e974d0528f8735c05 : SUCCESS in 18m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3de7b19e32794572a7fb056213606f5e : SUCCESS in 16m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3fae99611a1e4109abda9a31bd394df1 : FAILURE in 7m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6b4607a28e7047eba0a85a82432845e0 : SUCCESS in 12m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/218de5b6caf24118b28a576324918f2c : SUCCESS in 16m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1f20f6654e6e4cd992b9b9915be0e9e8 : SUCCESS in 11m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/16b08ca33a084237bad84884b92486f1 : SUCCESS in 17m 06s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b86adb5fec6748568d4d77abf788edd2 : SUCCESS in 1h 02m 09s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/b1c08e7dfb104efeb4dae9b6ae6f2c46 : SUCCESS in 1h 22m 35s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a20709c802a94050b5579adf788a3f1c : FAILURE in 15m 38s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f97f852f6c984ce693642b8882e59826 : SUCCESS in 56m 38s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/55ca1ffab9d54e9a8ce762d1aab1bf06 : SUCCESS in 1h 26m 07s\n- nova-next https://zuul.opendev.org/t/openstack/build/3ae90ac4ef42499f9dc940f711c6d2d9 : SUCCESS in 1h 25m 19s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/bf8d018ca89f46d1b6f7caaa5a57c00d : SUCCESS in 17m 39s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c0e36db9767b4b8290cc201acf9cdbe6 : SUCCESS in 1h 03m 14s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/fbd4ff419c5f4a208fedd72e1d183ee3 : SUCCESS in 50m 39s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/7d04fcacdc25421792c8de9742e108ea : FAILURE in 28m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"eb753f6257e88254a48083c9aaeaa6b19f799e47","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-09 15:48:51.000000000","message":"Patch Set 1:\n\nrecheck need new logs to see if error is real","accounts_in_message":[],"_revision_number":1},{"id":"947e0b931dca56d4e9a29e3fbab10b2efdbcce02","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-02-09 17:22:04.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/76/772276/1/check/tempest-dsvm-full-bionic/8f620b9/ : FAILURE in 54m 45s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/76/772276/1/check/tempest-dsvm-full-bionic-py3/2736d81/ : FAILURE in 52m 14s","accounts_in_message":[],"_revision_number":1},{"id":"683621c892f1fe9c0032518c154e757dd04a9988","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-02-09 18:34:14.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/772276/1/iscsi : FAILURE in 2h 43m 53s","accounts_in_message":[],"_revision_number":1},{"id":"5510ab4fe70e9ea7abb5042ff0b373bc1c61922c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 20:22:31.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/566f5f8126324b69abe3c7f4cb568df0 : SUCCESS in 1h 07m 17s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0614341544354544ab08a842b2ee87da : SUCCESS in 1h 25m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c17aee63cc7a41089634c746ec7370de : SUCCESS in 19m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/76ed3a8d44d647eca2410815923b5533 : SUCCESS in 16m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba744c24774d4621b6614f59e95b35b5 : FAILURE in 7m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9b69cf69a40e457f994c0d1a149b4927 : SUCCESS in 14m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4a5ea08d0a904f98a671ee19b6f94771 : SUCCESS in 13m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f40aefcb14fb408eb0da5f1efb783bb0 : SUCCESS in 10m 25s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5f786c5268e649f79ca76d47d00a013d : SUCCESS in 14m 28s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/f3681531ec674805b620732f8af859b0 : SUCCESS in 59m 24s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/9ea89dc4622444c0a66d195ef968fc21 : SUCCESS in 1h 05m 55s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/3e6d793c2e2d499f89a15f1dc6eb779c : FAILURE in 12m 14s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8404c764143f43689d1dd799d99a80ab : FAILURE in 11m 21s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/18c8bbea28a54b168db4bef569867671 : SUCCESS in 1h 18m 58s\n- nova-next https://zuul.opendev.org/t/openstack/build/9a47dac4c0ff4aff872b4548fc2c1fe4 : SUCCESS in 1h 29m 06s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/e802f18effe14abebdde4b1724e8afaa : SUCCESS in 20m 04s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f2265f8f2d394cbca621c62ad54ec287 : SUCCESS in 1h 00m 37s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f94be325e4114f03bc1d05a24b4a3c71 : SUCCESS in 57m 59s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/1a30b3710632434eaf9475814557029c : FAILURE in 30m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ef5fceabf15bf3ec5a90d04a2521e791719ecb73","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-11 17:07:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c6bd49d41941a1191a5f656821548fc728e3080e","revisions":{"c6bd49d41941a1191a5f656821548fc728e3080e":{"kind":"REWORK","_number":1,"created":"2021-01-25 09:50:58.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/76/772276/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/772276/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/772276/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/772276/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/772276/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/772276/1"}}},"commit":{"parents":[{"commit":"7ff9d4f38dc3e009bc247b197f2f2fe94b6edf6a","subject":"Merge \"Use cell targeted context to query BDMs for metadata\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7ff9d4f38dc3e009bc247b197f2f2fe94b6edf6a"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-14 10:50:59.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-25 09:50:17.000000000","tz":0},"subject":"utils: Remove periods from instance hostnames","message":"utils: Remove periods from instance hostnames\n\nWhen creating an instance, nova sanitizes the \u0027instance.name\u0027 attribute,\nusing the \u0027nova.utils.sanitize_hostname\u0027 function, and stores this as\nthe \u0027instance.hostname\u0027 attribute. If neutron has the DNS extension\nenabled then this attribute will be reported as the \u0027dns_name\u0027 value\nwhen attaching ports [1].\n\nNova does not currently remove or replace periods in the name as part of\nthis sanitization. This results in the hostname being identified as a\n(FQDN) fully qualified domain name, with all the constraints placed on\nFQDNs [2]. This can be problematic for instances with common names such\nas \u0027ubuntu18.04\u0027 or \u0027test.a\u0027, which aren\u0027t valid since TLDs must start\nwith an alpha character and must be greater than 1 character long,\nrespectively. Attempting to boot instances with such names can result in\nfailures like the below when DNS integration is enabled in neutron:\n\n  RescheduledException: Build of instance foo was re-scheduled:\n  Invalid input for dns_name.\n  Reason: \u0027test-ubuntu-20.04\u0027 not a valid PQDN or FQDN.\n  Reason: TLD \u002704\u0027 must not be all numeric.\n\nStart replacing these periods with hyphens. This is a change in behavior\nand may affect users who are relying on this inadvertent support for\ninstance names as FQDNs when using cloud-init, however, a quick poll on\nopenstack-discuss [3] suggests the people that are using FQDN-like\ninstance names are setting hostnames in the guest explicitly and not\nrelying on the information provided via the nova metadata service,\nmeaning this will not affect them.\n\n[1] https://docs.openstack.org/neutron/victoria/admin/config-dns-int.html\n[2] https://stackoverflow.com/a/53875771/613428\n[3] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/019113.html\n\nChange-Id: I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1581977\n(cherry picked from commit 9046f0fff4be424eda25401a3f9b8752964de775)\n(cherry picked from commit 0419847980fde4dbc980720a61315c14aeb4575b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6bd49d41941a1191a5f656821548fc728e3080e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6bd49d41941a1191a5f656821548fc728e3080e"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
