)]}'
{"id":"openstack%2Fnova~772277","triplet_id":"openstack%2Fnova~stable%2Ftrain~I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82","project":"openstack/nova","branch":"stable/train","topic":"bug/1581977","hashtags":[],"change_id":"I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82","subject":"utils: Remove periods from instance hostnames","status":"ABANDONED","created":"2021-01-25 09:52:44.000000000","updated":"2021-02-11 17:07:12.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4c3a63fb0a85f228a5d1ae310c06c8bb47635cdd","_number":772277,"virtual_id_number":772277,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-01-25 12:00:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-25 10:21:13.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-01-25 12:00:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-25 12:10:43.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"6625e8aa39cfb7ca750d00c9e268e7e8c675e826","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 09:52:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"91e02aeebbb269ec42aea99938ead23503c7614d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-01-25 10:21:13.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/772277/1 : FAILURE in 11m 58s","accounts_in_message":[],"_revision_number":1},{"id":"a7a9cea56ceb5e6440c2704ad05a27350d9a478a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-25 12:00:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/c64eba920dcc46e1bd5842289c6161c5 : FAILURE in 12m 11s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/6e6c9262f4c0426b92e060ac79ebe948 : FAILURE in 10m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0c76300077054fe89c0dbd76d4294b54 : SUCCESS in 13m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e8a3baf80ac14cf4ae76779353c06081 : SUCCESS in 15m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/116e90c48e0d480d9fcc15aade6aa9ac : FAILURE in 10m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c0dd5e0a66c84ac58ef14bd230788a4b : SUCCESS in 14m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/00f10422249c431bba375c635e9068a2 : SUCCESS in 12m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/da32f3e75867414b84de7c8a0acada55 : SUCCESS in 13m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f25fb4b312e4802bb4cf6ab1b79a76c : SUCCESS in 10m 40s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c55d1276c0624772a9113009a1c2674a : SUCCESS in 15m 19s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/037e89f6b6b84c98a2b4f4a29f54c40b : FAILURE in 12m 07s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/89f8961b4f674699a7ae2fa7385f93da : FAILURE in 15m 23s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/96f9dbc0c7c74945978b031ba5534270 : FAILURE in 14m 54s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/fc09ad02e3f747ada8b27593bfb0bd09 : FAILURE in 15m 47s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/2cecf9736b7b41ad8a5ee19426970fce : FAILURE in 17m 34s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/424431bc1f1c4496a9d36f90415b70f5 : FAILURE in 14m 32s\n- nova-next https://zuul.opendev.org/t/openstack/build/0b8d895a57094e889e231452dc2efb04 : POST_FAILURE in 12m 10s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bccd59c10cc846208b5963f3a7594ac3 : SUCCESS in 19m 42s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/03b70ec12939429f814f56be8ba5b63b : SUCCESS in 20m 27s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/8a382e6d4a6b4b7992d8b40a7051df61 : FAILURE in 16m 35s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/c8d466ad52684bd3a37b22e835ede062 : FAILURE in 11m 59s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dd018d83e2144223ba8747444e500faa : FAILURE in 8m 21s","accounts_in_message":[],"_revision_number":1},{"id":"54c911d2a83e37287c9db49344f8607a8b608e10","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-01-25 12:10:43.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/77/772277/1/check/tempest-dsvm-full-bionic-py3/99bf1c3/ : SUCCESS in 1h 47m 15s","accounts_in_message":[],"_revision_number":1},{"id":"b5bfbe07d4bcfb47149ebbd086d2c6583feb5dec","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-09 15:50:50.000000000","message":"Patch Set 1:\n\nrecheck gimme new logs","accounts_in_message":[],"_revision_number":1},{"id":"7983c55d59e566f73faddc0c523c0527d029de45","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-02-09 16:04:54.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/772277/1/iscsi : FAILURE in 10m 22s","accounts_in_message":[],"_revision_number":1},{"id":"a540138b64f166a80179e5cfe73bd996087121f6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-02-09 17:23:41.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/77/772277/1/check/tempest-dsvm-full-bionic-py3/c826960/ : FAILURE in 49m 15s","accounts_in_message":[],"_revision_number":1},{"id":"7ceb992e6608b4b06eaf9f4f3014f87084403860","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 20:46:39.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/525d636fb0e74903bf50f7e4e0084db0 : SUCCESS in 1h 08m 31s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c5090e7f045c43b9888095c756cf991c : SUCCESS in 1h 19m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d185bbe901ac495b9a4f698a121b485f : SUCCESS in 16m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e3de5a8621ff471e898272b1f713b342 : SUCCESS in 14m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/effc1898be034d128b736d12b12e26f0 : FAILURE in 10m 58s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8e5f383111044d89bb2954bdb2e53c96 : SUCCESS in 12m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8b8be0a425934f50be348a909b631bcc : SUCCESS in 13m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c9169dd4b54d429fbc4afa7c43eba623 : SUCCESS in 12m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e7d5ca50799c49fc843bdf3d1842cb83 : SUCCESS in 10m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d761467154f7432b9c451d7124ad2b10 : SUCCESS in 15m 35s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7de41420b6564b06ac08e81e141979c6 : SUCCESS in 1h 11m 04s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/216a714ecbea44078da3a209d37b5402 : SUCCESS in 1h 12m 16s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/3ed1e1fe95624667a06d39b9c7a4d8ca : SUCCESS in 1h 07m 46s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/6c5976b5eada432aa4cf40ce6bc6fa52 : SUCCESS in 1h 02m 21s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f24259bae3824c4d8a79c65ef6b47f16 : SUCCESS in 45m 20s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/b6be1e4987b84ef0aed4070bda0448ce : SUCCESS in 1h 24m 07s\n- nova-next https://zuul.opendev.org/t/openstack/build/19ad359dac0841ed83d1212a5eb43123 : SUCCESS in 1h 12m 57s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/a068e3e95bd24acfac606700277e9fa4 : SUCCESS in 20m 25s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/030b089f846440b8991304ffb8a66dc2 : SUCCESS in 18m 09s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/83198ad39ea243bc8d0da950d18105ef : SUCCESS in 1h 57m 33s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/2820061fdfa54076b3432f17bebafaac : SUCCESS in 57m 28s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1f7c386aff7c4dba8817226b6127727b : SUCCESS in 55m 31s","accounts_in_message":[],"_revision_number":1},{"id":"4c3a63fb0a85f228a5d1ae310c06c8bb47635cdd","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-11 17:07:12.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f56d73b44bd0178c1e33d1ca8b82e2701997f656","revisions":{"f56d73b44bd0178c1e33d1ca8b82e2701997f656":{"kind":"REWORK","_number":1,"created":"2021-01-25 09:52:44.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/77/772277/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/77/772277/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/772277/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/772277/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/772277/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/77/772277/1"}}},"commit":{"parents":[{"commit":"8378785f995dd4bec2a5a20f7bf5946b3075120d","subject":"Update pci stat pools based on PCI device changes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8378785f995dd4bec2a5a20f7bf5946b3075120d"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-14 10:50:59.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-25 09:52:15.000000000","tz":0},"subject":"utils: Remove periods from instance hostnames","message":"utils: Remove periods from instance hostnames\n\nWhen creating an instance, nova sanitizes the \u0027instance.name\u0027 attribute,\nusing the \u0027nova.utils.sanitize_hostname\u0027 function, and stores this as\nthe \u0027instance.hostname\u0027 attribute. If neutron has the DNS extension\nenabled then this attribute will be reported as the \u0027dns_name\u0027 value\nwhen attaching ports [1].\n\nNova does not currently remove or replace periods in the name as part of\nthis sanitization. This results in the hostname being identified as a\n(FQDN) fully qualified domain name, with all the constraints placed on\nFQDNs [2]. This can be problematic for instances with common names such\nas \u0027ubuntu18.04\u0027 or \u0027test.a\u0027, which aren\u0027t valid since TLDs must start\nwith an alpha character and must be greater than 1 character long,\nrespectively. Attempting to boot instances with such names can result in\nfailures like the below when DNS integration is enabled in neutron:\n\n  RescheduledException: Build of instance foo was re-scheduled:\n  Invalid input for dns_name.\n  Reason: \u0027test-ubuntu-20.04\u0027 not a valid PQDN or FQDN.\n  Reason: TLD \u002704\u0027 must not be all numeric.\n\nStart replacing these periods with hyphens. This is a change in behavior\nand may affect users who are relying on this inadvertent support for\ninstance names as FQDNs when using cloud-init, however, a quick poll on\nopenstack-discuss [3] suggests the people that are using FQDN-like\ninstance names are setting hostnames in the guest explicitly and not\nrelying on the information provided via the nova metadata service,\nmeaning this will not affect them.\n\n[1] https://docs.openstack.org/neutron/victoria/admin/config-dns-int.html\n[2] https://stackoverflow.com/a/53875771/613428\n[3] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/019113.html\n\nChange-Id: I2fac7f919e9ddd6b0925d3e5d04e61b2ba1b8c82\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1581977\n(cherry picked from commit 9046f0fff4be424eda25401a3f9b8752964de775)\n(cherry picked from commit 0419847980fde4dbc980720a61315c14aeb4575b)\n(cherry picked from commit c6bd49d41941a1191a5f656821548fc728e3080e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f56d73b44bd0178c1e33d1ca8b82e2701997f656"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f56d73b44bd0178c1e33d1ca8b82e2701997f656"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}