)]}'
{"nova/notifications/objects/image.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5101e32ff3857ca63c2083e43d6ddb6d124e11c3","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    # Version 1.3: Added hw_mem_encryption, hw_pmu and hw_time_hpet fields"},{"line_number":123,"context_line":"    # Version 1.4: Added \u0027mixed\u0027 to hw_cpu_policy field"},{"line_number":124,"context_line":"    # Version 1.5: Added \u0027hw_tpm_model\u0027 and \u0027hw_tpm_version\u0027 fields"},{"line_number":125,"context_line":"    # Version 1.6: Added \u0027socket\u0027 to hw_pci_numa_affinity_policy"},{"line_number":126,"context_line":"    VERSION \u003d \u00271.6\u0027"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"c4f31a95_812052e8","line":125,"updated":"2021-02-24 10:54:39.000000000","message":"nit: ...field","commit_id":"be80dfdc714d0f00c77d84d72703f7fea04d2f94"}],"nova/objects/image_meta.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5101e32ff3857ca63c2083e43d6ddb6d124e11c3","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    # Version 1.25: Added \u0027hw_pci_numa_affinity_policy\u0027 field"},{"line_number":177,"context_line":"    # Version 1.26: Added \u0027mixed\u0027 to \u0027hw_cpu_policy\u0027 field"},{"line_number":178,"context_line":"    # Version 1.27: Added \u0027hw_tpm_model\u0027 and \u0027hw_tpm_version\u0027 fields"},{"line_number":179,"context_line":"    # Version 1.28: Added \u0027socket\u0027 to \u0027hw_pci_numa_affinity_policy\u0027"},{"line_number":180,"context_line":"    # NOTE(efried): When bumping this version, the version of"},{"line_number":181,"context_line":"    # ImageMetaPropsPayload must also be bumped. See its docstring for details."},{"line_number":182,"context_line":"    VERSION \u003d \u00271.28\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"fb7e969c_4cf7291d","line":179,"updated":"2021-02-24 10:54:39.000000000","message":"nit: ...field","commit_id":"be80dfdc714d0f00c77d84d72703f7fea04d2f94"}],"nova/tests/unit/api/validation/extra_specs/test_validators.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"530be5ef03dd4027a305746ebe3093c21bede43a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            (\u0027hw:emulator_threads_policy\u0027, \u0027iisolate\u0027),"},{"line_number":91,"context_line":"            (\u0027hw:pci_numa_affinity_policy\u0027, \u0027lgacy\u0027),"},{"line_number":92,"context_line":"            (\u0027hw:pci_numa_affinity_policy\u0027, \u0027requird\u0027),"},{"line_number":93,"context_line":"            (\u0027hw:pci_numa_affinity_policy\u0027, \u0027prefrred\u0027),"},{"line_number":94,"context_line":"            (\u0027hw:pci_numa_affinity_policy\u0027, \u0027socet\u0027),"},{"line_number":95,"context_line":"        )"},{"line_number":96,"context_line":"        for key, value in invalid_specs:"}],"source_content_type":"text/x-python","patch_set":12,"id":"c450d34c_9675875f","line":93,"range":{"start_line":93,"start_character":45,"end_line":93,"end_character":53},"updated":"2021-02-23 17:32:28.000000000","message":"I was about to point out the typo...","commit_id":"f524c3d262a2daac7a4183007da6d3d89b9ea6d8"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"530be5ef03dd4027a305746ebe3093c21bede43a","unresolved":true,"context_lines":[{"line_number":413,"context_line":"    \u0027InstanceExistsPayload\u0027: \u00271.2-e082c02438ee57164829afaeee3bf7f8\u0027,"},{"line_number":414,"context_line":"    \u0027InstanceNUMACellPayload\u0027: \u00271.2-a367add3378c71c21c817ab2b23db3bf\u0027,"},{"line_number":415,"context_line":"    \u0027InstanceNUMATopologyPayload\u0027: \u00271.0-247361b152047c18ae9ad1da2544a3c9\u0027,"},{"line_number":416,"context_line":"    \u0027InstancePCIRequestPayload\u0027: \u00271.0-bda86a95ef04bdc27789342466b81bb5\u0027,"},{"line_number":417,"context_line":"    \u0027InstancePCIRequestsPayload\u0027: \u00271.0-6751cffe0c0fabd212aad624f672429a\u0027,"},{"line_number":418,"context_line":"    \u0027InstanceStateUpdatePayload\u0027: \u00271.0-07e111c0fa0f6db0f79b0726d593e3da\u0027,"},{"line_number":419,"context_line":"    \u0027InstanceUpdateNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ba5b190_200279c4","line":416,"updated":"2021-02-23 17:32:28.000000000","message":"You also need to bump this. See \u0027InstanceNUMACellPayload\u0027 in the same file as an example.\n\nIn general, if the hash changes, assume the version must be bumped also. The only reason not to do this is when the underlying remains the same (which is almost never true)","commit_id":"f524c3d262a2daac7a4183007da6d3d89b9ea6d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"53180e1025a714793d15534d27a18dac72fe78df","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    \u0027InstanceExistsPayload\u0027: \u00271.2-e082c02438ee57164829afaeee3bf7f8\u0027,"},{"line_number":414,"context_line":"    \u0027InstanceNUMACellPayload\u0027: \u00271.2-a367add3378c71c21c817ab2b23db3bf\u0027,"},{"line_number":415,"context_line":"    \u0027InstanceNUMATopologyPayload\u0027: \u00271.0-247361b152047c18ae9ad1da2544a3c9\u0027,"},{"line_number":416,"context_line":"    \u0027InstancePCIRequestPayload\u0027: \u00271.0-bda86a95ef04bdc27789342466b81bb5\u0027,"},{"line_number":417,"context_line":"    \u0027InstancePCIRequestsPayload\u0027: \u00271.0-6751cffe0c0fabd212aad624f672429a\u0027,"},{"line_number":418,"context_line":"    \u0027InstanceStateUpdatePayload\u0027: \u00271.0-07e111c0fa0f6db0f79b0726d593e3da\u0027,"},{"line_number":419,"context_line":"    \u0027InstanceUpdateNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"db99d2ab_85398ed0","line":416,"in_reply_to":"3ba5b190_200279c4","updated":"2021-02-24 10:24:29.000000000","message":"Done","commit_id":"f524c3d262a2daac7a4183007da6d3d89b9ea6d8"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c67aec812b8ed007f81f2ff4e550b729285a050a","unresolved":true,"context_lines":[{"line_number":1074,"context_line":"    \u0027HyperVLiveMigrateData\u0027: \u00271.4-e265780e6acfa631476c8170e8d6fce0\u0027,"},{"line_number":1075,"context_line":"    \u0027IDEDeviceBus\u0027: \u00271.0-29d4c9f27ac44197f01b6ac1b7e16502\u0027,"},{"line_number":1076,"context_line":"    \u0027ImageMeta\u0027: \u00271.8-642d1b2eb3e880a367f37d72dd76162d\u0027,"},{"line_number":1077,"context_line":"    \u0027ImageMetaProps\u0027: \u00271.27-a55674868f9e319a6b49d688e558d0aa\u0027,"},{"line_number":1078,"context_line":"    \u0027Instance\u0027: \u00272.7-d187aec68cad2e4d8b8a03a68e4739ce\u0027,"},{"line_number":1079,"context_line":"    \u0027InstanceAction\u0027: \u00271.2-9a5abc87fdd3af46f45731960651efb5\u0027,"},{"line_number":1080,"context_line":"    \u0027InstanceActionEvent\u0027: \u00271.4-5b1f361bd81989f8bb2c20bb7e8a4cb4\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"675ae0e6_ff2904d2","line":1077,"updated":"2021-02-19 18:11:56.000000000","message":"You need to add code to raise an error if the \u0027hw_pci_numa_affinity_policy\u0027 attribute is set to socket. See commit ba3388d666a for an example","commit_id":"a92a88ad1cb0b713b3adc2f1d494d29551064b8c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7a9616053edf6f0cd6fd21a7cb48095dfa5611fd","unresolved":true,"context_lines":[{"line_number":1074,"context_line":"    \u0027HyperVLiveMigrateData\u0027: \u00271.4-e265780e6acfa631476c8170e8d6fce0\u0027,"},{"line_number":1075,"context_line":"    \u0027IDEDeviceBus\u0027: \u00271.0-29d4c9f27ac44197f01b6ac1b7e16502\u0027,"},{"line_number":1076,"context_line":"    \u0027ImageMeta\u0027: \u00271.8-642d1b2eb3e880a367f37d72dd76162d\u0027,"},{"line_number":1077,"context_line":"    \u0027ImageMetaProps\u0027: \u00271.27-a55674868f9e319a6b49d688e558d0aa\u0027,"},{"line_number":1078,"context_line":"    \u0027Instance\u0027: \u00272.7-d187aec68cad2e4d8b8a03a68e4739ce\u0027,"},{"line_number":1079,"context_line":"    \u0027InstanceAction\u0027: \u00271.2-9a5abc87fdd3af46f45731960651efb5\u0027,"},{"line_number":1080,"context_line":"    \u0027InstanceActionEvent\u0027: \u00271.4-5b1f361bd81989f8bb2c20bb7e8a4cb4\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"355ac36f_b0eb7b8c","line":1077,"in_reply_to":"675ae0e6_ff2904d2","updated":"2021-02-21 14:02:05.000000000","message":"Done. I\u0027m pretty sure I\u0027ve missed on unit/api samples tests. I\u0027ll let CI run and fix them after.","commit_id":"a92a88ad1cb0b713b3adc2f1d494d29551064b8c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"530be5ef03dd4027a305746ebe3093c21bede43a","unresolved":true,"context_lines":[{"line_number":1092,"context_line":"    \u0027InstanceMappingList\u0027: \u00271.3-d34b6ebb076d542ae0f8b440534118da\u0027,"},{"line_number":1093,"context_line":"    \u0027InstanceNUMACell\u0027: \u00271.6-25d9120d83a18356f4146f2a6fe2cc8d\u0027,"},{"line_number":1094,"context_line":"    \u0027InstanceNUMATopology\u0027: \u00271.3-ec0030cb0402a49c96da7051c037082a\u0027,"},{"line_number":1095,"context_line":"    \u0027InstancePCIRequest\u0027: \u00271.3-b27808ae189699df27f8f5b908b6393e\u0027,"},{"line_number":1096,"context_line":"    \u0027InstancePCIRequests\u0027: \u00271.1-65e38083177726d806684cb1cc0136d2\u0027,"},{"line_number":1097,"context_line":"    \u0027KeyPair\u0027: \u00271.4-1244e8d1b103cc69d038ed78ab3a8cc6\u0027,"},{"line_number":1098,"context_line":"    \u0027KeyPairList\u0027: \u00271.3-94aad3ac5c938eef4b5e83da0212f506\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"a5e0ee15_7c0820da","line":1095,"updated":"2021-02-23 17:32:28.000000000","message":"This too","commit_id":"f524c3d262a2daac7a4183007da6d3d89b9ea6d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"53180e1025a714793d15534d27a18dac72fe78df","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"    \u0027InstanceMappingList\u0027: \u00271.3-d34b6ebb076d542ae0f8b440534118da\u0027,"},{"line_number":1093,"context_line":"    \u0027InstanceNUMACell\u0027: \u00271.6-25d9120d83a18356f4146f2a6fe2cc8d\u0027,"},{"line_number":1094,"context_line":"    \u0027InstanceNUMATopology\u0027: \u00271.3-ec0030cb0402a49c96da7051c037082a\u0027,"},{"line_number":1095,"context_line":"    \u0027InstancePCIRequest\u0027: \u00271.3-b27808ae189699df27f8f5b908b6393e\u0027,"},{"line_number":1096,"context_line":"    \u0027InstancePCIRequests\u0027: \u00271.1-65e38083177726d806684cb1cc0136d2\u0027,"},{"line_number":1097,"context_line":"    \u0027KeyPair\u0027: \u00271.4-1244e8d1b103cc69d038ed78ab3a8cc6\u0027,"},{"line_number":1098,"context_line":"    \u0027KeyPairList\u0027: \u00271.3-94aad3ac5c938eef4b5e83da0212f506\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"20ed15a8_013553c1","line":1095,"in_reply_to":"a5e0ee15_7c0820da","updated":"2021-02-24 10:24:29.000000000","message":"Done","commit_id":"f524c3d262a2daac7a4183007da6d3d89b9ea6d8"}]}
