)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"762d1196bdfd9cea171189940337e3d46ee9b931","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Khomesh Thakre \u003ckhomeshthakre24@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-30 16:56:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding a validation on os-resetState so that when vm is shelved offload,"},{"line_number":8,"context_line":"reseting the VM state is blocked. In shelved state VM doesnt existed physically"},{"line_number":9,"context_line":"on compute nodes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Khomesh Thakre \u003ckhomeshthakre24@gmail.com\u003e"},{"line_number":12,"context_line":"Closes-Bug: 1913016"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"42b9039c_ebae464d","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":17},"updated":"2021-02-04 13:30:01.000000000","message":"Can you add a title here? Something like\n\n    api: Reject requests to reset the state of SHELVE_OFFLOADED servers\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"70999bf3c7919306bbefe65371f9423ba3a02fe9"}],"nova/api/openstack/compute/admin_actions.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"762d1196bdfd9cea171189940337e3d46ee9b931","unresolved":true,"context_lines":[{"line_number":26,"context_line":"from nova import objects"},{"line_number":27,"context_line":"from nova.policies import admin_actions as aa_policies"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# States usable in resetState action"},{"line_number":31,"context_line":"# NOTE: It is necessary to update the schema of nova/api/openstack/compute/"},{"line_number":32,"context_line":"# schemas/reset_server_state.py, when updating this state_map."}],"source_content_type":"text/x-python","patch_set":3,"id":"48fa5fbb_df22043f","line":29,"updated":"2021-02-04 13:30:01.000000000","message":"unrelated change","commit_id":"70999bf3c7919306bbefe65371f9423ba3a02fe9"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"762d1196bdfd9cea171189940337e3d46ee9b931","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # If VM is shelved offload, setting the state is blocked"},{"line_number":80,"context_line":"        # As vm doesnt exist physically on compute node"},{"line_number":81,"context_line":"        if instance.vm_state \u003d\u003d \u0027shelved_offloaded\u0027:"},{"line_number":82,"context_line":"            msg \u003d _(\u0027Action not allowed as Instance is %(instance)s \u0027"},{"line_number":83,"context_line":"                    \u0027shelved\u0027) % {\u0027instance\u0027: instance.display_name}"},{"line_number":84,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"eda42145_2e0cd4f8","line":81,"range":{"start_line":81,"start_character":32,"end_line":81,"end_character":52},"updated":"2021-02-04 13:30:01.000000000","message":"vm_states.SHELVED_OFFLOADED","commit_id":"70999bf3c7919306bbefe65371f9423ba3a02fe9"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"762d1196bdfd9cea171189940337e3d46ee9b931","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            msg \u003d _(\u0027Action not allowed as Instance is %(instance)s \u0027"},{"line_number":83,"context_line":"                    \u0027shelved\u0027) % {\u0027instance\u0027: instance.display_name}"},{"line_number":84,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            instance.vm_state \u003d state"},{"line_number":87,"context_line":"            instance.task_state \u003d None"},{"line_number":88,"context_line":"            instance.save(admin_state_reset\u003dTrue)"},{"line_number":89,"context_line":"            instance_action.finish()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fcd371e_9af93b55","line":89,"range":{"start_line":85,"start_character":8,"end_line":89,"end_character":36},"updated":"2021-02-04 13:30:01.000000000","message":"You don\u0027t need to use an else here as the above will always raise","commit_id":"70999bf3c7919306bbefe65371f9423ba3a02fe9"}]}
