)]}'
{"id":"openstack%2Fnova~773334","triplet_id":"openstack%2Fnova~stable%2Fussuri~I759aa36dc00a6c0612b9755dacd9aa414c408498","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1909120","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-02-07 12:54:40.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I759aa36dc00a6c0612b9755dacd9aa414c408498","subject":"api: Reject requests to detach a volume when the compute is down","status":"ABANDONED","created":"2021-02-01 09:45:18.000000000","updated":"2024-02-07 12:54:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8e5d1acb1e1ed25be4f772b990331b0278732ff3","_number":773334,"virtual_id_number":773334,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-02-01 11:43:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-01 09:57:08.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-02-01 11:43:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-01 11:46:32.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-07 12:54:40.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"71a74ba815801321b22a278bef042777b8042a0f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-02-01 09:45:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"695216f88221cd55b6c1c8666640a04cd02e1c60","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-02-01 09:57:08.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/773334/1 : FAILURE in 9m 28s","accounts_in_message":[],"_revision_number":1},{"id":"17113e411ee9abeb0454cdf1a9f5236c38ae49ae","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-01 11:43:40.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/945a1012f3444b87b9df7cacf45cb2d8 : SUCCESS in 1h 10m 13s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/f858e8b50fa34d4aaa09d25f72b62db1 : SUCCESS in 1h 16m 59s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1d653f85350948d9a028ee7d3e7bbf73 : SUCCESS in 15m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/33a4d24be9cd4f2c9667adb03b4272c8 : SUCCESS in 17m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7c7f5e3d645845308037b7a84ad66623 : FAILURE in 8m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5ac46fd8610c4ad794d02deebaad0d0a : SUCCESS in 18m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/10682988ea8c4fd69941f837cb8771f9 : SUCCESS in 13m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5fce22cea85a47989e05b82cb102677e : SUCCESS in 12m 07s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/81f106a1847f4a66b1dfb6b0bc04dd29 : SUCCESS in 1h 00m 12s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/14183baa541d4f1b84c572997835e43a : SUCCESS in 1h 12m 42s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/25f2161f79d84db4b06f22ee3f161796 : SUCCESS in 1h 22m 55s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7ec83c43e45047c380461e09459aca45 : SUCCESS in 49m 31s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/3525e1bba7134647b48f9a5af227e861 : SUCCESS in 1h 21m 43s\n- nova-next https://zuul.opendev.org/t/openstack/build/64ad807b41ec4b658bc71afcdaaf4771 : SUCCESS in 1h 49m 17s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/d4ff07b1c76345eaa8b4c77ac6a5f91c : SUCCESS in 17m 58s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9fec5a71fc6f48e9a87faa667f987367 : SUCCESS in 40m 29s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3e4e9e6bcede4b109ddfccbe4d3ffccb : SUCCESS in 50m 57s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/ea40dc9b57804406b9ad55626ab7ff8f : FAILURE in 32m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cbe738ec29d245ee5be0239f0ac2345c2b5d008c","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-02-01 11:46:32.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/34/773334/1/check/tempest-dsvm-full-bionic/ab172ce/ : SUCCESS in 1h 55m 34s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/34/773334/1/check/tempest-dsvm-full-bionic-py3/3bfe12a/ : SUCCESS in 1h 28m 59s","accounts_in_message":[],"_revision_number":1},{"id":"2b468590241c8416bc81625c4d2ba27e8650dca9","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-03-24 16:17:51.000000000","message":"Topic set to bug/1909120","accounts_in_message":[],"_revision_number":1},{"id":"8e5d1acb1e1ed25be4f772b990331b0278732ff3","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-07 12:54:40.000000000","message":"Abandoned\n\nstable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8c479c449b90e806ae4453fbdbe1456555b5b26e","revisions":{"8c479c449b90e806ae4453fbdbe1456555b5b26e":{"kind":"REWORK","_number":1,"created":"2021-02-01 09:45:18.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/34/773334/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/773334/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/773334/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/773334/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/773334/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/773334/1"}}},"commit":{"parents":[{"commit":"529e1d70c427905dc5dd401e4c365bd8b6d7823f","subject":"Add regression test for bug #1909120","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/529e1d70c427905dc5dd401e4c365bd8b6d7823f"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-12-23 14:00:18.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-02-01 09:41:56.000000000","tz":0},"subject":"api: Reject requests to detach a volume when the compute is down","message":"api: Reject requests to detach a volume when the compute is down\n\nWhen detaching a volume from an instance Nova will currently always\nattempt to make a cast RPC call before returning a successful 202\nresponse to the caller.\n\nThe lack of checking here regarding the underlying compute can lead to\nrequests never being acted upon and has often confused callers when the\ncompute itself is down.\n\nThis change aims to correct this by having the state of the compute\nhosting the instance checked in the compute API layer. When the compute\nis down the initial request is now rejected with a 409 conflict to the\ncaller so they understand why the volume still appears attached.\n\nConflicts:\n    nova/tests/unit/compute/test_api.py\n    nova/compute/api.py\n\nNOTE(lyarwood): I5c9734ee712e4c91a3c7a37291c48932ce0b575c refactored\n_detach_volume back into detach_volume during Victoria that this change\nthen reverted in master. As a result in stable/ussuri we only have to\nadd the @check_instance_host decorator to _detach_volume.\nI59298788f26ca8f32bf3e38f3a52f72ff63fcc8b and\nI147bf4d95e6d86ff1f967a8ce37260730f21d236 cause the test conflict as\nneither is present in stable/ussuri.\n\nCloses-Bug: #1909120\nChange-Id: I759aa36dc00a6c0612b9755dacd9aa414c408498\n(cherry picked from commit db8213af8341989354231f9b67dd983365899015)\n(cherry picked from commit 602b3e046adff9fdf52eed28414f5d50056675a5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8c479c449b90e806ae4453fbdbe1456555b5b26e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8c479c449b90e806ae4453fbdbe1456555b5b26e"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}