)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7d02380bfdbf49e856d542ef8f1836b57a22c9b7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make enforce_multipath configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the enforce_multipath flag is hardcoded to true."},{"line_number":10,"context_line":"This might cause issues when volume_use_multipath is set to True"},{"line_number":11,"context_line":"and deployment doesn\u0027t support multipathing resulting in failed operation."},{"line_number":12,"context_line":"Making enforce_multipath configurable will allow operations to"},{"line_number":13,"context_line":"use single path when deployment doesn\u0027t support multipath."},{"line_number":14,"context_line":"This patch introduces a new config option ``volume_enforce_multipath``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2caf772d_5b000d63","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":74},"updated":"2021-02-02 09:09:31.000000000","message":"That\u0027s a valid failure case? If the operator has enabled [libvirt]volume_use_multipath and multipathd isn\u0027t running then get_connector_properties should fail IMHO.","commit_id":"1898804adb7d8fb78a1e8aa4b7fded7eaedff216"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"102d0f123ed1c9fc0077b14d3e58fb4332b18600","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make enforce_multipath configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the enforce_multipath flag is hardcoded to true."},{"line_number":10,"context_line":"This might cause issues when volume_use_multipath is set to True"},{"line_number":11,"context_line":"and deployment doesn\u0027t support multipathing resulting in failed operation."},{"line_number":12,"context_line":"Making enforce_multipath configurable will allow operations to"},{"line_number":13,"context_line":"use single path when deployment doesn\u0027t support multipath."},{"line_number":14,"context_line":"This patch introduces a new config option ``volume_enforce_multipath``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4f63f2a4_4d5b5166","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":74},"in_reply_to":"2caf772d_5b000d63","updated":"2021-02-02 09:46:13.000000000","message":"If it stands as a valid case then we shouldn\u0027t be passing any parameter named enforce multipath to os_brick and remove this if statement[1] to fail always\n\n[1] https://github.com/openstack/os-brick/blob/master/os_brick/initiator/linuxscsi.py#L219-L220","commit_id":"1898804adb7d8fb78a1e8aa4b7fded7eaedff216"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7d02380bfdbf49e856d542ef8f1836b57a22c9b7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Currently the enforce_multipath flag is hardcoded to true."},{"line_number":10,"context_line":"This might cause issues when volume_use_multipath is set to True"},{"line_number":11,"context_line":"and deployment doesn\u0027t support multipathing resulting in failed operation."},{"line_number":12,"context_line":"Making enforce_multipath configurable will allow operations to"},{"line_number":13,"context_line":"use single path when deployment doesn\u0027t support multipath."},{"line_number":14,"context_line":"This patch introduces a new config option ``volume_enforce_multipath``"},{"line_number":15,"context_line":"to achieve it. It defaults to ``True`` to matching current behavior."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I49c8eb35636d172a72b88c7171dbae209ac90162"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d2acee24_a01b4c00","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":68},"updated":"2021-02-02 09:09:31.000000000","message":"I don\u0027t think we want to allow this, in this case shouldn\u0027t the operator just disable [libvirt]volume_use_multipath if multipathd isn\u0027t running on their computes?","commit_id":"1898804adb7d8fb78a1e8aa4b7fded7eaedff216"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"102d0f123ed1c9fc0077b14d3e58fb4332b18600","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Currently the enforce_multipath flag is hardcoded to true."},{"line_number":10,"context_line":"This might cause issues when volume_use_multipath is set to True"},{"line_number":11,"context_line":"and deployment doesn\u0027t support multipathing resulting in failed operation."},{"line_number":12,"context_line":"Making enforce_multipath configurable will allow operations to"},{"line_number":13,"context_line":"use single path when deployment doesn\u0027t support multipath."},{"line_number":14,"context_line":"This patch introduces a new config option ``volume_enforce_multipath``"},{"line_number":15,"context_line":"to achieve it. It defaults to ``True`` to matching current behavior."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I49c8eb35636d172a72b88c7171dbae209ac90162"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"63755d98_f66f3fbe","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":68},"in_reply_to":"d2acee24_a01b4c00","updated":"2021-02-02 09:46:13.000000000","message":"enforce mutlipath is used to provide choice if the operator wants to be strict about using multipath or not.\nIf enforce_multipath isn\u0027t set then they can freely set volume_use_multipath without worrying about failing operation (not bothering about if it uses multipath or not)\nThis new parameter doesn\u0027t change any current behavior, just provides some flexibility with multipathing.","commit_id":"1898804adb7d8fb78a1e8aa4b7fded7eaedff216"}]}