)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a5231e4f198acae5c00750d2ae38e1542ac2f10","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        # NOTE(jaypipes): provider_summaries being None is treated differently"},{"line_number":480,"context_line":"        # from an empty dict. provider_summaries is None when we want to grab"},{"line_number":481,"context_line":"        # all compute nodes, for instance when using a scheduler driver that"},{"line_number":482,"context_line":"        # sets USES_ALLOCATION_CANDIDATES\u003dFalse."},{"line_number":483,"context_line":"        # The provider_summaries variable will be an empty dict when the"},{"line_number":484,"context_line":"        # Placement API found no providers that match the requested"},{"line_number":485,"context_line":"        # constraints, which in turn makes compute_uuids an empty list and"}],"source_content_type":"text/x-python","patch_set":3,"id":"73e49ffe_ea3165ef","side":"PARENT","line":482,"updated":"2021-06-18 15:22:37.000000000","message":"hm can we simplify the below logic then to:\n\n  compute_uuids \u003d list(provider_summaries.keys())\n  return self.host_manager.get_host_states_by_uuids(\n      context, compute_uuids, spec_obj)","commit_id":"b0cd985f0c09088098f74cc0cb1df616cc0ef12b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a9d96ca3884a591dc364ff0da729f7932fcd9301","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        # NOTE(jaypipes): provider_summaries being None is treated differently"},{"line_number":480,"context_line":"        # from an empty dict. provider_summaries is None when we want to grab"},{"line_number":481,"context_line":"        # all compute nodes, for instance when using a scheduler driver that"},{"line_number":482,"context_line":"        # sets USES_ALLOCATION_CANDIDATES\u003dFalse."},{"line_number":483,"context_line":"        # The provider_summaries variable will be an empty dict when the"},{"line_number":484,"context_line":"        # Placement API found no providers that match the requested"},{"line_number":485,"context_line":"        # constraints, which in turn makes compute_uuids an empty list and"}],"source_content_type":"text/x-python","patch_set":3,"id":"b35ac1fb_5bc13265","side":"PARENT","line":482,"in_reply_to":"73e49ffe_ea3165ef","updated":"2021-06-29 11:00:47.000000000","message":"I was going to say Done with the follow-up, but it seems this comment is incorrect. There appears to be another use case where this will by None: if we\u0027re in a rebuild then we never fetch provider summaries from placement, as seen at [1]. This makes sense since rebuilds happen in-place. I\u0027ll rework the follow-up shortly.\n\n[1] https://github.com/openstack/nova/blob/1f6c35171213c954317595d84c62f1dfddc69a5a/nova/scheduler/manager.py#L134-L136","commit_id":"b0cd985f0c09088098f74cc0cb1df616cc0ef12b"}],"nova/scheduler/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a5231e4f198acae5c00750d2ae38e1542ac2f10","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        alloc_reqs_by_rp_uuid, provider_summaries, allocation_request_version \\"},{"line_number":135,"context_line":"            \u003d None, None, None"},{"line_number":136,"context_line":"        if not is_rebuild:"},{"line_number":137,"context_line":"            # Only process the Placement request spec filters when Placement"},{"line_number":138,"context_line":"            # is used."},{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                request_filter.process_reqspec(ctxt, spec_obj)"},{"line_number":141,"context_line":"            except exception.RequestFilterFailed as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"6323b117_b5e19e65","line":138,"range":{"start_line":137,"start_character":0,"end_line":138,"end_character":22},"updated":"2021-06-18 15:22:37.000000000","message":"this comment can be dropped too as we always use Placement now.","commit_id":"7221fe02a8657dc4db15dc95f096113dbdc8463d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a9d96ca3884a591dc364ff0da729f7932fcd9301","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        alloc_reqs_by_rp_uuid, provider_summaries, allocation_request_version \\"},{"line_number":135,"context_line":"            \u003d None, None, None"},{"line_number":136,"context_line":"        if not is_rebuild:"},{"line_number":137,"context_line":"            # Only process the Placement request spec filters when Placement"},{"line_number":138,"context_line":"            # is used."},{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                request_filter.process_reqspec(ctxt, spec_obj)"},{"line_number":141,"context_line":"            except exception.RequestFilterFailed as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"de6a89b8_f9b038e2","line":138,"range":{"start_line":137,"start_character":0,"end_line":138,"end_character":22},"in_reply_to":"6323b117_b5e19e65","updated":"2021-06-29 11:00:47.000000000","message":"Done","commit_id":"7221fe02a8657dc4db15dc95f096113dbdc8463d"}],"nova/tests/functional/test_nova_manage.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6f706f6b271fd96b669bff89240770c6d8ba969","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        self.assertEqual(hostname, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        # Delete the server\u0027s allocations"},{"line_number":315,"context_line":"        self._delete_server_allocations(server[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Check that the compute node resource provider has no allocations."},{"line_number":318,"context_line":"        rp_uuid \u003d self._get_provider_uuid_by_host(hostname)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2ffa52fc_03b40235","line":315,"range":{"start_line":315,"start_character":5,"end_line":315,"end_character":53},"updated":"2021-07-23 15:22:51.000000000","message":"ok this is where tha tnew funciton is used cool\nhttps://review.opendev.org/c/openstack/nova/+/773640/5/nova/tests/functional/integrated_helpers.py","commit_id":"97d25371b3cbd20eab3b13b230fb87dfee8478bf"}]}