)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3b78be4b20d857effb6f8f8e8a7c5473c4266be7","unresolved":true,"context_lines":[{"line_number":15,"context_line":"It transpires that just as QEMU adds PS2 input devices for x86, libvirt"},{"line_number":16,"context_line":"automatically adds USB input devices for PPC64 [1]. These devices won\u0027t"},{"line_number":17,"context_line":"appear in the XML we provide to libvirt, since we, the user, are not the"},{"line_number":18,"context_line":"ones requesting them, but the disabling of the instance will result in"},{"line_number":19,"context_line":"the instance failing to boot and libvirt emitting the following error"},{"line_number":20,"context_line":"message:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d9efc15f_db133bd7","line":18,"range":{"start_line":18,"start_character":47,"end_line":18,"end_character":55},"updated":"2021-02-03 14:37:21.000000000","message":"controller?","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de34919f8ffa03f499597d20f6c2c759b301c3d4","unresolved":true,"context_lines":[{"line_number":15,"context_line":"It transpires that just as QEMU adds PS2 input devices for x86, libvirt"},{"line_number":16,"context_line":"automatically adds USB input devices for PPC64 [1]. These devices won\u0027t"},{"line_number":17,"context_line":"appear in the XML we provide to libvirt, since we, the user, are not the"},{"line_number":18,"context_line":"ones requesting them, but the disabling of the instance will result in"},{"line_number":19,"context_line":"the instance failing to boot and libvirt emitting the following error"},{"line_number":20,"context_line":"message:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9d78c92b_d8ee8d99","line":18,"range":{"start_line":18,"start_character":47,"end_line":18,"end_character":55},"in_reply_to":"d9efc15f_db133bd7","updated":"2021-02-09 16:39:08.000000000","message":"whoops, yeah","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c58d8d6604997d637a8c3bc8c54d1d2c2d43b23d","unresolved":true,"context_lines":[{"line_number":8424,"context_line":"        self.mock_get_arch.return_value \u003d fields.Architecture.PPC64"},{"line_number":8425,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":8426,"context_line":"        disk_info \u003d blockinfo.get_disk_info("},{"line_number":8427,"context_line":"            CONF.libvirt.virt_type, instance_ref, image_meta)"},{"line_number":8428,"context_line":""},{"line_number":8429,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [], image_meta, disk_info)"},{"line_number":8430,"context_line":"        for device in cfg.devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0c8754e_cc4917b2","line":8427,"updated":"2021-02-02 17:28:43.000000000","message":"not the image_meta and disk_info need to be crecreted here as the image methat previously requested a usb disk so cant be reused form before in the test.","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c58d8d6604997d637a8c3bc8c54d1d2c2d43b23d","unresolved":true,"context_lines":[{"line_number":8433,"context_line":"                self.assertIsNone(device.model)"},{"line_number":8434,"context_line":"                break"},{"line_number":8435,"context_line":"        else:"},{"line_number":8436,"context_line":"            self.fail(\u0027Did not find a USB host controller\u0027)"},{"line_number":8437,"context_line":""},{"line_number":8438,"context_line":"    @mock.patch.object(libvirt_driver, \u0027LOG\u0027)"},{"line_number":8439,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":1,"id":"151bb4e7_d28c6e5b","line":8436,"updated":"2021-02-02 17:28:43.000000000","message":"+1","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c58d8d6604997d637a8c3bc8c54d1d2c2d43b23d","unresolved":true,"context_lines":[{"line_number":5890,"context_line":""},{"line_number":5891,"context_line":"    def _guest_needs_usb(self, guest, image_meta):"},{"line_number":5892,"context_line":"        \"\"\"Evaluate devices currently attached to the guest.\"\"\""},{"line_number":5893,"context_line":"        if self._is_ppc64_guest(image_meta):"},{"line_number":5894,"context_line":"            # PPC64 guests get a USB keyboard and mouse automatically"},{"line_number":5895,"context_line":"            return True"},{"line_number":5896,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"34ffd728_b2a810b4","line":5893,"range":{"start_line":5893,"start_character":8,"end_line":5893,"end_character":44},"updated":"2021-02-02 17:28:43.000000000","message":"we might want to invert this actully\n\nit might make more sense to return True if not x86/x86_64\n\nwe did not have reports of this breaking AARCH64 so i guess they have\nps2 mouse and keyboard suport but it might be safter to only disable it for case where we know its not required.","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de34919f8ffa03f499597d20f6c2c759b301c3d4","unresolved":false,"context_lines":[{"line_number":5890,"context_line":""},{"line_number":5891,"context_line":"    def _guest_needs_usb(self, guest, image_meta):"},{"line_number":5892,"context_line":"        \"\"\"Evaluate devices currently attached to the guest.\"\"\""},{"line_number":5893,"context_line":"        if self._is_ppc64_guest(image_meta):"},{"line_number":5894,"context_line":"            # PPC64 guests get a USB keyboard and mouse automatically"},{"line_number":5895,"context_line":"            return True"},{"line_number":5896,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3c124f35_4d801a3b","line":5893,"range":{"start_line":5893,"start_character":8,"end_line":5893,"end_character":44},"in_reply_to":"34ffd728_b2a810b4","updated":"2021-02-09 16:39:08.000000000","message":"See the commit message. I checked the libvirt source and PPC64 is the only arch that has these added automatically in libvirt. x86 has a keyboard and mouse attached by QEMU, but that\u0027s on the PS2 bus so it\u0027s not necessary here","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3b78be4b20d857effb6f8f8e8a7c5473c4266be7","unresolved":true,"context_lines":[{"line_number":5918,"context_line":"        # controller (x86 gets one by default)"},{"line_number":5919,"context_line":"        usbhost.model \u003d None"},{"line_number":5920,"context_line":"        if not self._guest_needs_usb(guest, image_meta):"},{"line_number":5921,"context_line":"            usbhost.model \u003d \u0027none\u0027"},{"line_number":5922,"context_line":"        guest.add_device(usbhost)"},{"line_number":5923,"context_line":""},{"line_number":5924,"context_line":"    def _guest_add_pcie_root_ports(self, guest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa8e02e6_516e11ca","line":5921,"updated":"2021-02-03 14:37:21.000000000","message":"yikes. So setting it None mean auto configured, setting it to \u0027none\u0027 means disabled.","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de34919f8ffa03f499597d20f6c2c759b301c3d4","unresolved":false,"context_lines":[{"line_number":5918,"context_line":"        # controller (x86 gets one by default)"},{"line_number":5919,"context_line":"        usbhost.model \u003d None"},{"line_number":5920,"context_line":"        if not self._guest_needs_usb(guest, image_meta):"},{"line_number":5921,"context_line":"            usbhost.model \u003d \u0027none\u0027"},{"line_number":5922,"context_line":"        guest.add_device(usbhost)"},{"line_number":5923,"context_line":""},{"line_number":5924,"context_line":"    def _guest_add_pcie_root_ports(self, guest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"863cfeca_c0de7fb2","line":5921,"in_reply_to":"fa8e02e6_516e11ca","updated":"2021-02-09 16:39:08.000000000","message":"Yup /o\\","commit_id":"7961cc3428b14c92c80e0c435ae8a8ca1d9ea806"}]}