)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-08 13:56:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"support per port numa policies with sriov"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds support for booting vms and"},{"line_number":10,"context_line":"attaching port with per port sriov numa policies."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dc1ff9c0_b67dd243","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2021-03-08 18:53:29.000000000","message":"S","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-08 13:56:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"support per port numa policies with sriov"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds support for booting vms and"},{"line_number":10,"context_line":"attaching port with per port sriov numa policies."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"45253940_439472ff","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"in_reply_to":"dc1ff9c0_b67dd243","updated":"2021-03-08 19:48:54.000000000","message":"i tought we were not ment to capitalise the first lertter in commit title the same way we shoudl not end them with a \".\"\nbut ok","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change adds support for booting vms and"},{"line_number":10,"context_line":"attaching port with per port sriov numa policies."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"09661df1_9e3b071f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"updated":"2021-03-08 18:53:29.000000000","message":"A","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change adds support for booting vms and"},{"line_number":10,"context_line":"attaching port with per port sriov numa policies."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"f5d870dc_1c30353d","line":12,"range":{"start_line":12,"start_character":46,"end_line":12,"end_character":49},"updated":"2021-03-08 18:53:29.000000000","message":"PCI","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change adds support for booting vms and"},{"line_number":10,"context_line":"attaching port with per port sriov numa policies."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1c5d3ae1_0ebd449a","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"09661df1_9e3b071f","updated":"2021-03-08 19:48:54.000000000","message":"Ack","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change adds support for booting vms and"},{"line_number":10,"context_line":"attaching port with per port sriov numa policies."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"6085fb90_f623189f","line":12,"range":{"start_line":12,"start_character":46,"end_line":12,"end_character":49},"in_reply_to":"f5d870dc_1c30353d","updated":"2021-03-08 19:48:54.000000000","message":"Ack","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":10,"context_line":"attaching port with per port sriov numa policies."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"94af9c4e_dbcc3fbc","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":8},"updated":"2021-03-08 18:53:29.000000000","message":"NUMA","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":false,"context_lines":[{"line_number":10,"context_line":"attaching port with per port sriov numa policies."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"544154ae_61c41de1","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":8},"in_reply_to":"94af9c4e_dbcc3fbc","updated":"2021-03-08 19:48:54.000000000","message":"Ack","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id94fdc6789b2bae735b0d1e9a02dce60a8f3fb40"},{"line_number":18,"context_line":"Partial-Implements: blueprint port-scoped-sriov-numa-affinity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3820d888_ad4bb98e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"updated":"2021-03-08 18:53:29.000000000","message":"A","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id94fdc6789b2bae735b0d1e9a02dce60a8f3fb40"},{"line_number":18,"context_line":"Partial-Implements: blueprint port-scoped-sriov-numa-affinity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"49eb6ada_2733c7f8","line":15,"range":{"start_line":15,"start_character":23,"end_line":15,"end_character":31},"updated":"2021-03-08 18:53:29.000000000","message":"enforced","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":false,"context_lines":[{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id94fdc6789b2bae735b0d1e9a02dce60a8f3fb40"},{"line_number":18,"context_line":"Partial-Implements: blueprint port-scoped-sriov-numa-affinity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b0951ac9_7a52c5b0","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"3820d888_ad4bb98e","updated":"2021-03-08 19:48:54.000000000","message":"Ack","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":false,"context_lines":[{"line_number":12,"context_line":"affinity during scheduling is enforced by the pci"},{"line_number":13,"context_line":"and numa affinity filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"affinity for attach is enfroced by the hardware module."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id94fdc6789b2bae735b0d1e9a02dce60a8f3fb40"},{"line_number":18,"context_line":"Partial-Implements: blueprint port-scoped-sriov-numa-affinity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d55d5dfb_af6ecbc3","line":15,"range":{"start_line":15,"start_character":23,"end_line":15,"end_character":31},"in_reply_to":"49eb6ada_2733c7f8","updated":"2021-03-08 19:48:54.000000000","message":"Ack","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"}],"nova/network/model.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f06367fdafff1ce90c20b974203daac12bfe0eae","unresolved":true,"context_lines":[{"line_number":382,"context_line":"                 details\u003dNone, devname\u003dNone, ovs_interfaceid\u003dNone,"},{"line_number":383,"context_line":"                 qbh_params\u003dNone, qbg_params\u003dNone, active\u003dFalse,"},{"line_number":384,"context_line":"                 vnic_type\u003dVNIC_TYPE_NORMAL, profile\u003dNone,"},{"line_number":385,"context_line":"                 preserve_on_delete\u003dFalse, numa_policy\u003dNone, **kwargs):"},{"line_number":386,"context_line":"        super(VIF, self).__init__()"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        self[\u0027id\u0027] \u003d id"}],"source_content_type":"text/x-python","patch_set":1,"id":"659f4337_00890c5e","line":385,"updated":"2021-02-02 20:25:48.000000000","message":"i might not need theses changes\nnot that i look at it more closely but on the other had i had expected us to use\nthis more often.\nwe seam to be parsing the raw neutorn ports more then i would like.\n\ninany case i might remove this in the future.","commit_id":"1e5eea4a71ba1acf2d448ea40f46f3b0c141f604"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1740340a9dd71a4a05b3a32986906b12a6e1203a","unresolved":true,"context_lines":[{"line_number":382,"context_line":"                 details\u003dNone, devname\u003dNone, ovs_interfaceid\u003dNone,"},{"line_number":383,"context_line":"                 qbh_params\u003dNone, qbg_params\u003dNone, active\u003dFalse,"},{"line_number":384,"context_line":"                 vnic_type\u003dVNIC_TYPE_NORMAL, profile\u003dNone,"},{"line_number":385,"context_line":"                 preserve_on_delete\u003dFalse, numa_policy\u003dNone, **kwargs):"},{"line_number":386,"context_line":"        super(VIF, self).__init__()"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        self[\u0027id\u0027] \u003d id"}],"source_content_type":"text/x-python","patch_set":2,"id":"57595f4e_35077b18","line":385,"range":{"start_line":385,"start_character":55,"end_line":385,"end_character":59},"updated":"2021-02-16 13:56:22.000000000","message":"None-\u003e\"\"","commit_id":"0031d5bebf87e6e468a61139d0980c1d16e0d1ae"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1740340a9dd71a4a05b3a32986906b12a6e1203a","unresolved":true,"context_lines":[{"line_number":401,"context_line":"        self[\u0027preserve_on_delete\u0027] \u003d preserve_on_delete"},{"line_number":402,"context_line":"        self[\u0027numa_policy\u0027] \u003d numa_policy"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        self._set_meta(kwargs)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @property"},{"line_number":407,"context_line":"    def numa_policy(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"76f41422_654da82a","line":404,"range":{"start_line":404,"start_character":6,"end_line":404,"end_character":30},"updated":"2021-02-16 13:56:22.000000000","message":"this is slightly awward.\n\nthe nova model objects are not OVOs because they predate them.\nwe have not added any new filed in 7 years and since the last one we added versioned notifcation\nthat define the metadata as a dictofstrings field.\n\nwhich means if we write the network info cache values using an upgraded node and read it using a non upgraded\nnode any new filed will be treated as metadta.\n\nthat means we have to defulat them to \"\" instead of None or it will break.\nhttps://zuul.opendev.org/t/openstack/build/ccfcbf73456a41019d4c96400873fb4e/log/logs/subnode-2/screen-n-cpu.txt#14820\n\nthe real fix is we need to move the network_info_cache and all of these object to be OVOs\nwhich will need db changes and a cycle or 2 of compatablty code.\n\nthis is long overdue but i dont really want to do that now.\nthis code is currently not used although i had inteded to use it in a follow up so i could remvoe it but i have been using\nit for debugging so i kind of want to keep it.\n\ndefaulting to empty strings will avoid breaking the versioned notifications. its just a little odd to use as a parmater default although it is valid.","commit_id":"0031d5bebf87e6e468a61139d0980c1d16e0d1ae"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1740340a9dd71a4a05b3a32986906b12a6e1203a","unresolved":true,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @property"},{"line_number":407,"context_line":"    def numa_policy(self):"},{"line_number":408,"context_line":"        return self[\u0027numa_policy\u0027] if \u0027numa_policy\u0027 in self else None"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    @numa_policy.setter"},{"line_number":411,"context_line":"    def numa_policy(self, policy):"}],"source_content_type":"text/x-python","patch_set":2,"id":"48a769c7_76ed1d9c","line":408,"range":{"start_line":408,"start_character":65,"end_line":408,"end_character":69},"updated":"2021-02-16 13:56:22.000000000","message":"None -\u003e \"\"","commit_id":"0031d5bebf87e6e468a61139d0980c1d16e0d1ae"}],"nova/network/neutron.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f06367fdafff1ce90c20b974203daac12bfe0eae","unresolved":true,"context_lines":[{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"        :return: A tuple of vNIC type, trusted status, network ID and resource"},{"line_number":2034,"context_line":"                 request of the port if any. Trusted status only affects SR-IOV"},{"line_number":2035,"context_line":"                 ports and will always be None for other port types."},{"line_number":2036,"context_line":"        \"\"\""},{"line_number":2037,"context_line":"        port \u003d self._show_port("},{"line_number":2038,"context_line":"            context, port_id, neutron_client\u003dneutron,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9dacdec9_969473c0","line":2035,"updated":"2021-02-02 20:25:48.000000000","message":"i need to update the doc string here for the numa policy","commit_id":"1e5eea4a71ba1acf2d448ea40f46f3b0c141f604"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f06367fdafff1ce90c20b974203daac12bfe0eae","unresolved":true,"context_lines":[{"line_number":2050,"context_line":"        # applied to the port/network and the port-resource-request API"},{"line_number":2051,"context_line":"        # extension is enabled."},{"line_number":2052,"context_line":"        resource_request \u003d port.get(constants.RESOURCE_REQUEST, None)"},{"line_number":2053,"context_line":"        numa_policy \u003d port.get(consttants.NUMA_POLICY, None)"},{"line_number":2054,"context_line":"        return vnic_type, trusted, network_id, resource_request, numa_policy"},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"    def create_resource_requests("}],"source_content_type":"text/x-python","patch_set":1,"id":"38dd9201_d52ced20","line":2053,"range":{"start_line":2053,"start_character":8,"end_line":2053,"end_character":60},"updated":"2021-02-02 20:25:48.000000000","message":"note that i am defaulting to none to avoid needing to chekc for the presence of the api\nextention.\n\nthis avoid extra calls to neutron and None will have the correct default behviaor\nkeeping the code  simple.","commit_id":"1e5eea4a71ba1acf2d448ea40f46f3b0c141f604"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"433519aecbe302c7eaaeef2d49e8a736f1db0ea9","unresolved":true,"context_lines":[{"line_number":2050,"context_line":"        # applied to the port/network and the port-resource-request API"},{"line_number":2051,"context_line":"        # extension is enabled."},{"line_number":2052,"context_line":"        resource_request \u003d port.get(constants.RESOURCE_REQUEST, None)"},{"line_number":2053,"context_line":"        numa_policy \u003d port.get(consttants.NUMA_POLICY, None)"},{"line_number":2054,"context_line":"        return vnic_type, trusted, network_id, resource_request, numa_policy"},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"    def create_resource_requests("}],"source_content_type":"text/x-python","patch_set":1,"id":"f526530e_88037870","line":2053,"range":{"start_line":2053,"start_character":31,"end_line":2053,"end_character":41},"updated":"2021-02-03 13:41:43.000000000","message":"of course i typo\u0027d it here too anyway ill fix this in the next version","commit_id":"1e5eea4a71ba1acf2d448ea40f46f3b0c141f604"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c6e219d632f77653bee6726c366f0001821f1a68","unresolved":true,"context_lines":[{"line_number":2027,"context_line":"            return strutils.bool_from_string(value)"},{"line_number":2028,"context_line":""},{"line_number":2029,"context_line":"    # NOTE(sean-k-mooney): we might want to have this return a"},{"line_number":2030,"context_line":"    # nova.network.model.VIF object instead in the future."},{"line_number":2031,"context_line":"    def _get_port_vnic_info(self, context, neutron, port_id):"},{"line_number":2032,"context_line":"        \"\"\"Retrieve port vNIC info"},{"line_number":2033,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1b168525_2bf5a305","line":2030,"updated":"2021-03-01 08:26:52.000000000","message":"good point to return an object instead of an ever growing tuple","commit_id":"972ee0ecdeb82a73a472f619be585cf670b1a519"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d009d8af47212bf42c15e2915c8fa92ba8695a32","unresolved":true,"context_lines":[{"line_number":2027,"context_line":"            return strutils.bool_from_string(value)"},{"line_number":2028,"context_line":""},{"line_number":2029,"context_line":"    # NOTE(sean-k-mooney): we might want to have this return a"},{"line_number":2030,"context_line":"    # nova.network.model.VIF object instead in the future."},{"line_number":2031,"context_line":"    def _get_port_vnic_info(self, context, neutron, port_id):"},{"line_number":2032,"context_line":"        \"\"\"Retrieve port vNIC info"},{"line_number":2033,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fdc02fcc_ef11d6b7","line":2030,"in_reply_to":"1b168525_2bf5a305","updated":"2021-03-05 17:21:42.000000000","message":"right now the VIF object does not fully contiain all the files we are returning but i might try an consolidate om of the random data types we are using next cycle. for now though just extending it is fine but i would like to make this more stuctured eventualy hence the note.","commit_id":"972ee0ecdeb82a73a472f619be585cf670b1a519"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c6e219d632f77653bee6726c366f0001821f1a68","unresolved":true,"context_lines":[{"line_number":2043,"context_line":"            context, port_id, neutron_client\u003dneutron,"},{"line_number":2044,"context_line":"            fields\u003d["},{"line_number":2045,"context_line":"                \u0027binding:vnic_type\u0027, constants.BINDING_PROFILE, \u0027network_id\u0027,"},{"line_number":2046,"context_line":"                constants.RESOURCE_REQUEST, constants.NUMA_POLICY,"},{"line_number":2047,"context_line":"            ])"},{"line_number":2048,"context_line":"        network_id \u003d port.get(\u0027network_id\u0027)"},{"line_number":2049,"context_line":"        trusted \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5e794c_617a12af","line":2046,"updated":"2021-03-01 08:26:52.000000000","message":"Is this creates a valid query to neutron even if port-numa-affinity-policy extension is not enabled? I.e. can we list a nonexisting field in the query and still get a positive response?","commit_id":"972ee0ecdeb82a73a472f619be585cf670b1a519"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45cba93cd09ca50522f192abab3fc80677240d5e","unresolved":true,"context_lines":[{"line_number":2043,"context_line":"            context, port_id, neutron_client\u003dneutron,"},{"line_number":2044,"context_line":"            fields\u003d["},{"line_number":2045,"context_line":"                \u0027binding:vnic_type\u0027, constants.BINDING_PROFILE, \u0027network_id\u0027,"},{"line_number":2046,"context_line":"                constants.RESOURCE_REQUEST, constants.NUMA_POLICY,"},{"line_number":2047,"context_line":"            ])"},{"line_number":2048,"context_line":"        network_id \u003d port.get(\u0027network_id\u0027)"},{"line_number":2049,"context_line":"        trusted \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"15db07d2_81bd2a74","line":2046,"in_reply_to":"7a5e794c_617a12af","updated":"2021-03-02 18:42:28.000000000","message":"it looks like its ignored.\n\ncurl -g -i -X GET \"http://api.openstack.seanmooney.info:9696/v2.0/ports/e0e1ee75-c27d-4c6c-9650-a9ad84f7cb9d?fields\u003dmac_address\u0026fields\u003did\u0026fileds\u003dnot_a_real_field\"  -H \"X-Auth-Token: ${token}\"\nHTTP/1.1 200 OK\nContent-Type: application/json\nContent-Length: 88\nX-Openstack-Request-Id: req-37b2b496-7752-404c-9906-70b5282abdbb\nDate: Tue, 02 Mar 2021 18:33:46 GMT\n\n{\"port\":{\"id\":\"e0e1ee75-c27d-4c6c-9650-a9ad84f7cb9d\",\"mac_address\":\"fa:16:3e:40:26:fb\"}}\n\nbut i can make this conditional on if the extension is present too to make it more robost.\ntechnically looks like its not needed but it does not hurt.","commit_id":"972ee0ecdeb82a73a472f619be585cf670b1a519"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9fa2786cecb5823c26877746e856e3447ce4e5d2","unresolved":true,"context_lines":[{"line_number":2039,"context_line":"        :param neutron: The Neutron client"},{"line_number":2040,"context_line":"        :param port_id: The id of port to be queried"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        :return: A tuple of vNIC type, trusted status, network ID and resource"},{"line_number":2043,"context_line":"                 request of the port if any. Trusted status only affects SR-IOV"},{"line_number":2044,"context_line":"                 ports and will always be None for other port types."},{"line_number":2045,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"0f7b2cad_ede96e17","line":2042,"updated":"2021-03-08 11:24:44.000000000","message":"please list the new value in the return tuple","commit_id":"e2bec82c2e114afdaeb35bf966c32ca41b1a6bb5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9fa2786cecb5823c26877746e856e3447ce4e5d2","unresolved":true,"context_lines":[{"line_number":2161,"context_line":"                    requester_id\u003drequester_id)"},{"line_number":2162,"context_line":"                numa_policy \u003d port_numa_policy or affinity_policy"},{"line_number":2163,"context_line":"                if numa_policy:"},{"line_number":2164,"context_line":"                    request.numa_policy \u003d numa_policy"},{"line_number":2165,"context_line":"                pci_requests.requests.append(request)"},{"line_number":2166,"context_line":"                pci_request_id \u003d request.request_id"},{"line_number":2167,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"52cc6cb0_ea00aad6","line":2164,"updated":"2021-03-08 11:24:44.000000000","message":"OK, this assignment works as Enum values are coerced from strings","commit_id":"e2bec82c2e114afdaeb35bf966c32ca41b1a6bb5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":2040,"context_line":"        :param port_id: The id of port to be queried"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        :return: A tuple of vNIC type, trusted status, network ID, resource"},{"line_number":2043,"context_line":"                 request of the port if any and port numa affintiy policy."},{"line_number":2044,"context_line":"                 Trusted status only affects SR-IOV ports and will always be"},{"line_number":2045,"context_line":"                 None for other port types. If no port numa policy is"},{"line_number":2046,"context_line":"                 requested by a port, None will be returned."}],"source_content_type":"text/x-python","patch_set":6,"id":"a0380e28_b5f20620","line":2043,"range":{"start_line":2043,"start_character":12,"end_line":2043,"end_character":17},"updated":"2021-03-08 18:53:29.000000000","message":"nit: would be nice to drop this while we\u0027re here","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":2040,"context_line":"        :param port_id: The id of port to be queried"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        :return: A tuple of vNIC type, trusted status, network ID, resource"},{"line_number":2043,"context_line":"                 request of the port if any and port numa affintiy policy."},{"line_number":2044,"context_line":"                 Trusted status only affects SR-IOV ports and will always be"},{"line_number":2045,"context_line":"                 None for other port types. If no port numa policy is"},{"line_number":2046,"context_line":"                 requested by a port, None will be returned."}],"source_content_type":"text/x-python","patch_set":6,"id":"6f3b3452_e4fb247b","line":2043,"range":{"start_line":2043,"start_character":12,"end_line":2043,"end_character":17},"in_reply_to":"a0380e28_b5f20620","updated":"2021-03-08 19:48:54.000000000","message":"its technically an unrelated change but i can.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":2047,"context_line":"        \"\"\""},{"line_number":2048,"context_line":"        fields \u003d [\u0027binding:vnic_type\u0027, constants.BINDING_PROFILE,"},{"line_number":2049,"context_line":"                  \u0027network_id\u0027, constants.RESOURCE_REQUEST]"},{"line_number":2050,"context_line":"        if self.supports_port_numa_policy_extension(context):"},{"line_number":2051,"context_line":"            fields +\u003d [constants.NUMA_POLICY]"},{"line_number":2052,"context_line":"        port \u003d self._show_port("},{"line_number":2053,"context_line":"            context, port_id, neutron_client\u003dneutron, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":6,"id":"676a9647_0c1d298e","line":2050,"updated":"2021-03-08 18:53:29.000000000","message":"Why do we need to check for this feature yet we don\u0027t have to check for the resource request extension? gibi\u0027s note below suggests the resource-request field might not always be set, depending on the config of the neutron server.\n\nAlso note, since we\u0027re force refreshing the cache in \u0027supports_port_numa_policy_extension\u0027, this function will now consistently result in two calls to neutron. Maybe that\u0027s not an issue and I haven\u0027t checked all the callers of this to see how often it\u0027s used, but it\u0027s worth noting, particularly given the above.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":2047,"context_line":"        \"\"\""},{"line_number":2048,"context_line":"        fields \u003d [\u0027binding:vnic_type\u0027, constants.BINDING_PROFILE,"},{"line_number":2049,"context_line":"                  \u0027network_id\u0027, constants.RESOURCE_REQUEST]"},{"line_number":2050,"context_line":"        if self.supports_port_numa_policy_extension(context):"},{"line_number":2051,"context_line":"            fields +\u003d [constants.NUMA_POLICY]"},{"line_number":2052,"context_line":"        port \u003d self._show_port("},{"line_number":2053,"context_line":"            context, port_id, neutron_client\u003dneutron, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":6,"id":"6fd1c3ec_2da298f1","line":2050,"in_reply_to":"676a9647_0c1d298e","updated":"2021-03-08 19:48:54.000000000","message":"we technically dont gibi was not sure what would happen if we asked for a filed that did not exisit\ni checked and neutron currently ignored it but techinically it could treat it as a 400 since its undefiended if that is allowed.\n\nim  am only chekcing for the extention out of caution but technically we shoudl also be checking if the extention for resouce_requests exits.\n\n\nsylvain asked that i check just to be safe when i discussed this with him too just to be safe but your right technically we could get away without checking.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":2106,"context_line":""},{"line_number":2107,"context_line":"            if request_net.port_id:"},{"line_number":2108,"context_line":"                (vnic_type, trusted, network_id, resource_request,"},{"line_number":2109,"context_line":"                 port_numa_policy) \u003d self._get_port_vnic_info("},{"line_number":2110,"context_line":"                     context, neutron, request_net.port_id)"},{"line_number":2111,"context_line":"                physnet, tunneled_ \u003d self._get_physnet_tunneled_info("},{"line_number":2112,"context_line":"                    context, neutron, network_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"05d1efe6_a5589268","line":2109,"updated":"2021-03-08 18:53:29.000000000","message":"style nit:\n\n  (\n      vnic_type, trusted, network_id, resource_request,\n      port_numa_policy,\n  ) \u003d self._get_port_vnic_info( ...","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":2161,"context_line":"                    spec\u003d[spec],"},{"line_number":2162,"context_line":"                    request_id\u003duuidutils.generate_uuid(),"},{"line_number":2163,"context_line":"                    requester_id\u003drequester_id)"},{"line_number":2164,"context_line":"                numa_policy \u003d port_numa_policy or affinity_policy"},{"line_number":2165,"context_line":"                if numa_policy:"},{"line_number":2166,"context_line":"                    request.numa_policy \u003d numa_policy"},{"line_number":2167,"context_line":"                pci_requests.requests.append(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f50abb00_bf2089ce","line":2164,"updated":"2021-03-08 18:53:29.000000000","message":"So port policy overrides global policy. That\u0027s expected but you should call it out here with a note.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85a2ffa272133d236b30bb8c99d702af42f7f36c","unresolved":true,"context_lines":[{"line_number":2161,"context_line":"                    spec\u003d[spec],"},{"line_number":2162,"context_line":"                    request_id\u003duuidutils.generate_uuid(),"},{"line_number":2163,"context_line":"                    requester_id\u003drequester_id)"},{"line_number":2164,"context_line":"                numa_policy \u003d port_numa_policy or affinity_policy"},{"line_number":2165,"context_line":"                if numa_policy:"},{"line_number":2166,"context_line":"                    request.numa_policy \u003d numa_policy"},{"line_number":2167,"context_line":"                pci_requests.requests.append(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f339db39_3e61060e","line":2164,"in_reply_to":"96e14977_139bd8c1","updated":"2021-03-09 16:55:31.000000000","message":"Yes and no. We don\u0027t need an explanation of how Python works here. Rather, a bit of colour around what these attributes mean would help. You need to load a _lot_ of context before you realize that this is preferring port-specific policy to flavour/image-derived policy (not global as I suggested previously, since this code path wouldn\u0027t be used for PCI passthrough of NICs afaik)","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ce1aa9c7ac149c7c22fc587fa5e1fc5cfc066a9d","unresolved":true,"context_lines":[{"line_number":2161,"context_line":"                    spec\u003d[spec],"},{"line_number":2162,"context_line":"                    request_id\u003duuidutils.generate_uuid(),"},{"line_number":2163,"context_line":"                    requester_id\u003drequester_id)"},{"line_number":2164,"context_line":"                numa_policy \u003d port_numa_policy or affinity_policy"},{"line_number":2165,"context_line":"                if numa_policy:"},{"line_number":2166,"context_line":"                    request.numa_policy \u003d numa_policy"},{"line_number":2167,"context_line":"                pci_requests.requests.append(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7b0361c8_7fd57711","line":2164,"in_reply_to":"f339db39_3e61060e","updated":"2021-03-10 22:26:23.000000000","message":"it was used for neutron sriov port previously its common to alias based passthough and vnic_type\u003ddirect ectra.\nbut ya i added a comment in any case","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":2161,"context_line":"                    spec\u003d[spec],"},{"line_number":2162,"context_line":"                    request_id\u003duuidutils.generate_uuid(),"},{"line_number":2163,"context_line":"                    requester_id\u003drequester_id)"},{"line_number":2164,"context_line":"                numa_policy \u003d port_numa_policy or affinity_policy"},{"line_number":2165,"context_line":"                if numa_policy:"},{"line_number":2166,"context_line":"                    request.numa_policy \u003d numa_policy"},{"line_number":2167,"context_line":"                pci_requests.requests.append(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"96e14977_139bd8c1","line":2164,"in_reply_to":"f50abb00_bf2089ce","updated":"2021-03-08 19:48:54.000000000","message":"i could but i though it was obvious from the code ill add on i guess.\n\nwe use the or idiom in lots of places for setting default so i assumed people would be familar with the fact it short curcits so i didnt think it needed a note.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4a7a4e33a4dab3c5d3f918f4865aa68929252c5f","unresolved":true,"context_lines":[{"line_number":2040,"context_line":"        :param port_id: The id of port to be queried"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        :return: A tuple of vNIC type, trusted status, network ID, resource"},{"line_number":2043,"context_line":"        request of the port if any and port numa affintiy policy."},{"line_number":2044,"context_line":"        Trusted status only affects SR-IOV ports and will always be"},{"line_number":2045,"context_line":"        None for other port types. If no port numa policy is"},{"line_number":2046,"context_line":"        requested by a port, None will be returned."}],"source_content_type":"text/x-python","patch_set":8,"id":"4d229c6d_250ebb69","line":2043,"updated":"2021-03-09 15:25:57.000000000","message":"I think what Stephen asked for is to have a simple 4 space indent instead of a column aligned indent.","commit_id":"0de735bd1b3edb9b75f76bc078328b2e68068f1b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85a2ffa272133d236b30bb8c99d702af42f7f36c","unresolved":true,"context_lines":[{"line_number":2040,"context_line":"        :param port_id: The id of port to be queried"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        :return: A tuple of vNIC type, trusted status, network ID, resource"},{"line_number":2043,"context_line":"        request of the port if any and port numa affintiy policy."},{"line_number":2044,"context_line":"        Trusted status only affects SR-IOV ports and will always be"},{"line_number":2045,"context_line":"        None for other port types. If no port numa policy is"},{"line_number":2046,"context_line":"        requested by a port, None will be returned."}],"source_content_type":"text/x-python","patch_set":8,"id":"e9671d1e_2fa19db7","line":2043,"in_reply_to":"4d229c6d_250ebb69","updated":"2021-03-09 16:55:31.000000000","message":"Yuup. This won\u0027t render properly in Sphinx, not that we generate API docs","commit_id":"0de735bd1b3edb9b75f76bc078328b2e68068f1b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":2156,"context_line":"                    spec\u003d[spec],"},{"line_number":2157,"context_line":"                    request_id\u003duuidutils.generate_uuid(),"},{"line_number":2158,"context_line":"                    requester_id\u003drequester_id)"},{"line_number":2159,"context_line":"                # NOTE(sean-k-mooney): port numa policies take precedence"},{"line_number":2160,"context_line":"                # over image and flavor policies."},{"line_number":2161,"context_line":"                numa_policy \u003d port_numa_policy or affinity_policy"},{"line_number":2162,"context_line":"                if numa_policy:"}],"source_content_type":"text/x-python","patch_set":10,"id":"8bfc1ae7_341e89b6","line":2159,"range":{"start_line":2159,"start_character":44,"end_line":2159,"end_character":48},"updated":"2021-03-10 21:41:29.000000000","message":"NUMA","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ebf0d48e03101a0cddb1b1f3f197eac429ca2045","unresolved":true,"context_lines":[{"line_number":3060,"context_line":"            devname\u003ddevname,"},{"line_number":3061,"context_line":"            active\u003dvif_active,"},{"line_number":3062,"context_line":"            preserve_on_delete\u003dpreserve_on_delete"},{"line_number":3063,"context_line":"        )"},{"line_number":3064,"context_line":""},{"line_number":3065,"context_line":"    def _build_network_info_model(self, context, instance, networks\u003dNone,"},{"line_number":3066,"context_line":"                                  port_ids\u003dNone, admin_client\u003dNone,"}],"source_content_type":"text/x-python","patch_set":12,"id":"40bb2130_c721f25f","line":3063,"updated":"2021-03-11 11:29:10.000000000","message":"unrelated but meh","commit_id":"5cd1acc3bfbd70e18258d832d0910b250b1adb3e"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":1147,"context_line":"        port_id \u003d new_port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":1148,"context_line":"        port \u003d self.neutron.show_port(port_id)[\u0027port\u0027]"},{"line_number":1149,"context_line":"        self.assertEqual(port[constants.NUMA_POLICY], policy)"},{"line_number":1150,"context_line":"        return port, port_id"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    # NOTE(sean-k-mooney): i could just apply the ddt decorators"},{"line_number":1153,"context_line":"    # to this function for the most part but i have chosen to"}],"source_content_type":"text/x-python","patch_set":10,"id":"ace65487_b56e4fce","line":1150,"range":{"start_line":1150,"start_character":15,"end_line":1150,"end_character":19},"updated":"2021-03-10 21:41:29.000000000","message":"No caller is using this. Can you drop it?","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ce1aa9c7ac149c7c22fc587fa5e1fc5cfc066a9d","unresolved":true,"context_lines":[{"line_number":1147,"context_line":"        port_id \u003d new_port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":1148,"context_line":"        port \u003d self.neutron.show_port(port_id)[\u0027port\u0027]"},{"line_number":1149,"context_line":"        self.assertEqual(port[constants.NUMA_POLICY], policy)"},{"line_number":1150,"context_line":"        return port, port_id"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    # NOTE(sean-k-mooney): i could just apply the ddt decorators"},{"line_number":1153,"context_line":"    # to this function for the most part but i have chosen to"}],"source_content_type":"text/x-python","patch_set":10,"id":"f095646d_ac367b50","line":1150,"range":{"start_line":1150,"start_character":15,"end_line":1150,"end_character":19},"in_reply_to":"ace65487_b56e4fce","updated":"2021-03-10 22:26:23.000000000","message":"ya i debaed if i shoudl return port or port id so ir returned both\nill just make it the id","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":1152,"context_line":"    # NOTE(sean-k-mooney): i could just apply the ddt decorators"},{"line_number":1153,"context_line":"    # to this function for the most part but i have chosen to"},{"line_number":1154,"context_line":"    # keep one top level function per policy to make documenting"},{"line_number":1155,"context_line":"    # the test cases simpler."},{"line_number":1156,"context_line":"    def _test_policy(self, pci_numa_node, status, policy):"},{"line_number":1157,"context_line":"        # only allow cpus on numa node 1 to be used for pinning"},{"line_number":1158,"context_line":"        self.flags(cpu_dedicated_set\u003d\u00274-7\u0027, group\u003d\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"2438ca76_42ec5193","line":1155,"updated":"2021-03-10 21:41:29.000000000","message":"That makes sense. I think you can drop it from the code though","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ce1aa9c7ac149c7c22fc587fa5e1fc5cfc066a9d","unresolved":true,"context_lines":[{"line_number":1152,"context_line":"    # NOTE(sean-k-mooney): i could just apply the ddt decorators"},{"line_number":1153,"context_line":"    # to this function for the most part but i have chosen to"},{"line_number":1154,"context_line":"    # keep one top level function per policy to make documenting"},{"line_number":1155,"context_line":"    # the test cases simpler."},{"line_number":1156,"context_line":"    def _test_policy(self, pci_numa_node, status, policy):"},{"line_number":1157,"context_line":"        # only allow cpus on numa node 1 to be used for pinning"},{"line_number":1158,"context_line":"        self.flags(cpu_dedicated_set\u003d\u00274-7\u0027, group\u003d\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"84ac7317_369280ab","line":1155,"in_reply_to":"2438ca76_42ec5193","updated":"2021-03-10 22:26:23.000000000","message":"ok will do.\ni wanted to test all the nova paths since this should work and it found a bug in atroms previous patch so its already been useful. but ill drop the note","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"}],"nova/tests/unit/network/test_neutron.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":3534,"context_line":"        self.assertIsNone(physnet_name)"},{"line_number":3535,"context_line":""},{"line_number":3536,"context_line":"    def _test_get_port_vnic_info("},{"line_number":3537,"context_line":"            self, mock_get_client, binding_vnic_type, expected_vnic_type,"},{"line_number":3538,"context_line":"            port_resource_request\u003dNone, numa_policy\u003dNone):"},{"line_number":3539,"context_line":"        test_port \u003d {"},{"line_number":3540,"context_line":"            \u0027port\u0027: {\u0027id\u0027: \u0027my_port_id2\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"71b34cd1_d2bf5dfa","line":3537,"range":{"start_line":3537,"start_character":8,"end_line":3537,"end_character":12},"updated":"2021-03-08 18:53:29.000000000","message":"nit","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":3534,"context_line":"        self.assertIsNone(physnet_name)"},{"line_number":3535,"context_line":""},{"line_number":3536,"context_line":"    def _test_get_port_vnic_info("},{"line_number":3537,"context_line":"            self, mock_get_client, binding_vnic_type, expected_vnic_type,"},{"line_number":3538,"context_line":"            port_resource_request\u003dNone, numa_policy\u003dNone):"},{"line_number":3539,"context_line":"        test_port \u003d {"},{"line_number":3540,"context_line":"            \u0027port\u0027: {\u0027id\u0027: \u0027my_port_id2\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0b6d6f7c_fa7901f9","line":3537,"range":{"start_line":3537,"start_character":8,"end_line":3537,"end_character":12},"in_reply_to":"71b34cd1_d2bf5dfa","updated":"2021-03-08 19:48:54.000000000","message":"this is the correct way to do hanging indents it would be a pep8 error to remove it","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":3535,"context_line":""},{"line_number":3536,"context_line":"    def _test_get_port_vnic_info("},{"line_number":3537,"context_line":"            self, mock_get_client, binding_vnic_type, expected_vnic_type,"},{"line_number":3538,"context_line":"            port_resource_request\u003dNone, numa_policy\u003dNone):"},{"line_number":3539,"context_line":"        test_port \u003d {"},{"line_number":3540,"context_line":"            \u0027port\u0027: {\u0027id\u0027: \u0027my_port_id2\u0027,"},{"line_number":3541,"context_line":"                      \u0027network_id\u0027: \u0027net-id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"850c4bb9_f2a91950","line":3538,"range":{"start_line":3538,"start_character":56,"end_line":3538,"end_character":58},"updated":"2021-03-08 18:53:29.000000000","message":"nit:\n\n      ..., numa_policy\u003dNone,\n  ):","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":3535,"context_line":""},{"line_number":3536,"context_line":"    def _test_get_port_vnic_info("},{"line_number":3537,"context_line":"            self, mock_get_client, binding_vnic_type, expected_vnic_type,"},{"line_number":3538,"context_line":"            port_resource_request\u003dNone, numa_policy\u003dNone):"},{"line_number":3539,"context_line":"        test_port \u003d {"},{"line_number":3540,"context_line":"            \u0027port\u0027: {\u0027id\u0027: \u0027my_port_id2\u0027,"},{"line_number":3541,"context_line":"                      \u0027network_id\u0027: \u0027net-id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3861ad2c_d8be2d8f","line":3538,"range":{"start_line":3538,"start_character":56,"end_line":3538,"end_character":58},"in_reply_to":"850c4bb9_f2a91950","updated":"2021-03-08 19:48:54.000000000","message":"unless i also put this onto a new line.\n\nwith doing this removing the indent on line 3537 is not allowed.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"}],"nova/tests/unit/pci/test_stats.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":541,"context_line":"        self._create_pci_devices()"},{"line_number":542,"context_line":"        request \u003d objects.InstancePCIRequest("},{"line_number":543,"context_line":"            count\u003d1, spec\u003d[{\u0027physical_network\u0027: \u0027physnet1\u0027}])"},{"line_number":544,"context_line":"        self.assertTrue(self.pci_stats.support_requests([request]))"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def test_consume_requests(self):"},{"line_number":547,"context_line":"        self._create_pci_devices()"}],"source_content_type":"text/x-python","patch_set":10,"id":"a07f3b44_ebc53479","line":544,"updated":"2021-03-10 21:41:29.000000000","message":"Is this related? It doesn\u0027t seem like it\n\nLater: doesn\u0027t seem like it. I assume you\u0027re just closing a gap. If so, can you move this up with all the other \u0027test_support_requests\u0027 tests?","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ce1aa9c7ac149c7c22fc587fa5e1fc5cfc066a9d","unresolved":true,"context_lines":[{"line_number":541,"context_line":"        self._create_pci_devices()"},{"line_number":542,"context_line":"        request \u003d objects.InstancePCIRequest("},{"line_number":543,"context_line":"            count\u003d1, spec\u003d[{\u0027physical_network\u0027: \u0027physnet1\u0027}])"},{"line_number":544,"context_line":"        self.assertTrue(self.pci_stats.support_requests([request]))"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def test_consume_requests(self):"},{"line_number":547,"context_line":"        self._create_pci_devices()"}],"source_content_type":"text/x-python","patch_set":10,"id":"dbcb8a81_0be4db17","line":544,"in_reply_to":"a07f3b44_ebc53479","updated":"2021-03-10 22:26:23.000000000","message":"ya i was closing a gap i wanted a single simple test that just checks this for soemthing else.\nthere are more complex test that do. i might just remove it. ill try movingit up but i think it had to be here to have because of how we create the devices and configure the whitelist in this class and the other one were those function are do not do that.","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"}],"releasenotes/notes/port-numa-affinity-policy-f51a74065a1e4369.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c6e219d632f77653bee6726c366f0001821f1a68","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to speicify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"091153a6_f27dac1c","line":4,"range":{"start_line":4,"start_character":57,"end_line":4,"end_character":65},"updated":"2021-03-01 08:26:52.000000000","message":"nit: specify","commit_id":"972ee0ecdeb82a73a472f619be585cf670b1a519"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c6e219d632f77653bee6726c366f0001821f1a68","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precidnece over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"},{"line_number":11,"context_line":"    flavor or image and endusers to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6a89ba5f_b7b4f1be","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":30},"updated":"2021-03-01 08:26:52.000000000","message":"nit:precedence","commit_id":"972ee0ecdeb82a73a472f619be585cf670b1a519"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c6e219d632f77653bee6726c366f0001821f1a68","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precidnece over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"},{"line_number":11,"context_line":"    flavor or image and endusers to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron ml2_conf.ini. By default the extension"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bb308a4f_40373bcb","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":32},"updated":"2021-03-01 08:26:52.000000000","message":"end users","commit_id":"972ee0ecdeb82a73a472f619be585cf670b1a519"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c32bf683_f2626185","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":53},"updated":"2021-03-08 18:53:29.000000000","message":"Drop this. We know it\u0027s Wallaby since the heading will say so.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85a2ffa272133d236b30bb8c99d702af42f7f36c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5668f962_e8e73128","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":53},"in_reply_to":"bfd48811_b44d994b","updated":"2021-03-09 16:55:31.000000000","message":"It might be helpful for you, but it results in worse release notes for end users since we\u0027re stating unnecessary information. It\u0027s also actively harmful for bugfixes since we can\u0027t cherry-pick the release note.\n\nYou can get the tag that a release note was added (well, last updated) in with something like:\n\n  git tag --contains $(git log -3 --pretty\u003dformat:\"%h\" $PATH | tail -n 1)\n\nI\u0027d also be okay with adding a comment (YAML supports that) with context, if you like. I don\u0027t think it belongs here though","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bfd48811_b44d994b","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":53},"in_reply_to":"c32bf683_f2626185","updated":"2021-03-08 19:48:54.000000000","message":"it will but this is really useful to have when reading them in the git repo to know what release its added in.\nremoving it make it worse in my view so i would prefer to keep it i use this quite often personally.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1ed178af_3c330821","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":8},"updated":"2021-03-08 18:53:29.000000000","message":"NUMA","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f5739436_77837783","line":5,"range":{"start_line":5,"start_character":29,"end_line":5,"end_character":34},"updated":"2021-03-08 18:53:29.000000000","message":"SR-IOV","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6b089c9f_00a1a72f","line":5,"range":{"start_line":5,"start_character":62,"end_line":5,"end_character":69},"updated":"2021-03-08 18:53:29.000000000","message":"users","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"06635342_7b6e6836","line":6,"range":{"start_line":6,"start_character":63,"end_line":6,"end_character":67},"updated":"2021-03-08 18:53:29.000000000","message":"NUMA","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8722f9d5_78539f8f","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":17},"updated":"2021-03-08 18:53:29.000000000","message":"NUMA","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3d60d87a_524ee966","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":15},"updated":"2021-03-08 18:53:29.000000000","message":"CPUs","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    In the Wallaby (23.0.0) release support was added to specify a port"},{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"aa2caaef_a4289b10","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"updated":"2021-03-08 18:53:29.000000000","message":"guest\u0027s","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    numa affinity policy for sriov ports. This feature allows tenants"},{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"},{"line_number":11,"context_line":"    flavor or image and end users to express a more granular affinity"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3827feee_11b027fd","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":57},"updated":"2021-03-08 18:53:29.000000000","message":"flavor/image-derived PCI NUMA affinity policies","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    to set a numa affinity policy between a neutron port and a numa"},{"line_number":7,"context_line":"    guests cpus and memory. This feature supports the same policies"},{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"},{"line_number":11,"context_line":"    flavor or image and end users to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d51188da_d665380a","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":56},"updated":"2021-03-08 18:53:29.000000000","message":"these","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    as the existing flavor/image based vm scoped pci numa affinity"},{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"},{"line_number":11,"context_line":"    flavor or image and end users to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron ml2_conf.ini. By default the extension"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"def9a631_560696a9","line":11,"range":{"start_line":11,"start_character":20,"end_line":11,"end_character":44},"updated":"2021-03-08 18:53:29.000000000","message":"while end users express","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    policy and take precedence over the flavor and image values."},{"line_number":10,"context_line":"    This allows operators to set a default affinity policy in the"},{"line_number":11,"context_line":"    flavor or image and end users to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron ml2_conf.ini. By default the extension"},{"line_number":15,"context_line":"    is listed as avaibale but not enabled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"424d7341_81a54624","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":11},"updated":"2021-03-08 18:53:29.000000000","message":"when attaching interfaces.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    flavor or image and end users to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron ml2_conf.ini. By default the extension"},{"line_number":15,"context_line":"    is listed as avaibale but not enabled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"53134c4c_88bb0089","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":46},"updated":"2021-03-08 18:53:29.000000000","message":"configuration.  (we don\u0027t need to give specifics about how to configure neutron here)","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbb96343d16b21f27a7665e286eaac546abdf728","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    flavor or image and end users to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron ml2_conf.ini. By default the extension"},{"line_number":15,"context_line":"    is listed as avaibale but not enabled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"54db2409_445d4b75","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":46},"in_reply_to":"53134c4c_88bb0089","updated":"2021-03-08 19:48:54.000000000","message":"well i think we shoudl since 1 i got caught out by this and second the extension is listed on the neutron api if you dont configure it but the api will discard your policy but return it in the api request.\n\nso it will look like your policy was accepted but it will silently get ignored.\n\ni can drop the file name i guess but we shoudl call out the need to configure the service plug-in because its a pain to debug this.\n\nill fix the other issue too in the respin.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85a2ffa272133d236b30bb8c99d702af42f7f36c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    flavor or image and end users to express a more granular affinity"},{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron ml2_conf.ini. By default the extension"},{"line_number":15,"context_line":"    is listed as avaibale but not enabled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff5302e8_8b60b534","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":46},"in_reply_to":"54db2409_445d4b75","updated":"2021-03-09 16:55:31.000000000","message":"If that\u0027s the case, then can we add this information to the docs? Either neutron or nova would do, though I suspect it should probably be the former.","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8bf23a5145c0d7031f874e7472a9d5ecfb6d8792","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    policy. To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron ml2_conf.ini. By default the extension"},{"line_number":15,"context_line":"    is listed as avaibale but not enabled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2f418dcb_fbb3a23f","line":15,"range":{"start_line":15,"start_character":17,"end_line":15,"end_character":25},"updated":"2021-03-08 18:53:29.000000000","message":"available","commit_id":"395e1294644373a17a2ff1c61c48bb94034fd288"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    support was added to specify a port NUMA affinity policy"},{"line_number":5,"context_line":"    for SR-IOV ports. This feature allows users to set a NUMA affinity"},{"line_number":6,"context_line":"    policy between a neutron port and a NUMA guest\u0027s CPUs and memory."},{"line_number":7,"context_line":"    This feature supports the same policies as the existing VM Scoped"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5e2bfcff_82037ce0","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":11},"updated":"2021-03-10 21:41:29.000000000","message":"Support","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    This feature supports the same policies as the existing VM Scoped"},{"line_number":8,"context_line":"    PCI NUMA Affinity policy and take precedence over the"},{"line_number":9,"context_line":"    flavor and image policy. This allows operators to set a default"},{"line_number":10,"context_line":"    affinity policy in the flavor or image and while end users can"},{"line_number":11,"context_line":"    express a more granular affinity policy."},{"line_number":12,"context_line":"    To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"2e529ed5_fa056792","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":46},"updated":"2021-03-10 21:41:29.000000000","message":"strike","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    affinity policy in the flavor or image and while end users can"},{"line_number":11,"context_line":"    express a more granular affinity policy."},{"line_number":12,"context_line":"    To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron. By default the extension"},{"line_number":15,"context_line":"    is listed as available but is not enabled."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"85fac748_5a82abcf","line":13,"range":{"start_line":13,"start_character":34,"end_line":13,"end_character":44},"updated":"2021-03-10 21:41:29.000000000","message":"neutron extensions","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d43910738d79b4f530fd6b4176074ad6f53c543","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    express a more granular affinity policy."},{"line_number":12,"context_line":"    To use this feature operators must enable the"},{"line_number":13,"context_line":"    ``port-numa-affinity-policy`` extensions and configure the"},{"line_number":14,"context_line":"    service plugin in the neutron. By default the extension"},{"line_number":15,"context_line":"    is listed as available but is not enabled."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dbdd91f1_5d2509d4","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":25},"updated":"2021-03-10 21:41:29.000000000","message":"strike","commit_id":"6baba0b14f06a9a7af7c70aaf69d1f550c348662"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ebf0d48e03101a0cddb1b1f3f197eac429ca2045","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Support was added to specify a port NUMA affinity policy"},{"line_number":5,"context_line":"    for SR-IOV ports. This feature allows users to set a NUMA affinity"},{"line_number":6,"context_line":"    policy between a neutron port and a NUMA guest\u0027s CPUs and memory."},{"line_number":7,"context_line":"    This feature supports the same policies as the existing VM Scoped"},{"line_number":8,"context_line":"    PCI NUMA Affinity policy and take precedence over the"},{"line_number":9,"context_line":"    flavor and image policy. This allows operators to set a default"},{"line_number":10,"context_line":"    affinity policy in the flavor or image while end users can"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"39965512_f39e0158","line":7,"updated":"2021-03-11 11:29:10.000000000","message":"This is not 100% true as the VM scoped policies now support the value \"socket\" but that cannot be requested via neutron port yet.","commit_id":"5cd1acc3bfbd70e18258d832d0910b250b1adb3e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"74c304b57e1710c9c32956fddbc64c7aedc24b49","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Support was added to specify a port NUMA affinity policy"},{"line_number":5,"context_line":"    for SR-IOV ports. This feature allows users to set a NUMA affinity"},{"line_number":6,"context_line":"    policy between a neutron port and a NUMA guest\u0027s CPUs and memory."},{"line_number":7,"context_line":"    This feature supports the same policies as the existing VM Scoped"},{"line_number":8,"context_line":"    PCI NUMA Affinity policy and take precedence over the"},{"line_number":9,"context_line":"    flavor and image policy. This allows operators to set a default"},{"line_number":10,"context_line":"    affinity policy in the flavor or image while end users can"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fdd7faf7_4a2dee42","line":7,"in_reply_to":"22972ce9_fc3b2b8e","updated":"2021-03-11 17:00:25.000000000","message":"ack","commit_id":"5cd1acc3bfbd70e18258d832d0910b250b1adb3e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f27b03ac7e050d10c22e5e96a085bfeb33a4f9c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Support was added to specify a port NUMA affinity policy"},{"line_number":5,"context_line":"    for SR-IOV ports. This feature allows users to set a NUMA affinity"},{"line_number":6,"context_line":"    policy between a neutron port and a NUMA guest\u0027s CPUs and memory."},{"line_number":7,"context_line":"    This feature supports the same policies as the existing VM Scoped"},{"line_number":8,"context_line":"    PCI NUMA Affinity policy and take precedence over the"},{"line_number":9,"context_line":"    flavor and image policy. This allows operators to set a default"},{"line_number":10,"context_line":"    affinity policy in the flavor or image while end users can"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"22972ce9_fc3b2b8e","line":7,"in_reply_to":"39965512_f39e0158","updated":"2021-03-11 12:51:45.000000000","message":"a very true.\n\nill likely do this as a follow up yes assuming there are not merge conflcits ectra that require a respin","commit_id":"5cd1acc3bfbd70e18258d832d0910b250b1adb3e"}]}