)]}'
{"nova/objects/request_spec.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5ecd497c35cbfc729f9ff8e3bf1caefe1f0bcc6c","unresolved":true,"context_lines":[{"line_number":567,"context_line":"                \u0027tunneled\u0027, False)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"            # We also want to recreate the original NetworkRequests"},{"line_number":570,"context_line":"            # TODO(sbauza): We miss tag and pci_request_id information that is"},{"line_number":571,"context_line":"            # not stored in the VIF model to fully provide all fields"},{"line_number":572,"context_line":"            # FIXME(sbauza): We can\u0027t also guess whether the user provided us"},{"line_number":573,"context_line":"            # a specific IP address to use for create, and which one."}],"source_content_type":"text/x-python","patch_set":1,"id":"3395330b_d8b55ea6","line":570,"range":{"start_line":570,"start_character":44,"end_line":570,"end_character":58},"updated":"2021-02-04 12:57:13.000000000","message":"hm if we really need that then it can be recovered from the instance.pci_requests isn\u0027t it?","commit_id":"9e96f64126d0098b26a16da549860db2d6ac8b34"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dd85c59a175945d05995d8ded069d80dc216bf2c","unresolved":true,"context_lines":[{"line_number":567,"context_line":"                \u0027tunneled\u0027, False)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"            # We also want to recreate the original NetworkRequests"},{"line_number":570,"context_line":"            # TODO(sbauza): We miss tag and pci_request_id information that is"},{"line_number":571,"context_line":"            # not stored in the VIF model to fully provide all fields"},{"line_number":572,"context_line":"            # FIXME(sbauza): We can\u0027t also guess whether the user provided us"},{"line_number":573,"context_line":"            # a specific IP address to use for create, and which one."}],"source_content_type":"text/x-python","patch_set":1,"id":"55f989ad_954d2dcb","line":570,"range":{"start_line":570,"start_character":44,"end_line":570,"end_character":58},"in_reply_to":"0ad74216_b1e73ecc","updated":"2021-02-08 12:08:16.000000000","message":"yes I agree that we dont need it now. As of TODO vs FIXME I always thought that FIXME is mediate TODO is more for long term. So I\u0027m also OK with the current tag.","commit_id":"9e96f64126d0098b26a16da549860db2d6ac8b34"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f7ee82dacef3fb5dd3bd9a6182aeb309ff21fc5","unresolved":true,"context_lines":[{"line_number":567,"context_line":"                \u0027tunneled\u0027, False)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"            # We also want to recreate the original NetworkRequests"},{"line_number":570,"context_line":"            # TODO(sbauza): We miss tag and pci_request_id information that is"},{"line_number":571,"context_line":"            # not stored in the VIF model to fully provide all fields"},{"line_number":572,"context_line":"            # FIXME(sbauza): We can\u0027t also guess whether the user provided us"},{"line_number":573,"context_line":"            # a specific IP address to use for create, and which one."}],"source_content_type":"text/x-python","patch_set":1,"id":"0ad74216_b1e73ecc","line":570,"range":{"start_line":570,"start_character":44,"end_line":570,"end_character":58},"in_reply_to":"3395330b_d8b55ea6","updated":"2021-02-04 14:26:37.000000000","message":"We don\u0027t really need it *NOW*. Maybe people would like to have them later on, but for my series, nope at all. The TODO should maybe be a FIXME rather honestly.","commit_id":"9e96f64126d0098b26a16da549860db2d6ac8b34"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"abb928164b8f55c127b18cb3ffa68f3107bd6a92","unresolved":true,"context_lines":[{"line_number":575,"context_line":"                \u0027network_id\u0027: vif[\u0027network\u0027][\u0027id\u0027],"},{"line_number":576,"context_line":"                \u0027port_id\u0027: vif[\u0027id\u0027],"},{"line_number":577,"context_line":"            }"},{"line_number":578,"context_line":"            network_request \u003d objects.NetworkRequest(**nr_args)"},{"line_number":579,"context_line":"            network_requests.append(network_request)"},{"line_number":580,"context_line":"        self.network_metadata \u003d objects.NetworkMetadata("},{"line_number":581,"context_line":"            physnets\u003dphysnets, tunneled\u003dtunneled)"}],"source_content_type":"text/x-python","patch_set":1,"id":"024fb8f0_28a5fc52","line":578,"updated":"2021-02-09 17:43:44.000000000","message":"nit: I\u0027m not sure what you did this rather than passing the args to objects.NetworkRequest directly\n\n  network_request \u003d objects.NetworkRequest(\n      network_id\u003dvif[\u0027network\u0027][\u0027id\u0027],\n      port_id\u003dvif[\u0027id\u0027])\n\nThey\u0027re functionally the same though, I guess","commit_id":"9e96f64126d0098b26a16da549860db2d6ac8b34"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"abb928164b8f55c127b18cb3ffa68f3107bd6a92","unresolved":true,"context_lines":[{"line_number":8675,"context_line":"            objects\u003d[objects.NetworkRequest(port_id\u003duuids.port_instance)])"},{"line_number":8676,"context_line":""},{"line_number":8677,"context_line":"        with test.nested("},{"line_number":8678,"context_line":"                mock.patch.object(self.compute_api.compute_task_api,"},{"line_number":8679,"context_line":"                                  \u0027schedule_and_build_instances\u0027),"},{"line_number":8680,"context_line":"                mock.patch.object(self.compute_api.network_api,"},{"line_number":8681,"context_line":"                                  \u0027create_resource_requests\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f28fad3_bf5e3247","line":8678,"range":{"start_line":8678,"start_character":12,"end_line":8678,"end_character":16},"updated":"2021-02-09 17:43:44.000000000","message":"nit","commit_id":"9e96f64126d0098b26a16da549860db2d6ac8b34"}]}