)]}'
{"doc/source/admin/hw-machine-type.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"98c31060_15a8b7db","updated":"2021-02-16 10:25:00.000000000","message":"In line with the discussions on making the nova-manage commands more generic, this might need to be updated to reflect the generic\u0027ness. TBD.","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Introduction"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. todo::"},{"line_number":22,"context_line":"    Detail how to use can configure hw_machine_type with the HyperV driver."}],"source_content_type":"text/x-rst","patch_set":4,"id":"524d07e6_fdc44158","line":19,"updated":"2021-02-16 10:25:00.000000000","message":"Can you use ---- here and ~~~~ below, per the style guide [1]\n\n[1] https://docs.openstack.org/doc-contrib-guide/rst-conv/titles.html","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c544f5228c3b0801225074b143c9f8df5a4ca5cc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Introduction"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. todo::"},{"line_number":22,"context_line":"    Detail how to use can configure hw_machine_type with the HyperV driver."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc89481_5d539056","line":19,"in_reply_to":"524d07e6_fdc44158","updated":"2021-02-16 12:54:54.000000000","message":"TIL thanks.","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Libvirt"},{"line_number":25,"context_line":"-------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"QEMU\u0027s machine type concept can be thought of a virtual chipset that"},{"line_number":28,"context_line":"provides certain default devices (e.g. PCIe graphics card, Ethernet"},{"line_number":29,"context_line":"controller, SATA controllae, etc).  QEMU supports two main variants of"},{"line_number":30,"context_line":"\"machine type\" for x86 hosts: (a) ``pc``, which corresponds to Intel\u0027s"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bee4201b_b5aeff7a","line":27,"range":{"start_line":27,"start_character":46,"end_line":27,"end_character":47},"updated":"2021-02-16 10:25:00.000000000","message":"as a","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c544f5228c3b0801225074b143c9f8df5a4ca5cc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Libvirt"},{"line_number":25,"context_line":"-------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"QEMU\u0027s machine type concept can be thought of a virtual chipset that"},{"line_number":28,"context_line":"provides certain default devices (e.g. PCIe graphics card, Ethernet"},{"line_number":29,"context_line":"controller, SATA controllae, etc).  QEMU supports two main variants of"},{"line_number":30,"context_line":"\"machine type\" for x86 hosts: (a) ``pc``, which corresponds to Intel\u0027s"}],"source_content_type":"text/x-rst","patch_set":4,"id":"98c42389_069f98bc","line":27,"range":{"start_line":27,"start_character":46,"end_line":27,"end_character":47},"in_reply_to":"bee4201b_b5aeff7a","updated":"2021-02-16 12:54:54.000000000","message":"Ack","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"QEMU\u0027s machine type concept can be thought of a virtual chipset that"},{"line_number":28,"context_line":"provides certain default devices (e.g. PCIe graphics card, Ethernet"},{"line_number":29,"context_line":"controller, SATA controllae, etc).  QEMU supports two main variants of"},{"line_number":30,"context_line":"\"machine type\" for x86 hosts: (a) ``pc``, which corresponds to Intel\u0027s"},{"line_number":31,"context_line":"I440FX chipset, which is twenty-two years old as of this writing; and"},{"line_number":32,"context_line":"(b) ``q35``, which corresponds to Intel\u0027s 82Q35 chipset (released in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"43633823_abbf4446","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":27},"updated":"2021-02-16 10:25:00.000000000","message":"?","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c544f5228c3b0801225074b143c9f8df5a4ca5cc","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"QEMU\u0027s machine type concept can be thought of a virtual chipset that"},{"line_number":28,"context_line":"provides certain default devices (e.g. PCIe graphics card, Ethernet"},{"line_number":29,"context_line":"controller, SATA controllae, etc).  QEMU supports two main variants of"},{"line_number":30,"context_line":"\"machine type\" for x86 hosts: (a) ``pc``, which corresponds to Intel\u0027s"},{"line_number":31,"context_line":"I440FX chipset, which is twenty-two years old as of this writing; and"},{"line_number":32,"context_line":"(b) ``q35``, which corresponds to Intel\u0027s 82Q35 chipset (released in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a7c092c9_7afb80fd","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":27},"in_reply_to":"43633823_abbf4446","updated":"2021-02-16 12:54:54.000000000","message":"💩","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[{"line_number":28,"context_line":"provides certain default devices (e.g. PCIe graphics card, Ethernet"},{"line_number":29,"context_line":"controller, SATA controllae, etc).  QEMU supports two main variants of"},{"line_number":30,"context_line":"\"machine type\" for x86 hosts: (a) ``pc``, which corresponds to Intel\u0027s"},{"line_number":31,"context_line":"I440FX chipset, which is twenty-two years old as of this writing; and"},{"line_number":32,"context_line":"(b) ``q35``, which corresponds to Intel\u0027s 82Q35 chipset (released in"},{"line_number":33,"context_line":"2007; a relatively modern chipset).  For AArch64 hosts, the machine type"},{"line_number":34,"context_line":"is called: ``virt``."}],"source_content_type":"text/x-rst","patch_set":4,"id":"e978d682_78b305c1","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":64},"updated":"2021-02-16 10:25:00.000000000","message":"Maybe just give a release year like you do below? It\u0027ll age better","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c544f5228c3b0801225074b143c9f8df5a4ca5cc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"provides certain default devices (e.g. PCIe graphics card, Ethernet"},{"line_number":29,"context_line":"controller, SATA controllae, etc).  QEMU supports two main variants of"},{"line_number":30,"context_line":"\"machine type\" for x86 hosts: (a) ``pc``, which corresponds to Intel\u0027s"},{"line_number":31,"context_line":"I440FX chipset, which is twenty-two years old as of this writing; and"},{"line_number":32,"context_line":"(b) ``q35``, which corresponds to Intel\u0027s 82Q35 chipset (released in"},{"line_number":33,"context_line":"2007; a relatively modern chipset).  For AArch64 hosts, the machine type"},{"line_number":34,"context_line":"is called: ``virt``."}],"source_content_type":"text/x-rst","patch_set":4,"id":"b7c8ad1e_c48a636b","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":64},"in_reply_to":"e978d682_78b305c1","updated":"2021-02-16 12:54:54.000000000","message":"Done","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[{"line_number":34,"context_line":"is called: ``virt``."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The ``pc`` machine type is considered legacy, and does not support some of"},{"line_number":37,"context_line":"the modern features.  Although at this time of writing, upstream QEMU has not"},{"line_number":38,"context_line":"reached an agreement to remove new versioned variants of the ``pc`` machine"},{"line_number":39,"context_line":"type, some long-term stable Linux distributions (CentOS, RHEL, possibly others)"},{"line_number":40,"context_line":"are moving to support ``q35`` only."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ad06ebf4_288551a0","line":37,"updated":"2021-02-16 10:25:00.000000000","message":"does not support many modern features?","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c544f5228c3b0801225074b143c9f8df5a4ca5cc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"is called: ``virt``."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The ``pc`` machine type is considered legacy, and does not support some of"},{"line_number":37,"context_line":"the modern features.  Although at this time of writing, upstream QEMU has not"},{"line_number":38,"context_line":"reached an agreement to remove new versioned variants of the ``pc`` machine"},{"line_number":39,"context_line":"type, some long-term stable Linux distributions (CentOS, RHEL, possibly others)"},{"line_number":40,"context_line":"are moving to support ``q35`` only."}],"source_content_type":"text/x-rst","patch_set":4,"id":"8acf362c_8e4e9d68","line":37,"in_reply_to":"ad06ebf4_288551a0","updated":"2021-02-16 12:54:54.000000000","message":"Done","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For end users the machine type of an instance is controlled by the selection of"},{"line_number":46,"context_line":"an image with the `hw_machine_type image metadata property`_ set."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _`hw_machine_type image metadata property`: https://docs.openstack.org/glance/latest/admin/useful-image-properties.html"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"8f0dd27d_3722f530","line":46,"updated":"2021-02-16 10:25:00.000000000","message":"nit:\n\n  :glance-doc:`/admin/useful-image-properties.html`","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c544f5228c3b0801225074b143c9f8df5a4ca5cc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For end users the machine type of an instance is controlled by the selection of"},{"line_number":46,"context_line":"an image with the `hw_machine_type image metadata property`_ set."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _`hw_machine_type image metadata property`: https://docs.openstack.org/glance/latest/admin/useful-image-properties.html"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"0a9dc7e8_b977f490","line":46,"in_reply_to":"8f0dd27d_3722f530","updated":"2021-02-16 12:54:54.000000000","message":"TIL thanks.","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3c30163e8eccf139757d1d08b3a5f9918ed69f0","unresolved":true,"context_lines":[{"line_number":55,"context_line":"-------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The libvirt virt driver supports the configuration of a per compute host"},{"line_number":58,"context_line":"`default machine type`_ via the  :oslo.config:option:`libvirt.hw_machine_type`"},{"line_number":59,"context_line":"option.  Providing a default machine type per host architecture to be used when"},{"line_number":60,"context_line":"no corresponding ``hw_machine_type`` image property is provided for the"},{"line_number":61,"context_line":"instance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"de659291_eb757f1d","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":24},"updated":"2021-02-16 10:25:00.000000000","message":"I don\u0027t think this link adds much. The link to the config option is far more useful. If we need more information about that option, it should go in the docs for said option IMO","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c544f5228c3b0801225074b143c9f8df5a4ca5cc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"-------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The libvirt virt driver supports the configuration of a per compute host"},{"line_number":58,"context_line":"`default machine type`_ via the  :oslo.config:option:`libvirt.hw_machine_type`"},{"line_number":59,"context_line":"option.  Providing a default machine type per host architecture to be used when"},{"line_number":60,"context_line":"no corresponding ``hw_machine_type`` image property is provided for the"},{"line_number":61,"context_line":"instance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"2b390614_6314bbeb","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":24},"in_reply_to":"de659291_eb757f1d","updated":"2021-02-16 12:54:54.000000000","message":"ACK, removed.","commit_id":"4af54cd38cb2454b73b4cc00f1233c83f5da5ce7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a7ef043ce444e7f04d598d883005eb0835e94235","unresolved":true,"context_lines":[{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"hw_machine_type - Configuring and updating QEMU instance machine types"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Introduction"},{"line_number":19,"context_line":"------------"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"95adb8ef_c207e434","line":17,"updated":"2021-03-01 17:42:20.000000000","message":"This needs a note indicating this is libvirt-specific","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2bec8b7ab15f2a421f4624889d29e889a7773fa2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"hw_machine_type - Configuring and updating QEMU instance machine types"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Introduction"},{"line_number":19,"context_line":"------------"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7e7c4c1d_d9a8ce62","line":17,"in_reply_to":"95adb8ef_c207e434","updated":"2021-03-01 22:05:50.000000000","message":"Done","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a7ef043ce444e7f04d598d883005eb0835e94235","unresolved":true,"context_lines":[{"line_number":37,"context_line":"For end users the machine type of an instance is controlled by the selection of"},{"line_number":38,"context_line":"an image with the `hw_machine_type image metadata property`_ set."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. _`hw_machine_type image metadata property`: https://docs.openstack.org/glance/latest/admin/useful-image-properties.html"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. code-block:: shell"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"c73f7958_940b6e72","line":40,"updated":"2021-03-01 17:42:20.000000000","message":"nit: anonymous hyperlinks are way shorter\n\n  an image with the `hw_machine_type image metadata property`__ set.\n\n  .. __: https://...","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2bec8b7ab15f2a421f4624889d29e889a7773fa2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"For end users the machine type of an instance is controlled by the selection of"},{"line_number":38,"context_line":"an image with the `hw_machine_type image metadata property`_ set."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. _`hw_machine_type image metadata property`: https://docs.openstack.org/glance/latest/admin/useful-image-properties.html"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. code-block:: shell"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"8f89e815_03d021c0","line":40,"in_reply_to":"c73f7958_940b6e72","updated":"2021-03-01 22:05:50.000000000","message":"Done","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a7ef043ce444e7f04d598d883005eb0835e94235","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. code-block:: shell"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    $ openstack image set --property hw_machine_type\u003dq35 0358a574-8d47-4b89-969e-ae202a9a867a"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The libvirt virt driver supports the configuration of a per compute host"},{"line_number":47,"context_line":"default machine type via the  :oslo.config:option:`libvirt.hw_machine_type`"}],"source_content_type":"text/x-rst","patch_set":6,"id":"866d9ea3_df09b351","line":44,"range":{"start_line":44,"start_character":57,"end_line":44,"end_character":93},"updated":"2021-03-01 17:42:20.000000000","message":"Can you sub this with\n\n  $IMAGE","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2bec8b7ab15f2a421f4624889d29e889a7773fa2","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. code-block:: shell"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    $ openstack image set --property hw_machine_type\u003dq35 0358a574-8d47-4b89-969e-ae202a9a867a"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The libvirt virt driver supports the configuration of a per compute host"},{"line_number":47,"context_line":"default machine type via the  :oslo.config:option:`libvirt.hw_machine_type`"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e0e3559e_57735ff5","line":44,"range":{"start_line":44,"start_character":57,"end_line":44,"end_character":93},"in_reply_to":"866d9ea3_df09b351","updated":"2021-03-01 22:05:50.000000000","message":"Done","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a7ef043ce444e7f04d598d883005eb0835e94235","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Update"},{"line_number":69,"context_line":"------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Prior to the Wallaby (23.0.0) release the"},{"line_number":72,"context_line":":oslo.config:option:`libvirt.hw_machine_type` option had to remain static once"},{"line_number":73,"context_line":"set for the lifetime of a deployment. This was due to the machine type of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"44376c54_b19562ca","line":70,"updated":"2021-03-01 17:42:20.000000000","message":"versionadded/versionchanged ?","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f821a5c3632120b3665a6e24a6d7cd5bad77c853","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Update"},{"line_number":69,"context_line":"------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Prior to the Wallaby (23.0.0) release the"},{"line_number":72,"context_line":":oslo.config:option:`libvirt.hw_machine_type` option had to remain static once"},{"line_number":73,"context_line":"set for the lifetime of a deployment. This was due to the machine type of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"49c78162_fa57db6f","line":70,"in_reply_to":"043f91e2_e7ca121b","updated":"2021-03-02 10:51:08.000000000","message":"Oh, you\u0027ve got versionadded and versionchanged directive you can use for things like this:\n\n  .. versionchanged:: 23.0.0 (Wallaby)\n\n      Added tooling to support changing the default machine type for a deployment.","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2bec8b7ab15f2a421f4624889d29e889a7773fa2","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Update"},{"line_number":69,"context_line":"------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Prior to the Wallaby (23.0.0) release the"},{"line_number":72,"context_line":":oslo.config:option:`libvirt.hw_machine_type` option had to remain static once"},{"line_number":73,"context_line":"set for the lifetime of a deployment. This was due to the machine type of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"043f91e2_e7ca121b","line":70,"in_reply_to":"44376c54_b19562ca","updated":"2021-03-01 22:05:50.000000000","message":"I\u0027m not sure what you\u0027re asking for here sorry.","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d3b852d0205c238bb5a6bbce19fae84025e386cb","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Update"},{"line_number":69,"context_line":"------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Prior to the Wallaby (23.0.0) release the"},{"line_number":72,"context_line":":oslo.config:option:`libvirt.hw_machine_type` option had to remain static once"},{"line_number":73,"context_line":"set for the lifetime of a deployment. This was due to the machine type of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"26a48059_48a54490","line":70,"in_reply_to":"49c78162_fa57db6f","updated":"2021-03-02 12:12:34.000000000","message":"Ah TIL, I\u0027ll add it in if I respin otherwise I think it reads fine as is.","commit_id":"39481ce5c70bff05950b18d93fc739e58312f23c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cc55d82a2f2a66154c432c61f6688b81171a7f33","unresolved":true,"context_lines":[{"line_number":76,"context_line":":oslo.config:option:`libvirt.hw_machine_type` option had to remain static once"},{"line_number":77,"context_line":"set for the lifetime of a deployment. This was due to the machine type of"},{"line_number":78,"context_line":"instances without a ``hw_machine_type`` image property using the newly"},{"line_number":79,"context_line":"configured machine types after a hard reboot or migration This could in turn"},{"line_number":80,"context_line":"break the internal ABI of the instance when changing between underlying machine"},{"line_number":81,"context_line":"types such as ``pc`` to ``q35``."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"70286cd3_e3540bd7","line":79,"range":{"start_line":79,"start_character":56,"end_line":79,"end_character":58},"updated":"2021-03-03 13:46:05.000000000","message":"missing a dot?","commit_id":"56f22951f064c3bbe4079933bade009c0475f75a"}]}