)]}'
{"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b20ba03cc63e6936c122c465eeec93550589b63","unresolved":true,"context_lines":[{"line_number":1920,"context_line":"            \u0027nova.virt.libvirt.host.Host._log_host_capabilities\u0027))"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"        # Ensure tests perform the same on all host architectures"},{"line_number":1923,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":1924,"context_line":"            \u0027nova.virt.libvirt.utils.get_arch\u0027,"},{"line_number":1925,"context_line":"            return_value\u003dobj_fields.Architecture.X86_64))"},{"line_number":1926,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"322970bf_ff681727","line":1923,"range":{"start_line":1923,"start_character":8,"end_line":1923,"end_character":43},"updated":"2021-02-17 14:52:50.000000000","message":"+1 for not adding more uses of the nova stub_out function.","commit_id":"bd71cfc1152f551ffa50588cdfc1ca0c32d73a49"}],"nova/tests/unit/virt/libvirt/test_blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b20ba03cc63e6936c122c465eeec93550589b63","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                \u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":270,"context_line":"                \u0027type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: \u00271\u0027,"},{"line_number":271,"context_line":"            },"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        self.assertEqual(expect, mapping)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.utils.get_arch\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"58f7d55e_c43eb3b4","line":272,"updated":"2021-02-17 14:52:50.000000000","message":"yep this is cleaner","commit_id":"bd71cfc1152f551ffa50588cdfc1ca0c32d73a49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b20ba03cc63e6936c122c465eeec93550589b63","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        self.assertEqual(expect, mapping)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.utils.get_arch\u0027,"},{"line_number":276,"context_line":"        new\u003dmock.Mock(return_value\u003dobj_fields.Architecture.X86_64))"},{"line_number":277,"context_line":"    def test_get_disk_mapping_rescue_with_config__x86_64(self):"},{"line_number":278,"context_line":"        self._test_get_disk_mapping_rescue_with_config({"},{"line_number":279,"context_line":"            \u0027bus\u0027: \u0027ide\u0027, \u0027dev\u0027: \u0027hda\u0027, \u0027type\u0027: \u0027cdrom\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8859b13c_c6de82d2","line":276,"updated":"2021-02-17 14:52:50.000000000","message":"this is the default arch so you dont need this mock\nbut because you don\u0027t use the  FakeLibvirtFixture you do.\n\ni guess this is why you said almost all places in the commit message.\n\nmaybe you should still use the fixture here too for consitency so add a setup thatdoes \n\n        self.useFixture(fixtures.MockPatch(\n            \u0027nova.virt.libvirt.utils.get_arch\u0027,\n            return_value\u003dobj_fields.Architecture.X86_64))\n\nthis works but it might be nice have this bevhior in all tests by defualt.","commit_id":"bd71cfc1152f551ffa50588cdfc1ca0c32d73a49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b20ba03cc63e6936c122c465eeec93550589b63","unresolved":true,"context_lines":[{"line_number":1452,"context_line":"        for patcher in self.patchers:"},{"line_number":1453,"context_line":"            patcher.stop()"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"    @mock.patch("},{"line_number":1456,"context_line":"        \u0027nova.virt.libvirt.utils.get_arch\u0027,"},{"line_number":1457,"context_line":"        return_value\u003dobj_fields.Architecture.X86_64)"},{"line_number":1458,"context_line":"    def _test_default_device_names(self, eph, swap, bdm, mock_get_arch):"}],"source_content_type":"text/x-python","patch_set":4,"id":"151f7346_57a0296b","line":1455,"range":{"start_line":1455,"start_character":1,"end_line":1455,"end_character":2},"updated":"2021-02-17 14:52:50.000000000","message":"this too","commit_id":"bd71cfc1152f551ffa50588cdfc1ca0c32d73a49"}]}
