)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"180ebe0acb22cced42880dbe5da9349adbbc5c99","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        return cls.canonicalize(os.uname().machine)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def is_valid(cls, name):"},{"line_number":184,"context_line":"        \"\"\"Check if a string is a valid architecture"}],"source_content_type":"text/x-python","patch_set":3,"id":"9e052701_063e8f79","line":181,"updated":"2021-02-17 15:02:12.000000000","message":"that less cryptic alright named tules are defintly better.","commit_id":"2aa6564f39efe7bd2c0e63b00d39893dee7ea2f3"}],"nova/tests/unit/objects/test_fields.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"180ebe0acb22cced42880dbe5da9349adbbc5c99","unresolved":true,"context_lines":[{"line_number":29,"context_line":"from nova import utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"os_uname \u003d collections.namedtuple("},{"line_number":32,"context_line":"    \u0027uname_result\u0027, [\u0027sysname\u0027, \u0027nodename\u0027, \u0027release\u0027, \u0027version\u0027, \u0027machine\u0027],"},{"line_number":33,"context_line":")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"50c81576_7adddc4d","line":32,"range":{"start_line":32,"start_character":67,"end_line":32,"end_character":74},"updated":"2021-02-17 15:02:12.000000000","message":"nit: i probably would have called this instruction_set instead of machine.\n\ni686 does not map to any libvirt machine type or similar concpet its and instruciton set target level\n\ne.g. what you woudl set in -march with gcc\n\n\nalso can we move this to a common locaion insted.\nmaybe nova/test.py\n\nyou are duplicating it in the next few files and we really shoudl only have it once.","commit_id":"2aa6564f39efe7bd2c0e63b00d39893dee7ea2f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd7d28ee3e925afe0896e103837bef8bc3450aa1","unresolved":true,"context_lines":[{"line_number":29,"context_line":"from nova import utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"os_uname \u003d collections.namedtuple("},{"line_number":32,"context_line":"    \u0027uname_result\u0027, [\u0027sysname\u0027, \u0027nodename\u0027, \u0027release\u0027, \u0027version\u0027, \u0027machine\u0027],"},{"line_number":33,"context_line":")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"74f83226_d5431049","line":32,"range":{"start_line":32,"start_character":67,"end_line":32,"end_character":74},"in_reply_to":"50c81576_7adddc4d","updated":"2021-02-19 14:22:38.000000000","message":"\u003e nit: i probably would have called this instruction_set instead of machine.\n\nI have to mirror what os.uname returns, an instance of \u0027posix.uname_result\u0027. I can\u0027t use that specifically because it doesn\u0027t exist on Windows which means we\u0027d break unit tests there.\n\n\u003e i686 does not map to any libvirt machine type or similar concpet its and instruciton set target level\n\u003e \n\u003e e.g. what you woudl set in -march with gcc\n\u003e \n\u003e \n\u003e also can we move this to a common locaion insted.\n\u003e maybe nova/test.py\n\u003e \n\u003e you are duplicating it in the next few files and we really shoudl only have it once.\n\nI considered that but it didn\u0027t seem worth dumping it into a global module where it didn\u0027t really belong. I also considered setting up a global mock on the base test class but again, that felt like I was putting things at global scope where it didn\u0027t really belong. For the sake of the six lines total, I\u0027d rather just duplicate it.","commit_id":"2aa6564f39efe7bd2c0e63b00d39893dee7ea2f3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5e1a4a0a74d2f2a87460ae2e19b81763c8651d11","unresolved":true,"context_lines":[{"line_number":29,"context_line":"from nova import utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"os_uname \u003d collections.namedtuple("},{"line_number":32,"context_line":"    \u0027uname_result\u0027, [\u0027sysname\u0027, \u0027nodename\u0027, \u0027release\u0027, \u0027version\u0027, \u0027machine\u0027],"},{"line_number":33,"context_line":")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fbf7f1f7_ac3facc1","line":32,"range":{"start_line":32,"start_character":67,"end_line":32,"end_character":74},"in_reply_to":"74f83226_d5431049","updated":"2021-02-23 09:19:12.000000000","message":"I tend to be on Sean\u0027s side by asking you to make this a special object somewhere in some module (duplicating code is never a good idea) but I agree with you on the fact we don\u0027t really have some kind of helper library for mocked things in nova tests and generally we end up pulling stuff from nova/test.py directly which is gross (well, we have fixtures in nova/tests/fixtures.py) but this is only for fixtures, not fake objects.\n\nHonestly, I\u0027m on the pragmatic side and I\u0027d like to avoid unnecessary imports that could end up with more problems than it would resolve so maybe let\u0027s just consider that uname isn\u0027t really intended to have its API to change often...","commit_id":"2aa6564f39efe7bd2c0e63b00d39893dee7ea2f3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"93293992315cd254997f3a46a39abe16ef6b71a3","unresolved":true,"context_lines":[{"line_number":29,"context_line":"from nova import utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"os_uname \u003d collections.namedtuple("},{"line_number":32,"context_line":"    \u0027uname_result\u0027, [\u0027sysname\u0027, \u0027nodename\u0027, \u0027release\u0027, \u0027version\u0027, \u0027machine\u0027],"},{"line_number":33,"context_line":")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9dcfc75e_a53dc6f9","line":32,"range":{"start_line":32,"start_character":67,"end_line":32,"end_character":74},"in_reply_to":"74f83226_d5431049","updated":"2021-03-01 17:29:21.000000000","message":"ok the nameing makes sense.\n\nyou have still just put this at global/moduel scope by the way by the way.\ni would still prefer this to defined once but i wont block on this.\ni think if your going to add it at all its better to do it once other wise you took one step forward in nameing and one step back in duplciations","commit_id":"2aa6564f39efe7bd2c0e63b00d39893dee7ea2f3"}]}