)]}'
{"gate/test_evacuate.sh":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9f3373c659218cbc33f9957a036fd4aa6ab17841","unresolved":true,"context_lines":[{"line_number":63,"context_line":"$ANSIBLE subnodes --become -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"systemctl stop $_stop_services\""},{"line_number":64,"context_line":"$ANSIBLE subnodes --become -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"for domain in \\$(virsh list --all --name); do  virsh destroy \\$domain; done\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""},{"line_number":68,"context_line":"openstack --os-compute-api-version 2.11 compute service set --down ${subnode} nova-compute"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"41588f67_508f4c80","line":66,"updated":"2021-02-18 11:00:25.000000000","message":"unrelated change, will be removed","commit_id":"1741b5814bc00d1fd30317e97ed7071ac7bf7021"}],"roles/run-evacuate-hook/tasks/main.yaml":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4b7d799c4e1d536fd382b1be14ba24a5b2a38416","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  environment:"},{"line_number":6,"context_line":"    SUBNODE_HOSTNAME: \"{{ hostvars[\u0027compute1\u0027][\u0027ansible_hostname\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Fence subnode by stopping n-cpu"},{"line_number":9,"context_line":"  delegate_to: compute1"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  systemd:"},{"line_number":12,"context_line":"    name: devstack@n-cpu"},{"line_number":13,"context_line":"    state: stopped"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Check if q-agt exists"},{"line_number":16,"context_line":"  shell: sudo systemctl status devstack@q-agt"},{"line_number":17,"context_line":"  ignore_errors: true"},{"line_number":18,"context_line":"  register: qagtstatus"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Fence subnode by stopping q-agt (if exists)"},{"line_number":21,"context_line":"  delegate_to: compute1"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  systemd:"},{"line_number":24,"context_line":"    name: devstack@q-agt"},{"line_number":25,"context_line":"    state: stopped"},{"line_number":26,"context_line":"  when: qagtstatus.rc | int \u003d\u003d 0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Register running domains on subnode"},{"line_number":29,"context_line":"  delegate_to: compute1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b62818fe_a379b010","line":26,"range":{"start_line":8,"start_character":0,"end_line":26,"end_character":32},"updated":"2021-04-08 19:42:24.000000000","message":"Why don\u0027t you just append the original with ignore_errors: true?","commit_id":"20a7c98eff6592c3131360ad9d6eb12367dd11f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"eba3ab1baaec4d4eeb81f80f0fe2c2b542771b41","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  environment:"},{"line_number":6,"context_line":"    SUBNODE_HOSTNAME: \"{{ hostvars[\u0027compute1\u0027][\u0027ansible_hostname\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Fence subnode by stopping n-cpu"},{"line_number":9,"context_line":"  delegate_to: compute1"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  systemd:"},{"line_number":12,"context_line":"    name: devstack@n-cpu"},{"line_number":13,"context_line":"    state: stopped"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Check if q-agt exists"},{"line_number":16,"context_line":"  shell: sudo systemctl status devstack@q-agt"},{"line_number":17,"context_line":"  ignore_errors: true"},{"line_number":18,"context_line":"  register: qagtstatus"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Fence subnode by stopping q-agt (if exists)"},{"line_number":21,"context_line":"  delegate_to: compute1"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  systemd:"},{"line_number":24,"context_line":"    name: devstack@q-agt"},{"line_number":25,"context_line":"    state: stopped"},{"line_number":26,"context_line":"  when: qagtstatus.rc | int \u003d\u003d 0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Register running domains on subnode"},{"line_number":29,"context_line":"  delegate_to: compute1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c471656f_0c80a61a","line":26,"range":{"start_line":8,"start_character":0,"end_line":26,"end_character":32},"in_reply_to":"4bad5950_394d70a1","updated":"2021-04-09 09:48:13.000000000","message":"ACK okay my apologies, I hadn\u0027t thought of that.","commit_id":"20a7c98eff6592c3131360ad9d6eb12367dd11f6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4c6ac16e5cd227502415ecd7ab68a7120dfb32fa","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  environment:"},{"line_number":6,"context_line":"    SUBNODE_HOSTNAME: \"{{ hostvars[\u0027compute1\u0027][\u0027ansible_hostname\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Fence subnode by stopping n-cpu"},{"line_number":9,"context_line":"  delegate_to: compute1"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  systemd:"},{"line_number":12,"context_line":"    name: devstack@n-cpu"},{"line_number":13,"context_line":"    state: stopped"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Check if q-agt exists"},{"line_number":16,"context_line":"  shell: sudo systemctl status devstack@q-agt"},{"line_number":17,"context_line":"  ignore_errors: true"},{"line_number":18,"context_line":"  register: qagtstatus"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Fence subnode by stopping q-agt (if exists)"},{"line_number":21,"context_line":"  delegate_to: compute1"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  systemd:"},{"line_number":24,"context_line":"    name: devstack@q-agt"},{"line_number":25,"context_line":"    state: stopped"},{"line_number":26,"context_line":"  when: qagtstatus.rc | int \u003d\u003d 0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Register running domains on subnode"},{"line_number":29,"context_line":"  delegate_to: compute1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4bad5950_394d70a1","line":26,"range":{"start_line":8,"start_character":0,"end_line":26,"end_character":32},"in_reply_to":"b62818fe_a379b010","updated":"2021-04-09 09:00:17.000000000","message":"Because that\u0027s a change of behavior ?\n\nIf I append ignore_errors to the original black and n-cpu fails to be stopped the test will continue where originally, if it fails to stop the test would error out earlier.\n\nSame of q-agt, if we add ignore_errors and it\u0027s a ML2/OVS deployment (which has the agent) and it fails to be stopped the test would continue where originally it would have failed earlier.\n\nMy change tries to keep this behavior and only tries to stop q-agt if it\u0027s actually present in the system (which is true to ML2/OVS but false for ML2/OVN)","commit_id":"20a7c98eff6592c3131360ad9d6eb12367dd11f6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fafed4ab03bb2f62b1e70361b891bf01c60da7d4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  environment:"},{"line_number":6,"context_line":"    SUBNODE_HOSTNAME: \"{{ hostvars[\u0027compute1\u0027][\u0027ansible_hostname\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Fence subnode by stopping n-cpu"},{"line_number":9,"context_line":"  delegate_to: compute1"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  systemd:"},{"line_number":12,"context_line":"    name: devstack@n-cpu"},{"line_number":13,"context_line":"    state: stopped"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Check if q-agt exists"},{"line_number":16,"context_line":"  shell: sudo systemctl status devstack@q-agt"},{"line_number":17,"context_line":"  ignore_errors: true"},{"line_number":18,"context_line":"  register: qagtstatus"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Fence subnode by stopping q-agt (if exists)"},{"line_number":21,"context_line":"  delegate_to: compute1"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  systemd:"},{"line_number":24,"context_line":"    name: devstack@q-agt"},{"line_number":25,"context_line":"    state: stopped"},{"line_number":26,"context_line":"  when: qagtstatus.rc | int \u003d\u003d 0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Register running domains on subnode"},{"line_number":29,"context_line":"  delegate_to: compute1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ebc3fa11_66647664","line":26,"range":{"start_line":8,"start_character":0,"end_line":26,"end_character":32},"in_reply_to":"c471656f_0c80a61a","updated":"2021-04-09 14:13:55.000000000","message":"Nothing to apologize for, thank you for your review!","commit_id":"20a7c98eff6592c3131360ad9d6eb12367dd11f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb3d316e7b4dcfacf817865d1d89d7a841d29196","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    name: devstack@q-agt"},{"line_number":25,"context_line":"    state: stopped"},{"line_number":26,"context_line":"  when: qagtstatus.rc | int \u003d\u003d 0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Register running domains on subnode"},{"line_number":29,"context_line":"  delegate_to: compute1"},{"line_number":30,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ce443f27_74de4a92","line":27,"updated":"2021-04-08 10:25:26.000000000","message":"this makes sense althoug uwe may need to consider if we need to stop the ovn nortd/southd process on the compute node at somepoint.","commit_id":"20a7c98eff6592c3131360ad9d6eb12367dd11f6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4c6ac16e5cd227502415ecd7ab68a7120dfb32fa","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    name: devstack@q-agt"},{"line_number":25,"context_line":"    state: stopped"},{"line_number":26,"context_line":"  when: qagtstatus.rc | int \u003d\u003d 0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Register running domains on subnode"},{"line_number":29,"context_line":"  delegate_to: compute1"},{"line_number":30,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fb8cd5cc_45dba8b9","line":27,"in_reply_to":"ce443f27_74de4a92","updated":"2021-04-09 09:00:17.000000000","message":"I think we are good cause those do not run on the compute nodes, they are in the controllers.\n\nOr you meant controller nodes and we should stop those services ?","commit_id":"20a7c98eff6592c3131360ad9d6eb12367dd11f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"eba3ab1baaec4d4eeb81f80f0fe2c2b542771b41","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    name: devstack@q-agt"},{"line_number":25,"context_line":"    state: stopped"},{"line_number":26,"context_line":"  when: qagtstatus.rc | int \u003d\u003d 0"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Register running domains on subnode"},{"line_number":29,"context_line":"  delegate_to: compute1"},{"line_number":30,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1b63d6c1_6310061e","line":27,"in_reply_to":"fb8cd5cc_45dba8b9","updated":"2021-04-09 09:48:13.000000000","message":"Yeah I don\u0027t think we need to fence any services on the controller during these tests as that wouldn\u0027t happen when an operator fences the compute.","commit_id":"20a7c98eff6592c3131360ad9d6eb12367dd11f6"}]}