)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0a4ecae7bac7dd31497a99e15902bc6faf13f332","unresolved":true,"context_lines":[{"line_number":32,"context_line":"ability to identify this capability from the host. In this change, we"},{"line_number":33,"context_line":"add the ability to configure it for the guest."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[1] https://www.libvirt.org/news.html#v5-2-0-2019-04-03"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Blueprint: allow-secure-boot-for-qemu-kvm-guests"},{"line_number":38,"context_line":"Change-Id: I342e95fef0a792299180a4d8076e6e7c4041ac9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4f18701b_f7e99077","line":35,"updated":"2021-02-23 15:09:35.000000000","message":"thanks for the link, it helps.","commit_id":"6cad9fae74fc0062d59de67c799def83cd183091"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0a4ecae7bac7dd31497a99e15902bc6faf13f332","unresolved":true,"context_lines":[{"line_number":2484,"context_line":"                \u003cloader secure\u003d\u0027yes\u0027/\u003e"},{"line_number":2485,"context_line":"              \u003c/os\u003e"},{"line_number":2486,"context_line":"            \u003c/domain\u003e\"\"\","},{"line_number":2487,"context_line":"        )"},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"    def test_config_boot_menu(self):"},{"line_number":2490,"context_line":"        obj \u003d config.LibvirtConfigGuest()"}],"source_content_type":"text/x-python","patch_set":2,"id":"8d2b3777_41f415aa","line":2487,"updated":"2021-02-23 15:09:35.000000000","message":"could you please add tests for when loader secure value is \u0027no\u0027 ? thanks.\nhint : you could just use a helper method like \n\n def _test_config_uefi_autoconfigure(self, secure\u003dTrue):\n   # keep all the things but use secure as a parameter\n\n test_config_uefi_autoconfigure_secure(self):\n   self._test_config_uefi_autoconfigure()\n \n test_config_uefi_autoconfigure_unsecure(self):\n   self._test_config_uefi_autoconfigure(secure\u003dFalse)","commit_id":"6cad9fae74fc0062d59de67c799def83cd183091"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"79a2f90df0d99e744e333744ca2649be30ec2e4f","unresolved":false,"context_lines":[{"line_number":2484,"context_line":"                \u003cloader secure\u003d\u0027yes\u0027/\u003e"},{"line_number":2485,"context_line":"              \u003c/os\u003e"},{"line_number":2486,"context_line":"            \u003c/domain\u003e\"\"\","},{"line_number":2487,"context_line":"        )"},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"    def test_config_boot_menu(self):"},{"line_number":2490,"context_line":"        obj \u003d config.LibvirtConfigGuest()"}],"source_content_type":"text/x-python","patch_set":2,"id":"306295c3_069f7001","line":2487,"in_reply_to":"8d2b3777_41f415aa","updated":"2021-02-24 11:40:01.000000000","message":"Done in a follow-up https://review.opendev.org/c/openstack/nova/+/777367","commit_id":"6cad9fae74fc0062d59de67c799def83cd183091"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"021315b1037ca2132a2bcc3e0825cd570bf5a413","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _text_node(self, node_name, value, **kwargs):"},{"line_number":61,"context_line":"        child \u003d self._new_node(node_name, **kwargs)"},{"line_number":62,"context_line":"        if value is not None:"},{"line_number":63,"context_line":"            child.text \u003d str(value)"},{"line_number":64,"context_line":"        return child"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_yes_no_str(self, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"47f66dcc_da963652","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":35},"updated":"2021-03-04 17:07:05.000000000","message":"Huh, wasn\u0027t that a bug or did we ignore `None`?","commit_id":"6cad9fae74fc0062d59de67c799def83cd183091"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0a4ecae7bac7dd31497a99e15902bc6faf13f332","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        return child"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_yes_no_str(self, value):"},{"line_number":67,"context_line":"        return \u0027yes\u0027 if value else \u0027no\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def format_dom(self):"},{"line_number":70,"context_line":"        return self._new_node(self.root_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ece392f_ad8dce2f","line":67,"updated":"2021-02-23 15:09:35.000000000","message":"LOL to this.","commit_id":"6cad9fae74fc0062d59de67c799def83cd183091"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0a4ecae7bac7dd31497a99e15902bc6faf13f332","unresolved":true,"context_lines":[{"line_number":2831,"context_line":"        if self.os_mach_type is not None:"},{"line_number":2832,"context_line":"            type_node.set(\"machine\", self.os_mach_type)"},{"line_number":2833,"context_line":"        os.append(type_node)"},{"line_number":2834,"context_line":""},{"line_number":2835,"context_line":"        if self.os_kernel is not None:"},{"line_number":2836,"context_line":"            os.append(self._text_node(\"kernel\", self.os_kernel))"},{"line_number":2837,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"32f168a5_02308607","line":2834,"updated":"2021-02-23 15:09:35.000000000","message":"nit: a bit unrelated but meh.","commit_id":"6cad9fae74fc0062d59de67c799def83cd183091"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"021315b1037ca2132a2bcc3e0825cd570bf5a413","unresolved":true,"context_lines":[{"line_number":2955,"context_line":"                self.cpuset \u003d hardware.parse_cpu_spec(xmldoc.get(\u0027cpuset\u0027))"},{"line_number":2956,"context_line":""},{"line_number":2957,"context_line":"    def _parse_os(self, xmldoc):"},{"line_number":2958,"context_line":"        if xmldoc.get(\u0027firmware\u0027):"},{"line_number":2959,"context_line":"            self.os_firmware \u003d xmldoc.get(\u0027firmware\u0027)"},{"line_number":2960,"context_line":""},{"line_number":2961,"context_line":"        # smbios is skipped just because LibvirtConfigGuestSMBIOS"},{"line_number":2962,"context_line":"        # does not implement parse_dom method"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f4696f8_ecfe6cc1","line":2959,"range":{"start_line":2958,"start_character":0,"end_line":2959,"end_character":53},"updated":"2021-03-04 17:07:05.000000000","message":"You don\u0027t need the if here, Element.get defaults to None:\n\nhttps://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.get","commit_id":"6cad9fae74fc0062d59de67c799def83cd183091"}]}