)]}'
{"lower-constraints.txt":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fc9969a231cc4d060b6d4ba0b069cddf5402fa75","unresolved":true,"context_lines":[{"line_number":62,"context_line":"os-client-config\u003d\u003d1.29.0"},{"line_number":63,"context_line":"os-resource-classes\u003d\u003d0.4.0"},{"line_number":64,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":65,"context_line":"os-traits\u003d\u003d2.5.0"},{"line_number":66,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":67,"context_line":"os-win\u003d\u003d4.2.0"},{"line_number":68,"context_line":"os-xenapi\u003d\u003d0.3.4"}],"source_content_type":"text/plain","patch_set":3,"id":"6380ae12_0c0639e0","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":16},"updated":"2021-03-04 17:42:25.000000000","message":"I908ff07e1107304ca5926cc04d2fdc8fe0da5ed9 bumped this already so eventually we will need to rebase this series.","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc05f8f1cb47ba4eee9ec1041b1461127a25a0d0","unresolved":true,"context_lines":[{"line_number":62,"context_line":"os-client-config\u003d\u003d1.29.0"},{"line_number":63,"context_line":"os-resource-classes\u003d\u003d0.4.0"},{"line_number":64,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":65,"context_line":"os-traits\u003d\u003d2.5.0"},{"line_number":66,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":67,"context_line":"os-win\u003d\u003d4.2.0"},{"line_number":68,"context_line":"os-xenapi\u003d\u003d0.3.4"}],"source_content_type":"text/plain","patch_set":3,"id":"5a53e61d_977b777d","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":16},"in_reply_to":"6380ae12_0c0639e0","updated":"2021-03-04 18:46:41.000000000","message":"Git will happily merge this as-is, since there are no other differences in the area. Note that we don\u0027t have a Merge Conflict warning in the UI (at least not here - there is later but I\u0027m waiting for stuff to merge before rebasing)","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"}],"nova/virt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fc9969a231cc4d060b6d4ba0b069cddf5402fa75","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \"supports_image_type_ploop\": os_traits.COMPUTE_IMAGE_TYPE_PLOOP,"},{"line_number":129,"context_line":"    # Added in os-traits 2.1.0."},{"line_number":130,"context_line":"    \"supports_migrate_to_same_host\": os_traits.COMPUTE_SAME_HOST_COLD_MIGRATE,"},{"line_number":131,"context_line":"    # Added in os-traits 2.2.0."},{"line_number":132,"context_line":"    \"supports_bfv_rescue\": os_traits.COMPUTE_RESCUE_BFV,"},{"line_number":133,"context_line":"}"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"31f2d600_93eb1cb1","side":"PARENT","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":30},"updated":"2021-03-04 17:42:25.000000000","message":"I get that they aren\u0027t the most informative comments but why bother with this?","commit_id":"47cf817bacc61361189aaa7171422bb94d80b0c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc05f8f1cb47ba4eee9ec1041b1461127a25a0d0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \"supports_image_type_ploop\": os_traits.COMPUTE_IMAGE_TYPE_PLOOP,"},{"line_number":129,"context_line":"    # Added in os-traits 2.1.0."},{"line_number":130,"context_line":"    \"supports_migrate_to_same_host\": os_traits.COMPUTE_SAME_HOST_COLD_MIGRATE,"},{"line_number":131,"context_line":"    # Added in os-traits 2.2.0."},{"line_number":132,"context_line":"    \"supports_bfv_rescue\": os_traits.COMPUTE_RESCUE_BFV,"},{"line_number":133,"context_line":"}"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d3415908_0800ff13","side":"PARENT","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":30},"in_reply_to":"31f2d600_93eb1cb1","updated":"2021-03-04 18:46:41.000000000","message":"It annoyed me and I didn\u0027t want to propagate the annoyance. Omitting it would have suggested the new trait was added in 2.2.0 also though.","commit_id":"47cf817bacc61361189aaa7171422bb94d80b0c8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3e0ab56a7164510fbceef82b2cd1683ed6f98ba3","unresolved":true,"context_lines":[{"line_number":101,"context_line":"# trait, it needs to be (made) standard, and must be prefixed with"},{"line_number":102,"context_line":"# \"COMPUTE_\"."},{"line_number":103,"context_line":"CAPABILITY_TRAITS_MAP \u003d {"},{"line_number":104,"context_line":"    # Added in os-traits 0.7.0."},{"line_number":105,"context_line":"    \"supports_attach_interface\": os_traits.COMPUTE_NET_ATTACH_INTERFACE,"},{"line_number":106,"context_line":"    \"supports_device_tagging\": os_traits.COMPUTE_DEVICE_TAGGING,"},{"line_number":107,"context_line":"    \"supports_tagged_attach_interface\":"}],"source_content_type":"text/x-python","patch_set":5,"id":"7b44e061_300634fd","side":"PARENT","line":104,"updated":"2021-03-09 10:40:26.000000000","message":"I don\u0027t get why you remove this important note.","commit_id":"bc020efab3371b6ae7952dffe41f9f1247b385f1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e375f5ff09fdacbaf1a0fdf970faba43661ec125","unresolved":false,"context_lines":[{"line_number":101,"context_line":"# trait, it needs to be (made) standard, and must be prefixed with"},{"line_number":102,"context_line":"# \"COMPUTE_\"."},{"line_number":103,"context_line":"CAPABILITY_TRAITS_MAP \u003d {"},{"line_number":104,"context_line":"    # Added in os-traits 0.7.0."},{"line_number":105,"context_line":"    \"supports_attach_interface\": os_traits.COMPUTE_NET_ATTACH_INTERFACE,"},{"line_number":106,"context_line":"    \"supports_device_tagging\": os_traits.COMPUTE_DEVICE_TAGGING,"},{"line_number":107,"context_line":"    \"supports_tagged_attach_interface\":"}],"source_content_type":"text/x-python","patch_set":5,"id":"a93b5a13_f6bf98b4","side":"PARENT","line":104,"in_reply_to":"7b44e061_300634fd","updated":"2021-03-09 11:38:27.000000000","message":"https://review.opendev.org/c/openstack/nova/+/776679/3/nova/virt/driver.py#a131\n\nWe don\u0027t call out what version of libvirt a feature (like mdevs) was added in _unless_ we require a version greater than our current minimum. We remove this note once that minimum version is bumped. Given both placement and nova require the latest version of os-traits (placement actually has a test to enforce this), there is zero reason to include this information. This is noise, plain and simple.","commit_id":"bc020efab3371b6ae7952dffe41f9f1247b385f1"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fc9969a231cc4d060b6d4ba0b069cddf5402fa75","unresolved":true,"context_lines":[{"line_number":281,"context_line":"            \"supports_accelerators\": True,"},{"line_number":282,"context_line":"            \"supports_bfv_rescue\": True,"},{"line_number":283,"context_line":"            \"supports_vtpm\": CONF.libvirt.swtpm_enabled,"},{"line_number":284,"context_line":"            \"supports_secure_boot\": False,"},{"line_number":285,"context_line":"        }"},{"line_number":286,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da21a6de_3446d68a","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":42},"updated":"2021-03-04 17:42:25.000000000","message":"Why even list this before I171d47d72ebc81d1c905eb9130378dfef9a55ce5?","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e375f5ff09fdacbaf1a0fdf970faba43661ec125","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            \"supports_accelerators\": True,"},{"line_number":282,"context_line":"            \"supports_bfv_rescue\": True,"},{"line_number":283,"context_line":"            \"supports_vtpm\": CONF.libvirt.swtpm_enabled,"},{"line_number":284,"context_line":"            \"supports_secure_boot\": False,"},{"line_number":285,"context_line":"        }"},{"line_number":286,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f6a84374_3dce350a","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":42},"in_reply_to":"c9b412c2_3ffd77fb","updated":"2021-03-09 11:38:27.000000000","message":"I dropped this since it\u0027s not technically required, as you note","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc05f8f1cb47ba4eee9ec1041b1461127a25a0d0","unresolved":true,"context_lines":[{"line_number":281,"context_line":"            \"supports_accelerators\": True,"},{"line_number":282,"context_line":"            \"supports_bfv_rescue\": True,"},{"line_number":283,"context_line":"            \"supports_vtpm\": CONF.libvirt.swtpm_enabled,"},{"line_number":284,"context_line":"            \"supports_secure_boot\": False,"},{"line_number":285,"context_line":"        }"},{"line_number":286,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c9b412c2_3ffd77fb","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":42},"in_reply_to":"da21a6de_3446d68a","updated":"2021-03-04 18:46:41.000000000","message":"Fair point. This is mostly for completeness. As you know, this is transformed to a trait and the next change means the scheduler will start filtering on this trait. I set this to True for the Hyper-V driver, since that already supports secure boot. It made sense to add it here so I could later toggle it","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"}],"nova/virt/powervm/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fc9969a231cc4d060b6d4ba0b069cddf5402fa75","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            \u0027supports_pcpus\u0027: False,"},{"line_number":81,"context_line":"            \u0027supports_accelerators\u0027: False,"},{"line_number":82,"context_line":"            \u0027supports_vtpm\u0027: False,"},{"line_number":83,"context_line":"            \u0027supports_secure_boot\u0027: False,"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            # Supported image types"},{"line_number":86,"context_line":"            \"supports_image_type_aki\": False,"}],"source_content_type":"text/x-python","patch_set":3,"id":"07a61c64_b3cfec5f","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":42},"updated":"2021-03-04 17:42:25.000000000","message":"As with the libvirt driver, why does this need to be here?","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc05f8f1cb47ba4eee9ec1041b1461127a25a0d0","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            \u0027supports_pcpus\u0027: False,"},{"line_number":81,"context_line":"            \u0027supports_accelerators\u0027: False,"},{"line_number":82,"context_line":"            \u0027supports_vtpm\u0027: False,"},{"line_number":83,"context_line":"            \u0027supports_secure_boot\u0027: False,"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            # Supported image types"},{"line_number":86,"context_line":"            \"supports_image_type_aki\": False,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d22d6f9_f05253fd","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":42},"in_reply_to":"07a61c64_b3cfec5f","updated":"2021-03-04 18:46:41.000000000","message":"The PowerVM driver insists on all capabilities being provided, for some reason I can\u0027t recall","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e375f5ff09fdacbaf1a0fdf970faba43661ec125","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \u0027supports_pcpus\u0027: False,"},{"line_number":81,"context_line":"            \u0027supports_accelerators\u0027: False,"},{"line_number":82,"context_line":"            \u0027supports_vtpm\u0027: False,"},{"line_number":83,"context_line":"            \u0027supports_secure_boot\u0027: False,"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            # Supported image types"},{"line_number":86,"context_line":"            \"supports_image_type_aki\": False,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c93d2054_666e1c9e","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":42},"in_reply_to":"6d22d6f9_f05253fd","updated":"2021-03-09 11:38:27.000000000","message":"https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/powervm/test_driver.py#L67-L68","commit_id":"3bfd2d69104b873d72484b656185fd5cf2e69b65"}]}