)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5c0500898c5da1c0dbb99dbafc7decc47a8354e","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        return interfaces"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def get_interface_by_cfg("},{"line_number":235,"context_line":"            self,"},{"line_number":236,"context_line":"            cfg: vconfig.LibvirtConfigGuestDevice,"},{"line_number":237,"context_line":"            from_persistent_config: bool \u003d False"},{"line_number":238,"context_line":"    ) -\u003e ty.Optional[vconfig.LibvirtConfigGuestDevice]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"01efe896_bd89d808","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":12},"updated":"2021-02-23 16:39:41.000000000","message":"strike","commit_id":"3eead5dd25d426797891b84af07c1803c48da98d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3e24172821cc8ebb3d3dee5490f31d3165c99ae","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        return interfaces"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def get_interface_by_cfg("},{"line_number":235,"context_line":"            self,"},{"line_number":236,"context_line":"            cfg: vconfig.LibvirtConfigGuestDevice,"},{"line_number":237,"context_line":"            from_persistent_config: bool \u003d False"},{"line_number":238,"context_line":"    ) -\u003e ty.Optional[vconfig.LibvirtConfigGuestDevice]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da396839_d4763928","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":12},"in_reply_to":"01efe896_bd89d808","updated":"2021-02-24 09:24:44.000000000","message":"Done","commit_id":"3eead5dd25d426797891b84af07c1803c48da98d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5c0500898c5da1c0dbb99dbafc7decc47a8354e","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        return self.get_all_devices(vconfig.LibvirtConfigGuestDisk)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def get_all_devices("},{"line_number":371,"context_line":"            self,"},{"line_number":372,"context_line":"            devtype: vconfig.LibvirtConfigGuestDevice \u003d None,"},{"line_number":373,"context_line":"            from_persistent_config: bool \u003d False"},{"line_number":374,"context_line":"    ) -\u003e ty.List[vconfig.LibvirtConfigGuestDevice]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"63b3ec0e_12a70b4a","line":371,"range":{"start_line":371,"start_character":8,"end_line":371,"end_character":12},"updated":"2021-02-23 16:39:41.000000000","message":"strike","commit_id":"3eead5dd25d426797891b84af07c1803c48da98d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3e24172821cc8ebb3d3dee5490f31d3165c99ae","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        return self.get_all_devices(vconfig.LibvirtConfigGuestDisk)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def get_all_devices("},{"line_number":371,"context_line":"            self,"},{"line_number":372,"context_line":"            devtype: vconfig.LibvirtConfigGuestDevice \u003d None,"},{"line_number":373,"context_line":"            from_persistent_config: bool \u003d False"},{"line_number":374,"context_line":"    ) -\u003e ty.List[vconfig.LibvirtConfigGuestDevice]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"83cb97fd_43754f63","line":371,"range":{"start_line":371,"start_character":8,"end_line":371,"end_character":12},"in_reply_to":"63b3ec0e_12a70b4a","updated":"2021-02-24 09:24:44.000000000","message":"Done. Is there a way to teach PyCharm not to do this automatically?","commit_id":"3eead5dd25d426797891b84af07c1803c48da98d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6de924756fade88a7ff8c7c02658bbd4bb86e5dd","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        :param from_persistent_config: query the device from the persistent"},{"line_number":357,"context_line":"            domain (i.e. inactive XML configuration that\u0027ll be used on next"},{"line_number":358,"context_line":"            start of the domain) instead of the live domain configuration"},{"line_number":359,"context_line":"        :returns LibvirtConfigGuestDisk: mounted at device or None"},{"line_number":360,"context_line":"        \"\"\""},{"line_number":361,"context_line":"        flags \u003d 0"},{"line_number":362,"context_line":"        if from_persistent_config:"}],"source_content_type":"text/x-python","patch_set":7,"id":"8d05bcc9_e1198ba2","line":359,"range":{"start_line":359,"start_character":41,"end_line":359,"end_character":66},"updated":"2021-04-19 10:56:49.000000000","message":"nit - this isn\u0027t true, it\u0027s just the device name according to libvirt.","commit_id":"a7f2b65d17376710a311bd2f30a6524437bb3aa8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6de924756fade88a7ff8c7c02658bbd4bb86e5dd","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        except Exception:"},{"line_number":367,"context_line":"            return None"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        # FIXME(lyarwood): Workaround for the device being either a target dev"},{"line_number":370,"context_line":"        # when called via swap_volume or source file when called via"},{"line_number":371,"context_line":"        # live_snapshot. This should be removed once both are refactored to use"},{"line_number":372,"context_line":"        # only the target dev of the device."},{"line_number":373,"context_line":"        node \u003d doc.find(\"./devices/disk/target[@dev\u003d\u0027%s\u0027]..\" % device)"},{"line_number":374,"context_line":"        if node is None:"},{"line_number":375,"context_line":"            node \u003d doc.find(\"./devices/disk/source[@file\u003d\u0027%s\u0027]..\" % device)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1189f4c3_69f4ec56","line":372,"range":{"start_line":369,"start_character":0,"end_line":372,"end_character":44},"updated":"2021-04-19 10:56:49.000000000","message":"Right I really need to clean this up as it\u0027s pretty confusing IMHO.","commit_id":"a7f2b65d17376710a311bd2f30a6524437bb3aa8"}]}
