)]}'
{"id":"openstack%2Fnova~777168","triplet_id":"openstack%2Fnova~master~Ic3f22308df7e015b6fb9531b178262aa776cf0a8","project":"openstack/nova","branch":"master","topic":"mock-4.0.3","hashtags":[],"change_id":"Ic3f22308df7e015b6fb9531b178262aa776cf0a8","subject":"tests: Remove \u0027test_tcp_rst_no_compute_rpcapi\u0027","status":"ABANDONED","created":"2021-02-23 17:21:04.000000000","updated":"2021-02-23 17:24:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2fe5db4263b8ca13d6d7bac7ce52ca149428a3b6","_number":777168,"virtual_id_number":777168,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-23 17:22:00.000000000","updated_by":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"reviewer":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"state":"CC"}],"messages":[{"id":"038704e487e2195ab62156f78915bdc7d66c9306","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-23 17:21:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"668ead6cdef19e0b39182f65103e4597d3053086","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-23 17:23:04.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2fe5db4263b8ca13d6d7bac7ce52ca149428a3b6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-23 17:24:21.000000000","message":"Abandoned\n\nhttps://review.opendev.org/c/openstack/nova/+/741351 is a much nicer solution","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3fe3c041bc363d76f62f0e74a18299e0b1226c19","revisions":{"59c210125daec28bdc37de5f211b22ca3e347f4f":{"kind":"REWORK","_number":1,"created":"2021-02-23 17:21:04.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/68/777168/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/777168/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/777168/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/777168/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/777168/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/777168/1"}}},"commit":{"parents":[{"commit":"8ca5d2169fc3ba5cf86f830a93cf92bae925e1f4","subject":"Merge \"Support interface attach with QoS ports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8ca5d2169fc3ba5cf86f830a93cf92bae925e1f4"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-02-23 17:18:41.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-02-23 17:18:41.000000000","tz":0},"subject":"tests: Remove ;test_tcp_rst_no_compute_rpcapi\u0027","message":"tests: Remove ;test_tcp_rst_no_compute_rpcapi\u0027\n\nRemove the \u0027test_tcp_rst_no_compute_rpcapi\u0027 test case. This test is not\ncorrect. The \u0027self.wh\u0027 object is set to a proxy class that we mock to\ninherit from a \u0027Mock\u0027 object, so unset variables are returned as mocked\nvalues, which suggests this doesn\u0027t appear to have been testing what it\nwas expected to be testing. Along with a subtle change in Python 3.8 to\nhow this is mocked, the only way to get the test to pass would be to\nmock the return value we are checking, so we would just be testing that\nmocking works. This should probably be reimplemented as a functional\ntest since it tries to reach into external code to manipulate results.\n\nChange-Id: Ic3f22308df7e015b6fb9531b178262aa776cf0a8\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCo-authored-by: Melanie Witt \u003cmelwittt@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/59c210125daec28bdc37de5f211b22ca3e347f4f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/59c210125daec28bdc37de5f211b22ca3e347f4f"}]},"branch":"refs/heads/master"},"3fe3c041bc363d76f62f0e74a18299e0b1226c19":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-23 17:23:04.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/68/777168/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/777168/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/777168/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/777168/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/777168/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/777168/2"}}},"commit":{"parents":[{"commit":"8ca5d2169fc3ba5cf86f830a93cf92bae925e1f4","subject":"Merge \"Support interface attach with QoS ports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8ca5d2169fc3ba5cf86f830a93cf92bae925e1f4"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-02-23 17:18:41.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-02-23 17:22:59.000000000","tz":0},"subject":"tests: Remove \u0027test_tcp_rst_no_compute_rpcapi\u0027","message":"tests: Remove \u0027test_tcp_rst_no_compute_rpcapi\u0027\n\nRemove the \u0027test_tcp_rst_no_compute_rpcapi\u0027 test case. This test is not\ncorrect. The \u0027self.wh\u0027 object is set to a proxy class that we mock to\ninherit from a \u0027Mock\u0027 object, so unset variables are returned as mocked\nvalues, which suggests this doesn\u0027t appear to have been testing what it\nwas expected to be testing. Along with a subtle change in Python 3.8 to\nhow this is mocked, the only way to get the test to pass would be to\nmock the return value we are checking, so we would just be testing that\nmocking works. This should probably be reimplemented as a functional\ntest since it tries to reach into external code to manipulate results.\n\nChange-Id: Ic3f22308df7e015b6fb9531b178262aa776cf0a8\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCo-authored-by: Melanie Witt \u003cmelwittt@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3fe3c041bc363d76f62f0e74a18299e0b1226c19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3fe3c041bc363d76f62f0e74a18299e0b1226c19"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[],"submit_requirements":[]}