)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"015e1847f34626ae1c2997d190e78c4f85049c72","unresolved":true,"context_lines":[{"line_number":757,"context_line":"    STANDARD \u003d \"type-PCI\""},{"line_number":758,"context_line":"    SRIOV_PF \u003d \"type-PF\""},{"line_number":759,"context_line":"    SRIOV_VF \u003d \"type-VF\""},{"line_number":760,"context_line":"    # NOTE(sean-k-mooney): the db field is Column(String(8), nullable\u003dFalse)"},{"line_number":761,"context_line":"    # type-vdpa is 9 long... and as jay notes above the prefix is silly so"},{"line_number":762,"context_line":"    # for the new vdpa value we drop the prefix to avoid a db migration."},{"line_number":763,"context_line":"    VDPA \u003d \"vdpa\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a5826ec_2ec9011c","line":760,"range":{"start_line":760,"start_character":31,"end_line":760,"end_character":33},"updated":"2021-03-10 14:47:20.000000000","message":"DB","commit_id":"9b93607e34250a7022c3592f1b2ddeeed67b1676"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ed9323301ae18bb35d86aba2ee293c0b6b47ffd8","unresolved":false,"context_lines":[{"line_number":757,"context_line":"    STANDARD \u003d \"type-PCI\""},{"line_number":758,"context_line":"    SRIOV_PF \u003d \"type-PF\""},{"line_number":759,"context_line":"    SRIOV_VF \u003d \"type-VF\""},{"line_number":760,"context_line":"    # NOTE(sean-k-mooney): the db field is Column(String(8), nullable\u003dFalse)"},{"line_number":761,"context_line":"    # type-vdpa is 9 long... and as jay notes above the prefix is silly so"},{"line_number":762,"context_line":"    # for the new vdpa value we drop the prefix to avoid a db migration."},{"line_number":763,"context_line":"    VDPA \u003d \"vdpa\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5dd3a134_8a91d456","line":760,"range":{"start_line":760,"start_character":31,"end_line":760,"end_character":33},"in_reply_to":"1a5826ec_2ec9011c","updated":"2021-03-10 15:59:37.000000000","message":"Ack","commit_id":"9b93607e34250a7022c3592f1b2ddeeed67b1676"}],"nova/objects/pci_device.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"015e1847f34626ae1c2997d190e78c4f85049c72","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    # Version 1.4: Added parent_addr field"},{"line_number":99,"context_line":"    # Version 1.5: Added 2 new device statuses: UNCLAIMABLE and UNAVAILABLE"},{"line_number":100,"context_line":"    # Version 1.6: Added uuid field"},{"line_number":101,"context_line":"    # Version 1.7: Extened dev_type field to allow type-VDPA"},{"line_number":102,"context_line":"    VERSION \u003d \u00271.7\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"01208c8b_c3c84015","line":101,"range":{"start_line":101,"start_character":19,"end_line":101,"end_character":26},"updated":"2021-03-10 14:47:20.000000000","message":"Added VDPA to \u0027dev_type\u0027 field\n\n(there\u0027s no type-VDPA)","commit_id":"9b93607e34250a7022c3592f1b2ddeeed67b1676"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ed9323301ae18bb35d86aba2ee293c0b6b47ffd8","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    # Version 1.4: Added parent_addr field"},{"line_number":99,"context_line":"    # Version 1.5: Added 2 new device statuses: UNCLAIMABLE and UNAVAILABLE"},{"line_number":100,"context_line":"    # Version 1.6: Added uuid field"},{"line_number":101,"context_line":"    # Version 1.7: Extened dev_type field to allow type-VDPA"},{"line_number":102,"context_line":"    VERSION \u003d \u00271.7\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"673c1786_1155d4ad","line":101,"range":{"start_line":101,"start_character":19,"end_line":101,"end_character":26},"in_reply_to":"01208c8b_c3c84015","updated":"2021-03-10 15:59:37.000000000","message":"oh right i renamed it because of the db column length restirction to just vdpa and i missed doing the same here.","commit_id":"9b93607e34250a7022c3592f1b2ddeeed67b1676"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"015e1847f34626ae1c2997d190e78c4f85049c72","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                raise exception.ObjectActionError("},{"line_number":148,"context_line":"                    action\u003d\u0027obj_make_compatible\u0027,"},{"line_number":149,"context_line":"                    reason\u003d\u0027dev_type\u003d%s not supported in version %s\u0027 % ("},{"line_number":150,"context_line":"                        dev_type, target_version))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def update_device(self, dev_dict):"},{"line_number":153,"context_line":"        \"\"\"Sync the content from device dictionary to device object."}],"source_content_type":"text/x-python","patch_set":5,"id":"86ace0a4_3c25fded","line":150,"updated":"2021-03-10 14:47:20.000000000","message":"not your fault, but these are backwards from how we normally do this. Would be a great follow-up","commit_id":"9b93607e34250a7022c3592f1b2ddeeed67b1676"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ed9323301ae18bb35d86aba2ee293c0b6b47ffd8","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                raise exception.ObjectActionError("},{"line_number":148,"context_line":"                    action\u003d\u0027obj_make_compatible\u0027,"},{"line_number":149,"context_line":"                    reason\u003d\u0027dev_type\u003d%s not supported in version %s\u0027 % ("},{"line_number":150,"context_line":"                        dev_type, target_version))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def update_device(self, dev_dict):"},{"line_number":153,"context_line":"        \"\"\"Sync the content from device dictionary to device object."}],"source_content_type":"text/x-python","patch_set":5,"id":"725a6dc8_2647148e","line":150,"in_reply_to":"86ace0a4_3c25fded","updated":"2021-03-10 15:59:37.000000000","message":"ya i noticed that and found it odd, it leave the object in a semi incorrect state untill we finish processing all the ifs.\nin practice it will be the same but we do it the other way to avoid that so sure i can fix this in a follow up","commit_id":"9b93607e34250a7022c3592f1b2ddeeed67b1676"}]}