)]}'
{"id":"openstack%2Fnova~778462","triplet_id":"openstack%2Fnova~master~Ia222e0f64b932e6aefe779b168d0aa4e9ff48075","project":"openstack/nova","branch":"master","topic":"spec/libvirt-default-machine-type","hashtags":[],"change_id":"Ia222e0f64b932e6aefe779b168d0aa4e9ff48075","subject":"Fix ImageBackendFixture not to support direct_snapshot","status":"MERGED","created":"2021-03-03 13:46:59.000000000","updated":"2021-03-06 17:23:02.000000000","submitted":"2021-03-06 17:23:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"778462-spec/libvirt-default-machine-type","meta_rev_id":"54788fa9222e006392e3ad0e40a8bf0ad9827103","_number":778462,"virtual_id_number":778462,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-06 17:22:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2021-03-06 03:34:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2021-03-04 16:38:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2021-03-03 15:22:16.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2021-03-03 14:11:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2021-03-04 16:38:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-03 14:04:01.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-03 14:04:25.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-03-03 15:13:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-03 16:12:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-03 16:13:29.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-04 16:38:22.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-03-06 03:34:15.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"}],"messages":[{"id":"fab036714cd4a58c18f9772089bd8e352a5e617b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-03-03 13:46:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1d6487f331847e8b66f3e193d7420b70317a89e","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-03-03 14:04:01.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/778462/778462/1/check-not-vote/ext-nova-zuul/c82d958 : FAILURE in 9m 13s","accounts_in_message":[],"_revision_number":1},{"id":"422a07c02434c66738b6686c0456c194bf90ff09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-03 14:04:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dc934af73b688e701a043176bab448e989361bbd","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-03-03 14:11:27.000000000","message":"Patch Set 2: Code-Review+1\n\nI won\u0027t +2 this as it is mostly my own patch. :)","accounts_in_message":[],"_revision_number":2},{"id":"75b5dee357a53b147960554620e40882695bc50e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-03 15:13:19.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/c3e2344888974e27895b20dd7d517c0e : SUCCESS in 22m 39s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/b7ad675d8b93448b96d2f8bef108bcee : SUCCESS in 26m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"993da0fa242cb0bf15b8dea0508dad0da3807074","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-03 15:22:16.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM, I only edited the comment to drop the reference to the test I\u0027ve rebased on top of this so I feel comfortable +2\u0027ing.","accounts_in_message":[],"_revision_number":2},{"id":"ceb8df9b4b1b69ef99afbd41544d7131890d923d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-03 16:12:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6c714f4cf94f466e8246ca54df42cbcd : SUCCESS in 17m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c62872e527b34732be165d77a4a8526a : SUCCESS in 18m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1cc75697b0554090b6013437b4e6c44a : SUCCESS in 9m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f809d98138c4425c8e887df111771019 : SUCCESS in 13m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/731cfa3e2ba046ef9e79e5e2e2180870 : SUCCESS in 15m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/174c53f87b95464b9eb22bc742508a33 : SUCCESS in 13m 30s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/49dce0a04114434da45a4cb16323789f : SUCCESS in 10m 43s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a7d3e560ea8b47ada5711142f9ba9346 : SUCCESS in 19m 18s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a594c4e5e5ab46feb07d5c8948cd065f : SUCCESS in 22m 26s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c24ea3b0ad4eb33193524b45144c79fa50fb648a","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-03-03 16:13:29.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/62/778462/2/check/EMC_PowerFlex_NOVA/df5a7a6/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"1cdd48291431e5de2c876276dbcaccb3b02341b8","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-04 16:38:02.000000000","message":"Topic set to spec/libvirt-default-machine-type","accounts_in_message":[],"_revision_number":2},{"id":"d948b35a56423cbd62a2fd9ab5700ee6fa778cd2","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-04 16:38:22.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e5f939ee133e5c23147cfeccfa8a554dfe2da61e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 16:41:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1348e47b2313ca06dd4961c194c94b6d191ad5e6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 22:38:06.000000000","message":"Patch Set 2: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":2},{"id":"2552d914387c9f23c1c031dabbb416574ab87517","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-03-06 03:34:15.000000000","message":"Patch Set 2: Code-Review+1\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"967c1631b5758de7e9f9de4e01454875a025257f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 04:01:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/88122cc6f5de479dbad3f1767188cfd5 : SUCCESS in 17m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2bcc8c2b507b4692b3c80aa01dc2e3bd : SUCCESS in 14m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5a69de45b297475597606081190949ac : SUCCESS in 8m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7cbf2a9d00be41409d8cc1f111fefdf7 : SUCCESS in 13m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b7d4903a173f4057806557154854792b : SUCCESS in 14m 26s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9dc71145883a4ac4b7b28fd38c8938a7 : SUCCESS in 13m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6438a076faa746c280027028a6d57a37 : SUCCESS in 9m 16s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a22444815f0e4ec9b03799d18c1633b3 : SUCCESS in 20m 54s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d1cd1bf8f2ea47aabbbb47c3de1d2274 : SUCCESS in 20m 39s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b36febb08c36ecebd515b9356acb952a36441a20","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-03-06 04:02:37.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/62/778462/2/check/EMC_PowerFlex_NOVA/48ff719/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"66082a64c3d473359e21ec1e9ba37c55949d344d","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 05:08:05.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ade7754006e08eac87702386ddbce0b609b55a8f","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-03-06 05:09:35.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/62/778462/2/check/EMC_PowerFlex_NOVA/71795b8/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"f56f902e47b208791f28ddbd59773818620d9acd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 11:44:03.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e8776dc3e0d18a9db0fb9e3b8a385f69eac8ac83","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 17:22:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6abe047b6c2b4613bf7ec26277aeabdb : SUCCESS in 15m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/22b0c82b112b48c3884e4a22360feddb : SUCCESS in 9m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fc004e3c152f4ad3879eccf0fa91d94e : SUCCESS in 13m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e3abae8da8b640f5936105fc731a3e6c : SUCCESS in 12m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c195e6a51a3740caa8eae83c52715966 : SUCCESS in 9m 24s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/652eb8885b1d4eca93a3acd8298911de : SUCCESS in 20m 51s","accounts_in_message":[],"_revision_number":2},{"id":"54788fa9222e006392e3ad0e40a8bf0ad9827103","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 17:23:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"947f813e562101d6c05ae47940f36de7c33604e5","revisions":{"7ecfd19312ef100ef3eac7c7b31c19f4bc2de68c":{"kind":"REWORK","_number":1,"created":"2021-03-03 13:46:59.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/62/778462/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/778462/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/778462/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/778462/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/778462/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/778462/1"}}},"commit":{"parents":[{"commit":"86b9ab3fc59329ea648b9a5590c6fd56fed783e7","subject":"libvirt: Add a config update workflow test for [libvirt]hw_machine_type","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/86b9ab3fc59329ea648b9a5590c6fd56fed783e7"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-03-03 13:36:06.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-03-03 13:36:06.000000000","tz":60},"subject":"Fix ImageBackendFixture not to support direct_snapshot","message":"Fix ImageBackendFixture not to support direct_snapshot\n\nThe ImageBackendFixture mocks returns a mocked disk and that disk\nblindly supports the direct_snapshot call by returning a MagicMock as a\nresult. A real imagebacked returns the location of the snapshot instead.\nWhen the result of the snapshot is uploaded to the GlanceFixture the\nfixtures stores the metadata including the MagicMock. Later when such\nsnapshot is downloaded from the fixture (e.g. during unshelve) the\nGlance fixture tries to deepcopy the metadata to avoid clients modifying\nthe returned data to affect the internal state of the fixture. But\nMagicMock cannot be deep copied.\n\nAn easy fix is to declare direct_snapshot not supported for\nImageBackendFixture by raising NotImplementedError. This is already\nhandled by the virt driver as we have real backends that are not\nsupporting the direct snapshot call. This way the whole issue in the\nGlanceFixture can be avoided.\n\nAlso this path re-enables parts of the\ntest_hw_machine_type_config_update_workflow test case that was turned\noff due to the above described issue in the image backend fixture. The\nchange in the asserts of that test is due to having a wrong assert in\nthe first place.\n\nChange-Id: Ia222e0f64b932e6aefe779b168d0aa4e9ff48075\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7ecfd19312ef100ef3eac7c7b31c19f4bc2de68c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7ecfd19312ef100ef3eac7c7b31c19f4bc2de68c"}]},"branch":"refs/heads/master"},"947f813e562101d6c05ae47940f36de7c33604e5":{"kind":"REWORK","_number":2,"created":"2021-03-03 14:04:25.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/62/778462/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/778462/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/778462/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/778462/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/778462/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/778462/2"}}},"commit":{"parents":[{"commit":"8cddd243bfaac4454b088d49ba65d4fb3c42211a","subject":"nova-status: Add hw_machine_type check for libvirt instances","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8cddd243bfaac4454b088d49ba65d4fb3c42211a"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-03-03 13:36:06.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 14:03:49.000000000","tz":0},"subject":"Fix ImageBackendFixture not to support direct_snapshot","message":"Fix ImageBackendFixture not to support direct_snapshot\n\nThe ImageBackendFixture mocks returns a mocked disk and that disk\nblindly supports the direct_snapshot call by returning a MagicMock as a\nresult. A real imagebacked returns the location of the snapshot instead.\nWhen the result of the snapshot is uploaded to the GlanceFixture the\nfixtures stores the metadata including the MagicMock. Later when such\nsnapshot is downloaded from the fixture (e.g. during unshelve) the\nGlance fixture tries to deepcopy the metadata to avoid clients modifying\nthe returned data to affect the internal state of the fixture. But\nMagicMock cannot be deep copied.\n\nAn easy fix is to declare direct_snapshot not supported for\nImageBackendFixture by raising NotImplementedError. This is already\nhandled by the virt driver as we have real backends that are not\nsupporting the direct snapshot call. This way the whole issue in the\nGlanceFixture can be avoided.\n\nChange-Id: Ia222e0f64b932e6aefe779b168d0aa4e9ff48075\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/947f813e562101d6c05ae47940f36de7c33604e5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/947f813e562101d6c05ae47940f36de7c33604e5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}