)]}'
{"id":"openstack%2Fnova~778463","triplet_id":"openstack%2Fnova~master~Iba40c2df72228b461767d5734d5a62403d9f2cfa","project":"openstack/nova","branch":"master","topic":"bug/1917619","hashtags":[],"change_id":"Iba40c2df72228b461767d5734d5a62403d9f2cfa","subject":"libvirt: Simplify device_path check in _detach_encryptor","status":"MERGED","created":"2021-03-03 13:48:37.000000000","updated":"2021-04-09 01:57:20.000000000","submitted":"2021-04-09 01:55:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"778463-bug/1917619","meta_rev_id":"5dde30b121aae9c9e69bb63736d543ac14d48160","_number":778463,"virtual_id_number":778463,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-09 01:55:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2021-04-08 23:46:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2021-03-24 15:38:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2021-04-08 23:46:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-03 15:23:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-03 15:42:42.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-03 19:28:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-03 19:28:35.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-04 03:01:37.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-24 15:38:36.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-04-08 23:46:08.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"}],"messages":[{"id":"43b841ae11d8ff0cff6a45e41f5cefe3a17f15a1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-03 13:48:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e860552c8463838b3a34a821730a5f45c305f6c2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-03 14:15:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4a3ef2f84b026b6f9bfdab47ea38af8b07e9344f","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-03 15:23:30.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/0f26b2540b1946bc85e371d92d4df73d : SUCCESS in 22m 01s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/2fcc191a9665443e87d4e06496cfd30b : SUCCESS in 33m 04s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2c9a0ac48ac08a8843190c539daff2af7a7d7d6c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-03-03 15:42:42.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/778463/778463/2/check-not-vote/ext-nova-zuul/bf5a641 : SUCCESS in 1h 23m 48s","accounts_in_message":[],"_revision_number":2},{"id":"2195986d8eec9c5b97d44a8a86b3a31b14548381","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-03 19:28:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/b491ae582f3944f49f1e113f7150b510 : SUCCESS in 1h 23m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3a97f5d47ba34d8787555da295a95308 : SUCCESS in 19m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cf674312461b4db783513fb8952c1b2b : SUCCESS in 14m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef6cea12e0f9445ead6a465097772458 : SUCCESS in 8m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/70763a5ddfb3450285df7410eda9ed62 : SUCCESS in 14m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e80853e7d6d047578c921adf1ca5f300 : SUCCESS in 15m 01s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/39dddf811994477ea90bcf26f1c4f872 : SUCCESS in 14m 59s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fe355d42b331461d9950fdbe19e0f5e9 : SUCCESS in 12m 02s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/f7428af4379e4abab3516e20cad52080 : SUCCESS in 1h 13m 20s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/746156a8875b485c9c11b3a7bd0733a8 : SUCCESS in 1h 07m 48s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/049abc6a893b4d4880c9379decac6781 : SUCCESS in 1h 16m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/0a391a77a93545e29c8f54062a3c060a : SUCCESS in 56m 21s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/6af5935197f545c392f0c16a947ae011 : SUCCESS in 1h 00m 46s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/d0dd611960f441bb8e7a2eab092b4dd2 : SUCCESS in 1h 23m 49s\n- nova-next https://zuul.opendev.org/t/openstack/build/1cd6fdbf15da4ed793d96dd1deea4f4b : SUCCESS in 1h 41m 03s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/8a68aa9fe4af4d4d97afe3f0e3bc6982 : SUCCESS in 18m 07s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/16dceb9e29eb41669987b054ca8da3e4 : SUCCESS in 19m 34s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/8ff4735a3853484e8606d55bf58d172f : SUCCESS in 1h 03m 14s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/23a21f78fa1741e8addf58066f069105 : SUCCESS in 1h 02m 27s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4bba14af63354c86950202eff2e5621c : SUCCESS in 58m 08s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/4761f4860d6048d2b70325d8e61f07ba : SUCCESS in 31m 32s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/c6d039ce586a4af0a3da693d8fc5ba34 : SUCCESS in 40m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6b54d7bdb3545423d192abb10915ba35f9909912","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-03-03 19:28:35.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/63/778463/2/check/EMC_PowerFlex_NOVA/67ed22a/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"41f3bd3a6f172182409575d8b2a6a900700821ed","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-03-04 03:01:37.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/b3a5380abe0a42c6baf255f23bfa4027 : POST_FAILURE in 1h 54m 11s","accounts_in_message":[],"_revision_number":2},{"id":"e6aa1ea9d1e5c0acf1f16480a20dfa3b96ca4fca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-23 12:38:40.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"9df3bb137f3562f817e92902a7d9cea0adc2a172","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-03-23 12:40:50.000000000","message":"Patch Set 3:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"abcae438beed4ab00c99efc207ecc052ce167798","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-23 13:10:32.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ce739121e961479791e0bdaaffa53f54 : SUCCESS in 20m 36s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/0b96d32aeb694a67af570fb39d47c381 : SUCCESS in 27m 00s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"a13460be4463c8b917cdaed10c4bda6c8cda4096","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-23 14:14:51.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/26a41f7f6bf54b18b00255380e19856f : SUCCESS in 1h 20m 47s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dee54b892d174dfca2003fdac87577c7 : SUCCESS in 17m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0160a582cfe2447aa884f60b34d90b5f : SUCCESS in 14m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/49827107b9954d17ada8b7f9d8cab5a3 : SUCCESS in 8m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/76f5445368264172b7b637aa67679d06 : SUCCESS in 12m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/94f5ac9dc9bb4ae693aaa14405ec20fd : SUCCESS in 16m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/677bc13cdee14e0a817f1af9fdaaf556 : SUCCESS in 14m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cc86eeacd63b490b9f71cbe71a65cb3a : SUCCESS in 11m 24s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/759f0b1ba9de4ba1bbcf4fa1c91a0501 : SUCCESS in 1h 29m 30s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/df200e4f9d224a9788ac814933121580 : SUCCESS in 1h 25m 19s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/64979d84bf5a4905bbc7e88a4b2200c7 : SUCCESS in 1h 20m 23s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8fde59f2c7e046cb8d521fb00b9ce71a : SUCCESS in 55m 27s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/1ebe5191181b4576965679e01fd3715a : SUCCESS in 55m 26s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/29c7a951da4f44cfbd8da0f04c85b797 : SUCCESS in 1h 29m 23s\n- nova-next https://zuul.opendev.org/t/openstack/build/101711e0867e4e98ad3c09f336a0c4e0 : SUCCESS in 1h 29m 17s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/bb3b334f4cda4992be81dbb0a76cd0fb : SUCCESS in 18m 15s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/da27e8ace73c4feeb8d5d366664debee : SUCCESS in 17m 13s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/db362b92dfea4f1ba4a97914fd53e557 : SUCCESS in 1h 14m 39s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/08a6dd8805834e239ac7f8f9829ace7d : SUCCESS in 1h 06m 29s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/2708979b58c347d58cd3a1829fe38487 : SUCCESS in 52m 08s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/63f5e5d077c541fa9fa3fe3c5f88268f : SUCCESS in 25m 50s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/631ab9dc207a4e7392176bb454be0cc1 : SUCCESS in 35m 29s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"5df0379d537715f5428e6d429011600c19818a67","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-03-23 14:15:34.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/63/778463/3/check/EMC_PowerFlex_NOVA/57966be/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":3},{"id":"8fa6dee385603c281172a9a35a1af68930dee4f3","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-03-23 21:24:57.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/de738617f4794842a70c5ff89df26069 : RETRY_LIMIT in 1m 01s","accounts_in_message":[],"_revision_number":3},{"id":"78a915ddcd2baa74734cecb9a0de5c018e70bda4","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-24 12:33:56.000000000","message":"Topic set to bug/1917619","accounts_in_message":[],"_revision_number":3},{"id":"b77fe975b0cfd9021752e4fbd388a7a1a32d6a5e","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-03-24 15:38:36.000000000","message":"Patch Set 3: Code-Review+2\n\nLooks good","accounts_in_message":[],"_revision_number":3},{"id":"5cf9fffbfb8fd282c91843a79b38ba3ed63ef426","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-04-08 23:46:08.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)\n\nLooks reasonable to me, excellent commit message and code comment","accounts_in_message":[],"_revision_number":3},{"id":"7e96da16e5936a67af4b45fe9bca6840703445a4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-08 23:46:42.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"cb266dc228cd53d82371fc71d7374c2e589b5e91","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 01:55:13.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/746b2acbb47147d29a3a97ba228d904d : SUCCESS in 1h 28m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cbcb240ed1fd4b28b60126b0169d821c : SUCCESS in 15m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/786cb9b1cf6c4fa7838f0cebf71550b7 : SUCCESS in 8m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/71dc8d231aa04dea96b9d015f2697d72 : SUCCESS in 13m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7eee56058c024fb29bf5b44cdddcd130 : SUCCESS in 12m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/da7b7c92ccec467fb40d441165f71b3a : SUCCESS in 9m 52s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/3c972d873d0b4e0380cbff2d1c6c1d96 : SUCCESS in 1h 12m 46s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/16fdb4fe0c8f4325b094f300f09f705f : SUCCESS in 53m 03s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/a770a58a25c54c528bcf729df109af1c : SUCCESS in 53m 51s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d3b1069161f24581a398e2e22f4c8cca : SUCCESS in 20m 50s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/670e48a37f42494fb531ee8cc10a5233 : SUCCESS in 1h 21m 51s\n- nova-next https://zuul.opendev.org/t/openstack/build/73ab6324918c42ee879bdd76e63aa94d : SUCCESS in 1h 33m 16s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/9c27db35feed42f0b096ffe7cecd13f1 : SUCCESS in 1h 15m 31s\n- grenade https://zuul.opendev.org/t/openstack/build/0ea776893a2b447695c5dca127295a8b : SUCCESS in 51m 54s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/de0bf16723674fa18192aab130b5ee0b : SUCCESS in 45m 46s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/14fec4f2c7b14d078c36d5cc866af37d : SUCCESS in 45m 43s","accounts_in_message":[],"_revision_number":3},{"id":"529e2f7f417b8bf4ddd8999e1689514e2bffdcee","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 01:55:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"5dde30b121aae9c9e69bb63736d543ac14d48160","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 01:57:20.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/51e810ab9b214f14b0e2b019fc2ea6cf : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4908daed96ddda492ced6cbb084abe8f33a8b1f7","revisions":{"89f0491ea5a524a2b2b4518bde71962285f5f1b5":{"kind":"REWORK","_number":1,"created":"2021-03-03 13:48:37.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/63/778463/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/63/778463/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/63/778463/1"}}},"commit":{"parents":[{"commit":"5b66caab870558b8a7f7b662c01587b959ad3d41","subject":"Merge \"apidb: Compact Newton database migrations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5b66caab870558b8a7f7b662c01587b959ad3d41"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 12:33:49.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 13:47:16.000000000","tz":0},"subject":"libvirt: Simplify device_path check in _detach_encryptor","message":"libvirt: Simplify device_path check in _detach_encryptor\n\nIntroduced by Id670f13a7f197e71c77dc91276fc2fba2fc5f314 to resolve bug\n #1821696 this check was put in place to ensure _detach_encryptor did not\nattempt to use the os-brick encryptors with an unsupported volume type\nafter libvirt secrets had been removed outside the control of Nova.\n\nWith the introduction of the [workarounds]disable_native_luksv1 via\nIa500eb614cf575ab846f64f4b69c9068274c8c1f however the use of\n_allow_native_luksv1 as part of this check is no longer valid. As this\nhelper was updated to return False when the workaround is enabled,\nregardless of the underlying volume being attached natively or not.\n\nIf an admin had enabled the workaround after users had launched\ninstances with natively attached encrypted volumes *and* the libvirt\nsecrets had gone missing _detach_encryptor would attempt to use the\nos-brick encryptors. This would fail when the underlying volume type is\nunsupported, for example rbd. See bug #1917619 for an example.\n\nThis change resolves this corner case by dropping the use of\n_allow_native_luksv1 from the check and just asserting that a\ndevice_path is present for an encrypted volume before allowing the use\nof the os-brick encryptors.\n\nCloses-Bug: #1917619\nChange-Id: Iba40c2df72228b461767d5734d5a62403d9f2cfa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/89f0491ea5a524a2b2b4518bde71962285f5f1b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/89f0491ea5a524a2b2b4518bde71962285f5f1b5"}]},"branch":"refs/heads/master"},"5db8ecbe1f114595213ec3d514086daa71f4e0c6":{"kind":"REWORK","_number":2,"created":"2021-03-03 14:15:06.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/63/778463/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/63/778463/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/63/778463/2"}}},"commit":{"parents":[{"commit":"5b66caab870558b8a7f7b662c01587b959ad3d41","subject":"Merge \"apidb: Compact Newton database migrations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5b66caab870558b8a7f7b662c01587b959ad3d41"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 12:33:49.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 14:14:01.000000000","tz":0},"subject":"libvirt: Simplify device_path check in _detach_encryptor","message":"libvirt: Simplify device_path check in _detach_encryptor\n\nIntroduced by Id670f13a7f197e71c77dc91276fc2fba2fc5f314 to resolve bug\n #1821696 this check was put in place to ensure _detach_encryptor did not\nattempt to use the os-brick encryptors with an unsupported volume type\nafter libvirt secrets had been removed outside the control of Nova.\n\nWith the introduction of the [workarounds]disable_native_luksv1 via\nIa500eb614cf575ab846f64f4b69c9068274c8c1f however the use of\n_allow_native_luksv1 as part of this check is no longer valid. As this\nhelper was updated to return False when the workaround is enabled,\nregardless of the underlying volume being attached natively or not.\n\nIf an admin had enabled the workaround after users had launched\ninstances with natively attached encrypted volumes *and* the libvirt\nsecrets had gone missing _detach_encryptor would attempt to use the\nos-brick encryptors. This would fail when the underlying volume type is\nunsupported, for example rbd. See bug #1917619 for an example.\n\nThis change resolves this corner case by dropping the use of\n_allow_native_luksv1 from the check and just asserting that a\ndevice_path is present for an encrypted volume before allowing the use\nof the os-brick encryptors. As noted this is safe as calls to the\nencryptors are idempotent, ignoring failures to detach when the\nunderlying volume type is supported.\n\nCloses-Bug: #1917619\nChange-Id: Iba40c2df72228b461767d5734d5a62403d9f2cfa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5db8ecbe1f114595213ec3d514086daa71f4e0c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5db8ecbe1f114595213ec3d514086daa71f4e0c6"}]},"branch":"refs/heads/master"},"4908daed96ddda492ced6cbb084abe8f33a8b1f7":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-03-23 12:38:40.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/63/778463/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/63/778463/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/778463/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/63/778463/3"}}},"commit":{"parents":[{"commit":"3de7fb7c327db348d04d15d4cd3c4f811a336126","subject":"Merge \"Add missed accel_uuids for _poll_shelved_instances\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3de7fb7c327db348d04d15d4cd3c4f811a336126"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 12:33:49.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-23 12:38:40.000000000","tz":0},"subject":"libvirt: Simplify device_path check in _detach_encryptor","message":"libvirt: Simplify device_path check in _detach_encryptor\n\nIntroduced by Id670f13a7f197e71c77dc91276fc2fba2fc5f314 to resolve bug\n #1821696 this check was put in place to ensure _detach_encryptor did not\nattempt to use the os-brick encryptors with an unsupported volume type\nafter libvirt secrets had been removed outside the control of Nova.\n\nWith the introduction of the [workarounds]disable_native_luksv1 via\nIa500eb614cf575ab846f64f4b69c9068274c8c1f however the use of\n_allow_native_luksv1 as part of this check is no longer valid. As this\nhelper was updated to return False when the workaround is enabled,\nregardless of the underlying volume being attached natively or not.\n\nIf an admin had enabled the workaround after users had launched\ninstances with natively attached encrypted volumes *and* the libvirt\nsecrets had gone missing _detach_encryptor would attempt to use the\nos-brick encryptors. This would fail when the underlying volume type is\nunsupported, for example rbd. See bug #1917619 for an example.\n\nThis change resolves this corner case by dropping the use of\n_allow_native_luksv1 from the check and just asserting that a\ndevice_path is present for an encrypted volume before allowing the use\nof the os-brick encryptors. As noted this is safe as calls to the\nencryptors are idempotent, ignoring failures to detach when the\nunderlying volume type is supported.\n\nCloses-Bug: #1917619\nChange-Id: Iba40c2df72228b461767d5734d5a62403d9f2cfa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4908daed96ddda492ced6cbb084abe8f33a8b1f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4908daed96ddda492ced6cbb084abe8f33a8b1f7"}]},"branch":"refs/heads/master","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}