)]}'
{"nova/compute/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8d6eea1e3c3acc415a11415c4201275c8c2c2c8","unresolved":true,"context_lines":[{"line_number":1516,"context_line":"            user_data, metadata, access_ip_v4, access_ip_v6,"},{"line_number":1517,"context_line":"            requested_networks, config_drive, auto_disk_config,"},{"line_number":1518,"context_line":"            reservation_id, max_count, supports_port_resource_request,"},{"line_number":1519,"context_line":"        )"},{"line_number":1520,"context_line":""},{"line_number":1521,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":1522,"context_line":"        # check nova-compute nodes have been updated to Victoria to support the"}],"source_content_type":"text/x-python","patch_set":2,"id":"b063bce6_d837b416","line":1519,"updated":"2021-04-28 15:31:59.000000000","message":"okay, this seemed unrelated, but I understand why you do this.","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"90c256a40d742fff5a3b368116a3c19cea072e85","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"            user_data, metadata, access_ip_v4, access_ip_v6,"},{"line_number":1517,"context_line":"            requested_networks, config_drive, auto_disk_config,"},{"line_number":1518,"context_line":"            reservation_id, max_count, supports_port_resource_request,"},{"line_number":1519,"context_line":"        )"},{"line_number":1520,"context_line":""},{"line_number":1521,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":1522,"context_line":"        # check nova-compute nodes have been updated to Victoria to support the"}],"source_content_type":"text/x-python","patch_set":2,"id":"25d3a6f8_b7a2b166","line":1519,"in_reply_to":"b063bce6_d837b416","updated":"2021-04-28 15:52:36.000000000","message":"Yeah, you\u0027re right. I should have split this out /o\\ iirc, I had done this in a later patch and dragged it back here","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8d6eea1e3c3acc415a11415c4201275c8c2c2c8","unresolved":true,"context_lines":[{"line_number":5699,"context_line":"        ephemeral_size \u003d 24"},{"line_number":5700,"context_line":"        instance \u003d self._create_instance_obj()"},{"line_number":5701,"context_line":"        flavor \u003d self._create_flavor("},{"line_number":5702,"context_line":"            swap\u003dswap_size, ephemeral_gb\u003dephemeral_size)"},{"line_number":5703,"context_line":"        block_device_mapping \u003d ["},{"line_number":5704,"context_line":"                {\u0027device_name\u0027: \u0027/dev/sda1\u0027,"},{"line_number":5705,"context_line":"                 \u0027source_type\u0027: \u0027snapshot\u0027, \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f60bb920_bd0ab269","line":5702,"updated":"2021-04-28 15:31:59.000000000","message":"unrelated","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"90c256a40d742fff5a3b368116a3c19cea072e85","unresolved":false,"context_lines":[{"line_number":5699,"context_line":"        ephemeral_size \u003d 24"},{"line_number":5700,"context_line":"        instance \u003d self._create_instance_obj()"},{"line_number":5701,"context_line":"        flavor \u003d self._create_flavor("},{"line_number":5702,"context_line":"            swap\u003dswap_size, ephemeral_gb\u003dephemeral_size)"},{"line_number":5703,"context_line":"        block_device_mapping \u003d ["},{"line_number":5704,"context_line":"                {\u0027device_name\u0027: \u0027/dev/sda1\u0027,"},{"line_number":5705,"context_line":"                 \u0027source_type\u0027: \u0027snapshot\u0027, \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e30bb0ce_046e7dfa","line":5702,"in_reply_to":"f60bb920_bd0ab269","updated":"2021-04-28 15:52:36.000000000","message":"This one isn\u0027t entirely. I didn\u0027t want to leave indentation like so:\n\n  flavor \u003d self._create_flavor(swap\u003dswap_size,\n                                      ephemeral_gb\u003dephemeral_size)\n\nso I needed to fix this one manually","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8d6eea1e3c3acc415a11415c4201275c8c2c2c8","unresolved":true,"context_lines":[{"line_number":8613,"context_line":"    def test_create_instance_sets_system_metadata(self):"},{"line_number":8614,"context_line":"        # Make sure image properties are copied into system metadata."},{"line_number":8615,"context_line":"        with mock.patch.object("},{"line_number":8616,"context_line":"            self.compute_api.compute_task_api, \u0027schedule_and_build_instances\u0027,"},{"line_number":8617,"context_line":"        ) as mock_sbi:"},{"line_number":8618,"context_line":"            ref, resv_id \u003d self.compute_api.create("},{"line_number":8619,"context_line":"                self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f24f4162_bf5dd84c","line":8616,"updated":"2021-04-28 15:31:59.000000000","message":"unrelated","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8d6eea1e3c3acc415a11415c4201275c8c2c2c8","unresolved":true,"context_lines":[{"line_number":8633,"context_line":"    def test_create_saves_flavor(self):"},{"line_number":8634,"context_line":"        with mock.patch.object("},{"line_number":8635,"context_line":"            self.compute_api.compute_task_api, \u0027schedule_and_build_instances\u0027,"},{"line_number":8636,"context_line":"        ) as mock_sbi:"},{"line_number":8637,"context_line":"            ref, resv_id \u003d self.compute_api.create("},{"line_number":8638,"context_line":"                self.context,"},{"line_number":8639,"context_line":"                flavor\u003dself.default_flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"45a62c99_bc262430","line":8636,"updated":"2021-04-28 15:31:59.000000000","message":"unrelated again","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"90c256a40d742fff5a3b368116a3c19cea072e85","unresolved":false,"context_lines":[{"line_number":8633,"context_line":"    def test_create_saves_flavor(self):"},{"line_number":8634,"context_line":"        with mock.patch.object("},{"line_number":8635,"context_line":"            self.compute_api.compute_task_api, \u0027schedule_and_build_instances\u0027,"},{"line_number":8636,"context_line":"        ) as mock_sbi:"},{"line_number":8637,"context_line":"            ref, resv_id \u003d self.compute_api.create("},{"line_number":8638,"context_line":"                self.context,"},{"line_number":8639,"context_line":"                flavor\u003dself.default_flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"54c8c4d6_64a5130c","line":8636,"in_reply_to":"45a62c99_bc262430","updated":"2021-04-28 15:52:36.000000000","message":"Ack","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8d6eea1e3c3acc415a11415c4201275c8c2c2c8","unresolved":true,"context_lines":[{"line_number":8674,"context_line":"            side_effect\u003dexception.SecurityGroupNotFound(\u0027foo\u0027),"},{"line_number":8675,"context_line":"        ) as mock_secgroups:"},{"line_number":8676,"context_line":"            self.assertRaises("},{"line_number":8677,"context_line":"                exception.SecurityGroupNotFound,"},{"line_number":8678,"context_line":"                self.compute_api.create,"},{"line_number":8679,"context_line":"                self.context,"},{"line_number":8680,"context_line":"                flavor\u003dself.default_flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"861837af_3b7f431b","line":8677,"updated":"2021-04-28 15:31:59.000000000","message":"unrelated","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"90c256a40d742fff5a3b368116a3c19cea072e85","unresolved":false,"context_lines":[{"line_number":8674,"context_line":"            side_effect\u003dexception.SecurityGroupNotFound(\u0027foo\u0027),"},{"line_number":8675,"context_line":"        ) as mock_secgroups:"},{"line_number":8676,"context_line":"            self.assertRaises("},{"line_number":8677,"context_line":"                exception.SecurityGroupNotFound,"},{"line_number":8678,"context_line":"                self.compute_api.create,"},{"line_number":8679,"context_line":"                self.context,"},{"line_number":8680,"context_line":"                flavor\u003dself.default_flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"adc47edc_54b18e28","line":8677,"in_reply_to":"861837af_3b7f431b","updated":"2021-04-28 15:52:36.000000000","message":"Ack","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"}],"nova/tests/unit/test_quota.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8d6eea1e3c3acc415a11415c4201275c8c2c2c8","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        image_uuid \u003d \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            self.compute_api.create("},{"line_number":110,"context_line":"                self.context, min_count\u003d1, max_count\u003d1,"},{"line_number":111,"context_line":"                flavor\u003dself.flavor, image_href\u003dimage_uuid)"},{"line_number":112,"context_line":"        except exception.QuotaError as e:"},{"line_number":113,"context_line":"            expected_kwargs \u003d {\u0027code\u0027: 413,"}],"source_content_type":"text/x-python","patch_set":2,"id":"77fed49a_70a97bb7","line":110,"updated":"2021-04-28 15:31:59.000000000","message":"unrelated","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"90c256a40d742fff5a3b368116a3c19cea072e85","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        image_uuid \u003d \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            self.compute_api.create("},{"line_number":110,"context_line":"                self.context, min_count\u003d1, max_count\u003d1,"},{"line_number":111,"context_line":"                flavor\u003dself.flavor, image_href\u003dimage_uuid)"},{"line_number":112,"context_line":"        except exception.QuotaError as e:"},{"line_number":113,"context_line":"            expected_kwargs \u003d {\u0027code\u0027: 413,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f504a2ae_64974df4","line":110,"in_reply_to":"77fed49a_70a97bb7","updated":"2021-04-28 15:52:36.000000000","message":"Ack","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8d6eea1e3c3acc415a11415c4201275c8c2c2c8","unresolved":true,"context_lines":[{"line_number":150,"context_line":"            metadata[\u0027key%s\u0027 % i] \u003d \u0027value%s\u0027 % i"},{"line_number":151,"context_line":"        image_uuid \u003d \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027"},{"line_number":152,"context_line":"        self.assertRaises("},{"line_number":153,"context_line":"            exception.QuotaError, self.compute_api.create,"},{"line_number":154,"context_line":"            self.context, min_count\u003d1, max_count\u003d1, flavor\u003dself.flavor,"},{"line_number":155,"context_line":"            image_href\u003dimage_uuid, metadata\u003dmetadata)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0dfb365a_7809f5f6","line":153,"updated":"2021-04-28 15:31:59.000000000","message":"unrelated","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"90c256a40d742fff5a3b368116a3c19cea072e85","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            metadata[\u0027key%s\u0027 % i] \u003d \u0027value%s\u0027 % i"},{"line_number":151,"context_line":"        image_uuid \u003d \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027"},{"line_number":152,"context_line":"        self.assertRaises("},{"line_number":153,"context_line":"            exception.QuotaError, self.compute_api.create,"},{"line_number":154,"context_line":"            self.context, min_count\u003d1, max_count\u003d1, flavor\u003dself.flavor,"},{"line_number":155,"context_line":"            image_href\u003dimage_uuid, metadata\u003dmetadata)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df36943e_3a62d558","line":153,"in_reply_to":"0dfb365a_7809f5f6","updated":"2021-04-28 15:52:36.000000000","message":"Ack","commit_id":"1de6e960af829142c0c6e606ef10d06a44d2cae1"}]}