)]}'
{"nova/compute/claims.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        compute_node, pci_requests, migration, limits\u003dNone,"},{"line_number":167,"context_line":"    ):"},{"line_number":168,"context_line":"        self.context \u003d context"},{"line_number":169,"context_line":"        self.flavor \u003d flavor"},{"line_number":170,"context_line":"        if isinstance(image_meta, dict):"},{"line_number":171,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(image_meta)"},{"line_number":172,"context_line":"        self.image_meta \u003d image_meta"}],"source_content_type":"text/x-python","patch_set":2,"id":"dee2e6a4_4d29d5fd","line":169,"updated":"2021-05-18 09:45:53.000000000","message":"you\u0027re changing the argument, but that\u0027s fine.","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                      limits\u003dNone, image_meta\u003dNone, migration\u003dNone):"},{"line_number":203,"context_line":"        \"\"\"Create a claim for a rebuild operation.\"\"\""},{"line_number":204,"context_line":"        return self._move_claim("},{"line_number":205,"context_line":"            context, instance, instance.flavor, nodename, migration,"},{"line_number":206,"context_line":"            allocations, move_type\u003dfields.MigrationType.EVACUATION,"},{"line_number":207,"context_line":"            image_meta\u003dimage_meta, limits\u003dlimits)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"edfe8dc0_2ded34f8","line":205,"range":{"start_line":205,"start_character":30,"end_line":205,"end_character":46},"updated":"2021-05-18 09:45:53.000000000","message":"simplier, indeed.","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":1660,"context_line":"        \"\"\"Get the flavor from instance.\"\"\""},{"line_number":1661,"context_line":"        if migration.is_resize:"},{"line_number":1662,"context_line":"            return getattr(instance, \u0027%sflavor\u0027 % prefix)"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"        # NOTE(ndipanov): Certain migration types (all but resize)"},{"line_number":1665,"context_line":"        # do not change flavors so there is no need to stash"},{"line_number":1666,"context_line":"        # them. In that case - just get the instance flavor."}],"source_content_type":"text/x-python","patch_set":2,"id":"e590fdf2_55536ec7","line":1663,"updated":"2021-05-18 09:45:53.000000000","message":"unrelated \"else\" remove.","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/db/sqlalchemy/migrate_repo/versions/402_train.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":560,"context_line":"        mysql_charset\u003d\u0027utf8\u0027"},{"line_number":561,"context_line":"    )"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    # TODO(stephenfin): Remove this table since it has been moved to the API DB"},{"line_number":564,"context_line":"    instance_type_extra_specs \u003d Table(\u0027instance_type_extra_specs\u0027, meta,"},{"line_number":565,"context_line":"        Column(\u0027created_at\u0027, DateTime),"},{"line_number":566,"context_line":"        Column(\u0027updated_at\u0027, DateTime),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9cc4eb49_9f6df6d6","line":563,"updated":"2021-05-18 09:45:53.000000000","message":"a-ha, good point","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/notifications/base.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        hostname\u003dinstance.hostname,"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        # Type properties"},{"line_number":340,"context_line":"        instance_type\u003dflavor_name,"},{"line_number":341,"context_line":"        instance_type_id\u003dinstance.instance_type_id,"},{"line_number":342,"context_line":"        instance_flavor_id\u003dinstance_flavorid,"},{"line_number":343,"context_line":"        architecture\u003dinstance.architecture,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e2f6134_5f37b209","line":340,"range":{"start_line":340,"start_character":8,"end_line":340,"end_character":22},"updated":"2021-05-18 09:45:53.000000000","message":"+1, we can\u0027t change this directly.","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/objects/instance.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        \u0027node\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # TODO(stephenfin): Remove this in version 3.0 of the object as it has"},{"line_number":152,"context_line":"        # been replaced by \u0027flavor\u0027"},{"line_number":153,"context_line":"        \u0027instance_type_id\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        \u0027user_data\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"b54fc507_d58e97cd","line":152,"updated":"2021-05-18 09:45:53.000000000","message":"+1","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/api/openstack/compute/test_disk_config.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                \u0027vm_state\u0027: \u0027\u0027,"},{"line_number":84,"context_line":"                \u0027auto_disk_config\u0027: inst_[\u0027auto_disk_config\u0027],"},{"line_number":85,"context_line":"                \u0027security_groups\u0027: inst_[\u0027security_groups\u0027],"},{"line_number":86,"context_line":"                \u0027flavor\u0027: objects.Flavor.get_by_name(context, \u0027m1.small\u0027),"},{"line_number":87,"context_line":"            })"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            return inst"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd56e275_69c9b4a0","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":25},"updated":"2021-05-18 09:45:53.000000000","message":"fortunately you also changed the fake_db_instance object.","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/api/openstack/compute/test_flavor_access.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    {\u0027flavor_id\u0027: \u00272\u0027, \u0027project_id\u0027: \u0027proj2\u0027},"},{"line_number":61,"context_line":"    {\u0027flavor_id\u0027: \u00272\u0027, \u0027project_id\u0027: \u0027proj3\u0027},"},{"line_number":62,"context_line":"    {\u0027flavor_id\u0027: \u00273\u0027, \u0027project_id\u0027: \u0027proj3\u0027},"},{"line_number":63,"context_line":"]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def fake_get_flavor_access_by_flavor_id(context, flavorid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"6216fd2c_47951986","line":63,"updated":"2021-05-18 09:45:53.000000000","message":"unrelated","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        project_id\u003dtenant_id,"},{"line_number":79,"context_line":"        user_id\u003d\u0027fakeuser\u0027,"},{"line_number":80,"context_line":"        display_name\u003d\u0027name\u0027,"},{"line_number":81,"context_line":"        instance_type_id\u003dflavor.id,"},{"line_number":82,"context_line":"        launched_at\u003dstart,"},{"line_number":83,"context_line":"        terminated_at\u003dend,"},{"line_number":84,"context_line":"        vm_state\u003dvm_state,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6e8c19_0643d366","line":81,"updated":"2021-05-18 09:45:53.000000000","message":"this is correct, we can\u0027t change the object field yet.","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/db/fakes.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":28,"context_line":"def stub_out_db_instance_api(test, injected\u003dTrue):"},{"line_number":29,"context_line":"    \"\"\"Stubs out the db API for creating Instances.\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create_flavor(**updates):"},{"line_number":32,"context_line":"        flavor \u003d {\u0027id\u0027: 2,"},{"line_number":33,"context_line":"                         \u0027name\u0027: \u0027m1.tiny\u0027,"},{"line_number":34,"context_line":"                         \u0027memory_mb\u0027: 512,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a8633566_da237a14","line":31,"updated":"2021-05-18 09:45:53.000000000","message":"\\o/","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/fake_instance.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def fake_db_instance(**updates):"},{"line_number":46,"context_line":"    if \u0027flavor\u0027 in updates:"},{"line_number":47,"context_line":"        if isinstance(updates[\u0027flavor\u0027], objects.Flavor):"},{"line_number":48,"context_line":"            flavor \u003d updates[\u0027flavor\u0027]"},{"line_number":49,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a15506a6_ddb8e5db","line":46,"updated":"2021-05-18 09:45:53.000000000","message":"\\o/","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/test_notifications.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                                user_id\u003dself.user_id,"},{"line_number":73,"context_line":"                                project_id\u003dself.project_id,"},{"line_number":74,"context_line":"                                instance_type_id\u003dflavor.id,"},{"line_number":75,"context_line":"                                flavor\u003dflavor,"},{"line_number":76,"context_line":"                                root_gb\u003d0,"},{"line_number":77,"context_line":"                                ephemeral_gb\u003d0,"},{"line_number":78,"context_line":"                                access_ip_v4\u003d\u00271.2.3.4\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e9ef4185_f85a221d","line":75,"updated":"2021-05-18 09:45:53.000000000","message":"unnecessary change but ok","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":689,"context_line":"        \u0027system_metadata\u0027: {"},{"line_number":690,"context_line":"            \u0027image_disk_format\u0027: \u0027raw\u0027"},{"line_number":691,"context_line":"        },"},{"line_number":692,"context_line":"        \u0027instance_type_id\u0027: flavor.id,"},{"line_number":693,"context_line":"        \u0027flavor\u0027: flavor,"},{"line_number":694,"context_line":"        \u0027new_flavor\u0027: None,"},{"line_number":695,"context_line":"        \u0027old_flavor\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a72e787_474c6b8d","line":692,"updated":"2021-05-18 09:45:53.000000000","message":"unnecessary move but ok","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":21136,"context_line":""},{"line_number":21137,"context_line":"        instance \u003d fake_instance.fake_instance_obj("},{"line_number":21138,"context_line":"            self.context,"},{"line_number":21139,"context_line":"            expected_attrs\u003d[\u0027metadata\u0027, \u0027system_metadata\u0027, \u0027pci_devices\u0027],"},{"line_number":21140,"context_line":"            **inst)"},{"line_number":21141,"context_line":""},{"line_number":21142,"context_line":"        # Attributes which we need to be set so they don\u0027t touch the db,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4a68406e_716af5ec","line":21139,"updated":"2021-05-18 09:45:53.000000000","message":"unecessary indent modification but ok","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/tests/unit/virt/libvirt/test_migration.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":954,"context_line":"            \u0027root_gb\u0027: 10,"},{"line_number":955,"context_line":"            \u0027ephemeral_gb\u0027: 20,"},{"line_number":956,"context_line":"            \u0027instance_type_id\u0027: flavor.id,"},{"line_number":957,"context_line":"            \u0027flavor\u0027: flavor,"},{"line_number":958,"context_line":"            \u0027extra_specs\u0027: {},"},{"line_number":959,"context_line":"            \u0027system_metadata\u0027: {"},{"line_number":960,"context_line":"                \u0027image_disk_format\u0027: \u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"35840dc5_8ff0938f","line":957,"updated":"2021-05-18 09:45:53.000000000","message":"again, unnecessary move but ok","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2a68dcd02a4c1d39102077c85ab8da0cb3a7ddf5","unresolved":true,"context_lines":[{"line_number":8739,"context_line":""},{"line_number":8740,"context_line":"    def post_claim_migrate_data(self, context, instance, migrate_data, claim):"},{"line_number":8741,"context_line":"        migrate_data.dst_numa_info \u003d self._get_live_migrate_numa_info("},{"line_number":8742,"context_line":"            claim.claimed_numa_topology, claim.flavor, claim.image_meta)"},{"line_number":8743,"context_line":"        return migrate_data"},{"line_number":8744,"context_line":""},{"line_number":8745,"context_line":"    def _get_resources(self, instance, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3b5644d_593ca4af","line":8742,"range":{"start_line":8742,"start_character":41,"end_line":8742,"end_character":53},"updated":"2021-05-18 09:45:53.000000000","message":"indeed, you changed the attribute","commit_id":"1bf45c47205057801129dc20153de0a98d9c4e08"}]}