)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"af513d13abab39908a5b7ba4e2ea4005e2d3fab2","unresolved":true,"context_lines":[{"line_number":2321,"context_line":"            persistent_dev, guest, instance_uuid, device_name,"},{"line_number":2322,"context_line":"            persistent\u003dTrue, live\u003dFalse)"},{"line_number":2323,"context_line":""},{"line_number":2324,"context_line":"        # make sure the dev is really gone"},{"line_number":2325,"context_line":"        persistent_dev \u003d get_device_conf_func("},{"line_number":2326,"context_line":"            from_persistent_config\u003dTrue)"},{"line_number":2327,"context_line":"        if not persistent_dev:"},{"line_number":2328,"context_line":"            LOG.debug("},{"line_number":2329,"context_line":"                \u0027Successfully detached device %s from instance %s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"934ab54f_df79f019","line":2326,"range":{"start_line":2324,"start_character":0,"end_line":2326,"end_character":40},"updated":"2021-03-09 12:13:01.000000000","message":"I was worried for a second that we\u0027d end up raising the same error here but looking at the guest code it swallows all exceptions and returns None or [] for both possible functions called here.","commit_id":"23b5b36cb13291199bd2462d13a042e589eba5a0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0e82a47b526c0fecec7fb13bbdcb775007e144e0","unresolved":false,"context_lines":[{"line_number":2321,"context_line":"            persistent_dev, guest, instance_uuid, device_name,"},{"line_number":2322,"context_line":"            persistent\u003dTrue, live\u003dFalse)"},{"line_number":2323,"context_line":""},{"line_number":2324,"context_line":"        # make sure the dev is really gone"},{"line_number":2325,"context_line":"        persistent_dev \u003d get_device_conf_func("},{"line_number":2326,"context_line":"            from_persistent_config\u003dTrue)"},{"line_number":2327,"context_line":"        if not persistent_dev:"},{"line_number":2328,"context_line":"            LOG.debug("},{"line_number":2329,"context_line":"                \u0027Successfully detached device %s from instance %s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"e31ea3a1_58504ae9","line":2326,"range":{"start_line":2324,"start_character":0,"end_line":2326,"end_character":40},"in_reply_to":"934ab54f_df79f019","updated":"2021-04-14 16:34:34.000000000","message":"yepp.","commit_id":"23b5b36cb13291199bd2462d13a042e589eba5a0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa6b6bb89eaabe050bcbf46d908381b2d3a22e37","unresolved":true,"context_lines":[{"line_number":2533,"context_line":"                LOG.warning("},{"line_number":2534,"context_line":"                    \"During device detach, instance disappeared.\","},{"line_number":2535,"context_line":"                    instance_uuid\u003dinstance_uuid)"},{"line_number":2536,"context_line":"                # if the domain is disappeared then we have nothing detach"},{"line_number":2537,"context_line":"                return"},{"line_number":2538,"context_line":""},{"line_number":2539,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":5,"id":"852459a4_6c1a2559","line":2536,"range":{"start_line":2536,"start_character":32,"end_line":2536,"end_character":34},"updated":"2021-04-22 09:55:05.000000000","message":"has","commit_id":"865618d7286da50c5ada4cf0fe882dd54a012d7f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa6b6bb89eaabe050bcbf46d908381b2d3a22e37","unresolved":true,"context_lines":[{"line_number":2533,"context_line":"                LOG.warning("},{"line_number":2534,"context_line":"                    \"During device detach, instance disappeared.\","},{"line_number":2535,"context_line":"                    instance_uuid\u003dinstance_uuid)"},{"line_number":2536,"context_line":"                # if the domain is disappeared then we have nothing detach"},{"line_number":2537,"context_line":"                return"},{"line_number":2538,"context_line":""},{"line_number":2539,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":5,"id":"85b01375_97000949","line":2536,"range":{"start_line":2536,"start_character":67,"end_line":2536,"end_character":68},"updated":"2021-04-22 09:55:05.000000000","message":"to","commit_id":"865618d7286da50c5ada4cf0fe882dd54a012d7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1dc1e4ee32b21310b0478150db88d1b57db759cd","unresolved":false,"context_lines":[{"line_number":2533,"context_line":"                LOG.warning("},{"line_number":2534,"context_line":"                    \"During device detach, instance disappeared.\","},{"line_number":2535,"context_line":"                    instance_uuid\u003dinstance_uuid)"},{"line_number":2536,"context_line":"                # if the domain is disappeared then we have nothing detach"},{"line_number":2537,"context_line":"                return"},{"line_number":2538,"context_line":""},{"line_number":2539,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":5,"id":"aa41700b_f440a1db","line":2536,"range":{"start_line":2536,"start_character":32,"end_line":2536,"end_character":34},"in_reply_to":"852459a4_6c1a2559","updated":"2021-04-22 12:58:22.000000000","message":"Done","commit_id":"865618d7286da50c5ada4cf0fe882dd54a012d7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1dc1e4ee32b21310b0478150db88d1b57db759cd","unresolved":false,"context_lines":[{"line_number":2533,"context_line":"                LOG.warning("},{"line_number":2534,"context_line":"                    \"During device detach, instance disappeared.\","},{"line_number":2535,"context_line":"                    instance_uuid\u003dinstance_uuid)"},{"line_number":2536,"context_line":"                # if the domain is disappeared then we have nothing detach"},{"line_number":2537,"context_line":"                return"},{"line_number":2538,"context_line":""},{"line_number":2539,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":5,"id":"8ad1d357_10bf070c","line":2536,"range":{"start_line":2536,"start_character":67,"end_line":2536,"end_character":68},"in_reply_to":"85b01375_97000949","updated":"2021-04-22 12:58:22.000000000","message":"Done","commit_id":"865618d7286da50c5ada4cf0fe882dd54a012d7f"}]}