)]}'
{"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c1f9cf1167169c46ca3a4b0c8a99fcd921dad5bb","unresolved":true,"context_lines":[{"line_number":2470,"context_line":"                \u003cloader secure\u003d\u0027yes\u0027 readonly\u003d\u0027yes\u0027 type\u003d\u0027pflash\u0027\u003e/tmp/OVMF_CODE.secboot.fd\u003c/loader\u003e"},{"line_number":2471,"context_line":"              \u003c/os\u003e"},{"line_number":2472,"context_line":"            \u003c/domain\u003e\"\"\",  # noqa: E501"},{"line_number":2473,"context_line":"            xml,"},{"line_number":2474,"context_line":"        )"},{"line_number":2475,"context_line":""},{"line_number":2476,"context_line":"    def _test_config_uefi_autoconfigure(self, secure):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3300b89d_12cf5684","line":2473,"updated":"2021-03-11 15:11:32.000000000","message":"sure, this is better as assertEqual(example, query) but just a nit that wasn\u0027t needed for the modification.","commit_id":"9fff6893ce2ee38d2404a96ecfd240e256fb12c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e28ccfbc986b846771d47f1022a831d508067d6d","unresolved":false,"context_lines":[{"line_number":2470,"context_line":"                \u003cloader secure\u003d\u0027yes\u0027 readonly\u003d\u0027yes\u0027 type\u003d\u0027pflash\u0027\u003e/tmp/OVMF_CODE.secboot.fd\u003c/loader\u003e"},{"line_number":2471,"context_line":"              \u003c/os\u003e"},{"line_number":2472,"context_line":"            \u003c/domain\u003e\"\"\",  # noqa: E501"},{"line_number":2473,"context_line":"            xml,"},{"line_number":2474,"context_line":"        )"},{"line_number":2475,"context_line":""},{"line_number":2476,"context_line":"    def _test_config_uefi_autoconfigure(self, secure):"}],"source_content_type":"text/x-python","patch_set":3,"id":"93183dba_5c0d2994","line":2473,"in_reply_to":"3300b89d_12cf5684","updated":"2021-03-11 15:18:48.000000000","message":"Fair. fwiw, I had additional tests here previously but there were no longer useful. I decided to keep this though since this is correct (the API is \u0027assertEqual(expected, actual)\u0027 and the error message is confusing if you mix them up)","commit_id":"9fff6893ce2ee38d2404a96ecfd240e256fb12c3"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c1f9cf1167169c46ca3a4b0c8a99fcd921dad5bb","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        return xml_str"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __repr__(self):"},{"line_number":88,"context_line":"        return self.to_xml(pretty_print\u003dFalse)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class LibvirtConfigCaps(LibvirtConfigObject):"}],"source_content_type":"text/x-python","patch_set":3,"id":"e7935f16_f5a76c41","line":88,"updated":"2021-03-11 15:11:32.000000000","message":"nit: maybe just a comment explaining why we need to provide a __repr__ method should be nice.","commit_id":"9fff6893ce2ee38d2404a96ecfd240e256fb12c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e28ccfbc986b846771d47f1022a831d508067d6d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        return xml_str"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __repr__(self):"},{"line_number":88,"context_line":"        return self.to_xml(pretty_print\u003dFalse)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class LibvirtConfigCaps(LibvirtConfigObject):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8202ff6_1252d395","line":88,"in_reply_to":"e7935f16_f5a76c41","updated":"2021-03-11 15:18:48.000000000","message":"Fair point. For what it\u0027s worth, this was merely for debugging purposes. Without this, printing the object would result in meaningless output e.g.\n\n  \u003cLibvirtConfigCaps object at 0x7f5c09218500\u003e\n\nI don\u0027t think we log any of these so it won\u0027t be used there, but it should be kept as it\u0027s useful","commit_id":"9fff6893ce2ee38d2404a96ecfd240e256fb12c3"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"961c9ca87a3be1a21efe4df3ed25423775523188","unresolved":true,"context_lines":[{"line_number":5876,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":5877,"context_line":""},{"line_number":5878,"context_line":"                loader, nvram_template \u003d self._host.get_loader("},{"line_number":5879,"context_line":"                    arch, mach_type, has_secure_boot\u003dFalse)"},{"line_number":5880,"context_line":""},{"line_number":5881,"context_line":"                guest.os_loader \u003d loader"},{"line_number":5882,"context_line":"                guest.os_loader_type \u003d \u0027pflash\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"94e8a11d_a8784e91","line":5879,"in_reply_to":"82efd194_8310eb89","updated":"2021-03-09 14:26:01.000000000","message":"\u003e pep8: error: Argument 2 to \"get_loader\" of \"Host\" has incompatible type \"Optional[str]\"; expected \"str\"\n\nPlease fix.","commit_id":"cf23a9f66e65f78d09ff25a7003935cca18ce759"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"94a2ec9ccc8398297879b76630cb3002d4d0a1df","unresolved":false,"context_lines":[{"line_number":5875,"context_line":"                if not self._host.supports_uefi:"},{"line_number":5876,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":5877,"context_line":""},{"line_number":5878,"context_line":"                # TODO(stephenfin): Drop this when we drop support for legacy"},{"line_number":5879,"context_line":"                # architectures"},{"line_number":5880,"context_line":"                if not mach_type:"},{"line_number":5881,"context_line":"                    # loaders are specific to arch and machine type - if we"},{"line_number":5882,"context_line":"                    # don\u0027t have a machine type here, we\u0027re on a legacy"},{"line_number":5883,"context_line":"                    # architecture that we have no default machine type for"},{"line_number":5884,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":5885,"context_line":""},{"line_number":5886,"context_line":"                loader, nvram_template \u003d self._host.get_loader("},{"line_number":5887,"context_line":"                    arch, mach_type, has_secure_boot\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"96b70f42_6b70cb0d","line":5884,"range":{"start_line":5878,"start_character":0,"end_line":5884,"end_character":54},"updated":"2021-03-10 11:56:47.000000000","message":"ACK, seems the reported error listed the wrong argument but this LGTM.","commit_id":"9fff6893ce2ee38d2404a96ecfd240e256fb12c3"}]}