)]}'
{"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f4053008d9d98ce3bf86855b0d0df947390e6890","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        disk_format \u003d image_meta.get(\u0027disk_format\u0027)"},{"line_number":176,"context_line":"        if disk_format not in [\u0027iso\u0027, \u0027vmdk\u0027]:"},{"line_number":177,"context_line":"            msg \u003d _(\u0027Disk format %s is not supported.\u0027) % disk_format"},{"line_number":178,"context_line":"            raise exception.Invalid(msg)"},{"line_number":179,"context_line":"        return disk_format"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FYtE%3D","line":178,"updated":"2014-03-06 13:13:10.000000000","message":"Maybe try a more specific exception:\nhttps://github.com/openstack/nova/blob/master/nova/exception.py#L462","commit_id":"47812b02acbd4aa8eb8fda7c932fa54791733b7b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4c466b783f606018ad3dc175139c1faaa486cc1d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        disk_format \u003d image_meta.get(\u0027disk_format\u0027)"},{"line_number":176,"context_line":"        if disk_format not in [\u0027iso\u0027, \u0027vmdk\u0027]:"},{"line_number":177,"context_line":"            msg \u003d _(\u0027Disk format %s is not supported.\u0027) % disk_format"},{"line_number":178,"context_line":"            raise exception.Invalid(msg)"},{"line_number":179,"context_line":"        return disk_format"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FYdY%3D","line":178,"in_reply_to":"AAAAVn%2F%2FYtE%3D","updated":"2014-03-06 13:57:28.000000000","message":"Done","commit_id":"47812b02acbd4aa8eb8fda7c932fa54791733b7b"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"d1ee0550403dc72438550162ddca8b89e12ffb65","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        disk_format \u003d self._get_disk_format(image_meta)"},{"line_number":212,"context_line":"        # Get the file_type from the disk format"},{"line_number":213,"context_line":"        iso \u003d disk_format \u003d\u003d \u0027iso\u0027"},{"line_number":214,"context_line":"        file_type \u003d \u0027iso\u0027 if iso else \u0027vmdk\u0027"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        client_factory \u003d self._session._get_vim().client.factory"},{"line_number":217,"context_line":"        service_content \u003d self._session._get_vim().get_service_content()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FXvM%3D","line":214,"updated":"2014-03-06 15:22:32.000000000","message":"would be slightly nicer to confine the above 2 lines in the same function and thus keep all the logic dealing with disk formats in the same place but no big deal.","commit_id":"924e8f6cf3bff23ab8879f35b5bf70316bda0cdc"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"b38d4e66cc38bdd3b08369a72b8aea8d99bfffda","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            if block_device_mapping:"},{"line_number":209,"context_line":"                ebs_root \u003d True"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        disk_format \u003d self._get_disk_format(image_meta)"},{"line_number":212,"context_line":"        # Get the file_type from the disk format"},{"line_number":213,"context_line":"        iso \u003d disk_format \u003d\u003d \u0027iso\u0027"},{"line_number":214,"context_line":"        file_type \u003d \u0027iso\u0027 if iso else \u0027vmdk\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FUdY%3D","line":211,"updated":"2014-03-06 21:13:52.000000000","message":"+1 this is good.","commit_id":"2c49d6b35599b1c6ce529510b7bfbe5f81381021"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"b38d4e66cc38bdd3b08369a72b8aea8d99bfffda","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        disk_format \u003d self._get_disk_format(image_meta)"},{"line_number":212,"context_line":"        # Get the file_type from the disk format"},{"line_number":213,"context_line":"        iso \u003d disk_format \u003d\u003d \u0027iso\u0027"},{"line_number":214,"context_line":"        file_type \u003d \u0027iso\u0027 if iso else \u0027vmdk\u0027"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        client_factory \u003d self._session._get_vim().client.factory"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FUc4%3D","line":213,"updated":"2014-03-06 21:13:52.000000000","message":"this is a boolean. is_iso is a better name. \n\nSomething with enum would be better...\n* http://stackoverflow.com/questions/36932/how-can-i-represent-an-enum-in-python\n\nI don\u0027t like this being a naked string or a boolean.","commit_id":"2c49d6b35599b1c6ce529510b7bfbe5f81381021"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9255a940b66454bf60f8a3ef7ce8519edb5643bf","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        disk_format \u003d self._get_disk_format(image_meta)"},{"line_number":212,"context_line":"        # Get the file_type from the disk format"},{"line_number":213,"context_line":"        iso \u003d disk_format \u003d\u003d \u0027iso\u0027"},{"line_number":214,"context_line":"        file_type \u003d \u0027iso\u0027 if iso else \u0027vmdk\u0027"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        client_factory \u003d self._session._get_vim().client.factory"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FRrY%3D","line":213,"in_reply_to":"AAAAVn%2F%2FUc4%3D","updated":"2014-03-07 04:56:27.000000000","message":"Done","commit_id":"2c49d6b35599b1c6ce529510b7bfbe5f81381021"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"b38d4e66cc38bdd3b08369a72b8aea8d99bfffda","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        disk_format \u003d self._get_disk_format(image_meta)"},{"line_number":212,"context_line":"        # Get the file_type from the disk format"},{"line_number":213,"context_line":"        iso \u003d disk_format \u003d\u003d \u0027iso\u0027"},{"line_number":214,"context_line":"        file_type \u003d \u0027iso\u0027 if iso else \u0027vmdk\u0027"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        client_factory \u003d self._session._get_vim().client.factory"},{"line_number":217,"context_line":"        service_content \u003d self._session._get_vim().get_service_content()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FUcI%3D","line":214,"updated":"2014-03-06 21:13:52.000000000","message":"What is this now? is this file_extension? Why isn\u0027t is just disk_format since it\u0027s a string constrained to \u0027iso\u0027 or \u0027vmdk\u0027?","commit_id":"2c49d6b35599b1c6ce529510b7bfbe5f81381021"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9255a940b66454bf60f8a3ef7ce8519edb5643bf","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        disk_format \u003d self._get_disk_format(image_meta)"},{"line_number":212,"context_line":"        # Get the file_type from the disk format"},{"line_number":213,"context_line":"        iso \u003d disk_format \u003d\u003d \u0027iso\u0027"},{"line_number":214,"context_line":"        file_type \u003d \u0027iso\u0027 if iso else \u0027vmdk\u0027"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        client_factory \u003d self._session._get_vim().client.factory"},{"line_number":217,"context_line":"        service_content \u003d self._session._get_vim().get_service_content()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FRrQ%3D","line":214,"in_reply_to":"AAAAVn%2F%2FUcI%3D","updated":"2014-03-07 04:56:27.000000000","message":"Done","commit_id":"2c49d6b35599b1c6ce529510b7bfbe5f81381021"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"07adb16cfa9fd96efba01f87ec5f2a49f0548bc3","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            if block_device_mapping:"},{"line_number":221,"context_line":"                ebs_root \u003d True"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        (file_type, is_iso) \u003d self._get_disk_format(image_meta)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        client_factory \u003d self._session._get_vim().client.factory"},{"line_number":226,"context_line":"        service_content \u003d self._session._get_vim().get_service_content()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2BxDo%3D","line":223,"updated":"2014-03-12 09:57:29.000000000","message":"nit, no need for the brackets here.","commit_id":"f5bc15687bcab1e0e4a2163a194c04bd8c5d14d9"}]}