)]}'
{"id":"openstack%2Fnova~780014","triplet_id":"openstack%2Fnova~stable%2Ftrain~I1d029ebe78b16ed2d4345201b515baf3701533d5","project":"openstack/nova","branch":"stable/train","hashtags":[],"change_id":"I1d029ebe78b16ed2d4345201b515baf3701533d5","subject":"[stable-only] gate: Pin CEPH_RELEASE to nautilus in LM hook","status":"MERGED","created":"2021-03-11 15:17:06.000000000","updated":"2021-03-12 15:08:18.000000000","submitted":"2021-03-12 15:04:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"780014","meta_rev_id":"04a895ea6c8d6f6250cc9d0ae349aee9ca213953","_number":780014,"virtual_id_number":780014,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-12 15:04:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2021-03-11 20:04:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2021-03-12 11:22:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2021-03-12 11:23:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2021-03-12 11:23:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-11 15:57:16.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2021-03-11 19:19:21.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"CC"},{"updated":"2021-03-11 20:03:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-11 20:04:27.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2021-03-12 02:26:13.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-12 11:22:53.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"c5f13280b992312999e546395d86b44187483165","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-11 15:17:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"da74efb2b99a468d11f909479bb59f182f5d297f","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-11 15:26:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4e644131fe50a5f89aaf86ff94389464d7ae6673","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-11 15:40:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dee060befa95801972fd469b5fbb0e8e742151b8","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-03-11 19:19:21.000000000","message":"Patch Set 2:\n\nThis makes sense but I\u0027m not quite clear on, doesn\u0027t this mean any project using ceph on stable branches will be broken, that is, should the version not be pinned in a central place like in the plugin itself so that all get the needed pinning?","accounts_in_message":[],"_revision_number":2},{"id":"d102347c002a0098ee71769edabde2d837179241","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-03-11 19:35:21.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e This makes sense but I\u0027m not quite clear on, doesn\u0027t this mean any project using ceph on stable branches will be broken, that is, should the version not be pinned in a central place like in the plugin itself so that all get the needed pinning?\n\nMore specifically, I\u0027m thinking of the $TARGET_BRANCH related code in:\n\nhttps://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/plugin.sh\n\nand\n\nhttps://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/lib/ceph\n\nI think I just need some help understanding why we should pin the release per project and not set a working default for all somewhere in the plugin if $TARGET_BRANCH is one that cannot tolerate a newer ceph version.","accounts_in_message":[],"_revision_number":2},{"id":"0cf3e4b517ca9ceebe6098a29c793d7114436cf8","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-11 19:38:36.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e This makes sense but I\u0027m not quite clear on, doesn\u0027t this mean any project using ceph on stable branches will be broken, that is, should the version not be pinned in a central place like in the plugin itself so that all get the needed pinning?\n\nApologies I tried to explain this in the commit, the plugin based jobs are pinned. nova-live-migration and nova-grenade-multinode however are not based on these jobs and manually configure ceph via the hook scripts I\u0027ve modified here. It actually resulted in these jobs using an older release that I don\u0027t think was intended tbh.\n\nFWIW I\u0027m trying to replace both of these in master with plugin derived jobs.","accounts_in_message":[],"_revision_number":2},{"id":"4e0d13d8cf38656e7578dbb1d116e8785506fa27","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-03-11 19:46:09.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e This makes sense but I\u0027m not quite clear on, doesn\u0027t this mean any project using ceph on stable branches will be broken, that is, should the version not be pinned in a central place like in the plugin itself so that all get the needed pinning?\n\u003e \n\u003e Apologies I tried to explain this in the commit, the plugin based jobs are pinned. nova-live-migration and nova-grenade-multinode however are not based on these jobs and manually configure ceph via the hook scripts I\u0027ve modified here. It actually resulted in these jobs using an older release that I don\u0027t think was intended tbh.\n\u003e \n\u003e FWIW I\u0027m trying to replace both of these in master with plugin derived jobs.\n\nOh, I\u0027m sorry I didn\u0027t understand what you were trying to explain in the commit message 😞\n\nI didn\u0027t make the connection on jobs based on the plugin jobs vs not, but, I think what I\u0027m wondering is why wouldn\u0027t it be something like:\n\n if [[ \"$TARGET_BRANCH\" \u003d~ stable/train ]]; then\n     CEPH_RELEASE\u003dnautilus\n fi\n\nnear:\n\nhttps://github.com/openstack/devstack-plugin-ceph/blob/4c23af18d05f0f9f68f6abf14c6413ca357a924e/devstack/lib/ceph#L136\n\nI\u0027m sure there\u0027s a good reason not to, just want to understand it before going ahead.","accounts_in_message":[],"_revision_number":2},{"id":"9636e8a08647ea7ddc01091b19375f61b8257a53","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-11 19:59:01.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 2:\n\u003e \u003e \u003e \n\u003e \u003e \u003e This makes sense but I\u0027m not quite clear on, doesn\u0027t this mean any project using ceph on stable branches will be broken, that is, should the version not be pinned in a central place like in the plugin itself so that all get the needed pinning?\n\u003e \u003e \n\u003e \u003e Apologies I tried to explain this in the commit, the plugin based jobs are pinned. nova-live-migration and nova-grenade-multinode however are not based on these jobs and manually configure ceph via the hook scripts I\u0027ve modified here. It actually resulted in these jobs using an older release that I don\u0027t think was intended tbh.\n\u003e \u003e \n\u003e \u003e FWIW I\u0027m trying to replace both of these in master with plugin derived jobs.\n\u003e \n\u003e Oh, I\u0027m sorry I didn\u0027t understand what you were trying to explain in the commit message 😞\n\u003e \n\u003e I didn\u0027t make the connection on jobs based on the plugin jobs vs not, but, I think what I\u0027m wondering is why wouldn\u0027t it be something like:\n\u003e \n\u003e  if [[ \"$TARGET_BRANCH\" \u003d~ stable/train ]]; then\n\u003e      CEPH_RELEASE\u003dnautilus\n\u003e  fi\n\u003e \n\u003e near:\n\u003e \n\u003e https://github.com/openstack/devstack-plugin-ceph/blob/4c23af18d05f0f9f68f6abf14c6413ca357a924e/devstack/lib/ceph#L136\n\u003e \n\u003e I\u0027m sure there\u0027s a good reason not to, just want to understand it before going ahead.\n\nThat also works but Nova is the only project (ab)using the plugin like this, cloning and executing outside of the plugin provided zuul jobs that already pin the release per branch through CEPH_RELEASE.\n\nI don\u0027t mind which way we go tbh.","accounts_in_message":[],"_revision_number":2},{"id":"efcdf23813efc243f8c0911ef9580548399510bc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-11 20:03:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/2e4446698c7048ccaa974b5c055aa902 : SUCCESS in 1h 12m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3336b1d2f04348ed9597dabf6c2ccd5b : SUCCESS in 13m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c972022f39694f6c940d8cd194271ae0 : SUCCESS in 18m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/51b71c7fad844041b8e8fc6803bb52bf : SUCCESS in 12m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/673b7ce56558488c9895d06a5f38698f : SUCCESS in 14m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/87809b0dae1646c7a13d1bc8792940a3 : SUCCESS in 14m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/534ca3dbdf1946289220b8bdef6043f7 : SUCCESS in 14m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f722c7262eca4ba7964b6f55fe29439c : SUCCESS in 13m 50s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/addc37064e7e414f99e7e09cd46ba358 : SUCCESS in 1h 13m 15s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/f0f1ac98d74b421f88be4baabdef2efe : SUCCESS in 1h 16m 22s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/7fe4338e78c04275aa68f89f9c168616 : SUCCESS in 55m 30s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/0077be6e0f2b4aadba06af537ccfec7c : SUCCESS in 1h 12m 30s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/0e8680344dfc4438bbfd66f99e82f599 : SUCCESS in 47m 25s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ee18b913e3314cdc925ca2476745f9f7 : SUCCESS in 1h 37m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/052c478b2eda4054891770eccf4c0103 : SUCCESS in 1h 18m 48s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/77487893bae641429f2371a6bc85a612 : SUCCESS in 21m 26s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/fcf706aeaa8a403dbe31ac341860253b : SUCCESS in 24m 17s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/df1b876b0f8a472b868d0845c42f344d : SUCCESS in 1h 56m 29s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/13df2babfeeb43b98cc4df25e5807ebd : SUCCESS in 57m 26s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/07c710c3ca954278a408ac08576e9f87 : SUCCESS in 53m 17s","accounts_in_message":[],"_revision_number":2},{"id":"f3e0171283b225dbe267139b5568b04dcf3dd4eb","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-03-11 20:04:27.000000000","message":"Patch Set 2: Code-Review+2\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 2:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 2:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e This makes sense but I\u0027m not quite clear on, doesn\u0027t this mean any project using ceph on stable branches will be broken, that is, should the version not be pinned in a central place like in the plugin itself so that all get the needed pinning?\n\u003e \u003e \u003e \n\u003e \u003e \u003e Apologies I tried to explain this in the commit, the plugin based jobs are pinned. nova-live-migration and nova-grenade-multinode however are not based on these jobs and manually configure ceph via the hook scripts I\u0027ve modified here. It actually resulted in these jobs using an older release that I don\u0027t think was intended tbh.\n\u003e \u003e \u003e \n\u003e \u003e \u003e FWIW I\u0027m trying to replace both of these in master with plugin derived jobs.\n\u003e \u003e \n\u003e \u003e Oh, I\u0027m sorry I didn\u0027t understand what you were trying to explain in the commit message 😞\n\u003e \u003e \n\u003e \u003e I didn\u0027t make the connection on jobs based on the plugin jobs vs not, but, I think what I\u0027m wondering is why wouldn\u0027t it be something like:\n\u003e \u003e \n\u003e \u003e  if [[ \"$TARGET_BRANCH\" \u003d~ stable/train ]]; then\n\u003e \u003e      CEPH_RELEASE\u003dnautilus\n\u003e \u003e  fi\n\u003e \u003e \n\u003e \u003e near:\n\u003e \u003e \n\u003e \u003e https://github.com/openstack/devstack-plugin-ceph/blob/4c23af18d05f0f9f68f6abf14c6413ca357a924e/devstack/lib/ceph#L136\n\u003e \u003e \n\u003e \u003e I\u0027m sure there\u0027s a good reason not to, just want to understand it before going ahead.\n\u003e \n\u003e That also works but Nova is the only project (ab)using the plugin like this, cloning and executing outside of the plugin provided zuul jobs that already pin the release per branch through CEPH_RELEASE.\n\u003e \n\u003e I don\u0027t mind which way we go tbh.\n\nOK, so we are an outlier doing something unrecommended. That makes it clear for me, thanks for explaining all of it. I think this approach makes better sense if we have set up our jobs in a way different than everyone else.\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"d0643dfc0151677ebfc5b8d30cd217ddbf60c855","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-11 20:14:11.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review+2\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 2:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 2:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 2:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e This makes sense but I\u0027m not quite clear on, doesn\u0027t this mean any project using ceph on stable branches will be broken, that is, should the version not be pinned in a central place like in the plugin itself so that all get the needed pinning?\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Apologies I tried to explain this in the commit, the plugin based jobs are pinned. nova-live-migration and nova-grenade-multinode however are not based on these jobs and manually configure ceph via the hook scripts I\u0027ve modified here. It actually resulted in these jobs using an older release that I don\u0027t think was intended tbh.\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e FWIW I\u0027m trying to replace both of these in master with plugin derived jobs.\n\u003e \u003e \u003e \n\u003e \u003e \u003e Oh, I\u0027m sorry I didn\u0027t understand what you were trying to explain in the commit message 😞\n\u003e \u003e \u003e \n\u003e \u003e \u003e I didn\u0027t make the connection on jobs based on the plugin jobs vs not, but, I think what I\u0027m wondering is why wouldn\u0027t it be something like:\n\u003e \u003e \u003e \n\u003e \u003e \u003e  if [[ \"$TARGET_BRANCH\" \u003d~ stable/train ]]; then\n\u003e \u003e \u003e      CEPH_RELEASE\u003dnautilus\n\u003e \u003e \u003e  fi\n\u003e \u003e \u003e \n\u003e \u003e \u003e near:\n\u003e \u003e \u003e \n\u003e \u003e \u003e https://github.com/openstack/devstack-plugin-ceph/blob/4c23af18d05f0f9f68f6abf14c6413ca357a924e/devstack/lib/ceph#L136\n\u003e \u003e \u003e \n\u003e \u003e \u003e I\u0027m sure there\u0027s a good reason not to, just want to understand it before going ahead.\n\u003e \u003e \n\u003e \u003e That also works but Nova is the only project (ab)using the plugin like this, cloning and executing outside of the plugin provided zuul jobs that already pin the release per branch through CEPH_RELEASE.\n\u003e \u003e \n\u003e \u003e I don\u0027t mind which way we go tbh.\n\u003e \n\u003e OK, so we are an outlier doing something unrecommended. That makes it clear for me, thanks for explaining all of it. I think this approach makes better sense if we have set up our jobs in a way different than everyone else.\n\u003e \n\u003e LGTM\n\nThanks and apologies again for not making this all clear in the commit.","accounts_in_message":[],"_revision_number":2},{"id":"9e7e6972132d593e75de4266fa3df89822e77f65","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-03-12 02:26:13.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/780014/2/check/tempest-dsvm-full-bionic-py3/8aa36fa/ : SUCCESS in 1h 54m 45s","accounts_in_message":[],"_revision_number":2},{"id":"d115370352e55e7ba329e79a4e11b17c3d266248","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-03-12 11:22:53.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nwe discussed a few options for this on irc yesterday such as pinning the ceph plugin to a specific commit amoung other options. this uses a native facility of the plug to choose the ceph verision to install which i think is a reasonable way to approch this problem the only caveat i would have is that we need to ensure that the ceph plugin is not modified in a backward incompatable way going forward that would break nautilus support unless we also pin.\n\nthis makes sense to me however and we can cross pinning the version later if we need too.","accounts_in_message":[],"_revision_number":2},{"id":"46a2ef578b077252a47e08728e7ed1f86c350fd5","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-03-12 11:23:29.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nCI fix patch, unblocks stable/train. To pin ceph release to \u0027nautilus\u0027 looks OK to me.","accounts_in_message":[],"_revision_number":2},{"id":"290245d98049fbfa30fcfb9e7ed9da141389188d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-12 11:23:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"af59fbe4b630a5f26af9f04dfa626e388d94553b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-12 15:04:07.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0e9c09b658f345b196fe5909a3b2630f : SUCCESS in 1h 32m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/eb81c8bb40aa4ea49d7d88d23b8d57a9 : SUCCESS in 16m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c57f42067ccd4ac4913dbf608068ad49 : SUCCESS in 11m 55s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8c8f1a06f787492f97476c307a3d06a0 : SUCCESS in 15m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c399b0553e76443d9a9301ef31ac1075 : SUCCESS in 13m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2d0887ec5aeb4a66a23a4b56e25129d4 : SUCCESS in 16m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7893e879182b4b26812042726c8a5c6a : SUCCESS in 10m 36s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/cb2bb58584134ed68f0e6af01a72da5b : SUCCESS in 1h 04m 05s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ed5336d9ed6a4e91acd1f3560844a455 : SUCCESS in 46m 46s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/132b5505ba7142db99a5353b9bf87ace : SUCCESS in 21m 40s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/ccd87953faca42379741a1d1459808b6 : SUCCESS in 19m 40s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/11f009831d8049d0bbf2c1ee7ec7ccf1 : SUCCESS in 1h 17m 55s\n- nova-next https://zuul.opendev.org/t/openstack/build/323690ec26604bf397a8a6e8f18e11a6 : SUCCESS in 1h 17m 26s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/2fc87fce8f984635a7f5783765825640 : SUCCESS in 2h 16m 55s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/8c4fde3606464d08b6c53e1b17290fbe : SUCCESS in 1h 03m 10s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/584da9f916ac485584ebaddc98978cdf : SUCCESS in 57m 20s","accounts_in_message":[],"_revision_number":2},{"id":"d2fd10a1f27ebb024ae59c12fa3336d997470946","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-12 15:04:08.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"04a895ea6c8d6f6250cc9d0ae349aee9ca213953","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-12 15:08:18.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5dfc17739ac343c89b481c9e42db58d2 : SUCCESS in 54s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ff570d1b4e9b9777405ae75cc09eae2ce255bf19","revisions":{"ecf781da84187f95e079e18689d89434e0107cf2":{"kind":"REWORK","_number":1,"created":"2021-03-11 15:17:06.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/14/780014/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/780014/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/780014/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/780014/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/780014/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/780014/1"}}},"commit":{"parents":[{"commit":"e39e622cb004b7f8e986efe2ee814a3526205b82","subject":"Merge \"Disallow CONF.compute.max_disk_devices_to_attach \u003d 0\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e39e622cb004b7f8e986efe2ee814a3526205b82"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-11 15:08:12.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-11 15:16:29.000000000","tz":0},"subject":"[stable-only] gate: Skip ceph tests after plugin moved to Octopus release","message":"[stable-only] gate: Skip ceph tests after plugin moved to Octopus release\n\nI1edd5a50079f325fa143a7e0d51b3aa3bb5ed45d moved the branchless\ndevstack-plugin-ceph project to the Octopus release of Ceph that drops\nsupport for py2. As this was still the default on stable/train this\nbreaks the nova-live-migration and nova-grenade jobs.\n\nThis change works around this by skipping the ceph tests within the live\nmigration hook used by both of these jobs.\n\nNote that the devstack-plugin-ceph-tempest job from the plugin repo\ncontinues to pass as it is correctly pinned to the Luminous release that\nsupports py2.\n\nIf anything the above enforces the need to move away from these hook\nscripts and instead inherit our base ceph jobs from this repo in the\nfuture to avoid the Ceph release jumping around like this.\n\nChange-Id: I1d029ebe78b16ed2d4345201b515baf3701533d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ecf781da84187f95e079e18689d89434e0107cf2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ecf781da84187f95e079e18689d89434e0107cf2"}]},"branch":"refs/heads/stable/train"},"ff570d1b4e9b9777405ae75cc09eae2ce255bf19":{"kind":"REWORK","_number":2,"created":"2021-03-11 15:40:03.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/14/780014/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/780014/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/780014/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/780014/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/780014/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/780014/2"}}},"commit":{"parents":[{"commit":"e39e622cb004b7f8e986efe2ee814a3526205b82","subject":"Merge \"Disallow CONF.compute.max_disk_devices_to_attach \u003d 0\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e39e622cb004b7f8e986efe2ee814a3526205b82"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-11 15:08:12.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-11 15:38:12.000000000","tz":0},"subject":"[stable-only] gate: Pin CEPH_RELEASE to nautilus in LM hook","message":"[stable-only] gate: Pin CEPH_RELEASE to nautilus in LM hook\n\nI1edd5a50079f325fa143a7e0d51b3aa3bb5ed45d moved the branchless\ndevstack-plugin-ceph project to the Octopus release of Ceph that drops\nsupport for py2. As this was still the default on stable/train this\nbreaks the nova-live-migration and nova-grenade jobs.\n\nThis change works around this by pinning the CEPH_RELEASE to nautilus\nwithin the LM hook as was previously used prior to the above landing.\n\nNote that the devstack-plugin-ceph-tempest job from the plugin repo\ncontinues to pass as it is correctly pinned to the Luminous release that\nsupports py2.\n\nIf anything the above enforces the need to move away from these hook\nscripts and instead inherit our base ceph jobs from this repo in the\nfuture to avoid the Ceph release jumping around like this.\n\nChange-Id: I1d029ebe78b16ed2d4345201b515baf3701533d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ff570d1b4e9b9777405ae75cc09eae2ce255bf19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ff570d1b4e9b9777405ae75cc09eae2ce255bf19"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}