)]}'
{"id":"openstack%2Fnova~780780","triplet_id":"openstack%2Fnova~stable%2Fussuri~I17357d85f845d4160cb7c7784772530a1e92af76","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1885528","hashtags":[],"change_id":"I17357d85f845d4160cb7c7784772530a1e92af76","subject":"Make _rebase_with_qemu_img() generic","status":"MERGED","created":"2021-03-16 10:54:38.000000000","updated":"2021-03-31 10:42:23.000000000","submitted":"2021-03-31 10:39:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"780780-bug/1885528","meta_rev_id":"3baab207922e7995387644367b6843935d3da3ab","_number":780780,"virtual_id_number":780780,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-31 10:39:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2021-03-31 00:33:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2021-03-24 16:55:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2021-03-31 00:33:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"}],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-16 10:54:38.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"state":"REVIEWER"},{"updated":"2021-03-16 12:43:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-16 14:13:01.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-24 16:55:39.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2021-03-31 00:33:29.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"}],"messages":[{"id":"ef76d5d912eba10bebcbf30f28aaec9e13b4d046","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-16 10:54:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"64d43319962be4a2c0da60388b0b8b5556efaa66","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-16 12:43:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1b316ea516c94f80add89fe1bbef4add : SUCCESS in 1h 19m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d7fbe90132ba4b619478d0ce19e62243 : SUCCESS in 19m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c4a128b1d67d4d48ba8581da6d2e950e : SUCCESS in 27m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a4a0e4d15fa24fb0b11679587150032b : SUCCESS in 7m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8f5ed8749b52435d8e5f311c1ba06dde : SUCCESS in 17m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/542d5d5ce9ce4a2b954c6034072002df : SUCCESS in 10m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/22a7f0f830114b0f86938681e7f5a70c : SUCCESS in 13m 38s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/0cea08e3737f4e68913aef71d0f18054 : SUCCESS in 1h 31m 33s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/255b0583867b4b37a57436390290a3f9 : SUCCESS in 1h 32m 24s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/9a2c5aff6d14429580e8103ea4d49558 : SUCCESS in 1h 39m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/04f42187fa98417c843f00a1fcda98f0 : SUCCESS in 43m 37s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/8a6dcaf248a44cb7886aca47a07e17d3 : FAILURE in 1h 10m 16s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ba163282b272405fb21594f6f20319e8 : SUCCESS in 1h 29m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/84de2b00fec94b0c94576f58c9f14f51 : SUCCESS in 1h 33m 42s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/a769e468b26a449ca05598e765c3039b : SUCCESS in 21m 08s\n- grenade https://zuul.opendev.org/t/openstack/build/ff3645e657574bc3a621cadda9206951 : SUCCESS in 1h 13m 45s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f70e6b52d656419cb013b6de99758325 : SUCCESS in 1h 04m 53s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/70f44972707e4c42bccaf73f0e6a7947 : SUCCESS in 59m 10s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/0648f67dbddc4eebb8421aea6eeb93ab : FAILURE in 28m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fbd8ef39ed55f9b021ac832a2303ea300250bd59","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-03-16 14:13:01.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/80/780780/1/check/tempest-dsvm-full-bionic/a90724e/ : SUCCESS in 2h 28m 38s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/80/780780/1/check/tempest-dsvm-full-bionic-py3/f206654/ : SUCCESS in 2h 12m 45s","accounts_in_message":[],"_revision_number":1},{"id":"091984f999ead3041f2dd465fef331a2ef19432f","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-03-24 16:55:39.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry-pick from victoria, where the patch has merged. Actually, this patch was made to the fix of bug/1732428, but now needed for the fix of bug/1885528 to be a clean cherry-pick. Nevertheless, looks OK to backport.","accounts_in_message":[],"_revision_number":1},{"id":"403096e83cd956a91c44a73fd50392b23a7f1844","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-03-24 16:56:00.000000000","message":"Topic set to bug/1885528","accounts_in_message":[],"_revision_number":1},{"id":"ab71ac7c505e0050e82777001193d4a668b8a9a8","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-03-31 00:33:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport from victoria where the original change merged, this is a code refactor that prevents merge conflicts for the bug fix above it, LGTM","accounts_in_message":[],"_revision_number":1},{"id":"2c2cb402fa9071e945c9acd3fce7876122d4cc7e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 07:08:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"111b30242a406b157b02a31ec4357de68f04d55a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 10:39:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/9a271328ff5c4fc5b54e39677d770214 : SUCCESS in 2h 03m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e8b6b8d001e34455825a46708b72e982 : SUCCESS in 15m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/623ded1920184836a520df08cb6383dc : SUCCESS in 8m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d9dab1fd3ab840abb7cd4663cfeb8780 : SUCCESS in 17m 04s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ba4e687f5a6341e88ab3c6ded5040e0e : SUCCESS in 18m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6a7f89c014064f4dac2570d11f239132 : SUCCESS in 14m 59s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/cb9ed1aa72274dddbc05c6d10adc6bba : SUCCESS in 1h 42m 29s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f1ce5cda304b45e5b63a134791000cc1 : SUCCESS in 54m 28s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/67bcea8cfc194500bcc9a765b697e8f9 : SUCCESS in 17m 49s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/8dba587ee7b84ebbbf5d2d02ed227534 : SUCCESS in 1h 28m 55s\n- nova-next https://zuul.opendev.org/t/openstack/build/221ecd0909104a9cad88e2c600b6bfa0 : SUCCESS in 1h 27m 58s\n- grenade https://zuul.opendev.org/t/openstack/build/1b96bdb7491a47a4af64ed509c1268c8 : SUCCESS in 1h 11m 33s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/451fd2bf7bbe454f9ba04cafafaf15bf : SUCCESS in 1h 23m 36s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7229f82f55594d7c9cb8bca227137193 : SUCCESS in 40m 55s","accounts_in_message":[],"_revision_number":1},{"id":"966a05e0d1a70d7b88f55fc855ce08ff950a4361","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 10:39:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3baab207922e7995387644367b6843935d3da3ab","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 10:42:23.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca2c826671f642cf87ec310442e88523 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2e89699c3301bf801784c637b6919752fcd3503f","revisions":{"2e89699c3301bf801784c637b6919752fcd3503f":{"kind":"REWORK","_number":1,"created":"2021-03-16 10:54:38.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/80/780780/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/80/780780/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/80/780780/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/80/780780/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/80/780780/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/80/780780/1"}}},"commit":{"parents":[{"commit":"8cbb35521aa374bd424bb4ec29cc67cefa8ab646","subject":"Merge \"Handle instance \u003d None in _local_delete_cleanup\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8cbb35521aa374bd424bb4ec29cc67cefa8ab646"}]}],"author":{"name":"Alexandre Arents","email":"alexandre.arents@corp.ovh.com","date":"2019-11-26 10:26:32.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-16 10:53:28.000000000","tz":0},"subject":"Make _rebase_with_qemu_img() generic","message":"Make _rebase_with_qemu_img() generic\n\nMove volume_delete related logic away from this method, in order to make\nit generic and usable elsewhere.\n\nChange-Id: I17357d85f845d4160cb7c7784772530a1e92af76\nRelated-Bug: #1732428\n(cherry picked from commit ce2203456660083119cdbb7e73c1ad15e6e0a074)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2e89699c3301bf801784c637b6919752fcd3503f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2e89699c3301bf801784c637b6919752fcd3503f"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}