)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14af5997f60816fefd1c99a351cd987eaf347268","unresolved":true,"context_lines":[{"line_number":10695,"context_line":"            # if we got here it was due to a reschedule from the compute and"},{"line_number":10696,"context_line":"            # the request spec would already have the new flavor in it from the"},{"line_number":10697,"context_line":"            # else block below."},{"line_number":10698,"context_line":"        self.manager.prep_resize(context, image, instance, instance_type,"},{"line_number":10699,"context_line":"                                 request_spec, filter_properties, node,"},{"line_number":10700,"context_line":"                                 clean_shutdown, migration, host_list)"},{"line_number":10701,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0fe8162f_5e7e45dc","line":10698,"range":{"start_line":10698,"start_character":59,"end_line":10698,"end_character":72},"updated":"2021-03-25 08:59:16.000000000","message":"here you\u0027re fortunate that we don\u0027t provide the argument name as a keyword or this wouldn\u0027t work...","commit_id":"5b0253e8cd25561f914c921d287650a14f9ee014"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14af5997f60816fefd1c99a351cd987eaf347268","unresolved":true,"context_lines":[{"line_number":10701,"context_line":""},{"line_number":10702,"context_line":"    # 5.2 support for optional request_spec argument"},{"line_number":10703,"context_line":"    def resize_instance(self, context, instance, image,"},{"line_number":10704,"context_line":"                        migration, instance_type, clean_shutdown,"},{"line_number":10705,"context_line":"                        request_spec\u003dNone):"},{"line_number":10706,"context_line":"        self.manager.resize_instance(context, instance, image,"},{"line_number":10707,"context_line":"                                    migration, instance_type, clean_shutdown,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce821bce_bbb142c2","line":10704,"range":{"start_line":10704,"start_character":35,"end_line":10704,"end_character":48},"updated":"2021-03-25 08:59:16.000000000","message":"ditto","commit_id":"5b0253e8cd25561f914c921d287650a14f9ee014"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb57e29ad52997634d1aab30c80465b905011294","unresolved":false,"context_lines":[{"line_number":960,"context_line":"                    \u0027clean_shutdown\u0027: clean_shutdown,"},{"line_number":961,"context_line":"                    \u0027host_list\u0027: host_list}"},{"line_number":962,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":963,"context_line":"        version \u003d self._ver(ctxt, \u00275.1\u0027)"},{"line_number":964,"context_line":"        if not client.can_send_version(version):"},{"line_number":965,"context_line":"            msg_args[\u0027request_spec\u0027] \u003d ("},{"line_number":966,"context_line":"                request_spec.to_legacy_request_spec_dict())"}],"source_content_type":"text/x-python","patch_set":2,"id":"0f102238_88c03aaf","side":"PARENT","line":963,"updated":"2021-03-24 17:11:02.000000000","message":"Note for reviewers: _ver is very simple and checks if we can support 6.0, returning that version if so. Therefore this line could be replaced with:\n\n  version \u003d \u00276.0\u0027\n  if not client.can_send_version(version):\n      version \u003d \u00275.1\u0027\n\nCombined with the below, this ends up looking like:\n\n  version \u003d \u00276.0\u0027\n  if not client.can_send_version(version):\n      version \u003d \u00275.1\u0027\n      if not client.can_send_version(version):\n          msg_args[\u0027request_spec\u0027] \u003d (\n              request_spec.to_legacy_request_spec_dict())\n          version \u003d \u00275.0\u0027\n\nThis means...","commit_id":"340690fb00dfaf69760ed8429c9a41aa142c27e5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb57e29ad52997634d1aab30c80465b905011294","unresolved":false,"context_lines":[{"line_number":961,"context_line":"                    \u0027clean_shutdown\u0027: clean_shutdown,"},{"line_number":962,"context_line":"                    \u0027host_list\u0027: host_list}"},{"line_number":963,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":964,"context_line":"        if not client.can_send_version(version):"},{"line_number":965,"context_line":"            version \u003d \u00275.1\u0027"},{"line_number":966,"context_line":"            del msg_args[\u0027flavor\u0027]"},{"line_number":967,"context_line":"            msg_args[\u0027instance_type\u0027] \u003d instance_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6f6dca9_a856b727","line":964,"updated":"2021-03-24 17:11:02.000000000","message":"...all we\u0027re actually doing here is adding an additional bit of logic inside that first if-block\n\n  del msg_args[\u0027flavor\u0027]\n  msg_args[\u0027instance_type\u0027] \u003d instance_type\n\nSo\n\n  version \u003d \u00276.0\u0027\n  if not client.can_send_version(version):\n      version \u003d \u00275.1\u0027\n      if not client.can_send_version(version):\n          msg_args[\u0027request_spec\u0027] \u003d (\n              request_spec.to_legacy_request_spec_dict())\n          version \u003d \u00275.0\u0027\n\nfrom before is becoming:\n\n  version \u003d \u00276.0\u0027\n  if not client.can_send_version(version):\n      version \u003d \u00275.1\u0027\n      del msg_args[\u0027flavor\u0027]\n      msg_args[\u0027instance_type\u0027] \u003d instance_typ\n      if not client.can_send_version(version):\n          msg_args[\u0027request_spec\u0027] \u003d (\n              request_spec.to_legacy_request_spec_dict())\n          version \u003d \u00275.0\u0027\n\nThis would be ever so slightly more obvious if it weren\u0027t for the \u0027_ver\u0027 helper so hopefully this helps 😊","commit_id":"5b0253e8cd25561f914c921d287650a14f9ee014"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb57e29ad52997634d1aab30c80465b905011294","unresolved":false,"context_lines":[{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"            if not client.can_send_version(version):"},{"line_number":1150,"context_line":"                msg_args.pop(\u0027request_spec\u0027)"},{"line_number":1151,"context_line":"                version \u003d \u00275.0\u0027"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"        cctxt \u003d client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":1154,"context_line":"                version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e14fe5c7_2875d8e1","line":1151,"updated":"2021-03-24 17:11:02.000000000","message":"As above.","commit_id":"5b0253e8cd25561f914c921d287650a14f9ee014"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14af5997f60816fefd1c99a351cd987eaf347268","unresolved":true,"context_lines":[{"line_number":4695,"context_line":"        instance.task_state \u003d task_states.RESIZE_PREP"},{"line_number":4696,"context_line":"        instance.save()"},{"line_number":4697,"context_line":"        self.compute.prep_resize(self.context, instance\u003dinstance,"},{"line_number":4698,"context_line":"                                 flavor\u003dinstance_type,"},{"line_number":4699,"context_line":"                                 image\u003d{}, request_spec\u003d{},"},{"line_number":4700,"context_line":"                                 filter_properties\u003d{}, node\u003dNone,"},{"line_number":4701,"context_line":"                                 migration\u003dNone, clean_shutdown\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"76e790af_3bde51b0","line":4698,"updated":"2021-03-25 08:59:16.000000000","message":"yeah...","commit_id":"5b0253e8cd25561f914c921d287650a14f9ee014"}],"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb57e29ad52997634d1aab30c80465b905011294","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            request_spec\u003drequest_spec.to_legacy_request_spec_dict(),"},{"line_number":567,"context_line":"            filter_properties\u003d{\u0027fakeprop\u0027: \u0027fakeval\u0027},"},{"line_number":568,"context_line":"            migration\u003d\u0027migration\u0027,"},{"line_number":569,"context_line":"            node\u003d\u0027node\u0027, clean_shutdown\u003dTrue, host_list\u003dNone)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    def test_prep_snapshot_based_resize_at_dest(self):"},{"line_number":572,"context_line":"        \"\"\"Tests happy path for prep_snapshot_based_resize_at_dest rpc call\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"979282b0_6efbe867","line":569,"updated":"2021-03-24 17:11:02.000000000","message":"This test should probably have existed previously since there is already some logic in the client (the conversion of the request spec)","commit_id":"5b0253e8cd25561f914c921d287650a14f9ee014"}]}