)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"121d3a6b64761a96882b2854fe138d7eeefdc72a","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"There\u0027s a possibility, however slight, that some people are using"},{"line_number":26,"context_line":"namespaces that match actual nova namespaces such as \u0027hw\u0027 and a"},{"line_number":27,"context_line":"separator of \u0027_\u0027, but those will continue to work just fine. Setting"},{"line_number":28,"context_line":"anything else will result in the scheduler filter failing since the"},{"line_number":29,"context_line":"image property will always appear to be absent. As a result, these could"},{"line_number":30,"context_line":"be outright removed rather than deprecated. We choose to deprecate just"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f849519a_87389952","line":27,"updated":"2021-03-26 17:55:54.000000000","message":"i didnt think of this case ya they could have but ya it wont break so that is ok.","commit_id":"052f22462a4e8d1c81341192406036fba92bd072"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa56988fd459949669882d66e536eb908f18bb4f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"There\u0027s a possibility, however slight, that some people are using"},{"line_number":26,"context_line":"namespaces that match actual nova namespaces such as \u0027hw\u0027 and a"},{"line_number":27,"context_line":"separator of \u0027_\u0027, but those will continue to work just fine. Setting"},{"line_number":28,"context_line":"anything else will result in the scheduler filter failing since the"},{"line_number":29,"context_line":"image property will always appear to be absent. As a result, these could"},{"line_number":30,"context_line":"be outright removed rather than deprecated. We choose to deprecate just"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e38f42e9_e0dec1b6","line":27,"in_reply_to":"f849519a_87389952","updated":"2026-02-26 11:10:33.000000000","message":"Done","commit_id":"052f22462a4e8d1c81341192406036fba92bd072"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa56988fd459949669882d66e536eb908f18bb4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"94cc38f7_043eab82","updated":"2026-02-26 11:10:33.000000000","message":"This has been here way too long and is a no-op at runtime. Let\u0027s get it in.","commit_id":"fcbedce5581707036626ae7afb94f998ea8ff389"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e07f1f4c4642aef49f65008cc2d79f8ee6699204","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5e0a0f50_c20cbb38","updated":"2026-02-26 22:53:30.000000000","message":"recheck","commit_id":"fcbedce5581707036626ae7afb94f998ea8ff389"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"949533bafb5f5dd5ddddb1fa384ab84a1a8ae67e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f1a34513_59e86307","updated":"2026-02-27 11:15:05.000000000","message":"recheck","commit_id":"fcbedce5581707036626ae7afb94f998ea8ff389"}],"nova/conf/scheduler.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f21d9bf85581531fdd02aa38cc7877ecace44118","unresolved":true,"context_lines":[{"line_number":747,"context_line":"        \"aggregate_image_properties_isolation_namespace\","},{"line_number":748,"context_line":"        deprecated_group\u003d\"DEFAULT\","},{"line_number":749,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":750,"context_line":"        deprecated_since\u003d\"28.0.0\","},{"line_number":751,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":752,"context_line":"It no longer possible to filter on arbitrary image metadata properties. Support"},{"line_number":753,"context_line":"for this was removed in 12.0.0 (Liberty). As a result, this option is no longer"}],"source_content_type":"text/x-python","patch_set":3,"id":"c602bf9f_8f9d6b78","line":750,"updated":"2023-06-23 11:02:11.000000000","message":"i just rebased this and updated the number","commit_id":"e9aec3cb667913ed5bdc5240f55ac55bbca792bd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa56988fd459949669882d66e536eb908f18bb4f","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        \"aggregate_image_properties_isolation_namespace\","},{"line_number":748,"context_line":"        deprecated_group\u003d\"DEFAULT\","},{"line_number":749,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":750,"context_line":"        deprecated_since\u003d\"28.0.0\","},{"line_number":751,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":752,"context_line":"It no longer possible to filter on arbitrary image metadata properties. Support"},{"line_number":753,"context_line":"for this was removed in 12.0.0 (Liberty). As a result, this option is no longer"}],"source_content_type":"text/x-python","patch_set":3,"id":"4aa715f6_93d80129","line":750,"in_reply_to":"c602bf9f_8f9d6b78","updated":"2026-02-26 11:10:33.000000000","message":"Done","commit_id":"e9aec3cb667913ed5bdc5240f55ac55bbca792bd"}],"nova/scheduler/filters/aggregate_image_properties_isolation.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"121d3a6b64761a96882b2854fe138d7eeefdc72a","unresolved":true,"context_lines":[{"line_number":49,"context_line":"                \"aggregate_image_properties_isolation_namespace\u0027. \""},{"line_number":50,"context_line":"                \"You should unset this option and consider using the \""},{"line_number":51,"context_line":"                \"\u0027AggregateInstanceExtraSpecsFilter\u0027 filter instead, which \""},{"line_number":52,"context_line":"                \"allows filtering of arbitrary flavor extra specs.\""},{"line_number":53,"context_line":"            )"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        image_props \u003d spec_obj.image.properties if spec_obj.image else {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"20919bb7_b1b0a992","line":52,"updated":"2021-03-26 17:55:54.000000000","message":"i woudl not make this suggestion to use the filter they shoudl use the new placemnt way using traits\nhttps://docs.openstack.org/nova/latest/reference/isolate-aggregates.html\n\nsince image can request traits that method can repace both the AggregateInstanceExtraSpecsFilter and the AggregateImagePropertiesIsolation\nusing a custom trait and its more efficeint so can we recommend that instead.\n\ni think that was added in rocky so its not exacatly new either.\nhttps://docs.openstack.org/nova/latest/admin/aggregates.html#tenant-isolation-with-placement is also similar but its tenant based not flavor/image based.","commit_id":"052f22462a4e8d1c81341192406036fba92bd072"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4ce53f151b42e637c0b9748f27823ae6705970be","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \"aggregate_image_properties_isolation_namespace\u0027. \""},{"line_number":50,"context_line":"                \"You should unset this option and consider using the \""},{"line_number":51,"context_line":"                \"\u0027AggregateInstanceExtraSpecsFilter\u0027 filter instead, which \""},{"line_number":52,"context_line":"                \"allows filtering of arbitrary flavor extra specs.\""},{"line_number":53,"context_line":"            )"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        image_props \u003d spec_obj.image.properties if spec_obj.image else {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7fc00dac_d3bc294e","line":52,"in_reply_to":"20919bb7_b1b0a992","updated":"2021-03-26 18:35:36.000000000","message":"That\u0027s a good idea. Done","commit_id":"052f22462a4e8d1c81341192406036fba92bd072"}]}
