)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f9595730b85a24b987db832b49b75dc55363bef6","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"    \"\"\"Parse options and call the appropriate class/method.\"\"\""},{"line_number":1319,"context_line":"    # Make \"nova-manage version\" work exactly like \"nova-manage --version\""},{"line_number":1320,"context_line":"    if len(sys.argv) \u003d\u003d 2 and sys.argv[1] \u003d\u003d \u0027version\u0027:"},{"line_number":1321,"context_line":"        sys.argv[1] \u003d \u0027--version\u0027"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1324,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2Fe%2FQ%3D","line":1321,"updated":"2014-03-05 20:16:45.000000000","message":"This isn\u0027t 100% robust; what about the case of:\n\n    nova-manage --some-option --some-other-option version\n\nWould something of this form be better:\n\n    if CONF.category.name \u003d\u003d \"version\":\n        config.parse_args([sys.argv[0], \u0027--version\u0027])\n\nThis would probably be easier if oslo.config had a print_version() method to go with print_help() and print_usage()…","commit_id":"d65431478f6bf3b6343806e633a5da00d937ae4e"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"ecb3da3d4c3f3960a2e8c6db2fd64341f659ec82","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"        config.parse_args([sys.argv[0], \u0027--version\u0027])"},{"line_number":1338,"context_line":"        return(0)"},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"    elif CONF.category.name \u003d\u003d \"bash-completion\":"},{"line_number":1341,"context_line":"        if not CONF.category.query_category:"},{"line_number":1342,"context_line":"            print(\" \".join(CATEGORIES.keys()))"},{"line_number":1343,"context_line":"        elif CONF.category.query_category in CATEGORIES:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FblM%3D","line":1340,"updated":"2014-03-06 04:46:13.000000000","message":"It seems this change is meaningless.\nSince \"return\" is executed at line 1338, meaning of \"if \" in line 1340 is same as \"else if\" even if this is written as \"if\".","commit_id":"a5924a15447e06b59704971333da6bb5b6180a6f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"68457caa637d57f9dedf23b83c1f96ad0fd81e65","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"        config.parse_args([sys.argv[0], \u0027--version\u0027])"},{"line_number":1338,"context_line":"        return(0)"},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"    elif CONF.category.name \u003d\u003d \"bash-completion\":"},{"line_number":1341,"context_line":"        if not CONF.category.query_category:"},{"line_number":1342,"context_line":"            print(\" \".join(CATEGORIES.keys()))"},{"line_number":1343,"context_line":"        elif CONF.category.query_category in CATEGORIES:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FWEo%3D","line":1340,"in_reply_to":"AAAAVn%2F%2FYKc%3D","updated":"2014-03-06 17:57:13.000000000","message":"Eh.  Since it was \u0027if\u0027 before, I have a slight preference for leaving it the same to avoid gratuitous changes, but it\u0027s no big deal.  You will need to remove the import for \u0027version\u0027 now, though…","commit_id":"a5924a15447e06b59704971333da6bb5b6180a6f"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"6c344b409d9caa55326b6265da69cbfce0de1d17","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"        config.parse_args([sys.argv[0], \u0027--version\u0027])"},{"line_number":1338,"context_line":"        return(0)"},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"    elif CONF.category.name \u003d\u003d \"bash-completion\":"},{"line_number":1341,"context_line":"        if not CONF.category.query_category:"},{"line_number":1342,"context_line":"            print(\" \".join(CATEGORIES.keys()))"},{"line_number":1343,"context_line":"        elif CONF.category.query_category in CATEGORIES:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FYKc%3D","line":1340,"in_reply_to":"AAAAVn%2F%2FblM%3D","updated":"2014-03-06 14:25:31.000000000","message":"The elif makes it clearer that the choices are exclusive.  You\u0027re right that they work the same.","commit_id":"a5924a15447e06b59704971333da6bb5b6180a6f"}]}