)]}'
{"id":"openstack%2Fnova~784071","triplet_id":"openstack%2Fnova~stable%2Ftrain~I6c585a34d6e774f890f992be647214e7e1073edb","project":"openstack/nova","branch":"stable/train","hashtags":[],"change_id":"I6c585a34d6e774f890f992be647214e7e1073edb","subject":"WIP: live migration: Pass limits onto scheduler-chosen destination","status":"ABANDONED","created":"2021-03-31 10:55:31.000000000","updated":"2023-09-01 17:02:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e3adaf83799d3bda261999d83badd0c6f3729307","_number":784071,"virtual_id_number":784071,"owner":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-03-31 12:41:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-31 12:41:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-31 15:03:09.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-31 15:43:50.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"9e22dc021a4ad24b906f56bf9cae6314d9e147dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"date":"2021-03-31 10:55:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a601329be90d3411ca9efdc4951de9a4b80ce82e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 12:41:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/ecb6efecba7e4db7874bd71b668aa6cb : SUCCESS in 1h 15m 47s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b25a9b0bc02049c4a242752209dd53fc : FAILURE in 14m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9c865bef65584f4295c26b11078930ff : FAILURE in 14m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2ada37e77fbc4498bd16a55a8e349df8 : FAILURE in 10m 44s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/604f3ccd81954fca9e3f3e48b38b80e1 : FAILURE in 12m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e17b8d29035e411c926a07a321c7c8e0 : FAILURE in 12m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/61c4255e6ec94f46813136822fab8fcb : FAILURE in 14m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ad38178a42b48a292e5c80d9b7df2e2 : SUCCESS in 10m 56s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/0b02b8f253864d6a9dfcb49b189bbfd6 : SUCCESS in 1h 20m 49s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/12337e7e06ef468c90748e2a6517b7e6 : SUCCESS in 1h 17m 20s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/83b1351cfb1c40a0ac2c0d156f99e530 : SUCCESS in 1h 21m 54s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/b41a0b6b9bc048a7a70f2a117bc58e9e : SUCCESS in 1h 06m 06s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5b85655858f9424bbf802dc358ebc520 : SUCCESS in 48m 14s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/5879a49e965b4fcd83aa1656726eb259 : FAILURE in 1h 28m 47s\n- nova-next https://zuul.opendev.org/t/openstack/build/292da26b3f264b5aacae9fb733d82a7b : SUCCESS in 1h 08m 35s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/412e06f877e746129cb65494cd5f7379 : SUCCESS in 19m 42s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/0db997dd21574e7e920e635d260c7afa : SUCCESS in 17m 01s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/86dfe1c56f3e42ec8c366945ac7d2730 : SUCCESS in 1h 32m 45s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/bd4ae7f3178244a780f9e418997ca6a3 : SUCCESS in 52m 33s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/843964d2581d4f72ac48efe9b079867b : SUCCESS in 1h 02m 05s","accounts_in_message":[],"_revision_number":1},{"id":"907170ab7372f68fbc8688c956cbbf319d6e5b86","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-03-31 15:03:09.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/71/784071/1/SRIOV-nova-direct : FAILURE\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/71/784071/1/SRIOV-nova-macvtap : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"a61db57802b91ed4387e0931e326e774a86fb03e","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-03-31 15:43:50.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/71/784071/1/check/tempest-dsvm-full-bionic-py3/a6efbed/ : SUCCESS in 1h 50m 31s","accounts_in_message":[],"_revision_number":1},{"id":"ec930a3a0e704c1b3c57fca0010da3e7785263ef","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-03-31 17:18:12.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/71/784071/1/SRIOV-nova-direct : FAILURE\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/71/784071/1/SRIOV-nova-macvtap : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"e3adaf83799d3bda261999d83badd0c6f3729307","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 17:02:35.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ac00833545669b2efb80f6b18fb1e751e845375b","revisions":{"ac00833545669b2efb80f6b18fb1e751e845375b":{"kind":"REWORK","_number":1,"created":"2021-03-31 10:55:31.000000000","uploader":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"ref":"refs/changes/71/784071/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/784071/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/784071/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/784071/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/784071/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/784071/1"}}},"commit":{"parents":[{"commit":"8559ceeec4e52651a272d08ef344d7c03520ed19","subject":"Add config parameter \u0027live_migration_scheme\u0027 to live migration with tls guide","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8559ceeec4e52651a272d08ef344d7c03520ed19"}]}],"author":{"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","date":"2021-03-08 15:38:51.000000000","tz":-480},"committer":{"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","date":"2021-03-28 22:42:10.000000000","tz":-420},"subject":"WIP: live migration: Pass limits onto scheduler-chosen destination","message":"WIP: live migration: Pass limits onto scheduler-chosen destination\n\nIf a live migration without a specific destination has been requested,\nthe conductor will get a list of potential destinations from the\nscheduler. The conductor will then proceed to check if the destination\ncan accommodate the instance by calling check_can_live_migrate_destination.\n\nHowever, this call is made in _find_destination by calling\n_call_livem_checks_on_host, which will then remotely call the method\nmentioned above, and passing it self.limits, which at that point is still None.\n\nOn the nova-compute side, check_can_live_migrate_destination will also create\nthe resource claim, which also includes the soon-to-used NUMA topology that\nwill be used by the live-migrated instance. For this, the function\nnuma_fit_instance_to_host is called, which will return the first match that\nwill fit the instance NUMA topology. This function will also receive those\nlimits from the conductor, and because it\u0027s always None, CPU and memory\nallocation ratios are never respected for the NUMA node 0, so NUMA node 0\nis always a valid candidate for Live Migrations, which means that with\nevery Live Migration the NUMA node 0 will get more and more overcommited,\neventually causing VMs to get into OOM as well.\n\nThis commit simply passes those limits received from the scheduler onto\nnova-compute, so they can be used to make sure we don\u0027t overcommit NUMA nodes.\nThose limits are created by the NUMATopologyFilter.\n\nChange-Id: I6c585a34d6e774f890f992be647214e7e1073edb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ac00833545669b2efb80f6b18fb1e751e845375b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ac00833545669b2efb80f6b18fb1e751e845375b"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}