)]}'
{"nova/tests/functional/regressions/test_bug_1922053.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d8f4846d6c3df3f98b9556a76e41e9da4a41d6da","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        #   self._force_up_compute,"},{"line_number":69,"context_line":"        #   \u0027compute\u0027,"},{"line_number":70,"context_line":"        # )"},{"line_number":71,"context_line":"        # self.assertEqual(409, ex.response.status_code)"},{"line_number":72,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Assert that the evacuation migration record remains `done`"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6191962_2505af89","line":71,"range":{"start_line":71,"start_character":27,"end_line":71,"end_character":30},"updated":"2021-04-01 18:22:14.000000000","message":"400","commit_id":"896bfd5fd8f2e51eba2eade19482db40d6bdf738"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c3a3cc97c9d454b6218ad99f49fd319e6d6890cd","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Assert that the evacuation migration record remains `done`"},{"line_number":75,"context_line":"        self._wait_for_migration_status(server, [\"done\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Restart the source compute to move the migration record along"},{"line_number":78,"context_line":"        self.computes[\u0027compute\u0027].stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b2b7ee2_f96569b1","line":75,"updated":"2021-04-01 11:12:27.000000000","message":"Is there any easy-to-assert corruption this situation causes? Do we have a resource allocation issue in this case we can assert?","commit_id":"896bfd5fd8f2e51eba2eade19482db40d6bdf738"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c569f6a7ed84c9a5ecee20967fc0ccdffb62f6ee","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Assert that the evacuation migration record remains `done`"},{"line_number":75,"context_line":"        self._wait_for_migration_status(server, [\"done\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Restart the source compute to move the migration record along"},{"line_number":78,"context_line":"        self.computes[\u0027compute\u0027].stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"8fde3474_6e6e7d4c","line":75,"updated":"2021-04-01 11:37:33.000000000","message":"Shouldn\u0027t we rather be asserting that we timeout waiting for \"completed\" status? This feels like a repeat of L60...","commit_id":"896bfd5fd8f2e51eba2eade19482db40d6bdf738"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d8f4846d6c3df3f98b9556a76e41e9da4a41d6da","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Assert that the evacuation migration record remains `done`"},{"line_number":75,"context_line":"        self._wait_for_migration_status(server, [\"done\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Restart the source compute to move the migration record along"},{"line_number":78,"context_line":"        self.computes[\u0027compute\u0027].stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bad7bd6_ed6b4b8c","line":75,"in_reply_to":"1b2b7ee2_f96569b1","updated":"2021-04-01 18:22:14.000000000","message":"I *think* we only cleanup allocations from the source host resource provider once it comes back up so I could assert that here also.","commit_id":"896bfd5fd8f2e51eba2eade19482db40d6bdf738"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"bcaa2f2ffe902b87ae4c3d616e8f6e0806dfe9d4","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Assert that the evacuation migration record remains `done`"},{"line_number":75,"context_line":"        self._wait_for_migration_status(server, [\"done\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Restart the source compute to move the migration record along"},{"line_number":78,"context_line":"        self.computes[\u0027compute\u0027].stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"944828d5_86f16831","line":75,"in_reply_to":"78f2ffb3_e1273148","updated":"2021-04-01 18:38:51.000000000","message":"The way the waiter is implemented, it keeps getting the migration status, and exits when it finds the correct one, or timeouts if it never gets it after a certain amount of time. In this case, it will exit on the first attempt, which is why I said that it\u0027s repeating L60. The migration could theoretically still move to \"completed\" after said first attempt. In practice I know it never will, I\u0027m just pointing out that the waiting for \"done\" doesn\u0027t actually add anything. If we want to make the point that the migration never reaches \"complete\", then we should assert that waiting for \"complete\" times out.\n\nAnyways, I\u0027m not dying on this hill.","commit_id":"896bfd5fd8f2e51eba2eade19482db40d6bdf738"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d8f4846d6c3df3f98b9556a76e41e9da4a41d6da","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Assert that the evacuation migration record remains `done`"},{"line_number":75,"context_line":"        self._wait_for_migration_status(server, [\"done\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Restart the source compute to move the migration record along"},{"line_number":78,"context_line":"        self.computes[\u0027compute\u0027].stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"78f2ffb3_e1273148","line":75,"in_reply_to":"8fde3474_6e6e7d4c","updated":"2021-04-01 18:22:14.000000000","message":"I\u0027m not sure what if any value that would add here. This assertion is quick and confirms that forcing up the original host does nothing to the state of the evacuation migration record.","commit_id":"896bfd5fd8f2e51eba2eade19482db40d6bdf738"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3386c0c79363b3e9228bdcc31fa2978a5d905a9a","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Assert that the evacuation migration record remains `done`"},{"line_number":75,"context_line":"        self._wait_for_migration_status(server, [\"done\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Restart the source compute to move the migration record along"},{"line_number":78,"context_line":"        self.computes[\u0027compute\u0027].stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fdb16d56_814af321","line":75,"in_reply_to":"944828d5_86f16831","updated":"2021-04-01 20:35:28.000000000","message":"As the comment says it\u0027s asserting that nothing has changed given the compute service being forced up in between, IMHO that\u0027s a valid assertion both here when we allow the force up and in the future when we don\u0027t.\n\nAs you say it can never be `completed` here so a quick assertion using `done` to ensure nothing has changed made sense to me when writing this.","commit_id":"896bfd5fd8f2e51eba2eade19482db40d6bdf738"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"470ceff08455e62ce6ee2ef559ee5365474a1011","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self._force_up_compute(\u0027compute\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Assert that the evacuation migration record remains `done`"},{"line_number":76,"context_line":"        self._wait_for_migration_status(server, [\"done\"])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # Restart the source compute to move the migration record along"},{"line_number":79,"context_line":"        self.computes[\u0027compute\u0027].stop()"}],"source_content_type":"text/x-python","patch_set":2,"id":"b3fdefb8_e319b507","line":76,"updated":"2021-04-10 02:31:07.000000000","message":"Eh, agree this is weird and seemingly pointless as it will likely always say \"yes\" it\u0027s \"done\" since it began as \"done\" even if it were to change like one half second later. I guess really what you\u0027d want to do is pull the migration record again after forcing the compute up and assert it still has status \"done\". I recognize that this is doing that in one line :) but the \"wait for status\" words make it a bit odd.\n\nTo be clear, I think asserting a status of \"done\" is valid and I don\u0027t think you need to change how you\u0027re doing it.","commit_id":"db333070b61caef62ea5b68e5bf75f92d879db74"}]}