)]}'
{"nova/privsep/qemu.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c602d01301871a27871f1e847e693fe73b652956","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _qemu_img_limits():"},{"line_number":38,"context_line":"    global QEMU_IMG_LIMITS"},{"line_number":39,"context_line":"    if QEMU_IMG_LIMITS is None:"},{"line_number":40,"context_line":"        QEMU_IMG_LIMITS \u003d processutils.ProcessLimits("},{"line_number":41,"context_line":"            cpu_time\u003d30,"}],"source_content_type":"text/x-python","patch_set":5,"id":"731ba0f7_aa80afd5","line":38,"updated":"2021-04-13 13:21:32.000000000","message":"I don\u0027t think it is expensive to create ProcessLimits objects for each call so I suggest to drop the global and create the ProcessLimits for each call.","commit_id":"a283256cedd35b8f20f6a38040913f2a812b3c40"},{"author":{"_account_id":17813,"name":"wangzhh","email":"wzh_1993@126.com","username":"wangzhh"},"change_message_id":"e46cd11dd04fae8708e17d4611de54e2f7ebb3bb","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _qemu_img_limits():"},{"line_number":38,"context_line":"    global QEMU_IMG_LIMITS"},{"line_number":39,"context_line":"    if QEMU_IMG_LIMITS is None:"},{"line_number":40,"context_line":"        QEMU_IMG_LIMITS \u003d processutils.ProcessLimits("},{"line_number":41,"context_line":"            cpu_time\u003d30,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd1c05b2_3d11f302","line":38,"in_reply_to":"731ba0f7_aa80afd5","updated":"2021-04-13 13:43:15.000000000","message":"Agree with you, but do we need different ProcessLimits(different adress_space or cpu_time) for each call?\nIf yes, who will decide these values?\nIf no, I think it\u0027s better to use the global instead of same ProcessLimits for each call.","commit_id":"a283256cedd35b8f20f6a38040913f2a812b3c40"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c602d01301871a27871f1e847e693fe73b652956","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    if QEMU_IMG_LIMITS is None:"},{"line_number":40,"context_line":"        QEMU_IMG_LIMITS \u003d processutils.ProcessLimits("},{"line_number":41,"context_line":"            cpu_time\u003d30,"},{"line_number":42,"context_line":"            address_space\u003dCONF.libvirt.qemu_img_command_memory_limit *"},{"line_number":43,"context_line":"                          units.Mi)"},{"line_number":44,"context_line":"    return QEMU_IMG_LIMITS"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e94384be_2a42d875","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":68},"updated":"2021-04-13 13:21:32.000000000","message":"you need to define this new config option in nova/conf/libvirt.py","commit_id":"a283256cedd35b8f20f6a38040913f2a812b3c40"},{"author":{"_account_id":17813,"name":"wangzhh","email":"wzh_1993@126.com","username":"wangzhh"},"change_message_id":"e46cd11dd04fae8708e17d4611de54e2f7ebb3bb","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    if QEMU_IMG_LIMITS is None:"},{"line_number":40,"context_line":"        QEMU_IMG_LIMITS \u003d processutils.ProcessLimits("},{"line_number":41,"context_line":"            cpu_time\u003d30,"},{"line_number":42,"context_line":"            address_space\u003dCONF.libvirt.qemu_img_command_memory_limit *"},{"line_number":43,"context_line":"                          units.Mi)"},{"line_number":44,"context_line":"    return QEMU_IMG_LIMITS"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"2f2ce344_4348372c","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":68},"in_reply_to":"e94384be_2a42d875","updated":"2021-04-13 13:43:15.000000000","message":"Yes, I have defined it in nova/conf/libvirt.py.\nhttps://review.opendev.org/c/openstack/nova/+/785082/5/nova/conf/libvirt.py#980","commit_id":"a283256cedd35b8f20f6a38040913f2a812b3c40"}],"releasenotes/notes/bug_1921979-883c011ebbf34f9e.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c602d01301871a27871f1e847e693fe73b652956","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This resolves `bug 1921979`_ when ``nova-compute`` issues qemu-img command"},{"line_number":5,"context_line":"    on a busy machine with insufficient ``address_space``.For more infomation"},{"line_number":6,"context_line":"    about ``address_space`` you can refer to `this document"},{"line_number":7,"context_line":"    \u003chttps://docs.openstack.org/oslo.concurrency/latest/reference/processutils.html\u003e`_."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4f65411c_3ed0e834","line":5,"updated":"2021-04-13 13:21:32.000000000","message":"I would mention the new config option introduced.","commit_id":"a283256cedd35b8f20f6a38040913f2a812b3c40"},{"author":{"_account_id":17813,"name":"wangzhh","email":"wzh_1993@126.com","username":"wangzhh"},"change_message_id":"e46cd11dd04fae8708e17d4611de54e2f7ebb3bb","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This resolves `bug 1921979`_ when ``nova-compute`` issues qemu-img command"},{"line_number":5,"context_line":"    on a busy machine with insufficient ``address_space``.For more infomation"},{"line_number":6,"context_line":"    about ``address_space`` you can refer to `this document"},{"line_number":7,"context_line":"    \u003chttps://docs.openstack.org/oslo.concurrency/latest/reference/processutils.html\u003e`_."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5e1083e1_2070d8a3","line":5,"in_reply_to":"4f65411c_3ed0e834","updated":"2021-04-13 13:43:15.000000000","message":"Fine, let me improve it.","commit_id":"a283256cedd35b8f20f6a38040913f2a812b3c40"}]}