)]}'
{"id":"openstack%2Fnova~785577","triplet_id":"openstack%2Fnova~stable%2Fwallaby~Iba40c2df72228b461767d5734d5a62403d9f2cfa","project":"openstack/nova","branch":"stable/wallaby","topic":"bug/1917619","hashtags":[],"change_id":"Iba40c2df72228b461767d5734d5a62403d9f2cfa","subject":"libvirt: Simplify device_path check in _detach_encryptor","status":"MERGED","created":"2021-04-09 09:06:54.000000000","updated":"2021-04-26 16:38:05.000000000","submitted":"2021-04-26 16:36:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"785577-bug/1917619","meta_rev_id":"45b776db13f82c35a1ccf34bbdb531df98a16114","_number":785577,"virtual_id_number":785577,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-26 16:36:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2021-04-26 14:48:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-04-26 09:07:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2021-04-26 14:48:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2021-04-19 16:33:18.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-09 10:46:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-09 12:22:54.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-04-26 09:07:51.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2021-04-26 14:48:37.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"33d288c786060e157d7238051c6237d3eb6be44c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 09:06:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2f00f029d209d49a1d691c81234e1f0fb57688e0","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 09:07:04.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"9292f5ddac20836ab896ee9d9496f62fa5931fc5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 10:46:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/926fd2c05ee74de4b07b40ca9411e3ae : SUCCESS in 1h 12m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a68a0f285dfe4f9a9bb3edb2eeb6319b : SUCCESS in 24m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/af069206a3d5414d8369137c79359e42 : SUCCESS in 14m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/55abe15ab37040929cc6acd947ddf38a : SUCCESS in 8m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e5f85700e54044618c33f4c56e367014 : SUCCESS in 13m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d59d05ef60ec48fe8546b3087c1ec469 : SUCCESS in 12m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/65f3eccac0a24ba3b3060555535c1433 : SUCCESS in 13m 26s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bad9bf8c88ac401b9099a999a62af18b : SUCCESS in 10m 26s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/c87a2b73427446e69e5693c1ef62ea4e : SUCCESS in 1h 27m 53s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/dbd71c23ee7848a490427b9274b9690d : SUCCESS in 1h 14m 55s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/92e124b6dc824c61bafe9ab60c55dbc3 : SUCCESS in 1h 04m 39s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ac6180de16ba4fb79d48b1333b5b75ee : SUCCESS in 49m 08s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/112929ed2b0d45b0a41e55d972cda4e6 : SUCCESS in 1h 01m 35s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/768010769d19416296ac5dc7b8a1081b : SUCCESS in 1h 21m 46s\n- nova-next https://zuul.opendev.org/t/openstack/build/87be94f80c294d259c2746a0168abe92 : SUCCESS in 1h 34m 47s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/6034520465e94c70ac65aa19c5dde8a6 : SUCCESS in 22m 48s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/1a47bc653084476eaf67a97c74e5aacf : SUCCESS in 17m 41s (non-voting)\n- grenade https://zuul.opendev.org/t/openstack/build/f9ad7f8c50234e3cbc480d8a869ed160 : SUCCESS in 1h 00m 49s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c970b2862cff467390e747b00664cc8c : SUCCESS in 1h 03m 03s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/50994a75db3e4b37b314478932fbe6f4 : SUCCESS in 54m 44s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/56b8a840fe8c41afa64427df2f388f62 : SUCCESS in 21m 56s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/77299f70cca3433699338684f60051b8 : SUCCESS in 50m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e4562e8745435cc78117310d06b2a7c3f8cec5b5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-04-09 12:22:54.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/785577/1/iscsi : FAILURE in 3h 13m 14s","accounts_in_message":[],"_revision_number":1},{"id":"707467dbd25259bde08180707b9de3a203378d53","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-12 03:58:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d35cb5d264a1c44169167bc3c5c3c86397ab81a3","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-19 16:33:18.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"9313bbbe8a0ed1ee4364186b5ad0130f65dafba1","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2021-04-26 09:07:51.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry-pick.","accounts_in_message":[],"_revision_number":1},{"id":"0e0f377eb967a39c71d158a42d826149a38d9253","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-04-26 14:48:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean indeed + merged in master. Looks valid to backport.","accounts_in_message":[],"_revision_number":1},{"id":"09b37ca1885c1cdad09c3b0a96e772176b2725b1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-26 14:49:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"816c6a2db487ce0a9e9885f96604127cd8da7e10","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-04-26 14:49:24.000000000","message":"Topic set to bug/1917619","accounts_in_message":[],"_revision_number":1},{"id":"bfe0a9855b5bac921361da2fc2c036c28c5e2995","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-26 16:36:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/55192ebf21214c97b856f7d43d8759b8 : SUCCESS in 1h 37m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/09ee5588d80a43c5908f735694586073 : SUCCESS in 13m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/90e3688b7458476f9ee2bfef2e4711f1 : SUCCESS in 9m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d504588259124573b5b292bf09306713 : SUCCESS in 12m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b3c1bba09e044c29bf3494f57ed8b298 : SUCCESS in 13m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/37455c51e0e843bcb68c56e86a43461c : SUCCESS in 9m 44s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/343660ecbfab470cb85f2ca14a3da894 : SUCCESS in 1h 23m 35s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7dffb3783a4a40d4a88100061e05b319 : SUCCESS in 50m 45s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/49b4c99f55dc43d4907ce723d7453039 : SUCCESS in 20m 28s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/bb26b7c9ead241c3be34d664b079f82e : SUCCESS in 1h 23m 51s\n- nova-next https://zuul.opendev.org/t/openstack/build/fe374914aaa84e67aa216d0cbef47f8f : SUCCESS in 1h 19m 08s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/046be4ffecb74213b0b92f125460f1cd : SUCCESS in 1h 12m 11s\n- grenade https://zuul.opendev.org/t/openstack/build/3f9a0e9a5c6c4493beac0a6f865ee55b : SUCCESS in 1h 12m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f2b6a59a0e0f40ee8fc3dac4e2a5b9f6 : SUCCESS in 1h 03m 45s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c4ee2b00fa8042e385f5a629a84641bb : SUCCESS in 58m 16s","accounts_in_message":[],"_revision_number":1},{"id":"6d8c26e86d044dc9ead2a166f60d88c0f2db0b19","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-26 16:36:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"45b776db13f82c35a1ccf34bbdb531df98a16114","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-26 16:38:05.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/731459763c0e42a3a6f5b573670057d2 : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f99f667a96a357adc0070d75b5940e76726f9664","revisions":{"f99f667a96a357adc0070d75b5940e76726f9664":{"kind":"REWORK","_number":1,"created":"2021-04-09 09:06:54.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/77/785577/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/77/785577/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/785577/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/785577/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/785577/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/77/785577/1"}}},"commit":{"parents":[{"commit":"68af588d5c7b5c9472cbc2731fee2956c86206ea","subject":"Bumping min os-brick ver to 4.3.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/68af588d5c7b5c9472cbc2731fee2956c86206ea"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-03 12:33:49.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 09:06:44.000000000","tz":60},"subject":"libvirt: Simplify device_path check in _detach_encryptor","message":"libvirt: Simplify device_path check in _detach_encryptor\n\nIntroduced by Id670f13a7f197e71c77dc91276fc2fba2fc5f314 to resolve bug\n #1821696 this check was put in place to ensure _detach_encryptor did not\nattempt to use the os-brick encryptors with an unsupported volume type\nafter libvirt secrets had been removed outside the control of Nova.\n\nWith the introduction of the [workarounds]disable_native_luksv1 via\nIa500eb614cf575ab846f64f4b69c9068274c8c1f however the use of\n_allow_native_luksv1 as part of this check is no longer valid. As this\nhelper was updated to return False when the workaround is enabled,\nregardless of the underlying volume being attached natively or not.\n\nIf an admin had enabled the workaround after users had launched\ninstances with natively attached encrypted volumes *and* the libvirt\nsecrets had gone missing _detach_encryptor would attempt to use the\nos-brick encryptors. This would fail when the underlying volume type is\nunsupported, for example rbd. See bug #1917619 for an example.\n\nThis change resolves this corner case by dropping the use of\n_allow_native_luksv1 from the check and just asserting that a\ndevice_path is present for an encrypted volume before allowing the use\nof the os-brick encryptors. As noted this is safe as calls to the\nencryptors are idempotent, ignoring failures to detach when the\nunderlying volume type is supported.\n\nCloses-Bug: #1917619\nChange-Id: Iba40c2df72228b461767d5734d5a62403d9f2cfa\n(cherry picked from commit 4908daed96ddda492ced6cbb084abe8f33a8b1f7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f99f667a96a357adc0070d75b5940e76726f9664"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f99f667a96a357adc0070d75b5940e76726f9664"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}