)]}'
{"id":"openstack%2Fnova~785583","triplet_id":"openstack%2Fnova~stable%2Ftrain~I212a2db8d71702d330b146dc6f871b402a309e74","project":"openstack/nova","branch":"stable/train","topic":"bug/1919487","hashtags":[],"change_id":"I212a2db8d71702d330b146dc6f871b402a309e74","subject":"compute: Reject requests to commit intermediary snapshot of an inactive instance","status":"ABANDONED","created":"2021-04-09 09:17:06.000000000","updated":"2023-09-01 17:03:26.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"80c82b05153330b2bb4660e654e949fb2bae6ad9","_number":785583,"virtual_id_number":785583,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-04-09 11:18:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-09 11:18:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-09 11:19:37.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-09 14:12:02.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"f0c361e550ef8603125c99317d7371a8211eb110","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-04-09 09:17:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"df8eaa15c118699ca3cfe1364beb1b3a84e925b5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 11:18:15.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/9733f2587a244537af5803114d325f82 : SUCCESS in 1h 24m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/932eb9de8df24f1b9f759f948ab65b10 : SUCCESS in 17m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a73dd9d443f34b0281ef061c370a1d0f : SUCCESS in 15m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e33e8c51485a4d3e9c3e94276edd4a09 : FAILURE in 12m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ba6ae26a0320431d92716d5a9e395951 : SUCCESS in 13m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c24e017a599b440e84a8f8e92730c519 : SUCCESS in 13m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2b5aa95f2202404aacb3167a8d4b7221 : SUCCESS in 16m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae66a6a2fe3547b88e6adaf23d7314c9 : SUCCESS in 11m 41s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/285120381ca24de19c061eec6bcdcc47 : SUCCESS in 1h 08m 02s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/0b0635eab55d4391abf8faa393f18c99 : SUCCESS in 1h 12m 41s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/1c194082d83a47e29c37e88efc81579a : SUCCESS in 1h 01m 56s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ba09a5ffd9b34470a457235d87c61597 : FAILURE in 36m 40s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5d7fb381b02648709d25d0e32984d44f : SUCCESS in 57m 44s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/9876d7d9030a43bb8c0cfbac48a92092 : SUCCESS in 1h 32m 53s\n- nova-next https://zuul.opendev.org/t/openstack/build/efc5d0a5331b46c9adf73422d0c21563 : SUCCESS in 1h 20m 24s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b323a38ddf0940ad988bd66624cca91f : SUCCESS in 19m 39s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/58a041b825554b5d9b6959e2c1fde111 : SUCCESS in 18m 01s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/1a465f1329e248279c99a0be83ec1ba0 : SUCCESS in 1h 58m 48s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/0485e13908c94cd9b77ca741dd5c76c1 : SUCCESS in 45m 13s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/51aa3327cad94b4c9b9afe92ecc4ce9d : SUCCESS in 57m 24s","accounts_in_message":[],"_revision_number":1},{"id":"3b3d0ad250798761cc38b4b3a700ae104df5089f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-04-09 11:19:37.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/83/785583/1/check/tempest-dsvm-full-bionic-py3/8d0ea66/ : SUCCESS in 1h 49m 24s","accounts_in_message":[],"_revision_number":1},{"id":"33d3b71a0d7a1f3a66240f96cc9ece65020d3565","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-04-09 14:12:02.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/785583/1/iscsi : SUCCESS in 2h 45m 14s","accounts_in_message":[],"_revision_number":1},{"id":"fa390a8c2761fbb75d865c72e8af62a626ac7e1a","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-04-26 17:43:56.000000000","message":"Topic set to bug/1919487","accounts_in_message":[],"_revision_number":1},{"id":"80c82b05153330b2bb4660e654e949fb2bae6ad9","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 17:03:26.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"97e78d0b66c9246acb077749eea2a79f0709371b","revisions":{"97e78d0b66c9246acb077749eea2a79f0709371b":{"kind":"REWORK","_number":1,"created":"2021-04-09 09:17:06.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/83/785583/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/83/785583/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/83/785583/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/83/785583/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/83/785583/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/83/785583/1"}}},"commit":{"parents":[{"commit":"04298cfb3e087efd4b3be20e8a5565a9d08da418","subject":"Merge \"Test for disabling greendns\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/04298cfb3e087efd4b3be20e8a5565a9d08da418"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-17 17:28:05.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-04-09 09:16:49.000000000","tz":60},"subject":"compute: Reject requests to commit intermediary snapshot of an inactive instance","message":"compute: Reject requests to commit intermediary snapshot of an inactive instance\n\nIntroduced by I76eb2e4da027a13525314bd58264f482374d270d the\nos-assisted-volume-snapshots API is only implemented by the libvirt virt\ndriver and should only be called by c-vol as part of an orchestrated\nremotefs based volume snapshot creation or deletion workflow.\n\nWhile not documented clearly in the current api-ref there are code\ncomments within the compute API suggesting that this API can be called\nagainst a volume attached to an instance that is in *any* vm_state.\n\nThis however is not correct when deleting and in turn committing an\nintermediary volume snapshot of an instance that is not running given\nthe current implementation within the libvirt driver. With a request to\nvirDomainBlockCommit being made that fails if the instance and\nunderlying domain is not running.\n\nAdding support for an offline commit isn\u0027t trivial and would be\nconsidered a new feature and not something we could backport on the\nstable branches. As such this change seeks to ensure requests to commit\nan intermediary volume snapshot from an inactive instance are rejected\nquickly and clearly by the compute API to the caller before we cast to\nthe compute.\n\nCloses-Bug: #1919487\nChange-Id: I212a2db8d71702d330b146dc6f871b402a309e74\n(cherry picked from commit 99409375a03e6f923a8b6b00a5dd653bab74caaf)\n(cherry picked from commit 200c743400ed3fd5240fd25d0396eb6180b3f26a)\n(cherry picked from commit 8a41605a78173207746a38350d7fb554f2701b7a)\n(cherry picked from commit 57a810c0bddb2d5fb8c8e97bba07a1c4eeb2a11a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/97e78d0b66c9246acb077749eea2a79f0709371b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/97e78d0b66c9246acb077749eea2a79f0709371b"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}